| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ec6e4f0c-0836-cd09-cbc4-05957dee7dd6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A22:1E0602:240A9E:2E0B02:69903169 |
| html-safe-nonce | ec01dc69584f1a45198755365ec43a446a8e5a70d3d0ff7a1f7fa519525fc183 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTIyOjFFMDYwMjoyNDBBOUU6MkUwQjAyOjY5OTAzMTY5IiwidmlzaXRvcl9pZCI6IjQzNTk2OTAwMzI1NjAyMjI1NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d4fd48d669f015c5e27cdeb4d711a132023b76b5f2ae91426b9a0ded143eddc7 |
| hovercard-subject-tag | pull_request:220213454 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23251/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/58438a990d392e5fc0eec939f6c7b4f6b7595bb705bcc4741f5d24f4fa744661/nodejs/node/pull/23251 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/58438a990d392e5fc0eec939f6c7b4f6b7595bb705bcc4741f5d24f4fa744661/nodejs/node/pull/23251 |
| og:image:alt | refactor and deduplicate code
add list of slow tests - to be skipped for our CI debug build
The target is to get a regular CI job to finish in <= 1h (currently the debug build takes the longest... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23251#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23251 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23251 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23251 |
| Reload | https://github.com/nodejs/node/pull/23251 |
| Reload | https://github.com/nodejs/node/pull/23251 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:teach-test.py-new-tricks | https://github.com/refack/node/tree/teach-test.py-new-tricks |
| Conversation | https://github.com/nodejs/node/pull/23251 |
| Commits2 (2) | https://github.com/nodejs/node/pull/23251/commits |
| Checks | https://github.com/nodejs/node/pull/23251/checks |
| Files changed | https://github.com/nodejs/node/pull/23251/files |
| tools,test: teach test.py new tricks | https://github.com/nodejs/node/pull/23251#top |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:teach-test.py-new-tricks | https://github.com/refack/node/tree/teach-test.py-new-tricks |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/23251#issue-366572547 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://ci.nodejs.org/job/node-test-pull-request/17613/ | https://ci.nodejs.org/job/node-test-pull-request/17613/ |
| https://ci.nodejs.org/job/node-test-pull-request/17614/ | https://ci.nodejs.org/job/node-test-pull-request/17614/ |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-426840908 |
| @refack | https://github.com/refack |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1118/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1118/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/23251#event-1883322321 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/23251#event-1883323031 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Trott | https://github.com/Trott |
| October 3, 2018 23:54 | https://github.com/nodejs/node/pull/23251#event-1883323159 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/23251#event-1883323209 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/92bae01d1a7326f44b8f08da6effe32538344ef6..323234eb73492db79d8ce605dadd0e78d6e39d86 |
| 92bae01 | https://github.com/nodejs/node/commit/92bae01d1a7326f44b8f08da6effe32538344ef6 |
| 323234e | https://github.com/nodejs/node/commit/323234eb73492db79d8ce605dadd0e78d6e39d86 |
|
Compare
| https://github.com/nodejs/node/compare/92bae01d1a7326f44b8f08da6effe32538344ef6..323234eb73492db79d8ce605dadd0e78d6e39d86 |
| October 4, 2018 00:22 | https://github.com/nodejs/node/pull/23251#event-1883351919 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/23251#pullrequestreview-161434238 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23251/files |
| test/root.status | https://github.com/nodejs/node/pull/23251/files#diff-54e28d99692ec55b47a22b805fdbc4d234f4b1004c4dc1bce7c608aaa919dd5f |
| richardlau | https://github.com/richardlau |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r222526897 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| refack | https://github.com/refack |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r222696742 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| richardlau | https://github.com/richardlau |
| Oct 5, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r223045534 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-426886631 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-427039408 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| (arbitrary) test result | https://ci.nodejs.org/job/node-test-commit-linux-containered/7538/nodes=ubuntu1604_sharedlibs_debug_x64/testReport/(root)/test/ |
| spreadsheet | https://docs.google.com/spreadsheets/d/1YMov7MunAU3uwLEWrAEyhmLd65meOygJbkAmSpPCuao/edit?usp=sharing |
| debug CI job | https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_debug_x64/7555/ |
| https://www.diffchecker.com/5I31a6oR | https://www.diffchecker.com/5I31a6oR |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/aqrln |
| aqrln | https://github.com/aqrln |
|
Oct 5, 2018
| https://github.com/nodejs/node/pull/23251#pullrequestreview-161979595 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23251/files |
| tools/test.py | https://github.com/nodejs/node/pull/23251/files#diff-d8b9bc4155fea1e6e1cf17aef1109f9f69b8f487adf44ca1b3e7e0846bc9a0f9 |
| aqrln | https://github.com/aqrln |
| Oct 5, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r222963798 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| refack | https://github.com/refack |
| Oct 5, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r223040846 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/aqrln |
| aqrln | https://github.com/aqrln |
|
Oct 5, 2018
| https://github.com/nodejs/node/pull/23251#pullrequestreview-162083278 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23251/files |
| tools/test.py | https://github.com/nodejs/node/pull/23251/files#diff-d8b9bc4155fea1e6e1cf17aef1109f9f69b8f487adf44ca1b3e7e0846bc9a0f9 |
| aqrln | https://github.com/aqrln |
| Oct 5, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r223044606 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/nodejs/node/pull/23251/files#diff-37479d55e637ac7befeefff7f6d88025R1748 | https://github.com/nodejs/node/pull/23251/files#diff-37479d55e637ac7befeefff7f6d88025R1748 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| refack | https://github.com/refack |
| Oct 5, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r223045958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/b459ac2041f439f0f10113c93cf4e6fc684b33d7..b0adcab8ce50e4bd20810df1c322d8ff4aeface8 |
| b459ac2 | https://github.com/nodejs/node/commit/b459ac2041f439f0f10113c93cf4e6fc684b33d7 |
| b0adcab | https://github.com/nodejs/node/commit/b0adcab8ce50e4bd20810df1c322d8ff4aeface8 |
|
Compare
| https://github.com/nodejs/node/compare/b459ac2041f439f0f10113c93cf4e6fc684b33d7..b0adcab8ce50e4bd20810df1c322d8ff4aeface8 |
| October 5, 2018 21:55 | https://github.com/nodejs/node/pull/23251#event-1888188702 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 5, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-427510194 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| f89fd3b | https://github.com/nodejs/node/commit/f89fd3ba6de6bb7919b7a218825c6e955a137782 |
| b0adcab | https://github.com/nodejs/node/commit/b0adcab8ce50e4bd20810df1c322d8ff4aeface8 |
| https://ci.nodejs.org/job/node-test-pull-request/17651/ | https://ci.nodejs.org/job/node-test-pull-request/17651/ |
| https://ci.nodejs.org/job/node-test-pull-request/17655/ | https://ci.nodejs.org/job/node-test-pull-request/17655/ |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/aqrln |
| aqrln | https://github.com/aqrln |
|
Oct 10, 2018
| https://github.com/nodejs/node/pull/23251#pullrequestreview-163447968 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23251/files |
| tools/test.py | https://github.com/nodejs/node/pull/23251/files#diff-d8b9bc4155fea1e6e1cf17aef1109f9f69b8f487adf44ca1b3e7e0846bc9a0f9 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 10, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-428646011 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 10, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-428646861 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://ci.nodejs.org/job/node-test-pull-request/17723/ | https://ci.nodejs.org/job/node-test-pull-request/17723/ |
| https://ci.nodejs.org/job/node-test-pull-request/17725/ | https://ci.nodejs.org/job/node-test-pull-request/17725/ |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/8e7acc823f007ec19db0db0dc122891d666a5ceb..453096c3a361733575f3c9deba9caae57343b6ee |
| 8e7acc8 | https://github.com/nodejs/node/commit/8e7acc823f007ec19db0db0dc122891d666a5ceb |
| 453096c | https://github.com/nodejs/node/commit/453096c3a361733575f3c9deba9caae57343b6ee |
|
Compare
| https://github.com/nodejs/node/compare/8e7acc823f007ec19db0db0dc122891d666a5ceb..453096c3a361733575f3c9deba9caae57343b6ee |
| October 10, 2018 17:23 | https://github.com/nodejs/node/pull/23251#event-1896151966 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 10, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-428659517 |
| 2b24387 | https://github.com/nodejs/node/commit/2b24387c118ff03f650c050526ecfa1abc38d370 |
| 453096c | https://github.com/nodejs/node/commit/453096c3a361733575f3c9deba9caae57343b6ee |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Oct 11, 2018
| https://github.com/nodejs/node/pull/23251#pullrequestreview-163788696 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23251/files |
| tools/test.py | https://github.com/nodejs/node/pull/23251/files#diff-d8b9bc4155fea1e6e1cf17aef1109f9f69b8f487adf44ca1b3e7e0846bc9a0f9 |
| thefourtheye | https://github.com/thefourtheye |
| Oct 11, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r224427436 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| refack | https://github.com/refack |
| Oct 11, 2018 | https://github.com/nodejs/node/pull/23251#discussion_r224511371 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| tools/test.py | https://github.com/nodejs/node/pull/23251/files#diff-d8b9bc4155fea1e6e1cf17aef1109f9f69b8f487adf44ca1b3e7e0846bc9a0f9 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| tools/test.py | https://github.com/nodejs/node/pull/23251/files#diff-d8b9bc4155fea1e6e1cf17aef1109f9f69b8f487adf44ca1b3e7e0846bc9a0f9 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/671520f964ebbc7f969a44f195f007775963db99..41611a8043d4aa7c8554c2f038426ec2b56cf315 |
| 671520f | https://github.com/nodejs/node/commit/671520f964ebbc7f969a44f195f007775963db99 |
| 41611a8 | https://github.com/nodejs/node/commit/41611a8043d4aa7c8554c2f038426ec2b56cf315 |
|
Compare
| https://github.com/nodejs/node/compare/671520f964ebbc7f969a44f195f007775963db99..41611a8043d4aa7c8554c2f038426ec2b56cf315 |
| October 11, 2018 17:06 | https://github.com/nodejs/node/pull/23251#event-1898797408 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 11, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-429038413 |
| https://ci.nodejs.org/job/node-test-commit/22176/ | https://ci.nodejs.org/job/node-test-commit/22176/ |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 13, 2018
| https://github.com/nodejs/node/pull/23251#pullrequestreview-164450377 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23251/files |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/41611a8043d4aa7c8554c2f038426ec2b56cf315..172da2afee29df946b588853aec5913937f9909e |
| 41611a8 | https://github.com/nodejs/node/commit/41611a8043d4aa7c8554c2f038426ec2b56cf315 |
| 172da2a | https://github.com/nodejs/node/commit/172da2afee29df946b588853aec5913937f9909e |
|
Compare
| https://github.com/nodejs/node/compare/41611a8043d4aa7c8554c2f038426ec2b56cf315..172da2afee29df946b588853aec5913937f9909e |
| October 16, 2018 00:40 | https://github.com/nodejs/node/pull/23251#event-1905521515 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 16, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-430064763 |
| https://ci.nodejs.org/job/node-test-commit-linux-containered/7849/nodes=ubuntu1604_sharedlibs_debug_x64 | https://ci.nodejs.org/job/node-test-commit-linux-containered/7849/nodes=ubuntu1604_sharedlibs_debug_x64 |
| https://ci.nodejs.org/job/node-test-pull-request/17884/ | https://ci.nodejs.org/job/node-test-pull-request/17884/ |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| refack | https://github.com/refack |
| October 16, 2018 11:09 | https://github.com/nodejs/node/pull/23251#commits-pushed-ec4f70e |
|
| https://github.com/refack |
| tools,test: cleanup and dedup code | https://github.com/nodejs/node/pull/23251/commits/ec4f70e59aaccf6ca96f43326005316bb2ed2fd8 |
| ec4f70e | https://github.com/nodejs/node/pull/23251/commits/ec4f70e59aaccf6ca96f43326005316bb2ed2fd8 |
| nodejs#23251 | https://github.com/nodejs/node/pull/23251 |
|
| https://github.com/refack |
| tools,test: add list of slow tests | https://github.com/nodejs/node/pull/23251/commits/deaddd212c499c7ff88d20034753b5f3f00d5153 |
| deaddd2 | https://github.com/nodejs/node/pull/23251/commits/deaddd212c499c7ff88d20034753b5f3f00d5153 |
| nodejs#23251 | https://github.com/nodejs/node/pull/23251 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/172da2afee29df946b588853aec5913937f9909e..deaddd212c499c7ff88d20034753b5f3f00d5153 |
| 172da2a | https://github.com/nodejs/node/commit/172da2afee29df946b588853aec5913937f9909e |
| deaddd2 | https://github.com/nodejs/node/commit/deaddd212c499c7ff88d20034753b5f3f00d5153 |
|
Compare
| https://github.com/nodejs/node/compare/172da2afee29df946b588853aec5913937f9909e..deaddd212c499c7ff88d20034753b5f3f00d5153 |
| October 16, 2018 15:10 | https://github.com/nodejs/node/pull/23251#event-1907113766 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 16, 2018 | https://github.com/nodejs/node/pull/23251#issuecomment-430276526 |
| ec4f70e | https://github.com/nodejs/node/commit/ec4f70e59aaccf6ca96f43326005316bb2ed2fd8 |
| deaddd2 | https://github.com/nodejs/node/commit/deaddd212c499c7ff88d20034753b5f3f00d5153 |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
| https://github.com/refack |
| refack | https://github.com/refack |
| deaddd2 | https://github.com/nodejs/node/commit/deaddd212c499c7ff88d20034753b5f3f00d5153 |
| Oct 16, 2018 | https://github.com/nodejs/node/pull/23251#event-1907118123 |
| https://github.com/refack |
| refack | https://github.com/refack |
| October 16, 2018 15:16 | https://github.com/nodejs/node/pull/23251#event-1907131332 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23251#ref-pullrequest-369661322 |
|
test: add test-benchmark-napi
#23585
| https://github.com/nodejs/node/pull/23585 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-5b79d55 |
|
| https://github.com/refack |
|
| https://github.com/jasnell |
| tools,test: cleanup and dedup code | https://github.com/nodejs/node/commit/5b79d55ce3acbd7751c6dc4fac5b4331647886b0 |
| 5b79d55 | https://github.com/nodejs/node/commit/5b79d55ce3acbd7751c6dc4fac5b4331647886b0 |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-74c4bb7 |
|
| https://github.com/refack |
|
| https://github.com/jasnell |
| tools,test: add list of slow tests | https://github.com/nodejs/node/commit/74c4bb7e77d4f2f07693606c08cbe15198aa3fa3 |
| 74c4bb7 | https://github.com/nodejs/node/commit/74c4bb7e77d4f2f07693606c08cbe15198aa3fa3 |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-ab9527d |
|
| https://github.com/refack |
|
| https://github.com/addaleax |
| tools,test: cleanup and dedup code | https://github.com/nodejs/node/commit/ab9527d17f5855fcee09b0098574ae16c42382ca |
| ab9527d | https://github.com/nodejs/node/commit/ab9527d17f5855fcee09b0098574ae16c42382ca |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| addaleax | https://github.com/addaleax |
|
Oct 20, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-2b863f0 |
|
| https://github.com/refack |
|
| https://github.com/addaleax |
| tools,test: add list of slow tests | https://github.com/nodejs/node/commit/2b863f06945ad8e6c43b6618994445295e5f069c |
| 2b863f0 | https://github.com/nodejs/node/commit/2b863f06945ad8e6c43b6618994445295e5f069c |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 20, 2018 | https://github.com/nodejs/node/pull/23251#event-1916393493 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-148ae30 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| tools,test: cleanup and dedup code | https://github.com/nodejs/node/commit/148ae30fd77def2883d16a80ab554e9accb2a2d7 |
| 148ae30 | https://github.com/nodejs/node/commit/148ae30fd77def2883d16a80ab554e9accb2a2d7 |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-9e03393 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| tools,test: add list of slow tests | https://github.com/nodejs/node/commit/9e03393ff26c27199f49b26608e06194ab23cfbc |
| 9e03393 | https://github.com/nodejs/node/commit/9e03393ff26c27199f49b26608e06194ab23cfbc |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 23, 2018
| https://github.com/nodejs/node/pull/23251#ref-pullrequest-381752344 |
|
test: add a test to make sure the modules can be required independently
#24402
| https://github.com/nodejs/node/pull/24402 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23251#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://github.com/nodejs/node/pull/24675 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-8a28568 |
|
| https://github.com/refack |
|
| https://github.com/rvagg |
| tools,test: cleanup and dedup code | https://github.com/nodejs/node/commit/8a285688a7164c9bb20d7388f6ac29a9ee61553b |
| 8a28568 | https://github.com/nodejs/node/commit/8a285688a7164c9bb20d7388f6ac29a9ee61553b |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-d96c807 |
|
| https://github.com/refack |
|
| https://github.com/rvagg |
| tools,test: add list of slow tests | https://github.com/nodejs/node/commit/d96c807dc51bc4aeb567fcc78e7eedee7e7c8772 |
| d96c807 | https://github.com/nodejs/node/commit/d96c807dc51bc4aeb567fcc78e7eedee7e7c8772 |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-8e08a27 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| tools,test: cleanup and dedup code | https://github.com/nodejs/node/commit/8e08a27edf12c44c6ca71b8cabdf977152285716 |
| 8e08a27 | https://github.com/nodejs/node/commit/8e08a27edf12c44c6ca71b8cabdf977152285716 |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23251#ref-commit-e1f7924 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| tools,test: add list of slow tests | https://github.com/nodejs/node/commit/e1f7924b429e5bdb533142f7563ced1958916c65 |
| e1f7924 | https://github.com/nodejs/node/commit/e1f7924b429e5bdb533142f7563ced1958916c65 |
| #23251 | https://github.com/nodejs/node/pull/23251 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23251#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://github.com/nodejs/node/pull/24727 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Dec 16, 2021
| https://github.com/nodejs/node/pull/23251#ref-pullrequest-1082611032 |
|
test: mark test-crypto-keygen flaky on windows
#41207
| https://github.com/nodejs/node/pull/41207 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23251 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/23251/files/b459ac2041f439f0f10113c93cf4e6fc684b33d7 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/23251/files/41611a8043d4aa7c8554c2f038426ec2b56cf315 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/23251/files/453096c3a361733575f3c9deba9caae57343b6ee |
|
| https://github.com/aqrln |
|
aqrln
| https://github.com/aqrln |
|
| https://github.com/nodejs/node/pull/23251/files/c4d06cdf91b3c33305a9f06aca584f3fd634ae7f |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/23251 |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
|
| https://github.com/thefourtheye |
|
| https://github.com/aqrln |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |