René's URL Explorer Experiment


Title: test: error when empty buffer is passed to filehandle.read() by shisama · Pull Request #23250 · nodejs/node · GitHub

Open Graph Title: test: error when empty buffer is passed to filehandle.read() by shisama · Pull Request #23250 · nodejs/node

X Title: test: error when empty buffer is passed to filehandle.read() by shisama · Pull Request #23250 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Added tests to occur error when empty buffer is passed to filehandle.read() to increase coverage. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit...

X Description: Added tests to occur error when empty buffer is passed to filehandle.read() to increase coverage. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit...

Opengraph URL: https://github.com/nodejs/node/pull/23250

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:53322b96-395c-d4a5-2b8c-21330e04a9e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F76:17620D:166896A:1D1BBA4:6990841A
html-safe-nonced994b3eec7efa9a85b612b33e6c042a0ba84345c41b932aece4a263f4e54a462
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Rjc2OjE3NjIwRDoxNjY4OTZBOjFEMUJCQTQ6Njk5MDg0MUEiLCJ2aXNpdG9yX2lkIjoiMzcwODQyMzQ5NTU1OTk3MTg2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac228dfd175874ea20782457cde9a0d01f05881d7825332c9951a55765e0b5fd0e
hovercard-subject-tagpull_request:220206306
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23250/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aafd8b0f7cd6198060a3b33493ad2e4a0ae9a0de1f2eb0c4ca472ccaba648e38/nodejs/node/pull/23250
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aafd8b0f7cd6198060a3b33493ad2e4a0ae9a0de1f2eb0c4ca472ccaba648e38/nodejs/node/pull/23250
og:image:altAdded tests to occur error when empty buffer is passed to filehandle.read() to increase coverage. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshisama
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23250#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23250
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23250
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23250
Reloadhttps://github.com/nodejs/node/pull/23250
Reloadhttps://github.com/nodejs/node/pull/23250
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23250
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
shisamahttps://github.com/shisama
nodejs:masterhttps://github.com/nodejs/node/tree/master
shisama:test-fsPromises-readfile-empty-bufferhttps://github.com/shisama/node/tree/test-fsPromises-readfile-empty-buffer
Conversationhttps://github.com/nodejs/node/pull/23250
Commits3 (3)https://github.com/nodejs/node/pull/23250/commits
Checkshttps://github.com/nodejs/node/pull/23250/checks
Files changedhttps://github.com/nodejs/node/pull/23250/files
test: error when empty buffer is passed to filehandle.read()https://github.com/nodejs/node/pull/23250#top
shisamahttps://github.com/shisama
nodejs:masterhttps://github.com/nodejs/node/tree/master
shisama:test-fsPromises-readfile-empty-bufferhttps://github.com/shisama/node/tree/test-fsPromises-readfile-empty-buffer
https://github.com/shisama
shisamahttps://github.com/shisama
Oct 3, 2018https://github.com/nodejs/node/pull/23250#issue-366563290
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 3, 2018https://github.com/nodejs/node/pull/23250#event-1883269073
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 4, 2018 https://github.com/nodejs/node/pull/23250#pullrequestreview-161417363
View reviewed changes https://github.com/nodejs/node/pull/23250/files
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 4, 2018 https://github.com/nodejs/node/pull/23250#pullrequestreview-161432360
View reviewed changes https://github.com/nodejs/node/pull/23250/files
test/parallel/test-fs-read-empty-buffer.jshttps://github.com/nodejs/node/pull/23250/files#diff-a90fdc882610c2c8983f19bb1fa81066d454ccbc3c1571d8fc84bd4d429a5c30
thefourtheyehttps://github.com/thefourtheye
Oct 4, 2018https://github.com/nodejs/node/pull/23250#discussion_r222525236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 4, 2018 https://github.com/nodejs/node/pull/23250#pullrequestreview-161432487
View reviewed changes https://github.com/nodejs/node/pull/23250/files
test/parallel/test-fs-read-empty-buffer.jshttps://github.com/nodejs/node/pull/23250/files#diff-a90fdc882610c2c8983f19bb1fa81066d454ccbc3c1571d8fc84bd4d429a5c30
thefourtheyehttps://github.com/thefourtheye
Oct 4, 2018https://github.com/nodejs/node/pull/23250#discussion_r222525333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 4, 2018 https://github.com/nodejs/node/pull/23250#pullrequestreview-161650068
View reviewed changes https://github.com/nodejs/node/pull/23250/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 5, 2018 https://github.com/nodejs/node/pull/23250#pullrequestreview-162150407
View reviewed changes https://github.com/nodejs/node/pull/23250/files
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 6, 2018 https://github.com/nodejs/node/pull/23250#pullrequestreview-162257022
View reviewed changes https://github.com/nodejs/node/pull/23250/files
test/parallel/test-fs-read-empty-buffer.jshttps://github.com/nodejs/node/pull/23250/files#diff-a90fdc882610c2c8983f19bb1fa81066d454ccbc3c1571d8fc84bd4d429a5c30
thefourtheyehttps://github.com/thefourtheye
Oct 6, 2018https://github.com/nodejs/node/pull/23250#discussion_r223182372
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/shisama
shisamahttps://github.com/shisama
force-pushedhttps://github.com/nodejs/node/compare/61d6bef9fa3153d5f3c005b58392013d19d38807..a93f6e07e7aaa19c8b8d4436eab4f9961da9160f
61d6befhttps://github.com/nodejs/node/commit/61d6bef9fa3153d5f3c005b58392013d19d38807
a93f6e0https://github.com/nodejs/node/commit/a93f6e07e7aaa19c8b8d4436eab4f9961da9160f
Compare https://github.com/nodejs/node/compare/61d6bef9fa3153d5f3c005b58392013d19d38807..a93f6e07e7aaa19c8b8d4436eab4f9961da9160f
October 6, 2018 15:17https://github.com/nodejs/node/pull/23250#event-1888613737
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 6, 2018 https://github.com/nodejs/node/pull/23250#pullrequestreview-162263376
View reviewed changes https://github.com/nodejs/node/pull/23250/files
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23250#issuecomment-428458878
@shisamahttps://github.com/shisama
travishttps://travis-ci.com/nodejs/node/jobs/150152081#L753
https://ci.nodejs.org/job/node-test-pull-request/17719/https://ci.nodejs.org/job/node-test-pull-request/17719/
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/shisama
shisamahttps://github.com/shisama
force-pushedhttps://github.com/nodejs/node/compare/a93f6e07e7aaa19c8b8d4436eab4f9961da9160f..3b01a5ec6775961af3cac320dde9721edb09e598
a93f6e0https://github.com/nodejs/node/commit/a93f6e07e7aaa19c8b8d4436eab4f9961da9160f
3b01a5ehttps://github.com/nodejs/node/commit/3b01a5ec6775961af3cac320dde9721edb09e598
Compare https://github.com/nodejs/node/compare/a93f6e07e7aaa19c8b8d4436eab4f9961da9160f..3b01a5ec6775961af3cac320dde9721edb09e598
October 10, 2018 07:34https://github.com/nodejs/node/pull/23250#event-1894720307
https://github.com/shisama
shisamahttps://github.com/shisama
Oct 10, 2018https://github.com/nodejs/node/pull/23250#issuecomment-428469315
@danbevhttps://github.com/danbev
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23250#issuecomment-428484873
@shisamahttps://github.com/shisama
thishttps://travis-ci.com/nodejs/node/jobs/150821800#L755
#23397https://github.com/nodejs/node/pull/23397
Please reload this pagehttps://github.com/nodejs/node/pull/23250
October 10, 2018 18:10https://github.com/nodejs/node/pull/23250#commits-pushed-ea4b362
test: error when empty buffer is passed to filehandle.read()https://github.com/nodejs/node/pull/23250/commits/ea4b362d396547974588495ae98c6ec5f5834055
ea4b362https://github.com/nodejs/node/pull/23250/commits/ea4b362d396547974588495ae98c6ec5f5834055
test: use async function for filehandle.read() testhttps://github.com/nodejs/node/pull/23250/commits/464c83a324a5eec50ae4816f0649d364c8581ddb
464c83ahttps://github.com/nodejs/node/pull/23250/commits/464c83a324a5eec50ae4816f0649d364c8581ddb
test: make error message alignedhttps://github.com/nodejs/node/pull/23250/commits/41afe00a4a6a6aff94e9b24c7ac25a06c1e56150
41afe00https://github.com/nodejs/node/pull/23250/commits/41afe00a4a6a6aff94e9b24c7ac25a06c1e56150
https://github.com/shisama
shisamahttps://github.com/shisama
force-pushedhttps://github.com/nodejs/node/compare/3b01a5ec6775961af3cac320dde9721edb09e598..41afe00a4a6a6aff94e9b24c7ac25a06c1e56150
3b01a5ehttps://github.com/nodejs/node/commit/3b01a5ec6775961af3cac320dde9721edb09e598
41afe00https://github.com/nodejs/node/commit/41afe00a4a6a6aff94e9b24c7ac25a06c1e56150
Compare https://github.com/nodejs/node/compare/3b01a5ec6775961af3cac320dde9721edb09e598..41afe00a4a6a6aff94e9b24c7ac25a06c1e56150
October 10, 2018 09:10https://github.com/nodejs/node/pull/23250#event-1894934418
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23250#issuecomment-428515924
Please reload this pagehttps://github.com/nodejs/node/pull/23250
node-test-commit-linux-containeredhttps://ci.nodejs.org/job/node-test-commit-linux-containered/7694/
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/shisama
shisamahttps://github.com/shisama
Oct 10, 2018https://github.com/nodejs/node/pull/23250#issuecomment-428539924
@danbevhttps://github.com/danbev
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23250#issuecomment-428544529
a8530bchttps://github.com/nodejs/node/commit/a8530bc4e06642b0cf6b602c1c04d39ed9aeca26
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 10, 2018https://github.com/nodejs/node/pull/23250#event-1895302384
danbevhttps://github.com/danbev
Oct 10, 2018 https://github.com/nodejs/node/pull/23250#ref-commit-a8530bc
https://github.com/danbev
test: error when empty buffer is passed to filehandle.read()https://github.com/nodejs/node/commit/a8530bc4e06642b0cf6b602c1c04d39ed9aeca26
a8530bchttps://github.com/nodejs/node/commit/a8530bc4e06642b0cf6b602c1c04d39ed9aeca26
#23250https://github.com/nodejs/node/pull/23250
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Oct 10, 2018https://github.com/nodejs/node/pull/23250#event-1896750858
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23250#ref-commit-b5c75a3
https://github.com/jasnell
test: error when empty buffer is passed to filehandle.read()https://github.com/nodejs/node/commit/b5c75a331d9eacecf11da7f38fb4fa7a0263d5fe
b5c75a3https://github.com/nodejs/node/commit/b5c75a331d9eacecf11da7f38fb4fa7a0263d5fe
#23250https://github.com/nodejs/node/pull/23250
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23250
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23250/files/76fce3279dee3ab1779f83dfffec847ca913d45d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23250/files/a72be8202946c354062b1221bc5d5b1983a586ba
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23250/files/a72be8202946c354062b1221bc5d5b1983a586ba
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/23250/files/a93f6e07e7aaa19c8b8d4436eab4f9961da9160f
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/23250/files/76fce3279dee3ab1779f83dfffec847ca913d45d
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/23250
https://github.com/shisama
https://github.com/danbev
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.