René's URL Explorer Experiment


Title: http: add missing async_hooks destroy before asyncReset by basti1302 · Pull Request #23201 · nodejs/node · GitHub

Open Graph Title: http: add missing async_hooks destroy before asyncReset by basti1302 · Pull Request #23201 · nodejs/node

X Title: http: add missing async_hooks destroy before asyncReset by basti1302 · Pull Request #23201 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Emit a destroy before calling asyncReset because otherwise the old async_id never gets destroyed. Refs: #19859 This fixes one of the two issues described in here: #19859 (comment), namely the missi...

X Description: Emit a destroy before calling asyncReset because otherwise the old async_id never gets destroyed. Refs: #19859 This fixes one of the two issues described in here: #19859 (comment), namely the missi...

Opengraph URL: https://github.com/nodejs/node/pull/23201

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:db46240a-5598-8a7f-b552-07a0e3d4034b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3D2:2434A:C6C4BB:100CC69:6990636F
html-safe-nonce5a8bc7dfec469c0e56fc15b61c6f43dd491da1c99646f32f78ef59888f63159b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0QyOjI0MzRBOkM2QzRCQjoxMDBDQzY5OjY5OTA2MzZGIiwidmlzaXRvcl9pZCI6Ijg1MjkxMDExMDY0ODcyNTU5MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb6fdb0ad2532aed1852983f44910f64060f3f229ace13131b5ed6434fcdda2d4
hovercard-subject-tagpull_request:219432710
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23201/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bdc20c5119505bcea844814b164636e80ec0965a99b89cafdf8213db64a6b128/nodejs/node/pull/23201
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bdc20c5119505bcea844814b164636e80ec0965a99b89cafdf8213db64a6b128/nodejs/node/pull/23201
og:image:altEmit a destroy before calling asyncReset because otherwise the old async_id never gets destroyed. Refs: #19859 This fixes one of the two issues described in here: #19859 (comment), namely the missi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebasti1302
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23201#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23201
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23201
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23201
Reloadhttps://github.com/nodejs/node/pull/23201
Reloadhttps://github.com/nodejs/node/pull/23201
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23201
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
basti1302https://github.com/basti1302
nodejs:masterhttps://github.com/nodejs/node/tree/master
basti1302:fix-missing-async-hooks-destroy-http-agenthttps://github.com/basti1302/node/tree/fix-missing-async-hooks-destroy-http-agent
Conversationhttps://github.com/nodejs/node/pull/23201
Commits1 (1)https://github.com/nodejs/node/pull/23201/commits
Checkshttps://github.com/nodejs/node/pull/23201/checks
Files changedhttps://github.com/nodejs/node/pull/23201/files
http: add missing async_hooks destroy before asyncResethttps://github.com/nodejs/node/pull/23201#top
basti1302https://github.com/basti1302
nodejs:masterhttps://github.com/nodejs/node/tree/master
basti1302:fix-missing-async-hooks-destroy-http-agenthttps://github.com/basti1302/node/tree/fix-missing-async-hooks-destroy-http-agent
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 1, 2018https://github.com/nodejs/node/pull/23201#issue-365534858
Please reload this pagehttps://github.com/nodejs/node/pull/23201
#19859https://github.com/nodejs/node/issues/19859
#19859 (comment)https://github.com/nodejs/node/issues/19859#issuecomment-425815157
#23263https://github.com/nodejs/node/pull/23263
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23201
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Oct 1, 2018https://github.com/nodejs/node/pull/23201#event-1877156577
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 1, 2018https://github.com/nodejs/node/pull/23201#issuecomment-425968514
Please reload this pagehttps://github.com/nodejs/node/pull/23201
Reusing HTTP connection lead to no destroy triggered #19859 https://github.com/nodejs/node/issues/19859
http: remove duplicate async_hooks init for http parser #23263 https://github.com/nodejs/node/pull/23263
https://github.com/AyushG3112
AyushG3112https://github.com/AyushG3112
Oct 4, 2018https://github.com/nodejs/node/pull/23201#issuecomment-427054288
Please reload this pagehttps://github.com/nodejs/node/pull/23201
https://github.com/basti1302
http: add missing async_hooks destroy before asyncResethttps://github.com/nodejs/node/pull/23201/commits/08fcb79f755ff13f4adf2cd0afbfe00200744cbd
08fcb79https://github.com/nodejs/node/pull/23201/commits/08fcb79f755ff13f4adf2cd0afbfe00200744cbd
nodejs#19859https://github.com/nodejs/node/issues/19859
https://github.com/basti1302
basti1302https://github.com/basti1302
force-pushedhttps://github.com/nodejs/node/compare/eef00f11939e91caf7e5e15c482ed7f9ae94df4d..08fcb79f755ff13f4adf2cd0afbfe00200744cbd
eef00f1https://github.com/nodejs/node/commit/eef00f11939e91caf7e5e15c482ed7f9ae94df4d
08fcb79https://github.com/nodejs/node/commit/08fcb79f755ff13f4adf2cd0afbfe00200744cbd
Compare https://github.com/nodejs/node/compare/eef00f11939e91caf7e5e15c482ed7f9ae94df4d..08fcb79f755ff13f4adf2cd0afbfe00200744cbd
October 4, 2018 20:45https://github.com/nodejs/node/pull/23201#event-1885676799
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 4, 2018 https://github.com/nodejs/node/pull/23201#pullrequestreview-161828040
View reviewed changes https://github.com/nodejs/node/pull/23201/files/08fcb79f755ff13f4adf2cd0afbfe00200744cbd
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/23201#pullrequestreview-161828040
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23201
lib/_http_agent.jshttps://github.com/nodejs/node/pull/23201/files/08fcb79f755ff13f4adf2cd0afbfe00200744cbd#diff-82c531677b9ab4e260025e0397fb0ac4d4316459fa5d16346324e39584cfce96
addaleaxhttps://github.com/addaleax
Oct 4, 2018https://github.com/nodejs/node/pull/23201#discussion_r222841438
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23201
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23201#discussion_r222915216
Please reload this pagehttps://github.com/nodejs/node/pull/23201
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23272https://github.com/nodejs/node/pull/23272
Please reload this pagehttps://github.com/nodejs/node/pull/23201
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
async_wrap https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_wrap
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
Oct 4, 2018https://github.com/nodejs/node/pull/23201#event-1885833256
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018 https://github.com/nodejs/node/pull/23201#ref-pullrequest-367092245
Fix two missing async hooks destroy calls #23272 https://github.com/nodejs/node/pull/23272
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23201#issuecomment-427272961
@addaleaxhttps://github.com/addaleax
#23263https://github.com/nodejs/node/pull/23263
#23272https://github.com/nodejs/node/pull/23272
Please reload this pagehttps://github.com/nodejs/node/pull/23201
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23201#event-1886433222
https://github.com/basti1302
basti1302https://github.com/basti1302
Oct 5, 2018https://github.com/nodejs/node/pull/23201#issuecomment-427273374
Please reload this pagehttps://github.com/nodejs/node/pull/23201
Please reload this pagehttps://github.com/nodejs/node/pull/23201
https://github.com/basti1302
basti1302https://github.com/basti1302
October 10, 2018 08:15https://github.com/nodejs/node/pull/23201#event-1894804684
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 1, 2018 https://github.com/nodejs/node/pull/23201#ref-issue-371306904
Deep dive discussion on {Async,Promise}_hooks & performance nodejs/diagnostics#248 https://github.com/nodejs/diagnostics/issues/248
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23201
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23201/files/08fcb79f755ff13f4adf2cd0afbfe00200744cbd
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/23201
https://github.com/basti1302
https://github.com/AyushG3112
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.