René's URL Explorer Experiment


Title: src: deprecate `UVException()` without `Isolate*` by addaleax · Pull Request #23175 · nodejs/node · GitHub

Open Graph Title: src: deprecate `UVException()` without `Isolate*` by addaleax · Pull Request #23175 · nodejs/node

X Title: src: deprecate `UVException()` without `Isolate*` by addaleax · Pull Request #23175 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This method, like all other methods which use Isolate::GetCurrent(), should be avoided. This was probably overlooked in 75adde0. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes...

X Description: This method, like all other methods which use Isolate::GetCurrent(), should be avoided. This was probably overlooked in 75adde0. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes...

Opengraph URL: https://github.com/nodejs/node/pull/23175

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:69761d09-8ce7-a617-6423-f89807a4cdc3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9192:3EEF45:1096E0D:1561C13:6990C94C
html-safe-nonce03b0764495b10f0608234ae481a3475c4151b1ff409a264b4231cb34f3ec0d04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTkyOjNFRUY0NToxMDk2RTBEOjE1NjFDMTM6Njk5MEM5NEMiLCJ2aXNpdG9yX2lkIjoiNDI4NTM4MDIwOTIxMTkxODY2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacec0be4247a818ddfa1021dce965c69466570f2889ecd436023b93955cc20532f
hovercard-subject-tagpull_request:219212813
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23175/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/32870f590cf43c19b35e5909392a1f51b82590bdbadf6ee68217a2a7d9d2b6f8/nodejs/node/pull/23175
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/32870f590cf43c19b35e5909392a1f51b82590bdbadf6ee68217a2a7d9d2b6f8/nodejs/node/pull/23175
og:image:altThis method, like all other methods which use Isolate::GetCurrent(), should be avoided. This was probably overlooked in 75adde0. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23175#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23175
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23175
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23175
Reloadhttps://github.com/nodejs/node/pull/23175
Reloadhttps://github.com/nodejs/node/pull/23175
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23175
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:deprecate-uv-exception-without-isolatehttps://github.com/addaleax/node/tree/deprecate-uv-exception-without-isolate
Conversationhttps://github.com/nodejs/node/pull/23175
Commits1 (1)https://github.com/nodejs/node/pull/23175/commits
Checkshttps://github.com/nodejs/node/pull/23175/checks
Files changedhttps://github.com/nodejs/node/pull/23175/files
src: deprecate UVException() without Isolate*https://github.com/nodejs/node/pull/23175#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:deprecate-uv-exception-without-isolatehttps://github.com/addaleax/node/tree/deprecate-uv-exception-without-isolate
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 30, 2018https://github.com/nodejs/node/pull/23175#issue-365237808
75adde0https://github.com/nodejs/node/commit/75adde07f9a2de7f38a67bec72bd377d450bdb52
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23175
https://github.com/addaleax
src: deprecate UVException() without Isolate*https://github.com/nodejs/node/pull/23175/commits/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
45bc39chttps://github.com/nodejs/node/pull/23175/commits/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
75adde0https://github.com/addaleax/node/commit/75adde07f9a2de7f38a67bec72bd377d450bdb52
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
Sep 30, 2018https://github.com/nodejs/node/pull/23175#event-1875420586
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 30, 2018https://github.com/nodejs/node/pull/23175#issuecomment-425732299
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1068/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1068/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23175
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 30, 2018 https://github.com/nodejs/node/pull/23175#pullrequestreview-160119987
View reviewed changes https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 30, 2018 https://github.com/nodejs/node/pull/23175#pullrequestreview-160120059
View reviewed changes https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 30, 2018 https://github.com/nodejs/node/pull/23175#pullrequestreview-160120774
View reviewed changes https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 30, 2018 https://github.com/nodejs/node/pull/23175#ref-pullrequest-365238041
src: use default parameters for UVException() #23176 https://github.com/nodejs/node/pull/23176
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Sep 30, 2018 https://github.com/nodejs/node/pull/23175#pullrequestreview-160121046
View reviewed changes https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
Sep 30, 2018https://github.com/nodejs/node/pull/23175#event-1875434571
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 1, 2018 https://github.com/nodejs/node/pull/23175#pullrequestreview-160391680
View reviewed changes https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 1, 2018 https://github.com/nodejs/node/pull/23175#pullrequestreview-160425831
View reviewed changes https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 3, 2018https://github.com/nodejs/node/pull/23175#issuecomment-426794467
https://ci.nodejs.org/job/node-test-pull-request/17609/https://ci.nodejs.org/job/node-test-pull-request/17609/
Please reload this pagehttps://github.com/nodejs/node/pull/23175
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 3, 2018https://github.com/nodejs/node/pull/23175#event-1882983522
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 4, 2018https://github.com/nodejs/node/pull/23175#issuecomment-426898172
c3aaaa7https://github.com/nodejs/node/commit/c3aaaa70b8203cb1c1a52cc72c6fa005dcce9c44
Please reload this pagehttps://github.com/nodejs/node/pull/23175
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 4, 2018https://github.com/nodejs/node/pull/23175#event-1883692757
danbevhttps://github.com/danbev
Oct 4, 2018 https://github.com/nodejs/node/pull/23175#ref-commit-c3aaaa7
https://github.com/addaleax
https://github.com/danbev
src: deprecate UVException() without Isolate*https://github.com/nodejs/node/commit/c3aaaa70b8203cb1c1a52cc72c6fa005dcce9c44
c3aaaa7https://github.com/nodejs/node/commit/c3aaaa70b8203cb1c1a52cc72c6fa005dcce9c44
75adde0https://github.com/nodejs/node/commit/75adde07f9a2de7f38a67bec72bd377d450bdb52
#23175https://github.com/nodejs/node/pull/23175
targoshttps://github.com/targos
Oct 4, 2018 https://github.com/nodejs/node/pull/23175#ref-commit-2da6f62
https://github.com/addaleax
https://github.com/targos
src: deprecate UVException() without Isolate*https://github.com/nodejs/node/commit/2da6f622dc32ea4bacbf67d2acbc09d9359c27e7
2da6f62https://github.com/nodejs/node/commit/2da6f622dc32ea4bacbf67d2acbc09d9359c27e7
75adde0https://github.com/nodejs/node/commit/75adde07f9a2de7f38a67bec72bd377d450bdb52
#23175https://github.com/nodejs/node/pull/23175
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2018 https://github.com/nodejs/node/pull/23175#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23175#ref-commit-0adca98
https://github.com/addaleax
https://github.com/jasnell
src: deprecate UVException() without Isolate*https://github.com/nodejs/node/commit/0adca980991c8cb72a9b3b2f45e5728e44bab051
0adca98https://github.com/nodejs/node/commit/0adca980991c8cb72a9b3b2f45e5728e44bab051
75adde0https://github.com/nodejs/node/commit/75adde07f9a2de7f38a67bec72bd377d450bdb52
#23175https://github.com/nodejs/node/pull/23175
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 19, 2019 20:53https://github.com/nodejs/node/pull/23175#event-2351630755
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23175
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/23175/files/45bc39c1eb579aa8f99c3976a3f809e66e355cf7
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/23175
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/joyeecheung
https://github.com/devsnek
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.