René's URL Explorer Experiment


Title: doc: formalize non-const reference usage in C++ style guide by addaleax · Pull Request #23155 · nodejs/node · GitHub

Open Graph Title: doc: formalize non-const reference usage in C++ style guide by addaleax · Pull Request #23155 · nodejs/node

X Title: doc: formalize non-const reference usage in C++ style guide by addaleax · Pull Request #23155 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Split out from #23028 by request from @refack. I’ve added people who approved the other PR as reviewers on the commit. I’m also moving the tsc-agenda label over here, assuming @refack’s objection s...

X Description: Split out from #23028 by request from @refack. I’ve added people who approved the other PR as reviewers on the commit. I’m also moving the tsc-agenda label over here, assuming @refack’s objection s...

Opengraph URL: https://github.com/nodejs/node/pull/23155

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e93a551f-82bd-1adb-4ad3-186114c5f832
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE538:226374:2520B2:308E16:69906647
html-safe-noncea37783323a8fb385cf343797c4e99dd78a87b85fe857da097236761af10b8bbb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTM4OjIyNjM3NDoyNTIwQjI6MzA4RTE2OjY5OTA2NjQ3IiwidmlzaXRvcl9pZCI6Ijc3MjMzNzU2MTgzOTg2NDM3ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac79dbcbe67aa37b482da966759bd4a3889ab0ff164dcc90dab86d9c92106372bf
hovercard-subject-tagpull_request:219116061
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23155/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8095e68ff1135d36842504067da8274430d7f2999979a0c0c93fbd12b3ebb12/nodejs/node/pull/23155
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8095e68ff1135d36842504067da8274430d7f2999979a0c0c93fbd12b3ebb12/nodejs/node/pull/23155
og:image:altSplit out from #23028 by request from @refack. I’ve added people who approved the other PR as reviewers on the commit. I’m also moving the tsc-agenda label over here, assuming @refack’s objection s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23155#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23155
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23155
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23155
Reloadhttps://github.com/nodejs/node/pull/23155
Reloadhttps://github.com/nodejs/node/pull/23155
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23155
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:cpp-style-guide-no-non-const-referenceshttps://github.com/addaleax/node/tree/cpp-style-guide-no-non-const-references
Conversationhttps://github.com/nodejs/node/pull/23155
Commits5 (5)https://github.com/nodejs/node/pull/23155/commits
Checkshttps://github.com/nodejs/node/pull/23155/checks
Files changedhttps://github.com/nodejs/node/pull/23155/files
doc: formalize non-const reference usage in C++ style guidehttps://github.com/nodejs/node/pull/23155#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:cpp-style-guide-no-non-const-referenceshttps://github.com/addaleax/node/tree/cpp-style-guide-no-non-const-references
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 29, 2018https://github.com/nodejs/node/pull/23155#issue-365082735
Please reload this pagehttps://github.com/nodejs/node/pull/23155
#23028https://github.com/nodejs/node/pull/23028
@refackhttps://github.com/refack
@refackhttps://github.com/refack
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
doc: formalize non-const reference usage in C++ style guidehttps://github.com/nodejs/node/pull/23155/commits/73139a5bda0176b2a7dc62107b0441c089730bd0
73139a5https://github.com/nodejs/node/pull/23155/commits/73139a5bda0176b2a7dc62107b0441c089730bd0
nodejs#23028https://github.com/nodejs/node/pull/23028
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
tsc-agenda https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda
Sep 29, 2018https://github.com/nodejs/node/pull/23155#event-1874707099
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 29, 2018https://github.com/nodejs/node/pull/23155#issuecomment-425603792
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1056/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1056/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 29, 2018 https://github.com/nodejs/node/pull/23155#ref-pullrequest-362881065
doc: formalize auto usage in C++ style guide #23028 https://github.com/nodejs/node/pull/23028
https://github.com/refack
refackhttps://github.com/refack
Sep 29, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160061419
View reviewed changes https://github.com/nodejs/node/pull/23155/files/73139a5bda0176b2a7dc62107b0441c089730bd0
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/23155#pullrequestreview-160061419
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Sep 29, 2018https://github.com/nodejs/node/pull/23155#issuecomment-425607775
P.3: Express intenthttp://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#p3-express-intent
Reference Argumentshttps://google.github.io/styleguide/cppguide.html#Reference_Arguments
F.16: For “in” parameters, pass cheaply-copied types by value and others by reference to consthttp://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-in
F.17: For “in-out” parameters, pass by reference to non-consthttp://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-inout
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Sep 29, 2018https://github.com/nodejs/node/pull/23155#issuecomment-425607949
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/targos
targoshttps://github.com/targos
Sep 29, 2018https://github.com/nodejs/node/pull/23155#issuecomment-425622058
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Sep 29, 2018https://github.com/nodejs/node/pull/23155#issuecomment-425635326
1https://herbsutter.com/2013/06/05/gotw-91-solution-smart-pointer-parameters/
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Sep 29, 2018https://github.com/nodejs/node/pull/23155#issuecomment-425635833
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 29, 2018https://github.com/nodejs/node/pull/23155#issuecomment-425640834
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 29, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160081574
View reviewed changes https://github.com/nodejs/node/pull/23155/files/73139a5bda0176b2a7dc62107b0441c089730bd0
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 30, 2018https://github.com/nodejs/node/pull/23155#issuecomment-425760376
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 1, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160144709
View reviewed changes https://github.com/nodejs/node/pull/23155/files/73139a5bda0176b2a7dc62107b0441c089730bd0
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 1, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160217392
View reviewed changes https://github.com/nodejs/node/pull/23155/files/73139a5bda0176b2a7dc62107b0441c089730bd0
CPP_STYLE_GUIDE.mdhttps://github.com/nodejs/node/pull/23155/files/73139a5bda0176b2a7dc62107b0441c089730bd0#diff-29c9db0176a6dd3d4972619e0fc37c720580d56051e79de4deb53c383777e33e
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 1, 2018 https://github.com/nodejs/node/pull/23155#ref-issue-365430183
Node.js Foundation Technical Steering Committee (TSC) Meeting 2018-10-03 nodejs/TSC#608 https://github.com/nodejs/TSC/issues/608
https://github.com/addaleax
squash! doc: formalize non-const reference usage in C++ style guidehttps://github.com/nodejs/node/pull/23155/commits/8daa18eb3744c93222aae9a9cf9f0af300656144
8daa18ehttps://github.com/nodejs/node/pull/23155/commits/8daa18eb3744c93222aae9a9cf9f0af300656144
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 1, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160279416
View reviewed changes https://github.com/nodejs/node/pull/23155/files/8daa18eb3744c93222aae9a9cf9f0af300656144
CPP_STYLE_GUIDE.mdhttps://github.com/nodejs/node/pull/23155/files/8daa18eb3744c93222aae9a9cf9f0af300656144#diff-29c9db0176a6dd3d4972619e0fc37c720580d56051e79de4deb53c383777e33e
joyeecheunghttps://github.com/joyeecheung
Oct 1, 2018https://github.com/nodejs/node/pull/23155#discussion_r221595913
Please reload this pagehttps://github.com/nodejs/node/pull/23155
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23155
addaleaxhttps://github.com/addaleax
Oct 1, 2018https://github.com/nodejs/node/pull/23155#discussion_r221601991
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e9f8406https://github.com/nodejs/node/commit/e9f84067b623a056faa8ddb43290754450df1b09
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
fixup! squash! doc: formalize non-const reference usage in C++ style …https://github.com/nodejs/node/pull/23155/commits/e9f84067b623a056faa8ddb43290754450df1b09
e9f8406https://github.com/nodejs/node/pull/23155/commits/e9f84067b623a056faa8ddb43290754450df1b09
https://github.com/targos
targoshttps://github.com/targos
Oct 1, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160288720
View reviewed changes https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 1, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160309049
View reviewed changes https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 1, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160402586
View reviewed changes https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
ofrobotshttps://github.com/ofrobots
https://github.com/nodejs/node/pull/23155#pullrequestreview-160402586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://google.github.io/styleguide/cppguide.html#Reference_Argumentshttps://google.github.io/styleguide/cppguide.html#Reference_Arguments
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 2, 2018https://github.com/nodejs/node/pull/23155#issuecomment-426125716
Please reload this pagehttps://github.com/nodejs/node/pull/23155
@addaleaxhttps://github.com/addaleax
@apapirovskihttps://github.com/apapirovski
@danbevhttps://github.com/danbev
@jasnellhttps://github.com/jasnell
@joyeecheunghttps://github.com/joyeecheung
@ofrobotshttps://github.com/ofrobots
@targoshttps://github.com/targos
@cjihrighttps://github.com/cjihrig
@gabrielschulhofhttps://github.com/gabrielschulhof
@mcollinahttps://github.com/mcollina
@MylesBorinshttps://github.com/MylesBorins
@rvagghttps://github.com/rvagg
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 2, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160572255
View reviewed changes https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
CPP_STYLE_GUIDE.mdhttps://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09#diff-29c9db0176a6dd3d4972619e0fc37c720580d56051e79de4deb53c383777e33e
thefourtheyehttps://github.com/thefourtheye
Oct 2, 2018https://github.com/nodejs/node/pull/23155#discussion_r221830281
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23155
addaleaxhttps://github.com/addaleax
Oct 2, 2018https://github.com/nodejs/node/pull/23155#discussion_r221960390
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/23155
CPP_STYLE_GUIDE.mdhttps://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09#diff-29c9db0176a6dd3d4972619e0fc37c720580d56051e79de4deb53c383777e33e
thefourtheyehttps://github.com/thefourtheye
Oct 2, 2018https://github.com/nodejs/node/pull/23155#discussion_r221830307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 2, 2018https://github.com/nodejs/node/pull/23155#issuecomment-426173421
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 2, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-160677017
View reviewed changes https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 2, 2018https://github.com/nodejs/node/pull/23155#issuecomment-426266233
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
fixup! fixup! squash! doc: formalize non-const reference usage in C++…https://github.com/nodejs/node/pull/23155/commits/acba30df49557b5dc101b49b1d9f65703508d7ca
acba30dhttps://github.com/nodejs/node/pull/23155/commits/acba30df49557b5dc101b49b1d9f65703508d7ca
https://github.com/refack
refackhttps://github.com/refack
Oct 16, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430059707
Please reload this pagehttps://github.com/nodejs/node/pull/23155
@addaleaxhttps://github.com/addaleax
std::for_eachhttps://en.cppreference.com/w/cpp/algorithm/for_each
F.11https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-inout
Google style guidehttps://google.github.io/styleguide/cppguide.html#Reference_Arguments
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 16, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430188507
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Oct 16, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430240128
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430497380
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430520279
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430528350
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 17, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430681579
@addaleaxhttps://github.com/addaleax
@refackhttps://github.com/refack
@addaleaxhttps://github.com/addaleax
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430760349
@sam-githubhttps://github.com/sam-github
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 17, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430785257
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430786105
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-165850720
View reviewed changes https://github.com/nodejs/node/pull/23155/files/acba30df49557b5dc101b49b1d9f65703508d7ca
CPP_STYLE_GUIDE.mdhttps://github.com/nodejs/node/pull/23155/files/acba30df49557b5dc101b49b1d9f65703508d7ca#diff-29c9db0176a6dd3d4972619e0fc37c720580d56051e79de4deb53c383777e33e
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Oct 17, 2018https://github.com/nodejs/node/pull/23155#issuecomment-430811744
Please reload this pagehttps://github.com/nodejs/node/pull/23155
node/deps/v8/include/v8.hhttps://github.com/nodejs/node/blob/c1b9be53c89a7ac11c01905a4477785a6154512b/deps/v8/include/v8.h#L3398-L3399
c1b9be5https://github.com/nodejs/node/commit/c1b9be53c89a7ac11c01905a4477785a6154512b
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Oct 18, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-165908917
View reviewed changes https://github.com/nodejs/node/pull/23155/files/acba30df49557b5dc101b49b1d9f65703508d7ca
https://github.com/addaleax
fixup! fixup! fixup! squash! doc: formalize non-const reference usage…https://github.com/nodejs/node/pull/23155/commits/04f941ac965cd638c4dad8baf59ee539759975c3
04f941ahttps://github.com/nodejs/node/pull/23155/commits/04f941ac965cd638c4dad8baf59ee539759975c3
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 18, 2018https://github.com/nodejs/node/pull/23155#issuecomment-431167133
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/refack
refackhttps://github.com/refack
Oct 18, 2018 https://github.com/nodejs/node/pull/23155#pullrequestreview-166311428
View reviewed changes https://github.com/nodejs/node/pull/23155/files/04f941ac965cd638c4dad8baf59ee539759975c3
https://github.com/refack
refackhttps://github.com/refack
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 18, 2018https://github.com/nodejs/node/pull/23155#event-1913457599
https://github.com/refack
refackhttps://github.com/refack
Oct 18, 2018https://github.com/nodejs/node/pull/23155#issuecomment-431177748
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1285/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1285/
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
tsc-agenda https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda
Oct 21, 2018https://github.com/nodejs/node/pull/23155#event-1916474796
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23155#issuecomment-431635018
5550510https://github.com/nodejs/node/commit/5550510056570ed1266c4c3f9bab07f00d4e8ef2
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 21, 2018https://github.com/nodejs/node/pull/23155#event-1916475217
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 21, 2018 03:04https://github.com/nodejs/node/pull/23155#event-1916475229
addaleaxhttps://github.com/addaleax
Oct 21, 2018 https://github.com/nodejs/node/pull/23155#ref-commit-5550510
https://github.com/addaleax
doc: formalize non-const reference usage in C++ style guidehttps://github.com/nodejs/node/commit/5550510056570ed1266c4c3f9bab07f00d4e8ef2
5550510https://github.com/nodejs/node/commit/5550510056570ed1266c4c3f9bab07f00d4e8ef2
#23028https://github.com/nodejs/node/pull/23028
#23155https://github.com/nodejs/node/pull/23155
jasnellhttps://github.com/jasnell
Oct 21, 2018 https://github.com/nodejs/node/pull/23155#ref-commit-eaff120
https://github.com/addaleax
https://github.com/jasnell
doc: formalize non-const reference usage in C++ style guidehttps://github.com/nodejs/node/commit/eaff120bfd4b792b4dc53ad626acfdfc6d1d1f51
eaff120https://github.com/nodejs/node/commit/eaff120bfd4b792b4dc53ad626acfdfc6d1d1f51
#23028https://github.com/nodejs/node/pull/23028
#23155https://github.com/nodejs/node/pull/23155
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Nov 26, 2018https://github.com/nodejs/node/pull/23155#event-1987319857
MylesBorinshttps://github.com/MylesBorins
Nov 26, 2018 https://github.com/nodejs/node/pull/23155#ref-commit-30b1a4a
https://github.com/addaleax
https://github.com/MylesBorins
doc: formalize non-const reference usage in C++ style guidehttps://github.com/nodejs/node/commit/30b1a4a61f3a2f0ecc1f4ac34a074895bd10d0f8
30b1a4ahttps://github.com/nodejs/node/commit/30b1a4a61f3a2f0ecc1f4ac34a074895bd10d0f8
#23028https://github.com/nodejs/node/pull/23028
#23155https://github.com/nodejs/node/pull/23155
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23155#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23155#ref-commit-8e54ee1
https://github.com/addaleax
https://github.com/rvagg
doc: formalize non-const reference usage in C++ style guidehttps://github.com/nodejs/node/commit/8e54ee1712ddf8fc6483eece23d3d9e0d8eb8fa6
8e54ee1https://github.com/nodejs/node/commit/8e54ee1712ddf8fc6483eece23d3d9e0d8eb8fa6
#23028https://github.com/nodejs/node/pull/23028
#23155https://github.com/nodejs/node/pull/23155
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23155#ref-commit-75082ee
https://github.com/addaleax
https://github.com/MylesBorins
doc: formalize non-const reference usage in C++ style guidehttps://github.com/nodejs/node/commit/75082ee15b654f7d7f4edbbf0b396c124644136a
75082eehttps://github.com/nodejs/node/commit/75082ee15b654f7d7f4edbbf0b396c124644136a
#23028https://github.com/nodejs/node/pull/23028
#23155https://github.com/nodejs/node/pull/23155
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23155#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23155
https://github.com/ChALkeR
ChALkeR https://github.com/ChALkeR
https://github.com/nodejs/node/pull/23155/files/acba30df49557b5dc101b49b1d9f65703508d7ca
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node/pull/23155/files/acba30df49557b5dc101b49b1d9f65703508d7ca
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23155/files/73139a5bda0176b2a7dc62107b0441c089730bd0
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/23155/files/73139a5bda0176b2a7dc62107b0441c089730bd0
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/23155/files/acba30df49557b5dc101b49b1d9f65703508d7ca
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/23155/files/04f941ac965cd638c4dad8baf59ee539759975c3
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/23155/files/e9f84067b623a056faa8ddb43290754450df1b09
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Please reload this pagehttps://github.com/nodejs/node/pull/23155
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/targos
https://github.com/Trott
https://github.com/mcollina
https://github.com/MylesBorins
https://github.com/gabrielschulhof
https://github.com/rvagg
https://github.com/sam-github
https://github.com/apapirovski
https://github.com/ofrobots
https://github.com/ChALkeR
https://github.com/danbev
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/tniessen
https://github.com/joyeecheung
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.