René's URL Explorer Experiment


Title: fs: track file offset in writeFile of fs/promises by thefourtheye · Pull Request #23136 · nodejs/node · GitHub

Open Graph Title: fs: track file offset in writeFile of fs/promises by thefourtheye · Pull Request #23136 · nodejs/node

X Title: fs: track file offset in writeFile of fs/promises by thefourtheye · Pull Request #23136 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If the file offset is not tracked with position in the write calls all the data will be always written at the end of the file. This is problematic when we pass file descriptors to writeFile because...

X Description: If the file offset is not tracked with position in the write calls all the data will be always written at the end of the file. This is problematic when we pass file descriptors to writeFile because...

Opengraph URL: https://github.com/nodejs/node/pull/23136

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e44c3522-4a7a-d8cb-5ce1-91e227331dfa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E58:11FDDC:A96BFF:F849A8:6A4E1FCC
html-safe-nonce982eef5ad2b5de7a363b6fd5e687a8c0de3e05926a7d80da85323d970d9ab21f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTU4OjExRkREQzpBOTZCRkY6Rjg0OUE4OjZBNEUxRkNDIiwidmlzaXRvcl9pZCI6IjM4MzA5ODk0NTQwMzk3MTk4ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacff4868ba06b3432d9a16b81c99ea0740f1377aee3f1ac3d0b27f0b9c8f9c2641
hovercard-subject-tagpull_request:218817499
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23136/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/85129dad949ef91c02ee45129cb341df3a335c6954cd886e16b6cde0af57be76/nodejs/node/pull/23136
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/85129dad949ef91c02ee45129cb341df3a335c6954cd886e16b6cde0af57be76/nodejs/node/pull/23136
og:image:altIf the file offset is not tracked with position in the write calls all the data will be always written at the end of the file. This is problematic when we pass file descriptors to writeFile because...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethefourtheye
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5fe497b4815fcce3df76c0e246faa739a82c3124
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23136#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23136
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23136
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23136
Reloadhttps://github.com/nodejs/node/pull/23136
Reloadhttps://github.com/nodejs/node/pull/23136
Please reload this pagehttps://github.com/nodejs/node/pull/23136
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23136
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:fix-fs-promises-writefilehttps://github.com/thefourtheye/io.js/tree/fix-fs-promises-writefile
Conversationhttps://github.com/nodejs/node/pull/23136
Commits1 (1)https://github.com/nodejs/node/pull/23136/commits
Checkshttps://github.com/nodejs/node/pull/23136/checks
Files changedhttps://github.com/nodejs/node/pull/23136/files
fs: track file offset in writeFile of fs/promiseshttps://github.com/nodejs/node/pull/23136#top
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:fix-fs-promises-writefilehttps://github.com/thefourtheye/io.js/tree/fix-fs-promises-writefile
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Sep 27, 2018https://github.com/nodejs/node/pull/23136#issue-364690597
Please reload this pagehttps://github.com/nodejs/node/pull/23136
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
fs: track file offset in writeFile of fs/promiseshttps://github.com/nodejs/node/pull/23136/commits/18d8c1e8c4ba8d06369b1ad6969fa89a950571ae
18d8c1ehttps://github.com/nodejs/node/pull/23136/commits/18d8c1e8c4ba8d06369b1ad6969fa89a950571ae
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 27, 2018https://github.com/nodejs/node/pull/23136#issuecomment-425275742
@thefourtheyehttps://github.com/thefourtheye
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1046/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1046/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Sep 27, 2018https://github.com/nodejs/node/pull/23136#event-1872363936
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Sep 27, 2018https://github.com/nodejs/node/pull/23136#issuecomment-425278029
@vsemozhetbythttps://github.com/vsemozhetbyt
#22554https://github.com/nodejs/node/issues/22554
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Sep 27, 2018https://github.com/nodejs/node/pull/23136#issuecomment-425278514
https://ci.nodejs.org/job/node-test-pull-request/17479/https://ci.nodejs.org/job/node-test-pull-request/17479/
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Sep 28, 2018https://github.com/nodejs/node/pull/23136#event-1872693361
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Sep 30, 2018 https://github.com/nodejs/node/pull/23136#ref-pullrequest-365244011
fs: make sure that file is truncated in writeFile #23181 https://github.com/nodejs/node/pull/23181
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 30, 2018https://github.com/nodejs/node/pull/23136#issuecomment-425739745
#23181https://github.com/nodejs/node/pull/23181
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Sep 30, 2018https://github.com/nodejs/node/pull/23136#issuecomment-425741453
Please reload this pagehttps://github.com/nodejs/node/pull/23136
@addaleaxhttps://github.com/addaleax
#22554https://github.com/nodejs/node/issues/22554
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 30, 2018https://github.com/nodejs/node/pull/23136#issuecomment-425760265
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 5, 2018https://github.com/nodejs/node/pull/23136#issuecomment-427525615
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 9, 2018https://github.com/nodejs/node/pull/23136#event-1893601066
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 10, 2018https://github.com/nodejs/node/pull/23136#issuecomment-428574596
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 10, 2018 https://github.com/nodejs/node/pull/23136#pullrequestreview-163450530
View reviewed changes https://github.com/nodejs/node/pull/23136/files/18d8c1e8c4ba8d06369b1ad6969fa89a950571ae
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/23136/files/18d8c1e8c4ba8d06369b1ad6969fa89a950571ae#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
sam-githubhttps://github.com/sam-github
Oct 10, 2018https://github.com/nodejs/node/pull/23136#discussion_r224151966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23136
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2018https://github.com/nodejs/node/pull/23136#discussion_r224407547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 10, 2018https://github.com/nodejs/node/pull/23136#issuecomment-428641481
#10853 (comment)https://github.com/nodejs/node/pull/10853#issuecomment-273291312
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2018https://github.com/nodejs/node/pull/23136#issuecomment-428918271
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2018https://github.com/nodejs/node/pull/23136#issuecomment-429069515
@sam-githubhttps://github.com/sam-github
#23181https://github.com/nodejs/node/pull/23181
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Oct 11, 2018https://github.com/nodejs/node/pull/23136#issuecomment-429092234
@thefourtheyehttps://github.com/thefourtheye
#10853https://github.com/nodejs/node/pull/10853
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2018https://github.com/nodejs/node/pull/23136#issuecomment-429139969
@sam-githubhttps://github.com/sam-github
#10853https://github.com/nodejs/node/pull/10853
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2018https://github.com/nodejs/node/pull/23136#issuecomment-430771298
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 23, 2018https://github.com/nodejs/node/pull/23136#event-1921351053
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 20, 2018https://github.com/nodejs/node/pull/23136#issuecomment-440467739
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Dec 17, 2018https://github.com/nodejs/node/pull/23136#issuecomment-447729992
#23433https://github.com/nodejs/node/issues/23433
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Dec 17, 2018https://github.com/nodejs/node/pull/23136#event-2029370667
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
December 17, 2018 05:51https://github.com/nodejs/node/pull/23136#event-2029370721
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23136
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/23136/files/18d8c1e8c4ba8d06369b1ad6969fa89a950571ae
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Please reload this pagehttps://github.com/nodejs/node/pull/23136
https://github.com/thefourtheye
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/sam-github
https://github.com/jasnell
https://github.com/Trott
https://github.com/vsemozhetbyt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.