René's URL Explorer Experiment


Title: src: make req_wrap a unique_ptr in AfterConnect by danbev · Pull Request #23115 · nodejs/node · GitHub

Open Graph Title: src: make req_wrap a unique_ptr in AfterConnect by danbev · Pull Request #23115 · nodejs/node

X Title: src: make req_wrap a unique_ptr in AfterConnect by danbev · Pull Request #23115 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/23115

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:52053507-4bea-4d83-80a5-d4efc179ccd4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD12C:102AB5:9FEC58:CCA486:6990C96D
html-safe-nonced3b941cf6a7a6db835479e4d494dc83f87d3a4e0c30b4b9d57751de5828d0dfa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTJDOjEwMkFCNTo5RkVDNTg6Q0NBNDg2OjY5OTBDOTZEIiwidmlzaXRvcl9pZCI6IjMxOTU5MDY0NzgzNTI0MTkxODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace7efc11e0dc0041ab556ca65c3ab70b0b7f4a419fdaeca404e1f9e8657eda7b3
hovercard-subject-tagpull_request:218536830
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23115/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/660c84a9c8b0b5afbae3b37455489801e69477a5d09871c0a6b6a44350706032/nodejs/node/pull/23115
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/660c84a9c8b0b5afbae3b37455489801e69477a5d09871c0a6b6a44350706032/nodejs/node/pull/23115
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23115#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23115
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23115
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23115
Reloadhttps://github.com/nodejs/node/pull/23115
Reloadhttps://github.com/nodejs/node/pull/23115
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23115
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:connection_wrap_unique_ptrhttps://github.com/danbev/node/tree/connection_wrap_unique_ptr
Conversationhttps://github.com/nodejs/node/pull/23115
Commits1 (1)https://github.com/nodejs/node/pull/23115/commits
Checkshttps://github.com/nodejs/node/pull/23115/checks
Files changedhttps://github.com/nodejs/node/pull/23115/files
src: make req_wrap a unique_ptr in AfterConnecthttps://github.com/nodejs/node/pull/23115#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:connection_wrap_unique_ptrhttps://github.com/danbev/node/tree/connection_wrap_unique_ptr
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 27, 2018https://github.com/nodejs/node/pull/23115#issue-364321827
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 27, 2018https://github.com/nodejs/node/pull/23115#issuecomment-424973046
@danbevhttps://github.com/danbev
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1037/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1037/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Sep 27, 2018https://github.com/nodejs/node/pull/23115#event-1870171052
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 27, 2018https://github.com/nodejs/node/pull/23115#issuecomment-424973147
https://ci.nodejs.org/job/node-test-pull-request/17466/https://ci.nodejs.org/job/node-test-pull-request/17466/
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Sep 27, 2018https://github.com/nodejs/node/pull/23115#issuecomment-424983235
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Sep 27, 2018 https://github.com/nodejs/node/pull/23115#pullrequestreview-159309293
View reviewed changes https://github.com/nodejs/node/pull/23115/files
https://github.com/targos
targoshttps://github.com/targos
Sep 27, 2018 https://github.com/nodejs/node/pull/23115#pullrequestreview-159343692
View reviewed changes https://github.com/nodejs/node/pull/23115/files
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 27, 2018https://github.com/nodejs/node/pull/23115#issuecomment-425046905
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 27, 2018 https://github.com/nodejs/node/pull/23115#pullrequestreview-159402006
View reviewed changes https://github.com/nodejs/node/pull/23115/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 27, 2018 https://github.com/nodejs/node/pull/23115#pullrequestreview-159426618
View reviewed changes https://github.com/nodejs/node/pull/23115/files
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Sep 27, 2018 https://github.com/nodejs/node/pull/23115#pullrequestreview-159503159
View reviewed changes https://github.com/nodejs/node/pull/23115/files
https://github.com/danbev
src: make req_wrap a unique_ptr in AfterConnecthttps://github.com/nodejs/node/pull/23115/commits/312c95943dfbe4e28d25b4900dd600179bef09df
312c959https://github.com/nodejs/node/pull/23115/commits/312c95943dfbe4e28d25b4900dd600179bef09df
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/7b202f3035090c7a20479aa0b15a11f2064f4621..312c95943dfbe4e28d25b4900dd600179bef09df
7b202f3https://github.com/nodejs/node/commit/7b202f3035090c7a20479aa0b15a11f2064f4621
312c959https://github.com/nodejs/node/commit/312c95943dfbe4e28d25b4900dd600179bef09df
Compare https://github.com/nodejs/node/compare/7b202f3035090c7a20479aa0b15a11f2064f4621..312c95943dfbe4e28d25b4900dd600179bef09df
September 28, 2018 03:38https://github.com/nodejs/node/pull/23115#event-1872579686
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 28, 2018https://github.com/nodejs/node/pull/23115#issuecomment-425311351
https://ci.nodejs.org/job/node-test-pull-request/17489/https://ci.nodejs.org/job/node-test-pull-request/17489/
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 28, 2018 https://github.com/nodejs/node/pull/23115#pullrequestreview-160021627
View reviewed changes https://github.com/nodejs/node/pull/23115/files/312c95943dfbe4e28d25b4900dd600179bef09df
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 28, 2018 https://github.com/nodejs/node/pull/23115#pullrequestreview-160050207
View reviewed changes https://github.com/nodejs/node/pull/23115/files/312c95943dfbe4e28d25b4900dd600179bef09df
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 30, 2018https://github.com/nodejs/node/pull/23115#event-1875413091
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 30, 2018https://github.com/nodejs/node/pull/23115#issuecomment-425730881
https://ci.nodejs.org/job/node-test-pull-request/17527/https://ci.nodejs.org/job/node-test-pull-request/17527/
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 1, 2018https://github.com/nodejs/node/pull/23115#issuecomment-425791486
Please reload this pagehttps://github.com/nodejs/node/pull/23115
node-test-commit-windows-fanned/https://ci.nodejs.org/job/node-test-commit-windows-fanned/21157/
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 1, 2018https://github.com/nodejs/node/pull/23115#issuecomment-425802859
5c855a7https://github.com/nodejs/node/commit/5c855a7334e27fdff2fde9eae084adf588e1a135
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 1, 2018https://github.com/nodejs/node/pull/23115#event-1875876587
https://github.com/danbev
danbevhttps://github.com/danbev
October 1, 2018 06:33https://github.com/nodejs/node/pull/23115#event-1875876863
danbevhttps://github.com/danbev
Oct 1, 2018 https://github.com/nodejs/node/pull/23115#ref-commit-5c855a7
https://github.com/danbev
src: make req_wrap a unique_ptr in AfterConnecthttps://github.com/nodejs/node/commit/5c855a7334e27fdff2fde9eae084adf588e1a135
5c855a7https://github.com/nodejs/node/commit/5c855a7334e27fdff2fde9eae084adf588e1a135
#23115https://github.com/nodejs/node/pull/23115
targoshttps://github.com/targos
Oct 1, 2018 https://github.com/nodejs/node/pull/23115#ref-commit-279c07e
https://github.com/danbev
https://github.com/targos
src: make req_wrap a unique_ptr in AfterConnecthttps://github.com/nodejs/node/commit/279c07eec574c1cc35ac319b28fa9b9a64bb8ae9
279c07ehttps://github.com/nodejs/node/commit/279c07eec574c1cc35ac319b28fa9b9a64bb8ae9
#23115https://github.com/nodejs/node/pull/23115
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 2, 2018 https://github.com/nodejs/node/pull/23115#ref-issue-365839731
CI failures: 20180927-20181002 nodejs/reliability#18 https://github.com/nodejs/reliability/issues/18
targoshttps://github.com/targos
Oct 3, 2018 https://github.com/nodejs/node/pull/23115#ref-commit-20a4f14
https://github.com/danbev
https://github.com/targos
src: make req_wrap a unique_ptr in AfterConnecthttps://github.com/nodejs/node/commit/20a4f14c576d4176c516deb4d7c5f41210b443a4
20a4f14https://github.com/nodejs/node/commit/20a4f14c576d4176c516deb4d7c5f41210b443a4
#23115https://github.com/nodejs/node/pull/23115
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2018 https://github.com/nodejs/node/pull/23115#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23115
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23115/files/312c95943dfbe4e28d25b4900dd600179bef09df
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23115/files/e1ec6c18cca746da5948e4f5f3d0df966878cbd4
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/23115/files/e1ec6c18cca746da5948e4f5f3d0df966878cbd4
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23115/files/e1ec6c18cca746da5948e4f5f3d0df966878cbd4
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23115/files/312c95943dfbe4e28d25b4900dd600179bef09df
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/23115/files/e1ec6c18cca746da5948e4f5f3d0df966878cbd4
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/23115/files/e1ec6c18cca746da5948e4f5f3d0df966878cbd4
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/23115
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/gireeshpunathil
https://github.com/addaleax
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/targos
https://github.com/cjihrig
https://github.com/joyeecheung
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.