René's URL Explorer Experiment


Title: crypto: replace goto SSL_CTX_use_certificate_chain by danbev · Pull Request #23113 · nodejs/node · GitHub

Open Graph Title: crypto: replace goto SSL_CTX_use_certificate_chain by danbev · Pull Request #23113 · nodejs/node

X Title: crypto: replace goto SSL_CTX_use_certificate_chain by danbev · Pull Request #23113 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit removes the goto statements in SSL_CTX_use_certificate_chain by using a unique_ptr. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit gu...

X Description: This commit removes the goto statements in SSL_CTX_use_certificate_chain by using a unique_ptr. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit gu...

Opengraph URL: https://github.com/nodejs/node/pull/23113

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ed06a842-44aa-2b03-8bc6-0ad9ec92a4bf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD322:A9CDC:120380A:1750FFD:6990CE1E
html-safe-nonce992524c97266860496fabb2973f20559f29a8cb576d2d7c2007749609b88de28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzIyOkE5Q0RDOjEyMDM4MEE6MTc1MEZGRDo2OTkwQ0UxRSIsInZpc2l0b3JfaWQiOiI1MDQyMzc5MzUzNDU2OTU0OTEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac64bbc4786c667eccaa3384d594c6f1b67dd8e7136fc8c0fba3f2fee7bdfca0b1
hovercard-subject-tagpull_request:218521232
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23113/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/24b55d87049876cd2b6093a12486e969e963628a80bcec24fa0e969ecc9494be/nodejs/node/pull/23113
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/24b55d87049876cd2b6093a12486e969e963628a80bcec24fa0e969ecc9494be/nodejs/node/pull/23113
og:image:altThis commit removes the goto statements in SSL_CTX_use_certificate_chain by using a unique_ptr. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit gu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23113#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23113
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23113
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23113
Reloadhttps://github.com/nodejs/node/pull/23113
Reloadhttps://github.com/nodejs/node/pull/23113
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23113
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto_cert_chain_gotohttps://github.com/danbev/node/tree/crypto_cert_chain_goto
Conversationhttps://github.com/nodejs/node/pull/23113
Commits1 (1)https://github.com/nodejs/node/pull/23113/commits
Checkshttps://github.com/nodejs/node/pull/23113/checks
Files changedhttps://github.com/nodejs/node/pull/23113/files
crypto: replace goto SSL_CTX_use_certificate_chainhttps://github.com/nodejs/node/pull/23113#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto_cert_chain_gotohttps://github.com/danbev/node/tree/crypto_cert_chain_goto
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 27, 2018https://github.com/nodejs/node/pull/23113#issue-364301221
Please reload this pagehttps://github.com/nodejs/node/pull/23113
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 27, 2018https://github.com/nodejs/node/pull/23113#issuecomment-424955883
@danbevhttps://github.com/danbev
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1035/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1035/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Sep 27, 2018https://github.com/nodejs/node/pull/23113#event-1870054136
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 27, 2018https://github.com/nodejs/node/pull/23113#issuecomment-424955935
https://ci.nodejs.org/job/node-test-pull-request/17464/https://ci.nodejs.org/job/node-test-pull-request/17464/
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 27, 2018 https://github.com/nodejs/node/pull/23113#pullrequestreview-159410554
View reviewed changes https://github.com/nodejs/node/pull/23113/files
src/node_crypto.cchttps://github.com/nodejs/node/pull/23113/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 27, 2018 https://github.com/nodejs/node/pull/23113#pullrequestreview-159609759
View reviewed changes https://github.com/nodejs/node/pull/23113/files
src/node_crypto.cchttps://github.com/nodejs/node/pull/23113/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
bnoordhuishttps://github.com/bnoordhuis
Sep 27, 2018https://github.com/nodejs/node/pull/23113#discussion_r221052470
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23113
addaleaxhttps://github.com/addaleax
Sep 30, 2018https://github.com/nodejs/node/pull/23113#discussion_r221463884
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23113
danbevhttps://github.com/danbev
Oct 2, 2018https://github.com/nodejs/node/pull/23113#discussion_r221817140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 3, 2018 https://github.com/nodejs/node/pull/23113#ref-pullrequest-365082735
doc: formalize non-const reference usage in C++ style guide #23155 https://github.com/nodejs/node/pull/23155
https://github.com/danbev
danbevhttps://github.com/danbev
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 3, 2018https://github.com/nodejs/node/pull/23113#event-1881666621
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/bbfee1c9e2b9966d92ee414879fd5c4ffe77253b..65405867969f4136289312a120e02cb9bf0c90fe
bbfee1chttps://github.com/nodejs/node/commit/bbfee1c9e2b9966d92ee414879fd5c4ffe77253b
6540586https://github.com/nodejs/node/commit/65405867969f4136289312a120e02cb9bf0c90fe
Compare https://github.com/nodejs/node/compare/bbfee1c9e2b9966d92ee414879fd5c4ffe77253b..65405867969f4136289312a120e02cb9bf0c90fe
October 3, 2018 12:54https://github.com/nodejs/node/pull/23113#event-1881813442
https://github.com/danbev
crypto: replace goto SSL_CTX_use_certificate_chainhttps://github.com/nodejs/node/pull/23113/commits/a46fae02d6cbc45ab0532ac8d039c09643aa8123
a46fae0https://github.com/nodejs/node/pull/23113/commits/a46fae02d6cbc45ab0532ac8d039c09643aa8123
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/65405867969f4136289312a120e02cb9bf0c90fe..a46fae02d6cbc45ab0532ac8d039c09643aa8123
6540586https://github.com/nodejs/node/commit/65405867969f4136289312a120e02cb9bf0c90fe
a46fae0https://github.com/nodejs/node/commit/a46fae02d6cbc45ab0532ac8d039c09643aa8123
Compare https://github.com/nodejs/node/compare/65405867969f4136289312a120e02cb9bf0c90fe..a46fae02d6cbc45ab0532ac8d039c09643aa8123
October 4, 2018 06:51https://github.com/nodejs/node/pull/23113#event-1883743874
https://github.com/danbev
danbevhttps://github.com/danbev
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 4, 2018https://github.com/nodejs/node/pull/23113#event-1883748723
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 4, 2018https://github.com/nodejs/node/pull/23113#issuecomment-426905822
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://ci.nodejs.org/job/node-test-pull-request/17623/https://ci.nodejs.org/job/node-test-pull-request/17623/
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 4, 2018 https://github.com/nodejs/node/pull/23113#pullrequestreview-161823603
View reviewed changes https://github.com/nodejs/node/pull/23113/files/a46fae02d6cbc45ab0532ac8d039c09643aa8123
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/23113#pullrequestreview-161823603
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 4, 2018https://github.com/nodejs/node/pull/23113#event-1885798808
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 5, 2018 https://github.com/nodejs/node/pull/23113#pullrequestreview-162148533
View reviewed changes https://github.com/nodejs/node/pull/23113/files/a46fae02d6cbc45ab0532ac8d039c09643aa8123
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 8, 2018https://github.com/nodejs/node/pull/23113#issuecomment-427716450
8d218a9https://github.com/nodejs/node/commit/8d218a9bb96015d69c3d1bc81cd320c2b99d79e9
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 8, 2018https://github.com/nodejs/node/pull/23113#event-1889363143
https://github.com/danbev
danbevhttps://github.com/danbev
October 8, 2018 03:56https://github.com/nodejs/node/pull/23113#event-1889363313
danbevhttps://github.com/danbev
Oct 8, 2018 https://github.com/nodejs/node/pull/23113#ref-commit-8d218a9
https://github.com/danbev
crypto: replace goto SSL_CTX_use_certificate_chainhttps://github.com/nodejs/node/commit/8d218a9bb96015d69c3d1bc81cd320c2b99d79e9
8d218a9https://github.com/nodejs/node/commit/8d218a9bb96015d69c3d1bc81cd320c2b99d79e9
#23113https://github.com/nodejs/node/pull/23113
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23113#ref-commit-5f450f3
https://github.com/danbev
https://github.com/targos
crypto: replace goto SSL_CTX_use_certificate_chainhttps://github.com/nodejs/node/commit/5f450f3f926370b1caff3960d884d7afef8a1f30
5f450f3https://github.com/nodejs/node/commit/5f450f3f926370b1caff3960d884d7afef8a1f30
#23113https://github.com/nodejs/node/pull/23113
https://github.com/targos
targoshttps://github.com/targos
Oct 10, 2018 https://github.com/nodejs/node/pull/23113#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/23113#ref-commit-0ed26b5
https://github.com/danbev
https://github.com/jasnell
crypto: replace goto SSL_CTX_use_certificate_chainhttps://github.com/nodejs/node/commit/0ed26b5a2dde2b1c775a2090cba57049c450660c
0ed26b5https://github.com/nodejs/node/commit/0ed26b5a2dde2b1c775a2090cba57049c450660c
#23113https://github.com/nodejs/node/pull/23113
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23113
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/23113/files/bbfee1c9e2b9966d92ee414879fd5c4ffe77253b
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23113/files/a46fae02d6cbc45ab0532ac8d039c09643aa8123
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23113/files/a46fae02d6cbc45ab0532ac8d039c09643aa8123
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/23113
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.