René's URL Explorer Experiment


Title: src: ready background workers before bootstrap by ofrobots · Pull Request #23110 · nodejs/node · GitHub

Open Graph Title: src: ready background workers before bootstrap by ofrobots · Pull Request #23110 · nodejs/node

X Title: src: ready background workers before bootstrap by ofrobots · Pull Request #23110 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes the thread race on startup with background threads (#23065). Included here is a fix in libuv that needs to land upstream (libuv/libuv#2003), but I am opening the PR early so that I can g...

X Description: This fixes the thread race on startup with background threads (#23065). Included here is a fix in libuv that needs to land upstream (libuv/libuv#2003), but I am opening the PR early so that I can g...

Opengraph URL: https://github.com/nodejs/node/pull/23110

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:22ce415c-b513-c9ce-a0c4-5b0e1f0f4143
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD57C:1AF714:1A2C446:21250ED:699191B8
html-safe-noncee9e61d9f8d6bd9d0dc8e1017a20c1c91dd4c9d2d79f08a2daa9ec0feaf7230da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTdDOjFBRjcxNDoxQTJDNDQ2OjIxMjUwRUQ6Njk5MTkxQjgiLCJ2aXNpdG9yX2lkIjoiMTIxMjcyNjM0ODk5NDQxNzA4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd849074947986c1514ac3c1ed6d9a40d9b7224a6106b86b712bfdf17b15d3c48
hovercard-subject-tagpull_request:218487482
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23110/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/27715e24e8d2a881607112b4cd715f100e2787269a1feacd40bf0d33cd77fad1/nodejs/node/pull/23110
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/27715e24e8d2a881607112b4cd715f100e2787269a1feacd40bf0d33cd77fad1/nodejs/node/pull/23110
og:image:altThis fixes the thread race on startup with background threads (#23065). Included here is a fix in libuv that needs to land upstream (libuv/libuv#2003), but I am opening the PR early so that I can g...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameofrobots
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23110#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23110
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23110
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23110
Reloadhttps://github.com/nodejs/node/pull/23110
Reloadhttps://github.com/nodejs/node/pull/23110
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23110
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ofrobotshttps://github.com/ofrobots
nodejs:masterhttps://github.com/nodejs/node/tree/master
ofrobots:fix-windows-background-worker-inithttps://github.com/ofrobots/node/tree/fix-windows-background-worker-init
Conversationhttps://github.com/nodejs/node/pull/23110
Commits2 (2)https://github.com/nodejs/node/pull/23110/commits
Checkshttps://github.com/nodejs/node/pull/23110/checks
Files changedhttps://github.com/nodejs/node/pull/23110/files
src: ready background workers before bootstraphttps://github.com/nodejs/node/pull/23110#top
ofrobotshttps://github.com/ofrobots
nodejs:masterhttps://github.com/nodejs/node/tree/master
ofrobots:fix-windows-background-worker-inithttps://github.com/ofrobots/node/tree/fix-windows-background-worker-init
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 26, 2018https://github.com/nodejs/node/pull/23110#issue-364255485
#23065https://github.com/nodejs/node/issues/23065
libuv/libuv#2003https://github.com/libuv/libuv/pull/2003
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2018https://github.com/nodejs/node/pull/23110#issuecomment-424908299
@ofrobotshttps://github.com/ofrobots
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1033/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1033/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
libuv https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alibuv
Sep 26, 2018https://github.com/nodejs/node/pull/23110#event-1869781988
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
force-pushedhttps://github.com/nodejs/node/compare/2a5cf523a8650ac00c55a57363a0f2ab2a561b09..58b2294e17b3c0981b35b63b6e356cbc4bb83633
2a5cf52https://github.com/nodejs/node/commit/2a5cf523a8650ac00c55a57363a0f2ab2a561b09
58b2294https://github.com/nodejs/node/commit/58b2294e17b3c0981b35b63b6e356cbc4bb83633
Compare https://github.com/nodejs/node/compare/2a5cf523a8650ac00c55a57363a0f2ab2a561b09..58b2294e17b3c0981b35b63b6e356cbc4bb83633
September 27, 2018 00:05https://github.com/nodejs/node/pull/23110#event-1869791243
https://github.com/mscdex
mscdexhttps://github.com/mscdex
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Sep 27, 2018https://github.com/nodejs/node/pull/23110#event-1869820535
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 28, 2018 https://github.com/nodejs/node/pull/23110#ref-pullrequest-325489986
src: trace_event: secondary storage for metadata #20900 https://github.com/nodejs/node/pull/20900
https://github.com/jasnell
jasnellhttps://github.com/jasnell
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Sep 28, 2018https://github.com/nodejs/node/pull/23110#event-1874619521
ofrobotshttps://github.com/ofrobots
October 1, 2018 13:19https://github.com/nodejs/node/pull/23110#commits-pushed-32bd197
https://github.com/ofrobots
deps: uv: cherry-pickhttps://github.com/nodejs/node/pull/23110/commits/32bd1978807bd40ea513eb6c7417b62e0cd7f9a9
a989af1https://github.com/ofrobots/node/commit/a989af126201294afc475e315f628f43323634d9
from upstreamhttps://github.com/nodejs/node/pull/23110/commits/32bd1978807bd40ea513eb6c7417b62e0cd7f9a9
32bd197https://github.com/nodejs/node/pull/23110/commits/32bd1978807bd40ea513eb6c7417b62e0cd7f9a9
https://github.com/ofrobots
src: ready background workers before bootstraphttps://github.com/nodejs/node/pull/23110/commits/f0db5929ffd118d8ee8ab520da16448b491af071
f0db592https://github.com/nodejs/node/pull/23110/commits/f0db5929ffd118d8ee8ab520da16448b491af071
nodejs#23065https://github.com/nodejs/node/issues/23065
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
force-pushedhttps://github.com/nodejs/node/compare/58b2294e17b3c0981b35b63b6e356cbc4bb83633..f0db5929ffd118d8ee8ab520da16448b491af071
58b2294https://github.com/nodejs/node/commit/58b2294e17b3c0981b35b63b6e356cbc4bb83633
f0db592https://github.com/nodejs/node/commit/f0db5929ffd118d8ee8ab520da16448b491af071
Compare https://github.com/nodejs/node/compare/58b2294e17b3c0981b35b63b6e356cbc4bb83633..f0db5929ffd118d8ee8ab520da16448b491af071
October 1, 2018 22:27https://github.com/nodejs/node/pull/23110#event-1877968875
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 1, 2018https://github.com/nodejs/node/pull/23110#event-1877969246
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 1, 2018https://github.com/nodejs/node/pull/23110#issuecomment-426085422
https://ci.nodejs.org/job/node-test-pull-request/17570/https://ci.nodejs.org/job/node-test-pull-request/17570/
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 1, 2018 https://github.com/nodejs/node/pull/23110#ref-issue-363278324
Platform thread race: process.exit executed before background threads are ready #23065 https://github.com/nodejs/node/issues/23065
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 2, 2018 https://github.com/nodejs/node/pull/23110#pullrequestreview-160554471
View reviewed changes https://github.com/nodejs/node/pull/23110/files/f0db5929ffd118d8ee8ab520da16448b491af071
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 2, 2018 https://github.com/nodejs/node/pull/23110#ref-issue-365839731
CI failures: 20180927-20181002 nodejs/reliability#18 https://github.com/nodejs/reliability/issues/18
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 2, 2018 https://github.com/nodejs/node/pull/23110#ref-issue-365893851
Access to AIX and SmartOS machine for ofrobots nodejs/build#1514 https://github.com/nodejs/build/issues/1514
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 2, 2018https://github.com/nodejs/node/pull/23110#issuecomment-426346494
https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/18151/consolehttps://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/18151/console
#22631https://github.com/nodejs/node/pull/22631
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 2, 2018https://github.com/nodejs/node/pull/23110#issuecomment-426459801
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 2, 2018https://github.com/nodejs/node/pull/23110#issuecomment-426465437
@ofrobotshttps://github.com/ofrobots
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 3, 2018https://github.com/nodejs/node/pull/23110#issuecomment-426475637
Please reload this pagehttps://github.com/nodejs/node/pull/23110
@joyeecheunghttps://github.com/joyeecheung
supporthttps://github.com/nodejs/node/blob/master/BUILDING.md#supported-platforms-1
end-of-lifehttps://www-01.ibm.com/support/docview.wss?uid=isg3T1012517
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 3, 2018 https://github.com/nodejs/node/pull/23110#ref-pullrequest-366140121
src: ready background workers before bootstrap #23233 https://github.com/nodejs/node/pull/23233
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 3, 2018https://github.com/nodejs/node/pull/23110#issuecomment-426485457
supporthttps://github.com/nodejs/node/blob/master/BUILDING.md#supported-platforms-1
end-of-lifehttps://www-01.ibm.com/support/docview.wss?uid=isg3T1012517
supported on AIX 6.1 TL09https://github.com/nodejs/node/blob/v6.x/BUILDING.md#supported-platforms-1
code paths in libuv on AIXhttps://github.com/libuv/libuv/pull/1940#discussion_r208405542
@gdamshttps://github.com/gdams
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 3, 2018https://github.com/nodejs/node/pull/23110#issuecomment-426726349
#23233https://github.com/nodejs/node/pull/23233
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 3, 2018https://github.com/nodejs/node/pull/23110#event-1882542680
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
October 3, 2018 17:31https://github.com/nodejs/node/pull/23110#event-1882542889
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23110
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23110/files/f0db5929ffd118d8ee8ab520da16448b491af071
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
libuv https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alibuv
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/23110
https://github.com/ofrobots
https://github.com/nodejs-github-bot
https://github.com/joyeecheung
https://github.com/richardlau
https://github.com/jasnell
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.