René's URL Explorer Experiment


Title: test: replace localhost with os.hostname in fs-readfilesync by lundibundi · Pull Request #23101 · nodejs/node · GitHub

Open Graph Title: test: replace localhost with os.hostname in fs-readfilesync by lundibundi · Pull Request #23101 · nodejs/node

X Title: test: replace localhost with os.hostname in fs-readfilesync by lundibundi · Pull Request #23101 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #21501 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes (waiting for CI) tests and/or benchmarks are included commit message follows commit guidelines @targos could yo...

X Description: Fixes: #21501 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes (waiting for CI) tests and/or benchmarks are included commit message follows commit guidelines @targos could yo...

Opengraph URL: https://github.com/nodejs/node/pull/23101

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fc66ffeb-9f1b-6d53-b095-9546e578cccb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD6F8:1F7AEB:74344E:935214:69913864
html-safe-nonce74b47a07a58b4022b7d6bd2ae6c3aab1b40983fa6a55ae322467dd7345265a4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkY4OjFGN0FFQjo3NDM0NEU6OTM1MjE0OjY5OTEzODY0IiwidmlzaXRvcl9pZCI6IjMwODM1MjY0MTI3ODQ3MTE3ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf7b16f5dc22cce7a7a41e8e8a876e5bb0279bcff921415ee42b16005cb24e044
hovercard-subject-tagpull_request:218278611
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23101/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d2525a3c7ab28716888eb08e0818e9970b4e1548735d6c267a898c3e5ca5f814/nodejs/node/pull/23101
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d2525a3c7ab28716888eb08e0818e9970b4e1548735d6c267a898c3e5ca5f814/nodejs/node/pull/23101
og:image:altFixes: #21501 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes (waiting for CI) tests and/or benchmarks are included commit message follows commit guidelines @targos could yo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelundibundi
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23101#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23101
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23101
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23101
Reloadhttps://github.com/nodejs/node/pull/23101
Reloadhttps://github.com/nodejs/node/pull/23101
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23101
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 710 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:fix-localhost-readfilesynchttps://github.com/lundibundi/node/tree/fix-localhost-readfilesync
Conversationhttps://github.com/nodejs/node/pull/23101
Commits1 (1)https://github.com/nodejs/node/pull/23101/commits
Checkshttps://github.com/nodejs/node/pull/23101/checks
Files changedhttps://github.com/nodejs/node/pull/23101/files
test: replace localhost with os.hostname in fs-readfilesynchttps://github.com/nodejs/node/pull/23101#top
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:fix-localhost-readfilesynchttps://github.com/lundibundi/node/tree/fix-localhost-readfilesync
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 26, 2018https://github.com/nodejs/node/pull/23101#issue-363978992
#21501https://github.com/nodejs/node/issues/21501
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/lundibundi
test: replace localhost with os.hostname in fs-readfilesynchttps://github.com/nodejs/node/pull/23101/commits/5768ae7fc518e197106ef02961433d79b3d6f3ad
5768ae7https://github.com/nodejs/node/pull/23101/commits/5768ae7fc518e197106ef02961433d79b3d6f3ad
nodejs#21501https://github.com/nodejs/node/issues/21501
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 26, 2018https://github.com/nodejs/node/pull/23101#issuecomment-424679281
@lundibundihttps://github.com/lundibundi
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1024/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1024/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Sep 26, 2018https://github.com/nodejs/node/pull/23101#event-1868123499
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 26, 2018https://github.com/nodejs/node/pull/23101#event-1868124510
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 26, 2018https://github.com/nodejs/node/pull/23101#issuecomment-424698098
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 26, 2018https://github.com/nodejs/node/pull/23101#issuecomment-424698256
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 29, 2018https://github.com/nodejs/node/pull/23101#issuecomment-425652862
Please reload this pagehttps://github.com/nodejs/node/pull/23101
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 29, 2018https://github.com/nodejs/node/pull/23101#issuecomment-425652918
https://ci.nodejs.org/job/node-test-pull-request/17507/https://ci.nodejs.org/job/node-test-pull-request/17507/
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 29, 2018https://github.com/nodejs/node/pull/23101#issuecomment-425679717
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 30, 2018 https://github.com/nodejs/node/pull/23101#pullrequestreview-160118851
View reviewed changes https://github.com/nodejs/node/pull/23101/files/5768ae7fc518e197106ef02961433d79b3d6f3ad
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 30, 2018https://github.com/nodejs/node/pull/23101#event-1875408204
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 30, 2018https://github.com/nodejs/node/pull/23101#issuecomment-425729880
https://ci.nodejs.org/job/node-test-pull-request/17524/https://ci.nodejs.org/job/node-test-pull-request/17524/
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Sep 30, 2018 https://github.com/nodejs/node/pull/23101#pullrequestreview-160122467
View reviewed changes https://github.com/nodejs/node/pull/23101/files/5768ae7fc518e197106ef02961433d79b3d6f3ad
jdaltonhttps://github.com/jdalton
https://github.com/nodejs/node/pull/23101#pullrequestreview-160122467
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 30, 2018https://github.com/nodejs/node/pull/23101#issuecomment-425757413
https://ci.nodejs.org/job/node-test-pull-request/17540/https://ci.nodejs.org/job/node-test-pull-request/17540/
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 1, 2018https://github.com/nodejs/node/pull/23101#issuecomment-425792754
1be804dhttps://github.com/nodejs/node/commit/1be804d625e6904f053b09b9066ba32e0f48fa99
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 1, 2018https://github.com/nodejs/node/pull/23101#event-1875806049
danbevhttps://github.com/danbev
Oct 1, 2018 https://github.com/nodejs/node/pull/23101#ref-commit-1be804d
https://github.com/lundibundi
https://github.com/danbev
test: replace localhost with os.hostname in fs-readfilesynchttps://github.com/nodejs/node/commit/1be804d625e6904f053b09b9066ba32e0f48fa99
1be804dhttps://github.com/nodejs/node/commit/1be804d625e6904f053b09b9066ba32e0f48fa99
#23101https://github.com/nodejs/node/pull/23101
#21501https://github.com/nodejs/node/issues/21501
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
October 1, 2018 09:20https://github.com/nodejs/node/pull/23101#event-1876182818
targoshttps://github.com/targos
Oct 1, 2018 https://github.com/nodejs/node/pull/23101#ref-commit-a1677e9
https://github.com/lundibundi
https://github.com/targos
test: replace localhost with os.hostname in fs-readfilesynchttps://github.com/nodejs/node/commit/a1677e92dc3d3acdfe67022d509f648ea0705c9c
a1677e9https://github.com/nodejs/node/commit/a1677e92dc3d3acdfe67022d509f648ea0705c9c
#23101https://github.com/nodejs/node/pull/23101
#21501https://github.com/nodejs/node/issues/21501
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 2, 2018 https://github.com/nodejs/node/pull/23101#ref-issue-365839731
CI failures: 20180927-20181002 nodejs/reliability#18 https://github.com/nodejs/reliability/issues/18
targoshttps://github.com/targos
Oct 3, 2018 https://github.com/nodejs/node/pull/23101#ref-commit-23525b0
https://github.com/lundibundi
https://github.com/targos
test: replace localhost with os.hostname in fs-readfilesynchttps://github.com/nodejs/node/commit/23525b05473651c6d317117071bcab0c34576a22
23525b0https://github.com/nodejs/node/commit/23525b05473651c6d317117071bcab0c34576a22
#23101https://github.com/nodejs/node/pull/23101
#21501https://github.com/nodejs/node/issues/21501
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2018 https://github.com/nodejs/node/pull/23101#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23101
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/23101/files/5768ae7fc518e197106ef02961433d79b3d6f3ad
https://github.com/jdalton
jdalton https://github.com/jdalton
https://github.com/nodejs/node/pull/23101/files/5768ae7fc518e197106ef02961433d79b3d6f3ad
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
test-fs-readfilesync-enoent failing locally with unknown error https://github.com/nodejs/node/issues/21501
Please reload this pagehttps://github.com/nodejs/node/pull/23101
https://github.com/lundibundi
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/danbev
https://github.com/jdalton
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.