| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4e938d4b-fa6c-8814-7e41-b18656f0d533 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB26:120B97:19285F8:200E2F4:69917B2F |
| html-safe-nonce | a35f79c6082ed2916bb1bdcaab3ffebd940250fab81f72e5d58102c6ccc277a6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjI2OjEyMEI5NzoxOTI4NUY4OjIwMEUyRjQ6Njk5MTdCMkYiLCJ2aXNpdG9yX2lkIjoiNjQ5NzM4MzY3NjI3MTIyOTc0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8be89fee499846ba41aaab2ac533ac0257e2db545b75be65c5bc6dcfcbaecc91 |
| hovercard-subject-tag | pull_request:217845102 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23072/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3e2a944707090deed0e7d9537d185b556e4ffeb73f0893d1b765e92de44f9c69/nodejs/node/pull/23072 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3e2a944707090deed0e7d9537d185b556e4ffeb73f0893d1b765e92de44f9c69/nodejs/node/pull/23072 |
| og:image:alt | This patch:
Refactors the MemoryRetainer API so that the impementer no longer
calls TrackThis() that sets the size of node on the top of the stack,
which may be hard to understand. Instead they im... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23072#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23072 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23072 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23072 |
| Reload | https://github.com/nodejs/node/pull/23072 |
| Reload | https://github.com/nodejs/node/pull/23072 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:reverse-track | https://github.com/joyeecheung/node/tree/reverse-track |
| Conversation | https://github.com/nodejs/node/pull/23072 |
| Commits4 (4) | https://github.com/nodejs/node/pull/23072/commits |
| Checks | https://github.com/nodejs/node/pull/23072/checks |
| Files changed | https://github.com/nodejs/node/pull/23072/files |
| src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/pull/23072#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:reverse-track | https://github.com/joyeecheung/node/tree/reverse-track |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#issue-363395713 |
| https://user-images.githubusercontent.com/4299420/45990889-5c1b2680-c050-11e8-87fe-1b5910a434c0.png |
| https://user-images.githubusercontent.com/4299420/45990897-60474400-c050-11e8-9f2c-370ca8f7d8f5.png |
| https://user-images.githubusercontent.com/4299420/45990938-8ff64c00-c050-11e8-894d-e7b4ebc9a59c.png |
| https://user-images.githubusercontent.com/4299420/45990930-8b319800-c050-11e8-940f-51f1d37bf5ff.png |
| https://user-images.githubusercontent.com/4299420/45990989-c8962580-c050-11e8-8d3e-781ccd84cc69.png |
| https://user-images.githubusercontent.com/4299420/45990983-c03dea80-c050-11e8-87ae-a91f700e9743.png |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-424195324 |
| @joyeecheung | https://github.com/joyeecheung |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1001/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1001/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#event-1864644878 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
dont-land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#event-1864645006 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-424195391 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://ci.nodejs.org/job/node-test-pull-request/17416/ | https://ci.nodejs.org/job/node-test-pull-request/17416/ |
| https://ci.nodejs.org/job/node-test-pull-request/17417/ | https://ci.nodejs.org/job/node-test-pull-request/17417/ |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-424195492 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23072#pullrequestreview-158366801 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23072/files |
| src/async_wrap.cc | https://github.com/nodejs/node/pull/23072/files#diff-a409448439ca3d2669ce04c6aee43977b52f25ef894a58c7a6d74e6d92e69808 |
| devsnek | https://github.com/devsnek |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220049675 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| src/async_wrap.cc | https://github.com/nodejs/node/pull/23072/files#diff-a409448439ca3d2669ce04c6aee43977b52f25ef894a58c7a6d74e6d92e69808 |
| devsnek | https://github.com/devsnek |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220050056 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220050491 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/cef975bb230bcd94374f9d9748d6ad21081fea26..80f852acb3beaf2fab5b476a73f0f56c09b8ccd3 |
| cef975b | https://github.com/nodejs/node/commit/cef975bb230bcd94374f9d9748d6ad21081fea26 |
| 80f852a | https://github.com/nodejs/node/commit/80f852acb3beaf2fab5b476a73f0f56c09b8ccd3 |
|
Compare
| https://github.com/nodejs/node/compare/cef975bb230bcd94374f9d9748d6ad21081fea26..80f852acb3beaf2fab5b476a73f0f56c09b8ccd3 |
| September 25, 2018 03:34 | https://github.com/nodejs/node/pull/23072#event-1864653219 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23072#pullrequestreview-158460338 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23072/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/23072#pullrequestreview-158460338 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| src/heap_utils.cc | https://github.com/nodejs/node/pull/23072/files#diff-124f51f6a9986b18bfc73bc152dc0655344c40cba234e26b698aed1f84767088 |
| addaleax | https://github.com/addaleax |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220127486 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220175658 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| src/memory_tracker-inl.h | https://github.com/nodejs/node/pull/23072/files#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1 |
| addaleax | https://github.com/addaleax |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220128311 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| src/memory_tracker-inl.h | https://github.com/nodejs/node/pull/23072/files#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| src/memory_tracker-inl.h | https://github.com/nodejs/node/pull/23072/files#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1 |
| addaleax | https://github.com/addaleax |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220132707 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220179819 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220180687 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| addaleax | https://github.com/addaleax |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220280034 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| src/memory_tracker-inl.h | https://github.com/nodejs/node/pull/23072/files#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1 |
| addaleax | https://github.com/addaleax |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220133173 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| src/memory_tracker.h | https://github.com/nodejs/node/pull/23072/files#diff-ecfefa9391ad48418d0f175130891d93cb01622b97c85c0072c63aee1694caae |
| addaleax | https://github.com/addaleax |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220136221 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r220181913 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23072#ref-issue-363725227 |
|
CI failures: 20180925
nodejs/reliability#17
| https://github.com/nodejs/reliability/issues/17 |
| joyeecheung | https://github.com/joyeecheung |
| October 2, 2018 11:21 | https://github.com/nodejs/node/pull/23072#commits-pushed-e18aafa |
|
| https://github.com/joyeecheung |
| src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/pull/23072/commits/e18aafa042b117d2080f99667650b99bd828302a |
| e18aafa | https://github.com/nodejs/node/pull/23072/commits/e18aafa042b117d2080f99667650b99bd828302a |
|
| https://github.com/joyeecheung |
| fixup! src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/pull/23072/commits/cd072350e51d62fb3d294db6537c748d6d8261e3 |
| cd07235 | https://github.com/nodejs/node/pull/23072/commits/cd072350e51d62fb3d294db6537c748d6d8261e3 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/80f852acb3beaf2fab5b476a73f0f56c09b8ccd3..cd072350e51d62fb3d294db6537c748d6d8261e3 |
| 80f852a | https://github.com/nodejs/node/commit/80f852acb3beaf2fab5b476a73f0f56c09b8ccd3 |
| cd07235 | https://github.com/nodejs/node/commit/cd072350e51d62fb3d294db6537c748d6d8261e3 |
|
Compare
| https://github.com/nodejs/node/compare/80f852acb3beaf2fab5b476a73f0f56c09b8ccd3..cd072350e51d62fb3d294db6537c748d6d8261e3 |
| October 2, 2018 09:52 | https://github.com/nodejs/node/pull/23072#event-1878856118 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 2, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-426216388 |
| @addaleax | https://github.com/addaleax |
| @devsnek | https://github.com/devsnek |
| https://ci.nodejs.org/job/node-test-pull-request/17583/ | https://ci.nodejs.org/job/node-test-pull-request/17583/ |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 2, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-426256215 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 2, 2018
| https://github.com/nodejs/node/pull/23072#pullrequestreview-160738200 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23072/files/cd072350e51d62fb3d294db6537c748d6d8261e3 |
| src/memory_tracker.h | https://github.com/nodejs/node/pull/23072/files/cd072350e51d62fb3d294db6537c748d6d8261e3#diff-ecfefa9391ad48418d0f175130891d93cb01622b97c85c0072c63aee1694caae |
| addaleax | https://github.com/addaleax |
| Oct 2, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r221964574 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
|
| https://github.com/joyeecheung |
| fixup! src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/pull/23072/commits/774ae1144ae0ebe2657df8300a395283667c3f94 |
| 774ae11 | https://github.com/nodejs/node/pull/23072/commits/774ae1144ae0ebe2657df8300a395283667c3f94 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-426583156 |
| https://ci.nodejs.org/job/node-test-pull-request/17600/ | https://ci.nodejs.org/job/node-test-pull-request/17600/ |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/hashseed |
| hashseed | https://github.com/hashseed |
| Oct 3, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-426585797 |
| @ulan | https://github.com/ulan |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/ulan |
| ulan | https://github.com/ulan |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/23072#pullrequestreview-161530316 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23072/files/774ae1144ae0ebe2657df8300a395283667c3f94 |
| src/memory_tracker-inl.h | https://github.com/nodejs/node/pull/23072/files/774ae1144ae0ebe2657df8300a395283667c3f94#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1 |
| ulan | https://github.com/ulan |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#discussion_r222605244 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/ulan |
| ulan | https://github.com/ulan |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-426958129 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
|
| https://github.com/joyeecheung |
| fixup! src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/pull/23072/commits/e56d4c0f9dc57b038365f82d5cf9c1e917536cff |
| e56d4c0 | https://github.com/nodejs/node/pull/23072/commits/e56d4c0f9dc57b038365f82d5cf9c1e917536cff |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-426963979 |
| https://ci.nodejs.org/job/node-test-pull-request/17624/ | https://ci.nodejs.org/job/node-test-pull-request/17624/ |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-427021615 |
| 92fa0fc | https://github.com/nodejs/node/commit/92fa0fcdb76e2b6cb0040eede97fe3c167c31897 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#event-1884639259 |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/23072#ref-commit-92fa0fc |
|
| https://github.com/joyeecheung |
| src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/commit/92fa0fcdb76e2b6cb0040eede97fe3c167c31897 |
| 92fa0fc | https://github.com/nodejs/node/commit/92fa0fcdb76e2b6cb0040eede97fe3c167c31897 |
| #23072 | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-427094807 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#event-1885195250 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-427106320 |
| #22106 | https://github.com/nodejs/node/pull/22106 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#event-1885275860 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#event-1885275862 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-427107426 |
| @joyeecheung | https://github.com/joyeecheung |
| #22106 | https://github.com/nodejs/node/pull/22106 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-427115931 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-427155752 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/23072#issuecomment-427158535 |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 5, 2018
| https://github.com/nodejs/node/pull/23072#ref-pullrequest-367146700 |
|
src: remove accidentally added src/txt
#23273
| https://github.com/nodejs/node/pull/23273 |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 5, 2018
| https://github.com/nodejs/node/pull/23072#ref-commit-e1d4b0a |
|
| https://github.com/joyeecheung |
| src: remove accidentally added src/txt | https://github.com/nodejs/node/commit/e1d4b0a6467d6ee47eebf223c773946d38427d74 |
| e1d4b0a | https://github.com/nodejs/node/commit/e1d4b0a6467d6ee47eebf223c773946d38427d74 |
| #23273 | https://github.com/nodejs/node/pull/23273 |
| #23072 | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 5, 2018
| https://github.com/nodejs/node/pull/23072#ref-issue-366664814 |
|
Post-mortem out of memory analysis
nodejs/diagnostics#239
| https://github.com/nodejs/diagnostics/issues/239 |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 5, 2018
| https://github.com/nodejs/node/pull/23072#ref-commit-d220d60 |
|
| https://github.com/joyeecheung |
| src: name EmbededderGraph edges and use class names for nodes | https://github.com/joyeecheung/node/commit/d220d6004d6d2cb8b295803e177e1948669fe97e |
| d220d60 | https://github.com/joyeecheung/node/commit/d220d6004d6d2cb8b295803e177e1948669fe97e |
| nodejs#23072 | https://github.com/nodejs/node/pull/23072 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 6, 2018
| https://github.com/nodejs/node/pull/23072#ref-pullrequest-367487178 |
|
[v10.x] backport EmbededderGraph related changes to v10.x
#23295
| https://github.com/nodejs/node/pull/23295 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Oct 7, 2018 | https://github.com/nodejs/node/pull/23072#event-1888931395 |
| targos | https://github.com/targos |
|
Oct 7, 2018
| https://github.com/nodejs/node/pull/23072#ref-commit-8fff3b0 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/commit/8fff3b09e2aa89acbfe6b1f74c2351ee792f8095 |
| 8fff3b0 | https://github.com/nodejs/node/commit/8fff3b09e2aa89acbfe6b1f74c2351ee792f8095 |
| #23295 | https://github.com/nodejs/node/pull/23295 |
| #23072 | https://github.com/nodejs/node/pull/23072 |
| targos | https://github.com/targos |
|
Oct 7, 2018
| https://github.com/nodejs/node/pull/23072#ref-commit-950ccee |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/commit/950ccee3860286c4e780baaa2e39eb4a5dc8b7c8 |
| 950ccee | https://github.com/nodejs/node/commit/950ccee3860286c4e780baaa2e39eb4a5dc8b7c8 |
| #23295 | https://github.com/nodejs/node/pull/23295 |
| #23072 | https://github.com/nodejs/node/pull/23072 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 7, 2018
| https://github.com/nodejs/node/pull/23072#ref-pullrequest-367548700 |
|
Release proposal: v10.12.0
#23313
| https://github.com/nodejs/node/pull/23313 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#225
| https://github.com/beevelop/docker-nodejs/issues/225 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#239
| https://github.com/beevelop/docker-android-nodejs/issues/239 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#226
| https://github.com/beevelop/docker-nodejs/issues/226 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#240
| https://github.com/beevelop/docker-android-nodejs/issues/240 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#227
| https://github.com/beevelop/docker-nodejs/issues/227 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#241
| https://github.com/beevelop/docker-android-nodejs/issues/241 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#242
| https://github.com/beevelop/docker-android-nodejs/issues/242 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#228
| https://github.com/beevelop/docker-nodejs/issues/228 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#243
| https://github.com/beevelop/docker-android-nodejs/issues/243 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#229
| https://github.com/beevelop/docker-nodejs/issues/229 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23072#ref-commit-b082adc |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
| src: name EmbededderGraph edges and use class names for nodes | https://github.com/nodejs/node/commit/b082adc701f055ed2f81763f25229e44d9833665 |
| b082adc | https://github.com/nodejs/node/commit/b082adc701f055ed2f81763f25229e44d9833665 |
| #23072 | https://github.com/nodejs/node/pull/23072 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/23072#ref-commit-6580ce5 |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
| src: remove accidentally added src/txt | https://github.com/nodejs/node/commit/6580ce54dc4b5ba2d64bbda3ecd0a001b5968e1f |
| 6580ce5 | https://github.com/nodejs/node/commit/6580ce54dc4b5ba2d64bbda3ecd0a001b5968e1f |
| #23273 | https://github.com/nodejs/node/pull/23273 |
| #23072 | https://github.com/nodejs/node/pull/23072 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23072 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/23072/files/cd072350e51d62fb3d294db6537c748d6d8261e3 |
|
| https://github.com/ulan |
|
ulan
| https://github.com/ulan |
|
| https://github.com/nodejs/node/pull/23072/files/774ae1144ae0ebe2657df8300a395283667c3f94 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/23072/files/36d41f2592453706d5f4826ad5c7317ca98ced47 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/23072 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/hashseed |
|
| https://github.com/ulan |
|
| https://github.com/addaleax |
|
| https://github.com/TimothyGu |
|
| https://github.com/devsnek |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |