| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b48afc91-42d7-e51c-4754-b1e709b9c27e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D722:1588EC:1A15A0F:21D4AEA:69909D48 |
| html-safe-nonce | 265581ddfb1a1f0f5a94c189321c223df4da67179f7404161c2594c57d5e33b7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzIyOjE1ODhFQzoxQTE1QTBGOjIxRDRBRUE6Njk5MDlENDgiLCJ2aXNpdG9yX2lkIjoiMjg3ODU2MDM5ODY0MjAyNzg0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ad1d10374968bf8a12736b167f8bee879722baaf7f506cb6970b4a6a5970d011 |
| hovercard-subject-tag | pull_request:217472325 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23028/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4e02671b2bad0f9138cb8eb91ae6cd57f93c2511064f384c06a5423e6f145eb1/nodejs/node/pull/23028 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4e02671b2bad0f9138cb8eb91ae6cd57f93c2511064f384c06a5423e6f145eb1/nodejs/node/pull/23028 |
| og:image:alt | Adjust heading levels to align with the table of contents, and write down 2 more existing rules (avoiding non-const references and auto under most circumstances).
We generally avoid using auto if n... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23028#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23028 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23028 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23028 |
| Reload | https://github.com/nodejs/node/pull/23028 |
| Reload | https://github.com/nodejs/node/pull/23028 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
704
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:cpp-style-update | https://github.com/addaleax/node/tree/cpp-style-update |
| Conversation | https://github.com/nodejs/node/pull/23028 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23028/commits |
| Checks | https://github.com/nodejs/node/pull/23028/checks |
| Files changed | https://github.com/nodejs/node/pull/23028/files |
| doc: formalize auto usage in C++ style guide | https://github.com/nodejs/node/pull/23028#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:cpp-style-update | https://github.com/addaleax/node/tree/cpp-style-update |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#issue-362881065 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| #23155 | https://github.com/nodejs/node/pull/23155 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423765034 |
| @addaleax | https://github.com/addaleax |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/979/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/979/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#event-1861711759 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/23028#ref-pullrequest-362854411 |
|
cli: normalize _ → - when parsing options
#23020
| https://github.com/nodejs/node/pull/23020 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/23028#pullrequestreview-157920015 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23028/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/23028#pullrequestreview-157920125 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23028/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/4395d622825ff87ebb558cdc67cba2cc62a1988c..650305ac3f4800b492158feb5acc82c9beca68a0 |
| 4395d62 | https://github.com/nodejs/node/commit/4395d622825ff87ebb558cdc67cba2cc62a1988c |
| 650305a | https://github.com/nodejs/node/commit/650305ac3f4800b492158feb5acc82c9beca68a0 |
|
Compare
| https://github.com/nodejs/node/compare/4395d622825ff87ebb558cdc67cba2cc62a1988c..650305ac3f4800b492158feb5acc82c9beca68a0 |
| September 22, 2018 20:08 | https://github.com/nodejs/node/pull/23028#event-1861736575 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/23028#pullrequestreview-157923305 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23028/files |
| refack | https://github.com/refack |
| https://github.com/nodejs/node/pull/23028#pullrequestreview-157923305 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/23028#pullrequestreview-157923308 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23028/files |
| refack | https://github.com/refack |
| https://github.com/nodejs/node/pull/23028#pullrequestreview-157923308 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/23028#pullrequestreview-157923454 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23028/files |
| CPP_STYLE_GUIDE.md | https://github.com/nodejs/node/pull/23028/files#diff-29c9db0176a6dd3d4972619e0fc37c720580d56051e79de4deb53c383777e33e |
| joyeecheung | https://github.com/joyeecheung |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#discussion_r219683236 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| refack | https://github.com/refack |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#discussion_r219683347 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://www.youtube.com/watch?v=hEx5DNLWGgA | https://www.youtube.com/watch?v=hEx5DNLWGgA |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| jasnell | https://github.com/jasnell |
| Sep 23, 2018 | https://github.com/nodejs/node/pull/23028#discussion_r219715641 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 23, 2018 | https://github.com/nodejs/node/pull/23028#discussion_r219716139 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @refack | https://github.com/refack |
| back in 2015 | https://github.com/joyeecheung/my-tech-diary/blob/3aa5de496e3d45db994ae77d936fa4fe3c14ed27/2015/08/2015-08-18.md#dont-be-scared-by-auto |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| addaleax | https://github.com/addaleax |
| Sep 23, 2018 | https://github.com/nodejs/node/pull/23028#discussion_r219716306 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| refack | https://github.com/refack |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/23028#discussion_r219717273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| addaleax | https://github.com/addaleax |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/23028#discussion_r219766625 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 46 % of npm users | https://twitter.com/seldo/status/1024052940355526656 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/23028#discussion_r219862998 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423776670 |
| ES.11: Use auto to avoid redundant repetition of type names | http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-auto |
| P.3: Express intent | http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#p3-express-intent |
| auto | https://google.github.io/styleguide/cppguide.html#auto |
| Reference Arguments | https://google.github.io/styleguide/cppguide.html#Reference_Arguments |
| F.16: For “in” parameters, pass cheaply-copied types by value and others by reference to const | http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-in |
| F.17: For “in-out” parameters, pass by reference to non-const | http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-inout |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423776755 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423777245 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423777269 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423777569 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423777965 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| ES.55: Avoid the need for range checking | https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-range-checking |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 23, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423790180 |
| https://www.youtube.com/watch?v=bSkpMdDe4g4 | https://www.youtube.com/watch?v=bSkpMdDe4g4 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 23, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423830107 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423859634 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Sep 24, 2018
| https://github.com/nodejs/node/pull/23028#pullrequestreview-157973116 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23028/files |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423877513 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423911982 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Sep 24, 2018
| https://github.com/nodejs/node/pull/23028#pullrequestreview-158071209 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23028/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-423979272 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-424045691 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| addaleax | https://github.com/addaleax |
|
Sep 24, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-084a043 |
|
| https://github.com/addaleax |
| doc: fix heading levels in C++ style guide | https://github.com/addaleax/node/commit/084a04364795ee0475476b52aefa1857b9a2e5a3 |
| 084a043 | https://github.com/addaleax/node/commit/084a04364795ee0475476b52aefa1857b9a2e5a3 |
| nodejs#23028 | https://github.com/nodejs/node/pull/23028 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 24, 2018
| https://github.com/nodejs/node/pull/23028#ref-pullrequest-363232061 |
|
doc: fix heading levels in C++ style guide
#23061
| https://github.com/nodejs/node/pull/23061 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/0fc3c63ad6402423e5f370d48339fa2d8836cae0..1a97e3166fc22d7d27cf2d5e30d8d16c3248728e |
| 0fc3c63 | https://github.com/nodejs/node/commit/0fc3c63ad6402423e5f370d48339fa2d8836cae0 |
| 1a97e31 | https://github.com/nodejs/node/commit/1a97e3166fc22d7d27cf2d5e30d8d16c3248728e |
|
Compare
| https://github.com/nodejs/node/compare/0fc3c63ad6402423e5f370d48339fa2d8836cae0..1a97e3166fc22d7d27cf2d5e30d8d16c3248728e |
| September 24, 2018 18:15 | https://github.com/nodejs/node/pull/23028#event-1863830071 |
| addaleax | https://github.com/addaleax |
|
Sep 24, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-50944f3 |
|
| https://github.com/addaleax |
| doc: fix heading levels in C++ style guide | https://github.com/addaleax/node/commit/50944f34fea03c52e533f1b1e20ebc0de2365a72 |
| 50944f3 | https://github.com/addaleax/node/commit/50944f34fea03c52e533f1b1e20ebc0de2365a72 |
| nodejs#23028 | https://github.com/nodejs/node/pull/23028 |
| nodejs#23061 | https://github.com/nodejs/node/pull/23061 |
| targos | https://github.com/targos |
|
Sep 24, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-0519689 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| doc: fix heading levels in C++ style guide | https://github.com/nodejs/node/commit/05196893b9619274f2d5c4d1386b5013fa2242e2 |
| 0519689 | https://github.com/nodejs/node/commit/05196893b9619274f2d5c4d1386b5013fa2242e2 |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| #23061 | https://github.com/nodejs/node/pull/23061 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-424198114 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 29, 2018
| https://github.com/nodejs/node/pull/23028#ref-pullrequest-365082735 |
|
doc: formalize non-const reference usage in C++ style guide
#23155
| https://github.com/nodejs/node/pull/23155 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Sep 29, 2018 | https://github.com/nodejs/node/pull/23028#event-1874707259 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 29, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-425603829 |
| @refack | https://github.com/refack |
| #23155 | https://github.com/nodejs/node/pull/23155 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Sep 29, 2018
| https://github.com/nodejs/node/pull/23028#pullrequestreview-160061345 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23028/files/39c5cac595a8aff256aaf8419f240fabc32943a8 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 29, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-425605890 |
| #23155 | https://github.com/nodejs/node/pull/23155 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 29, 2018 | https://github.com/nodejs/node/pull/23028#event-1874721164 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 30, 2018 | https://github.com/nodejs/node/pull/23028#issuecomment-425729200 |
| aba7677 | https://github.com/nodejs/node/commit/aba7677e826065fc1f1025ee2db5faee035fd515 |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 30, 2018 | https://github.com/nodejs/node/pull/23028#event-1875404791 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| September 30, 2018 15:32 | https://github.com/nodejs/node/pull/23028#event-1875404827 |
| addaleax | https://github.com/addaleax |
|
Sep 30, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-aba7677 |
|
| https://github.com/addaleax |
| doc: formalize auto usage in C++ style guide | https://github.com/nodejs/node/commit/aba7677e826065fc1f1025ee2db5faee035fd515 |
| aba7677 | https://github.com/nodejs/node/commit/aba7677e826065fc1f1025ee2db5faee035fd515 |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| targos | https://github.com/targos |
|
Oct 1, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-7d34177 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| doc: formalize auto usage in C++ style guide | https://github.com/nodejs/node/commit/7d341779ff3354184d0cb9ef70a5cf6edc8b71e5 |
| 7d34177 | https://github.com/nodejs/node/commit/7d341779ff3354184d0cb9ef70a5cf6edc8b71e5 |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| targos | https://github.com/targos |
|
Oct 3, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-e791abe |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| doc: formalize auto usage in C++ style guide | https://github.com/nodejs/node/commit/e791abe5ef0d97db374967d34107c7d5a296be29 |
| e791abe | https://github.com/nodejs/node/commit/e791abe5ef0d97db374967d34107c7d5a296be29 |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 7, 2018
| https://github.com/nodejs/node/pull/23028#ref-pullrequest-367548700 |
|
Release proposal: v10.12.0
#23313
| https://github.com/nodejs/node/pull/23313 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#225
| https://github.com/beevelop/docker-nodejs/issues/225 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#239
| https://github.com/beevelop/docker-android-nodejs/issues/239 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#226
| https://github.com/beevelop/docker-nodejs/issues/226 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#240
| https://github.com/beevelop/docker-android-nodejs/issues/240 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#227
| https://github.com/beevelop/docker-nodejs/issues/227 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#241
| https://github.com/beevelop/docker-android-nodejs/issues/241 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#242
| https://github.com/beevelop/docker-android-nodejs/issues/242 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#228
| https://github.com/beevelop/docker-nodejs/issues/228 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#243
| https://github.com/beevelop/docker-android-nodejs/issues/243 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#229
| https://github.com/beevelop/docker-nodejs/issues/229 |
| addaleax | https://github.com/addaleax |
|
Oct 21, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-5550510 |
|
| https://github.com/addaleax |
| doc: formalize non-const reference usage in C++ style guide | https://github.com/nodejs/node/commit/5550510056570ed1266c4c3f9bab07f00d4e8ef2 |
| 5550510 | https://github.com/nodejs/node/commit/5550510056570ed1266c4c3f9bab07f00d4e8ef2 |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| #23155 | https://github.com/nodejs/node/pull/23155 |
| jasnell | https://github.com/jasnell |
|
Oct 21, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-eaff120 |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
| doc: formalize non-const reference usage in C++ style guide | https://github.com/nodejs/node/commit/eaff120bfd4b792b4dc53ad626acfdfc6d1d1f51 |
| eaff120 | https://github.com/nodejs/node/commit/eaff120bfd4b792b4dc53ad626acfdfc6d1d1f51 |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| #23155 | https://github.com/nodejs/node/pull/23155 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 15, 2018
| https://github.com/nodejs/node/pull/23028#ref-pullrequest-379578132 |
|
doc: make C++ core guidelines a reference
#24315
| https://github.com/nodejs/node/pull/24315 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 26, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-30b1a4a |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| doc: formalize non-const reference usage in C++ style guide | https://github.com/nodejs/node/commit/30b1a4a61f3a2f0ecc1f4ac34a074895bd10d0f8 |
| 30b1a4a | https://github.com/nodejs/node/commit/30b1a4a61f3a2f0ecc1f4ac34a074895bd10d0f8 |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| #23155 | https://github.com/nodejs/node/pull/23155 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-8e54ee1 |
|
| https://github.com/addaleax |
|
| https://github.com/rvagg |
| doc: formalize non-const reference usage in C++ style guide | https://github.com/nodejs/node/commit/8e54ee1712ddf8fc6483eece23d3d9e0d8eb8fa6 |
| 8e54ee1 | https://github.com/nodejs/node/commit/8e54ee1712ddf8fc6483eece23d3d9e0d8eb8fa6 |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| #23155 | https://github.com/nodejs/node/pull/23155 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 29, 2018
| https://github.com/nodejs/node/pull/23028#ref-commit-75082ee |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| doc: formalize non-const reference usage in C++ style guide | https://github.com/nodejs/node/commit/75082ee15b654f7d7f4edbbf0b396c124644136a |
| 75082ee | https://github.com/nodejs/node/commit/75082ee15b654f7d7f4edbbf0b396c124644136a |
| #23028 | https://github.com/nodejs/node/pull/23028 |
| #23155 | https://github.com/nodejs/node/pull/23155 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Feb 14, 2019
| https://github.com/nodejs/node/pull/23028#ref-pullrequest-408499959 |
|
src: fix modernize-return-braced-init-list
#26023
| https://github.com/nodejs/node/pull/26023 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23028 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23028/files/650305ac3f4800b492158feb5acc82c9beca68a0 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/23028/files/1a97e3166fc22d7d27cf2d5e30d8d16c3248728e |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/23028/files/650305ac3f4800b492158feb5acc82c9beca68a0 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/23028/files/4395d622825ff87ebb558cdc67cba2cc62a1988c |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/23028/files/650305ac3f4800b492158feb5acc82c9beca68a0 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/23028/files/1a97e3166fc22d7d27cf2d5e30d8d16c3248728e |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/23028/files/39c5cac595a8aff256aaf8419f240fabc32943a8 |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/23028/files/650305ac3f4800b492158feb5acc82c9beca68a0 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/23028/files/1a97e3166fc22d7d27cf2d5e30d8d16c3248728e |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/23028 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/refack |
|
| https://github.com/joyeecheung |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/jasnell |
|
| https://github.com/danbev |
|
| https://github.com/thefourtheye |
|
| https://github.com/lpinca |
|
| https://github.com/tniessen |
|
| https://github.com/mhdawson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |