| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4c8e1b09-8a5b-e4b3-44a9-73b2b8131601 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DDF2:629BA:2DC60C7:3A67CD4:69913753 |
| html-safe-nonce | 01deea78c01590b963a7e0d39995144e4d37a3a508b19adef6dbcf02ae39831f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREYyOjYyOUJBOjJEQzYwQzc6M0E2N0NENDo2OTkxMzc1MyIsInZpc2l0b3JfaWQiOiIyODU1MDI2NzQyNTc5MTc3NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f73c52a371dd3abd79c4389faa53d60a4c652dd9cebcac10fea3263ed2bf96b2 |
| hovercard-subject-tag | pull_request:217454275 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23019/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b2859fc1e9336cf761d0edc8218c8fa9d4c2a7f673a34a1d692a95e7a595b6ee/nodejs/node/pull/23019 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b2859fc1e9336cf761d0edc8218c8fa9d4c2a7f673a34a1d692a95e7a595b6ee/nodejs/node/pull/23019 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23019#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23019 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23019 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23019 |
| Reload | https://github.com/nodejs/node/pull/23019 |
| Reload | https://github.com/nodejs/node/pull/23019 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23019 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
710
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:zlib-refactor | https://github.com/addaleax/node/tree/zlib-refactor |
| Conversation | https://github.com/nodejs/node/pull/23019 |
| Commits3 (3) | https://github.com/nodejs/node/pull/23019/commits |
| Checks | https://github.com/nodejs/node/pull/23019/checks |
| Files changed | https://github.com/nodejs/node/pull/23019/files |
| src: some refactoring of node_zlib.cc | https://github.com/nodejs/node/pull/23019#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:zlib-refactor | https://github.com/addaleax/node/tree/zlib-refactor |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23019#issue-362852052 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23019 |
| addaleax | https://github.com/addaleax |
| September 22, 2018 12:43 | https://github.com/nodejs/node/pull/23019#commits-pushed-c9e6d96 |
|
| https://github.com/addaleax |
| src: refactor zlib dictionary to STL vector | https://github.com/nodejs/node/pull/23019/commits/c9e6d96a84252e3c156c64ecabad6cce39c57355 |
| c9e6d96 | https://github.com/nodejs/node/pull/23019/commits/c9e6d96a84252e3c156c64ecabad6cce39c57355 |
|
| https://github.com/addaleax |
| src: make ZCtx::Init() non-static | https://github.com/nodejs/node/pull/23019/commits/94d29bb8c0d3f1daf28ee524b780948055cf8c67 |
| 94d29bb | https://github.com/nodejs/node/pull/23019/commits/94d29bb8c0d3f1daf28ee524b780948055cf8c67 |
|
| https://github.com/addaleax |
| src: define zlib constants in node_zlib.cc | https://github.com/nodejs/node/pull/23019/commits/64830cf5c9343f2f6b8074c09305fdd7108701d1 |
| 64830cf | https://github.com/nodejs/node/pull/23019/commits/64830cf5c9343f2f6b8074c09305fdd7108701d1 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23019#issuecomment-423739564 |
| @addaleax | https://github.com/addaleax |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/974/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/974/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/23019 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
zlib
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/23019#event-1861575583 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/23019#pullrequestreview-157913694 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23019/files/64830cf5c9343f2f6b8074c09305fdd7108701d1 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 23, 2018 | https://github.com/nodejs/node/pull/23019#issuecomment-423846690 |
| https://ci.nodejs.org/job/node-test-pull-request/17391/ | https://ci.nodejs.org/job/node-test-pull-request/17391/ |
| Please reload this page | https://github.com/nodejs/node/pull/23019 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Sep 23, 2018
| https://github.com/nodejs/node/pull/23019#pullrequestreview-157951467 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23019/files/64830cf5c9343f2f6b8074c09305fdd7108701d1 |
| danbev | https://github.com/danbev |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23019#ref-commit-c496e58 |
|
| https://github.com/addaleax |
|
| https://github.com/danbev |
| src: refactor zlib dictionary to STL vector | https://github.com/nodejs/node/commit/c496e5879d13ba3a428abe90c4f86d60309305cb |
| c496e58 | https://github.com/nodejs/node/commit/c496e5879d13ba3a428abe90c4f86d60309305cb |
| #23019 | https://github.com/nodejs/node/pull/23019 |
| danbev | https://github.com/danbev |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23019#ref-commit-0630da1 |
|
| https://github.com/addaleax |
|
| https://github.com/danbev |
| src: make ZCtx::Init() non-static | https://github.com/nodejs/node/commit/0630da14159759dff8c2befdabaef359482b9b26 |
| 0630da1 | https://github.com/nodejs/node/commit/0630da14159759dff8c2befdabaef359482b9b26 |
| #23019 | https://github.com/nodejs/node/pull/23019 |
| danbev | https://github.com/danbev |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23019#ref-commit-ead5c4c |
|
| https://github.com/addaleax |
|
| https://github.com/danbev |
| src: define zlib constants in node_zlib.cc | https://github.com/nodejs/node/commit/ead5c4c054863cbc82bd2c2a8ddb31860f9e51f7 |
| ead5c4c | https://github.com/nodejs/node/commit/ead5c4c054863cbc82bd2c2a8ddb31860f9e51f7 |
| #23019 | https://github.com/nodejs/node/pull/23019 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23019#issuecomment-424199942 |
| ead5c4c | https://github.com/nodejs/node/commit/ead5c4c054863cbc82bd2c2a8ddb31860f9e51f7 |
| 0630da1 | https://github.com/nodejs/node/commit/0630da14159759dff8c2befdabaef359482b9b26 |
| c496e58 | https://github.com/nodejs/node/commit/c496e5879d13ba3a428abe90c4f86d60309305cb |
| Please reload this page | https://github.com/nodejs/node/pull/23019 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/23019#event-1864675088 |
| targos | https://github.com/targos |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23019#ref-commit-56b1a3c |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: refactor zlib dictionary to STL vector | https://github.com/nodejs/node/commit/56b1a3cf6e772ba8ad0b44a4739b9d9c8a0c4928 |
| 56b1a3c | https://github.com/nodejs/node/commit/56b1a3cf6e772ba8ad0b44a4739b9d9c8a0c4928 |
| #23019 | https://github.com/nodejs/node/pull/23019 |
| targos | https://github.com/targos |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23019#ref-commit-d72867e |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: make ZCtx::Init() non-static | https://github.com/nodejs/node/commit/d72867ec0c0a33bc32b47767d561a92bef06a3f1 |
| d72867e | https://github.com/nodejs/node/commit/d72867ec0c0a33bc32b47767d561a92bef06a3f1 |
| #23019 | https://github.com/nodejs/node/pull/23019 |
| targos | https://github.com/targos |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/23019#ref-commit-90f1200 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| src: define zlib constants in node_zlib.cc | https://github.com/nodejs/node/commit/90f1200be99c2d33d8aa4ee4d37590525013fb73 |
| 90f1200 | https://github.com/nodejs/node/commit/90f1200be99c2d33d8aa4ee4d37590525013fb73 |
| #23019 | https://github.com/nodejs/node/pull/23019 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 7, 2018
| https://github.com/nodejs/node/pull/23019#ref-pullrequest-367548700 |
|
Release proposal: v10.12.0
#23313
| https://github.com/nodejs/node/pull/23313 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#225
| https://github.com/beevelop/docker-nodejs/issues/225 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#239
| https://github.com/beevelop/docker-android-nodejs/issues/239 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#226
| https://github.com/beevelop/docker-nodejs/issues/226 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#240
| https://github.com/beevelop/docker-android-nodejs/issues/240 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#227
| https://github.com/beevelop/docker-nodejs/issues/227 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#241
| https://github.com/beevelop/docker-android-nodejs/issues/241 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#242
| https://github.com/beevelop/docker-android-nodejs/issues/242 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#228
| https://github.com/beevelop/docker-nodejs/issues/228 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#243
| https://github.com/beevelop/docker-android-nodejs/issues/243 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#229
| https://github.com/beevelop/docker-nodejs/issues/229 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23019 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23019/files/64830cf5c9343f2f6b8074c09305fdd7108701d1 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/23019/files/64830cf5c9343f2f6b8074c09305fdd7108701d1 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
zlib
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib |
| Please reload this page | https://github.com/nodejs/node/pull/23019 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
|
| https://github.com/devsnek |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |