René's URL Explorer Experiment


Title: src: remove calls to SetWrapperClassId() by joyeecheung · Pull Request #22975 · nodejs/node · GitHub

Open Graph Title: src: remove calls to SetWrapperClassId() by joyeecheung · Pull Request #22975 · nodejs/node

X Title: src: remove calls to SetWrapperClassId() by joyeecheung · Pull Request #22975 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We have migrated from the deprecated RetainedObjectInfo API to the new EmbedderGraph API, so there is no need to take care of wrapper class ids anymore since they are dedicated to the deprecated AP...

X Description: We have migrated from the deprecated RetainedObjectInfo API to the new EmbedderGraph API, so there is no need to take care of wrapper class ids anymore since they are dedicated to the deprecated AP...

Opengraph URL: https://github.com/nodejs/node/pull/22975

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e1ab084-2e00-2085-84f8-5185676d33e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB232:3F004:43BB8ED:5757C03:69912DE0
html-safe-noncefec22dc2acace251e9709a07cdd6d3eb022e42218579f669c6e7fa8e86d92e49
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjMyOjNGMDA0OjQzQkI4RUQ6NTc1N0MwMzo2OTkxMkRFMCIsInZpc2l0b3JfaWQiOiI3ODkxMTk0OTI3MzA5OTAwNDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacefb7918ba8f44e3f2f5c1cd9a38abe3c2ce029210e06932334ed31d181d4e1f3
hovercard-subject-tagpull_request:217031550
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22975/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/29371ded17ca4106dcda29bfb62ad44011a1d96bcde7af5a79b247ec5aea59bc/nodejs/node/pull/22975
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/29371ded17ca4106dcda29bfb62ad44011a1d96bcde7af5a79b247ec5aea59bc/nodejs/node/pull/22975
og:image:altWe have migrated from the deprecated RetainedObjectInfo API to the new EmbedderGraph API, so there is no need to take care of wrapper class ids anymore since they are dedicated to the deprecated AP...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22975#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22975
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22975
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22975
Reloadhttps://github.com/nodejs/node/pull/22975
Reloadhttps://github.com/nodejs/node/pull/22975
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22975
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:remove-wcihttps://github.com/joyeecheung/node/tree/remove-wci
Conversationhttps://github.com/nodejs/node/pull/22975
Commits2 (2)https://github.com/nodejs/node/pull/22975/commits
Checkshttps://github.com/nodejs/node/pull/22975/checks
Files changedhttps://github.com/nodejs/node/pull/22975/files
src: remove calls to SetWrapperClassId()https://github.com/nodejs/node/pull/22975#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:remove-wcihttps://github.com/joyeecheung/node/tree/remove-wci
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 20, 2018https://github.com/nodejs/node/pull/22975#issue-362263427
Please reload this pagehttps://github.com/nodejs/node/pull/22975
#21741https://github.com/nodejs/node/pull/21741
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22975
https://github.com/joyeecheung
src: remove calls to SetWrapperClassId()https://github.com/nodejs/node/pull/22975/commits/78a88591f8c23598977ea590559a21a74884ca37
78a8859https://github.com/nodejs/node/pull/22975/commits/78a88591f8c23598977ea590559a21a74884ca37
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 20, 2018https://github.com/nodejs/node/pull/22975#issuecomment-423244872
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/949/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/949/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22975
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Sep 20, 2018https://github.com/nodejs/node/pull/22975#event-1858162929
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 20, 2018https://github.com/nodejs/node/pull/22975#issuecomment-423244988
https://ci.nodejs.org/job/node-test-pull-request/17342/https://ci.nodejs.org/job/node-test-pull-request/17342/
Please reload this pagehttps://github.com/nodejs/node/pull/22975
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Sep 20, 2018https://github.com/nodejs/node/pull/22975#event-1858164739
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 20, 2018 https://github.com/nodejs/node/pull/22975#pullrequestreview-157359981
View reviewed changes https://github.com/nodejs/node/pull/22975/files/78a88591f8c23598977ea590559a21a74884ca37
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 20, 2018https://github.com/nodejs/node/pull/22975#issuecomment-423295682
https://ci.nodejs.org/job/node-test-commit-windows-fanned/20899/https://ci.nodejs.org/job/node-test-commit-windows-fanned/20899/
Please reload this pagehttps://github.com/nodejs/node/pull/22975
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 20, 2018 https://github.com/nodejs/node/pull/22975#pullrequestreview-157423480
View reviewed changes https://github.com/nodejs/node/pull/22975/files/78a88591f8c23598977ea590559a21a74884ca37
src/async_wrap.cchttps://github.com/nodejs/node/pull/22975/files/78a88591f8c23598977ea590559a21a74884ca37#diff-a409448439ca3d2669ce04c6aee43977b52f25ef894a58c7a6d74e6d92e69808
Please reload this pagehttps://github.com/nodejs/node/pull/22975
https://github.com/joyeecheung
fixup! src: remove calls to SetWrapperClassId()https://github.com/nodejs/node/pull/22975/commits/56473a644c145a3296d39fbe937e302613b88eb1
56473a6https://github.com/nodejs/node/pull/22975/commits/56473a644c145a3296d39fbe937e302613b88eb1
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 20, 2018https://github.com/nodejs/node/pull/22975#issuecomment-423304189
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/job/node-test-pull-request/17346/https://ci.nodejs.org/job/node-test-pull-request/17346/
Please reload this pagehttps://github.com/nodejs/node/pull/22975
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 20, 2018https://github.com/nodejs/node/pull/22975#event-1858795590
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 21, 2018https://github.com/nodejs/node/pull/22975#issuecomment-423402621
Please reload this pagehttps://github.com/nodejs/node/pull/22975
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 21, 2018 https://github.com/nodejs/node/pull/22975#pullrequestreview-157672341
View reviewed changes https://github.com/nodejs/node/pull/22975/files/56473a644c145a3296d39fbe937e302613b88eb1
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 23, 2018https://github.com/nodejs/node/pull/22975#issuecomment-423856310
c67d3d0https://github.com/nodejs/node/commit/c67d3d0c3caf74795871f813dbef2ec3fc196e58
Please reload this pagehttps://github.com/nodejs/node/pull/22975
joyeecheunghttps://github.com/joyeecheung
Sep 23, 2018 https://github.com/nodejs/node/pull/22975#ref-commit-c67d3d0
https://github.com/joyeecheung
src: remove calls to SetWrapperClassId()https://github.com/nodejs/node/commit/c67d3d0c3caf74795871f813dbef2ec3fc196e58
c67d3d0https://github.com/nodejs/node/commit/c67d3d0c3caf74795871f813dbef2ec3fc196e58
#22975https://github.com/nodejs/node/pull/22975
#21741https://github.com/nodejs/node/pull/21741
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 24, 2018https://github.com/nodejs/node/pull/22975#event-1862285669
targoshttps://github.com/targos
Sep 24, 2018 https://github.com/nodejs/node/pull/22975#ref-commit-cb3062a
https://github.com/joyeecheung
https://github.com/targos
src: remove calls to SetWrapperClassId()https://github.com/nodejs/node/commit/cb3062aa42241c1bdceb595f31e70a796f40e04c
cb3062ahttps://github.com/nodejs/node/commit/cb3062aa42241c1bdceb595f31e70a796f40e04c
#22975https://github.com/nodejs/node/pull/22975
#21741https://github.com/nodejs/node/pull/21741
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2018 https://github.com/nodejs/node/pull/22975#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22975
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22975/files/78a88591f8c23598977ea590559a21a74884ca37
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22975/files/78a88591f8c23598977ea590559a21a74884ca37
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22975/files/56473a644c145a3296d39fbe937e302613b88eb1
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/22975
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.