| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1a7114c2-d443-689d-7ece-7ba9efc7d40e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA08:7B2C1:95C7DC:C9C4B2:6A4D7022 |
| html-safe-nonce | dfd51379ed077934b05216eb2539ebc029bef92691da573d904b4191933d4828 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTA4OjdCMkMxOjk1QzdEQzpDOUM0QjI6NkE0RDcwMjIiLCJ2aXNpdG9yX2lkIjoiMzA5Njc4MjQwNDE1NDM4ODUxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a7f723c99ceaee19792974a6c785bd75bc30514da4f42d64eeb54d840dac8caf |
| hovercard-subject-tag | pull_request:216853127 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22969/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d560d8630c26a8622ef1d9a1fda933cf0f2daa4d7a242fdb2c48f04a66b1ab1d/nodejs/node/pull/22969 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d560d8630c26a8622ef1d9a1fda933cf0f2daa4d7a242fdb2c48f04a66b1ab1d/nodejs/node/pull/22969 |
| og:image:alt | Remove ERR_INDEX_OUT_OF_RANGE in favor of ERR_OUT_OF_RANGE which is
capable of providing more detail. (In one instance, use
ERR_BUFFER_OUT_OF_BOUNDS which is more accurate in that one instance.)
Up... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | c78260c7b3f4ac4b0356c8208537f05406a3a2d46a9ec3f735b372dcc519c39e |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 399fff412f48461d435721c009efc17ea44be72f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22969#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22969 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22969 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22969 |
| Reload | https://github.com/nodejs/node/pull/22969 |
| Reload | https://github.com/nodejs/node/pull/22969 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
962
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:remove-index-out-of-range | https://github.com/Trott/io.js/tree/remove-index-out-of-range |
| Conversation | https://github.com/nodejs/node/pull/22969 |
| Commits10 (10) | https://github.com/nodejs/node/pull/22969/commits |
| Checks | https://github.com/nodejs/node/pull/22969/checks |
| Files changed | https://github.com/nodejs/node/pull/22969/files |
| errors: use ERR_OUT_OF_RANGE for index errors | https://github.com/nodejs/node/pull/22969#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:remove-index-out-of-range | https://github.com/Trott/io.js/tree/remove-index-out-of-range |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#issue-362029618 |
| @apapirovski | https://github.com/apapirovski |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
|
| https://github.com/Trott |
| errors: use ERR_OUT_OF_RANGE for index errors | https://github.com/nodejs/node/pull/22969/commits/2fa028adb5b23631e40a8a1c8723ae377ab41019 |
| 2fa028a | https://github.com/nodejs/node/pull/22969/commits/2fa028adb5b23631e40a8a1c8723ae377ab41019 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#event-1856737541 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-423049912 |
| @Trott | https://github.com/Trott |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/948/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/948/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#event-1856737645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-423050046 |
| https://ci.nodejs.org/job/node-test-pull-request/17335/ | https://ci.nodejs.org/job/node-test-pull-request/17335/ |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157117836 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157118115 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019 |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157131995 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019 |
| lib/buffer.js | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| lib/buffer.js | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| lib/buffer.js | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| lib/buffer.js | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| test/parallel/test-async-wrap-trigger-id.js | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-f8b369fd78dc252df5643c5417f59732c47c6f6b91ddfb575b77e2b73e78bf53 |
| BridgeAR | https://github.com/BridgeAR |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#discussion_r219056707 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| test/parallel/test-buffer-fill.js | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-0cde8c435c6e93186699b49b8fa4df620f6d6159e5f6d8c4b20d42088cb483a9 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157138032 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019 |
| test/parallel/test-async-wrap-trigger-id.js | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-f8b369fd78dc252df5643c5417f59732c47c6f6b91ddfb575b77e2b73e78bf53 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157138555 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019 |
| test/parallel/test-async-wrap-trigger-id.js | https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019#diff-f8b369fd78dc252df5643c5417f59732c47c6f6b91ddfb575b77e2b73e78bf53 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| Trott | https://github.com/Trott |
| September 20, 2018 05:51 | https://github.com/nodejs/node/pull/22969#commits-pushed-215a746 |
|
| https://github.com/Trott |
| squash! remove unrelated and incorrect change | https://github.com/nodejs/node/pull/22969/commits/215a746be4679b067fceea4aefafb31b364d803d |
| 215a746 | https://github.com/nodejs/node/pull/22969/commits/215a746be4679b067fceea4aefafb31b364d803d |
|
| https://github.com/Trott |
| squash! fix errors doc copy/paste error | https://github.com/nodejs/node/pull/22969/commits/dd49e5abadd7070a84e006b442388242d7ba2a51 |
| dd49e5a | https://github.com/nodejs/node/pull/22969/commits/dd49e5abadd7070a84e006b442388242d7ba2a51 |
|
| https://github.com/Trott |
| squash! remove blank line | https://github.com/nodejs/node/pull/22969/commits/f50964057d026966d9aeaa75696c5e75b1d997d8 |
| f509640 | https://github.com/nodejs/node/pull/22969/commits/f50964057d026966d9aeaa75696c5e75b1d997d8 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| stale review | https://github.com/nodejs/node/pull/22969#pullrequestreview-157138555 |
| September 20, 2018 12:57 | https://github.com/nodejs/node/pull/22969#event-1857617369 |
| Trott | https://github.com/Trott |
| September 20, 2018 06:19 | https://github.com/nodejs/node/pull/22969#commits-pushed-3ee951d |
|
| https://github.com/Trott |
| fixup! add target.length to message about targetEnd range | https://github.com/nodejs/node/pull/22969/commits/3ee951d0fafba56baaf935247f39983f84bb3e51 |
| 3ee951d | https://github.com/nodejs/node/pull/22969/commits/3ee951d0fafba56baaf935247f39983f84bb3e51 |
|
| https://github.com/Trott |
| fixup! add max value to sourceEnd out-of-range message | https://github.com/nodejs/node/pull/22969/commits/92fc0c64b61ed5948bb6308a91e04f577af733cf |
| 92fc0c6 | https://github.com/nodejs/node/pull/22969/commits/92fc0c64b61ed5948bb6308a91e04f577af733cf |
|
| https://github.com/Trott |
| fixup! add range in msg | https://github.com/nodejs/node/pull/22969/commits/f1791dbdd2861c651d69748a2ff13f9469ef3b1e |
| f1791db | https://github.com/nodejs/node/pull/22969/commits/f1791dbdd2861c651d69748a2ff13f9469ef3b1e |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157269063 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/f1791dbdd2861c651d69748a2ff13f9469ef3b1e |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/22969/files/f1791dbdd2861c651d69748a2ff13f9469ef3b1e#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| Trott | https://github.com/Trott |
| September 20, 2018 06:34 | https://github.com/nodejs/node/pull/22969#commits-pushed-4da4144 |
|
| https://github.com/Trott |
| squash! add message text to some test cases | https://github.com/nodejs/node/pull/22969/commits/4da414437eeccc42e1a1229b0350940496aff406 |
| 4da4144 | https://github.com/nodejs/node/pull/22969/commits/4da414437eeccc42e1a1229b0350940496aff406 |
|
| https://github.com/Trott |
| squash! add pr-url to YAML, move to top of changes list | https://github.com/nodejs/node/pull/22969/commits/4dfc67f8bd1313cc265922f24ac5d6f2f61dd2e8 |
| 4dfc67f | https://github.com/nodejs/node/pull/22969/commits/4dfc67f8bd1313cc265922f24ac5d6f2f61dd2e8 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-423186831 |
| https://ci.nodejs.org/job/node-test-pull-request/17340/ | https://ci.nodejs.org/job/node-test-pull-request/17340/ |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157359120 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/4dfc67f8bd1313cc265922f24ac5d6f2f61dd2e8 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157360067 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/4dfc67f8bd1313cc265922f24ac5d6f2f61dd2e8 |
|
| https://github.com/Trott |
| squash! remove check for message that originates in C++ and varies by OS | https://github.com/nodejs/node/pull/22969/commits/8dba23abf0178845afd59b480563a1aa262b98aa |
| 8dba23a | https://github.com/nodejs/node/pull/22969/commits/8dba23abf0178845afd59b480563a1aa262b98aa |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-423255966 |
| https://ci.nodejs.org/job/node-test-pull-request/17343/ | https://ci.nodejs.org/job/node-test-pull-request/17343/ |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157394191 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/8dba23abf0178845afd59b480563a1aa262b98aa |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157394191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157424181 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/8dba23abf0178845afd59b480563a1aa262b98aa |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-423312982 |
| https://ci.nodejs.org/job/node-test-pull-request/17347/ | https://ci.nodejs.org/job/node-test-pull-request/17347/ |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-423330118 |
| https://ci.nodejs.org/job/node-test-commit-windows-fanned/20904/ | https://ci.nodejs.org/job/node-test-commit-windows-fanned/20904/ |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
|
Sep 21, 2018
| https://github.com/nodejs/node/pull/22969#pullrequestreview-157523151 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22969/files/8dba23abf0178845afd59b480563a1aa262b98aa |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-423412597 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://ci.nodejs.org/job/node-test-commit-windows-fanned/20909/ | https://ci.nodejs.org/job/node-test-commit-windows-fanned/20909/ |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 23, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-423796075 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1557/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1557/ |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/22969#ref-issue-363725227 |
|
CI failures: 20180925
nodejs/reliability#17
| https://github.com/nodejs/reliability/issues/17 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 27, 2018 | https://github.com/nodejs/node/pull/22969#issuecomment-424937542 |
| f8d6991 | https://github.com/nodejs/node/commit/f8d69911bef0ddd150d0f66f7a75b4655cf60b00 |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 27, 2018 | https://github.com/nodejs/node/pull/22969#event-1869949763 |
| Trott | https://github.com/Trott |
|
Sep 27, 2018
| https://github.com/nodejs/node/pull/22969#ref-commit-f8d6991 |
|
| https://github.com/Trott |
| errors: use ERR_OUT_OF_RANGE for index errors | https://github.com/Trott/io.js/commit/f8d69911bef0ddd150d0f66f7a75b4655cf60b00 |
| f8d6991 | https://github.com/Trott/io.js/commit/f8d69911bef0ddd150d0f66f7a75b4655cf60b00 |
| nodejs#22969 | https://github.com/nodejs/node/pull/22969 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:50 | https://github.com/nodejs/node/pull/22969#event-5890968275 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22969 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22969/files/4dfc67f8bd1313cc265922f24ac5d6f2f61dd2e8 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/22969/files/8dba23abf0178845afd59b480563a1aa262b98aa |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/22969/files/4dfc67f8bd1313cc265922f24ac5d6f2f61dd2e8 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/22969/files/8dba23abf0178845afd59b480563a1aa262b98aa |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/22969/files/2fa028adb5b23631e40a8a1c8723ae377ab41019 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/22969/files/f1791dbdd2861c651d69748a2ff13f9469ef3b1e |
|
| https://github.com/starkwang |
|
starkwang
| https://github.com/starkwang |
|
| https://github.com/nodejs/node/pull/22969/files/8dba23abf0178845afd59b480563a1aa262b98aa |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Please reload this page | https://github.com/nodejs/node/pull/22969 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/joyeecheung |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/starkwang |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |