| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:74871550-008d-1136-d020-9114535b01b1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B926:13DA52:F06BB6:12ECAB5:69915246 |
| html-safe-nonce | 89a77a2e7075fad9a1fced600c669df9327aa812939977d2ac86d6689be3c87d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTI2OjEzREE1MjpGMDZCQjY6MTJFQ0FCNTo2OTkxNTI0NiIsInZpc2l0b3JfaWQiOiI3MjAyNzk2Mzg5MjMwNzkzMjg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cca147899b0fbb5631f0b8ebfba832ead0fe4f18088e478be4cd144e9d78487d |
| hovercard-subject-tag | pull_request:216525077 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22943/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/63422a828eba22fca2e9cb9867d927a59c74df167a558932ec03565097767bb3/nodejs/node/pull/22943 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/63422a828eba22fca2e9cb9867d927a59c74df167a558932ec03565097767bb3/nodejs/node/pull/22943 |
| og:image:alt | This commit adds a CheckOptions function that the options classes can
optionally implement to check that options specified are correct
(dependencies between options are met or options that are mutu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22943#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22943 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22943 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22943 |
| Reload | https://github.com/nodejs/node/pull/22943 |
| Reload | https://github.com/nodejs/node/pull/22943 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:check_options | https://github.com/danbev/node/tree/check_options |
| Conversation | https://github.com/nodejs/node/pull/22943 |
| Commits2 (2) | https://github.com/nodejs/node/pull/22943/commits |
| Checks | https://github.com/nodejs/node/pull/22943/checks |
| Files changed | https://github.com/nodejs/node/pull/22943/files |
| src: add CheckOptions to Options classes | https://github.com/nodejs/node/pull/22943#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:check_options | https://github.com/danbev/node/tree/check_options |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22943#issue-361593681 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
|
| https://github.com/danbev |
| src: add CheckOptions to Options classes | https://github.com/nodejs/node/pull/22943/commits/cc9e95411e84a2ff97f19fc5e1a3135ec1a9acf5 |
| cc9e954 | https://github.com/nodejs/node/pull/22943/commits/cc9e95411e84a2ff97f19fc5e1a3135ec1a9acf5 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22943#issuecomment-422668058 |
| @danbev | https://github.com/danbev |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/940/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/940/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22943#event-1854141481 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22943#issuecomment-422669415 |
| https://ci.nodejs.org/job/node-test-pull-request/17310/ | https://ci.nodejs.org/job/node-test-pull-request/17310/ |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 19, 2018
| https://github.com/nodejs/node/pull/22943#pullrequestreview-156914853 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22943/files/cc9e95411e84a2ff97f19fc5e1a3135ec1a9acf5 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 19, 2018
| https://github.com/nodejs/node/pull/22943#pullrequestreview-156924860 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22943/files/cc9e95411e84a2ff97f19fc5e1a3135ec1a9acf5 |
| src/node_options.cc | https://github.com/nodejs/node/pull/22943/files/cc9e95411e84a2ff97f19fc5e1a3135ec1a9acf5#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| addaleax | https://github.com/addaleax |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22943#discussion_r218885517 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
| danbev | https://github.com/danbev |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22943#discussion_r219027945 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
|
| https://github.com/danbev |
| squash: make CheckOptions delegate | https://github.com/nodejs/node/pull/22943/commits/0c61a6d9e4f71403e943ea7ab8519385acf88cf6 |
| 0c61a6d | https://github.com/nodejs/node/pull/22943/commits/0c61a6d9e4f71403e943ea7ab8519385acf88cf6 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22943#issuecomment-423417501 |
| https://ci.nodejs.org/job/node-test-pull-request/17350/ | https://ci.nodejs.org/job/node-test-pull-request/17350/ |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 21, 2018
| https://github.com/nodejs/node/pull/22943#pullrequestreview-157687082 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22943/files/0c61a6d9e4f71403e943ea7ab8519385acf88cf6 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/22943#issuecomment-423732084 |
| 36bdd19 | https://github.com/nodejs/node/commit/36bdd19a6b3aee18143a3d45d6eedc19a2e95189 |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/22943#event-1861540030 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/22943#ref-commit-36bdd19 |
|
| https://github.com/danbev |
|
| https://github.com/addaleax |
| src: add CheckOptions to Options classes | https://github.com/nodejs/node/commit/36bdd19a6b3aee18143a3d45d6eedc19a2e95189 |
| 36bdd19 | https://github.com/nodejs/node/commit/36bdd19a6b3aee18143a3d45d6eedc19a2e95189 |
| #22943 | https://github.com/nodejs/node/pull/22943 |
| targos | https://github.com/targos |
|
Sep 23, 2018
| https://github.com/nodejs/node/pull/22943#ref-commit-b6cd185 |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| src: add CheckOptions to Options classes | https://github.com/nodejs/node/commit/b6cd18517c55f9209f632ecce1a9782e4d3217dd |
| b6cd185 | https://github.com/nodejs/node/commit/b6cd18517c55f9209f632ecce1a9782e4d3217dd |
| #22943 | https://github.com/nodejs/node/pull/22943 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 7, 2018
| https://github.com/nodejs/node/pull/22943#ref-pullrequest-367548700 |
|
Release proposal: v10.12.0
#23313
| https://github.com/nodejs/node/pull/23313 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#225
| https://github.com/beevelop/docker-nodejs/issues/225 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#239
| https://github.com/beevelop/docker-android-nodejs/issues/239 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#226
| https://github.com/beevelop/docker-nodejs/issues/226 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#240
| https://github.com/beevelop/docker-android-nodejs/issues/240 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#227
| https://github.com/beevelop/docker-nodejs/issues/227 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#241
| https://github.com/beevelop/docker-android-nodejs/issues/241 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#242
| https://github.com/beevelop/docker-android-nodejs/issues/242 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#228
| https://github.com/beevelop/docker-nodejs/issues/228 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#243
| https://github.com/beevelop/docker-android-nodejs/issues/243 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#229
| https://github.com/beevelop/docker-nodejs/issues/229 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| August 20, 2019 07:50 | https://github.com/nodejs/node/pull/22943#event-2568712694 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22943 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22943/files/cc9e95411e84a2ff97f19fc5e1a3135ec1a9acf5 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22943/files/cc9e95411e84a2ff97f19fc5e1a3135ec1a9acf5 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/22943/files/0c61a6d9e4f71403e943ea7ab8519385acf88cf6 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/22943 |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/joyeecheung |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |