René's URL Explorer Experiment


Title: trace_event: destroy platform before tracing by ofrobots · Pull Request #22938 · nodejs/node · GitHub

Open Graph Title: trace_event: destroy platform before tracing by ofrobots · Pull Request #22938 · nodejs/node

X Title: trace_event: destroy platform before tracing by ofrobots · Pull Request #22938 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: For safer shutdown, we should destroy the platform – and platform threads - before the tracing infrastructure is destroyed. This change fixes the relative order of NodePlatform disposition and the ...

X Description: For safer shutdown, we should destroy the platform – and platform threads - before the tracing infrastructure is destroyed. This change fixes the relative order of NodePlatform disposition and the ...

Opengraph URL: https://github.com/nodejs/node/pull/22938

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c5e86729-8e9a-5e0f-0e1e-981781043e2c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD0E:2338CF:3CC7E0:4EB68D:69909C99
html-safe-noncef3fc6185fce1197504a09aed9e2e6dea564d349138e56cbfb4c707dae3d72a65
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDBFOjIzMzhDRjozQ0M3RTA6NEVCNjhEOjY5OTA5Qzk5IiwidmlzaXRvcl9pZCI6Ijc4MTk4NzAwNjg4MTczMDQ3MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb1385a6dd3a18c8456301e9c98124c85695f32bdf0aba0bcc026395ec827f55b
hovercard-subject-tagpull_request:216449508
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22938/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4104cabee8884b243d2a5c8aed97b7848df461346cdfdd9eacf78c80e2252ab9/nodejs/node/pull/22938
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4104cabee8884b243d2a5c8aed97b7848df461346cdfdd9eacf78c80e2252ab9/nodejs/node/pull/22938
og:image:altFor safer shutdown, we should destroy the platform – and platform threads - before the tracing infrastructure is destroyed. This change fixes the relative order of NodePlatform disposition and the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameofrobots
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22938#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22938
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22938
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22938
Reloadhttps://github.com/nodejs/node/pull/22938
Reloadhttps://github.com/nodejs/node/pull/22938
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22938
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ofrobotshttps://github.com/ofrobots
nodejs:masterhttps://github.com/nodejs/node/tree/master
ofrobots:fix-platform-tracing-shutdown-racehttps://github.com/ofrobots/node/tree/fix-platform-tracing-shutdown-race
Conversationhttps://github.com/nodejs/node/pull/22938
Commits2 (2)https://github.com/nodejs/node/pull/22938/commits
Checkshttps://github.com/nodejs/node/pull/22938/checks
Files changedhttps://github.com/nodejs/node/pull/22938/files
trace_event: destroy platform before tracinghttps://github.com/nodejs/node/pull/22938#top
ofrobotshttps://github.com/ofrobots
nodejs:masterhttps://github.com/nodejs/node/tree/master
ofrobots:fix-platform-tracing-shutdown-racehttps://github.com/ofrobots/node/tree/fix-platform-tracing-shutdown-race
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 18, 2018https://github.com/nodejs/node/pull/22938#issue-361490924
Please reload this pagehttps://github.com/nodejs/node/pull/22938
#22865https://github.com/nodejs/node/issues/22865
92b695ehttps://github.com/nodejs/node/commit/92b695ed2690504b7cbc630b3f5c85e7bd87ca55
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
https://ci.nodejs.org/job/node-test-pull-request/17302/https://ci.nodejs.org/job/node-test-pull-request/17302/
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 18, 2018https://github.com/nodejs/node/pull/22938#issuecomment-422561698
@ofrobotshttps://github.com/ofrobots
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/937/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/937/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Sep 18, 2018https://github.com/nodejs/node/pull/22938#event-1853541043
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
eugeneohttps://github.com/eugeneo
September 18, 2018 21:27https://github.com/nodejs/node/pull/22938#event-1853541078
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
Sep 18, 2018 https://github.com/nodejs/node/pull/22938#pullrequestreview-156579460
View reviewed changes https://github.com/nodejs/node/pull/22938/files
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 19, 2018https://github.com/nodejs/node/pull/22938#issuecomment-422781158
https://ci.nodejs.org/job/node-test-linter/22199/https://ci.nodejs.org/job/node-test-linter/22199/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/20863/https://ci.nodejs.org/job/node-test-commit-windows-fanned/20863/
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 19, 2018https://github.com/nodejs/node/pull/22938#issuecomment-422810363
https://ci.nodejs.org/job/node-test-commit-windows-fanned/20869/https://ci.nodejs.org/job/node-test-commit-windows-fanned/20869/
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 19, 2018 https://github.com/nodejs/node/pull/22938#pullrequestreview-156915680
View reviewed changes https://github.com/nodejs/node/pull/22938/files
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 19, 2018https://github.com/nodejs/node/pull/22938#issuecomment-422881030
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 19, 2018 https://github.com/nodejs/node/pull/22938#pullrequestreview-156983056
View reviewed changes https://github.com/nodejs/node/pull/22938/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/22938#pullrequestreview-156983056
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 19, 2018https://github.com/nodejs/node/pull/22938#issuecomment-422995373
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 20, 2018https://github.com/nodejs/node/pull/22938#issuecomment-422999218
Please reload this pagehttps://github.com/nodejs/node/pull/22938
ofrobotshttps://github.com/ofrobots
September 20, 2018 14:45https://github.com/nodejs/node/pull/22938#commits-pushed-7139e97
https://github.com/ofrobots
trace_event: destroy platform before tracinghttps://github.com/nodejs/node/pull/22938/commits/7139e97e8b667ece3093443d30cff5ae960a21a1
7139e97https://github.com/nodejs/node/pull/22938/commits/7139e97e8b667ece3093443d30cff5ae960a21a1
nodejs#22865https://github.com/nodejs/node/issues/22865
https://github.com/ofrobots
[squash] lint fixhttps://github.com/nodejs/node/pull/22938/commits/db9b5ff7bc6d3c60739d42bfa9ae674496fd1167
db9b5ffhttps://github.com/nodejs/node/pull/22938/commits/db9b5ff7bc6d3c60739d42bfa9ae674496fd1167
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
force-pushedhttps://github.com/nodejs/node/compare/b2718fe81142e1a8062e2447f4783d0512ed4ce1..db9b5ff7bc6d3c60739d42bfa9ae674496fd1167
b2718fehttps://github.com/nodejs/node/commit/b2718fe81142e1a8062e2447f4783d0512ed4ce1
db9b5ffhttps://github.com/nodejs/node/commit/db9b5ff7bc6d3c60739d42bfa9ae674496fd1167
Compare https://github.com/nodejs/node/compare/b2718fe81142e1a8062e2447f4783d0512ed4ce1..db9b5ff7bc6d3c60739d42bfa9ae674496fd1167
September 20, 2018 21:45https://github.com/nodejs/node/pull/22938#event-1858850461
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 20, 2018https://github.com/nodejs/node/pull/22938#issuecomment-423363096
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 23, 2018 https://github.com/nodejs/node/pull/22938#ref-issue-360389142
Investigate flaky test/parallel/test-trace-events-fs-sync #22865 https://github.com/nodejs/node/issues/22865
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 23, 2018https://github.com/nodejs/node/pull/22938#issuecomment-423847474
@ofrobotshttps://github.com/ofrobots
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/refack
refackhttps://github.com/refack
Sep 24, 2018 https://github.com/nodejs/node/pull/22938#pullrequestreview-157960458
View reviewed changes https://github.com/nodejs/node/pull/22938/files/db9b5ff7bc6d3c60739d42bfa9ae674496fd1167
src/tracing/agent.cchttps://github.com/nodejs/node/pull/22938/files/db9b5ff7bc6d3c60739d42bfa9ae674496fd1167#diff-00b6f2609d3eb76c793b2bd03a5ab088fd32eb130ec6e0ba945cb8e5853abdf9
refackhttps://github.com/refack
Sep 24, 2018https://github.com/nodejs/node/pull/22938#discussion_r219719219
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22938
ofrobotshttps://github.com/ofrobots
Sep 24, 2018https://github.com/nodejs/node/pull/22938#discussion_r219859331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 24, 2018https://github.com/nodejs/node/pull/22938#issuecomment-423996181
Please reload this pagehttps://github.com/nodejs/node/pull/22938
instructionshttps://github.com/nodejs/node/pull/13947#issuecomment-312231068
thishttps://stackoverflow.com/questions/13876222/creating-dump-file-at-the-moment-of-access-violation
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 24, 2018https://github.com/nodejs/node/pull/22938#issuecomment-424084341
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 24, 2018 https://github.com/nodejs/node/pull/22938#ref-issue-363278324
Platform thread race: process.exit executed before background threads are ready #23065 https://github.com/nodejs/node/issues/23065
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 24, 2018https://github.com/nodejs/node/pull/22938#issuecomment-424087152
#23065https://github.com/nodejs/node/issues/23065
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/Trott
Trotthttps://github.com/Trott
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Sep 24, 2018https://github.com/nodejs/node/pull/22938#event-1864318833
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 24, 2018https://github.com/nodejs/node/pull/22938#issuecomment-424143631
#23065https://github.com/nodejs/node/issues/23065
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Sep 28, 2018 https://github.com/nodejs/node/pull/22938#ref-pullrequest-325489986
src: trace_event: secondary storage for metadata #20900 https://github.com/nodejs/node/pull/20900
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/22938#issuecomment-427548866
#23065https://github.com/nodejs/node/issues/23065
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/Trott
Trotthttps://github.com/Trott
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Oct 6, 2018https://github.com/nodejs/node/pull/22938#event-1888435281
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/22938#issuecomment-427548913
https://ci.nodejs.org/job/node-test-pull-request/17658/https://ci.nodejs.org/job/node-test-pull-request/17658/
Please reload this pagehttps://github.com/nodejs/node/pull/22938
Trotthttps://github.com/Trott
Oct 6, 2018 https://github.com/nodejs/node/pull/22938#ref-commit-68b3e46
https://github.com/ofrobots
https://github.com/Trott
trace_events: destroy platform before tracinghttps://github.com/Trott/io.js/commit/68b3e46fbf88ad81f50f68c7f0c725dc06c8beb0
68b3e46https://github.com/Trott/io.js/commit/68b3e46fbf88ad81f50f68c7f0c725dc06c8beb0
nodejs#22865https://github.com/nodejs/node/issues/22865
nodejs#22938https://github.com/nodejs/node/pull/22938
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/22938#issuecomment-427572239
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 6, 2018https://github.com/nodejs/node/pull/22938#event-1888564733
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Oct 6, 2018https://github.com/nodejs/node/pull/22938#event-1888566760
https://github.com/targos
targoshttps://github.com/targos
Oct 6, 2018https://github.com/nodejs/node/pull/22938#issuecomment-427572679
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 10, 2018 https://github.com/nodejs/node/pull/22938#ref-pullrequest-368502723
[v10.x backport] backport 23233, 22938 #23398 https://github.com/nodejs/node/pull/23398
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
October 10, 2018 16:56https://github.com/nodejs/node/pull/22938#event-1896090886
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Oct 10, 2018https://github.com/nodejs/node/pull/22938#issuecomment-428649491
#23398https://github.com/nodejs/node/pull/23398
Please reload this pagehttps://github.com/nodejs/node/pull/22938
ofrobotshttps://github.com/ofrobots
Oct 13, 2018 https://github.com/nodejs/node/pull/22938#ref-commit-afca579
https://github.com/ofrobots
trace_events: destroy platform before tracinghttps://github.com/ofrobots/node/commit/afca57981d7772a56dcbd548ce983927d0b67b86
afca579https://github.com/ofrobots/node/commit/afca57981d7772a56dcbd548ce983927d0b67b86
nodejs#22865https://github.com/nodejs/node/issues/22865
nodejs#22938https://github.com/nodejs/node/pull/22938
ofrobotshttps://github.com/ofrobots
Oct 15, 2018 https://github.com/nodejs/node/pull/22938#ref-commit-0df91e6
https://github.com/ofrobots
trace_events: destroy platform before tracinghttps://github.com/nodejs/node/commit/0df91e644e14743d9a6f9d83e03c18dcd20396d6
0df91e6https://github.com/nodejs/node/commit/0df91e644e14743d9a6f9d83e03c18dcd20396d6
#22865https://github.com/nodejs/node/issues/22865
#22938https://github.com/nodejs/node/pull/22938
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Oct 15, 2018https://github.com/nodejs/node/pull/22938#event-1904803001
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/22938#ref-commit-1ef83c8
https://github.com/ofrobots
https://github.com/jasnell
trace_events: destroy platform before tracinghttps://github.com/nodejs/node/commit/1ef83c882b30e4f6e11ab0abdf0c317cd269196a
1ef83c8https://github.com/nodejs/node/commit/1ef83c882b30e4f6e11ab0abdf0c317cd269196a
#22865https://github.com/nodejs/node/issues/22865
#22938https://github.com/nodejs/node/pull/22938
MylesBorinshttps://github.com/MylesBorins
Oct 30, 2018 https://github.com/nodejs/node/pull/22938#ref-commit-808f37c
https://github.com/ofrobots
https://github.com/MylesBorins
trace_events: destroy platform before tracinghttps://github.com/nodejs/node/commit/808f37c97f9a4c4e972ab284fb71277515abd133
808f37chttps://github.com/nodejs/node/commit/808f37c97f9a4c4e972ab284fb71277515abd133
#22865https://github.com/nodejs/node/issues/22865
#22938https://github.com/nodejs/node/pull/22938
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/22938#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/22938#ref-commit-735e502
https://github.com/ofrobots
https://github.com/rvagg
trace_events: destroy platform before tracinghttps://github.com/nodejs/node/commit/735e502c96ceb6dc2e48de34ef61e96a9ffa9f7b
735e502https://github.com/nodejs/node/commit/735e502c96ceb6dc2e48de34ef61e96a9ffa9f7b
#22865https://github.com/nodejs/node/issues/22865
#22938https://github.com/nodejs/node/pull/22938
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/22938#ref-commit-1b8b5e5
https://github.com/ofrobots
https://github.com/MylesBorins
trace_events: destroy platform before tracinghttps://github.com/nodejs/node/commit/1b8b5e525cbe30e0435b7747e05f7d8e8d1b49cb
1b8b5e5https://github.com/nodejs/node/commit/1b8b5e525cbe30e0435b7747e05f7d8e8d1b49cb
#22865https://github.com/nodejs/node/issues/22865
#22938https://github.com/nodejs/node/pull/22938
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/22938#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jan 14, 2019 https://github.com/nodejs/node/pull/22938#ref-pullrequest-357293945
node-report: meld into core #22712 https://github.com/nodejs/node/pull/22712
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22938
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/22938/files/b2718fe81142e1a8062e2447f4783d0512ed4ce1
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22938/files/b2718fe81142e1a8062e2447f4783d0512ed4ce1
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/22938/files/db9b5ff7bc6d3c60739d42bfa9ae674496fd1167
https://github.com/eugeneo
eugeneo https://github.com/eugeneo
https://github.com/nodejs/node/pull/22938/files/39bd952d6ba1f67adda21aa9c9f8700fb6ccc0cb
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Investigate flaky test/parallel/test-trace-events-fs-sync https://github.com/nodejs/node/issues/22865
Please reload this pagehttps://github.com/nodejs/node/pull/22938
https://github.com/ofrobots
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/BridgeAR
https://github.com/targos
https://github.com/mcollina
https://github.com/refack
https://github.com/eugeneo
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.