| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dfdb9b34-3622-82b9-7762-0d105491319c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC66:5A3DD:EC16B5:12AA396:69915236 |
| html-safe-nonce | a500aeda0312956c63b92c6f35469b54091abbe1d88ef385a08d74dfe5802cc1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzY2OjVBM0REOkVDMTZCNToxMkFBMzk2OjY5OTE1MjM2IiwidmlzaXRvcl9pZCI6IjM0NDI4NTUwODkxNDM4OTQ1ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5f7489fa7441d24ffac0a9f8896c8c60ef0da7bc38ed1297104a9ab5453a601f |
| hovercard-subject-tag | pull_request:216169757 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22920/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/47c616fd3f435cf7e14db52c66f7fb801e4d920d0101632f2b936452dfb706f3/nodejs/node/pull/22920 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/47c616fd3f435cf7e14db52c66f7fb801e4d920d0101632f2b936452dfb706f3/nodejs/node/pull/22920 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines
Roughly working. In CI I've stumbled into #2200... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22920#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22920 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22920 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22920 |
| Reload | https://github.com/nodejs/node/pull/22920 |
| Reload | https://github.com/nodejs/node/pull/22920 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:canary-base | https://github.com/nodejs/node/tree/canary-base |
| refack:gyp-v8-embedded-builtins | https://github.com/refack/node/tree/gyp-v8-embedded-builtins |
| Conversation | https://github.com/nodejs/node/pull/22920 |
| Commits7 (7) | https://github.com/nodejs/node/pull/22920/commits |
| Checks | https://github.com/nodejs/node/pull/22920/checks |
| Files changed | https://github.com/nodejs/node/pull/22920/files |
| [canary] GYP v8 embedded builtins | https://github.com/nodejs/node/pull/22920#top |
| refack | https://github.com/refack |
| nodejs:canary-base | https://github.com/nodejs/node/tree/canary-base |
| refack:gyp-v8-embedded-builtins | https://github.com/refack/node/tree/gyp-v8-embedded-builtins |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22920#issue-361117597 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| #22006 | https://github.com/nodejs/node/issues/22006 |
| nodejs/node-v8#75 | https://github.com/nodejs/node-v8/issues/75 |
| nodejs/node-v8#39 | https://github.com/nodejs/node-v8/issues/39 |
| nodejs/node-v8#74 | https://github.com/nodejs/node-v8/issues/74 |
| #22757 | https://github.com/nodejs/node/issues/22757 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-422238321 |
| @refack | https://github.com/refack |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/918/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/918/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22920#event-1851283133 |
| https://github.com/refack |
| refack | https://github.com/refack |
| targos | https://github.com/targos |
| September 18, 2018 03:02 | https://github.com/nodejs/node/pull/22920#event-1851283153 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-422238513 |
| https://ci.nodejs.org/job/node-test-commit/21549/ | https://ci.nodejs.org/job/node-test-commit/21549/ |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/d381eebaf8d7b880fc72987e5b246d390ab87444..17297a9f4e61d11a5bb2a3f687170e79ce3b6cf4 |
| d381eeb | https://github.com/nodejs/node/commit/d381eebaf8d7b880fc72987e5b246d390ab87444 |
| 17297a9 | https://github.com/nodejs/node/commit/17297a9f4e61d11a5bb2a3f687170e79ce3b6cf4 |
|
Compare
| https://github.com/nodejs/node/compare/d381eebaf8d7b880fc72987e5b246d390ab87444..17297a9f4e61d11a5bb2a3f687170e79ce3b6cf4 |
| September 18, 2018 07:47 | https://github.com/nodejs/node/pull/22920#event-1851622672 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/b55c5bbd5918ef129623fe70e160775afd06850d..ef1ca1329b4a6d868af4b95e8dbdd5c44a148b53 |
| b55c5bb | https://github.com/nodejs/node/commit/b55c5bbd5918ef129623fe70e160775afd06850d |
| ef1ca13 | https://github.com/nodejs/node/commit/ef1ca1329b4a6d868af4b95e8dbdd5c44a148b53 |
|
Compare
| https://github.com/nodejs/node/compare/b55c5bbd5918ef129623fe70e160775afd06850d..ef1ca1329b4a6d868af4b95e8dbdd5c44a148b53 |
| September 18, 2018 08:18 | https://github.com/nodejs/node/pull/22920#event-1851687504 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/17297a9f4e61d11a5bb2a3f687170e79ce3b6cf4..b7f5b534af32d444d762cecfe476e62ebf4fa19a |
| 17297a9 | https://github.com/nodejs/node/commit/17297a9f4e61d11a5bb2a3f687170e79ce3b6cf4 |
| b7f5b53 | https://github.com/nodejs/node/commit/b7f5b534af32d444d762cecfe476e62ebf4fa19a |
|
Compare
| https://github.com/nodejs/node/compare/17297a9f4e61d11a5bb2a3f687170e79ce3b6cf4..b7f5b534af32d444d762cecfe476e62ebf4fa19a |
| September 18, 2018 08:20 | https://github.com/nodejs/node/pull/22920#event-1851693128 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22920#event-1851696203 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-422302324 |
| https://ci.nodejs.org/job/node-test-pull-request/17273/ | https://ci.nodejs.org/job/node-test-pull-request/17273/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1696/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1696/ |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22920#pullrequestreview-156289978 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22920/files |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-422347020 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-422409416 |
| #22006 | https://github.com/nodejs/node/issues/22006 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/ivz-dev |
| ivz-dev | https://github.com/ivz-dev |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22920#pullrequestreview-156526863 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22920/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22920#ref-issue-361489080 |
|
CI failures: 20180918
nodejs/reliability#16
| https://github.com/nodejs/reliability/issues/16 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-422607482 |
| https://ci.nodejs.org/job/node-test-pull-request/17305/ | https://ci.nodejs.org/job/node-test-pull-request/17305/ |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Sep 19, 2018
| https://github.com/nodejs/node/pull/22920#ref-pullrequest-361542267 |
|
build: automatically generate some file lists that the GN build uses
electron/node#63
| https://github.com/electron/node/pull/63 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/67ca58363591beeff0e13f2b79add52e8bcb6386..0f6d4d3660441788b55c07602f966cd0b9b12541 |
| 67ca583 | https://github.com/nodejs/node/commit/67ca58363591beeff0e13f2b79add52e8bcb6386 |
| 0f6d4d3 | https://github.com/nodejs/node/commit/0f6d4d3660441788b55c07602f966cd0b9b12541 |
|
Compare
| https://github.com/nodejs/node/compare/67ca58363591beeff0e13f2b79add52e8bcb6386..0f6d4d3660441788b55c07602f966cd0b9b12541 |
| September 19, 2018 22:37 | https://github.com/nodejs/node/pull/22920#event-1856302287 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-422981996 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://ci.nodejs.org/job/node-test-pull-request/17330/ | https://ci.nodejs.org/job/node-test-pull-request/17330/ |
| https://ci.nodejs.org/job/node-test-commit/21633/ | https://ci.nodejs.org/job/node-test-commit/21633/ |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-422997341 |
| https://ci.nodejs.org/job/node-test-commit/21635/ | https://ci.nodejs.org/job/node-test-commit/21635/ |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423185051 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| ubuntu1804-docker | https://ci.nodejs.org/job/node-test-commit-linux/21717/nodes=ubuntu1804-docker/console |
| ppcle-ubuntu1404 | https://ci.nodejs.org/job/node-test-commit-plinux/20368/nodes=ppcle-ubuntu1404/console |
| ubuntu1604_sharedlibs_withoutintl_x64 | https://ci.nodejs.org/job/node-test-commit-linux-containered/7218/nodes=ubuntu1604_sharedlibs_withoutintl_x64/console |
| ubuntu1604-arm64 | https://ci.nodejs.org/job/node-test-commit-arm/18606/nodes=ubuntu1604-arm64/console |
| win-vs2017 | https://ci.nodejs.org/job/node-compile-windows/20967/label=win-vs2017/console |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423185398 |
| SmartOS | https://ci.nodejs.org/job/node-test-commit-smartos/20363/nodes=smartos17-64/console |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423186688 |
| ubuntu1604_sharedlibs_debug_x64 | https://ci.nodejs.org/job/node-test-commit-linux-containered/7218/nodes=ubuntu1604_sharedlibs_debug_x64/console |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423187434 |
| aix61-ppc64 | https://ci.nodejs.org/job/node-test-commit-aix/17878/nodes=aix61-ppc64/console |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 20, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423192083 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| embedded_default.cc.txt | https://github.com/nodejs/node/files/2401585/embedded_default.cc.txt |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423380923 |
| https://ci.nodejs.org/job/node-test-commit/21656/ | https://ci.nodejs.org/job/node-test-commit/21656/ |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423384514 |
| aix61-ppc64 | https://ci.nodejs.org/job/node-test-commit-aix/17878/nodes=aix61-ppc64/console |
| src/snapshot/macros.h | https://github.com/nodejs/node/blob/canary-base/deps/v8/src/snapshot/macros.h |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423387472 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| @richardlau | https://github.com/richardlau |
| embedded_default.s.gz | https://github.com/nodejs/node/files/2403608/embedded_default.s.gz |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22920#event-1859126255 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-423394491 |
| AIX assembler | https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.alangref/alangref_kickoff.htm |
| Appendix A messages | https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.alangref/idalangref_appendixa_messages.htm |
| @john-yan | https://github.com/john-yan |
| nodejs/node-v8#79 | https://github.com/nodejs/node-v8/issues/79 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/c8224ab05d471eb060f79a6dc896b3f0782be4cc..e366bc69c8c8cc35de5313ee2f8abbb91712a348 |
| c8224ab | https://github.com/nodejs/node/commit/c8224ab05d471eb060f79a6dc896b3f0782be4cc |
| e366bc6 | https://github.com/nodejs/node/commit/e366bc69c8c8cc35de5313ee2f8abbb91712a348 |
|
Compare
| https://github.com/nodejs/node/compare/c8224ab05d471eb060f79a6dc896b3f0782be4cc..e366bc69c8c8cc35de5313ee2f8abbb91712a348 |
| October 4, 2018 18:06 | https://github.com/nodejs/node/pull/22920#event-1885339205 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/a6069bb7dabc5656d7efc46b42d7b788f9ab193d..278d2059d79c108b6226bcf8275318db275cd564 |
| a6069bb | https://github.com/nodejs/node/commit/a6069bb7dabc5656d7efc46b42d7b788f9ab193d |
| 278d205 | https://github.com/nodejs/node/commit/278d2059d79c108b6226bcf8275318db275cd564 |
|
Compare
| https://github.com/nodejs/node/compare/a6069bb7dabc5656d7efc46b42d7b788f9ab193d..278d2059d79c108b6226bcf8275318db275cd564 |
| October 4, 2018 18:10 | https://github.com/nodejs/node/pull/22920#event-1885348682 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-427117355 |
| https://ci.nodejs.org/job/node-test-commit/22030/ | https://ci.nodejs.org/job/node-test-commit/22030/ |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#event-1885351706 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/22920#pullrequestreview-161744036 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22920/files |
| deps/v8/gypfiles/features.gypi | https://github.com/nodejs/node/pull/22920/files#diff-80df43e7273439ce801e12c82184a84c9d4bb67b81618c922d0b9856d2025d98 |
| refack | https://github.com/refack |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222775067 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| hashseed | https://github.com/hashseed |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222779926 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| BUILD.gn | https://github.com/v8/v8/blob/7.0-lkgr/BUILD.gn#L71 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| hashseed | https://github.com/hashseed |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222780565 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/22920#pullrequestreview-161760898 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22920/files |
| deps/v8/gypfiles/v8.gyp | https://github.com/nodejs/node/pull/22920/files#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
| targos | https://github.com/targos |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222788338 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/22920#pullrequestreview-161762595 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22920/files |
| deps/v8/gypfiles/v8_external_snapshot.gypi | https://github.com/nodejs/node/pull/22920/files#diff-36b7f95066ba1d296e4fdb5e710c8bd03ca4638d1e844c8ea741a514f6589e40 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/22920#pullrequestreview-161763047 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22920/files |
| Makefile | https://github.com/nodejs/node/pull/22920/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
| targos | https://github.com/targos |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222790080 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #23255 | https://github.com/nodejs/node/issues/23255 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| refack | https://github.com/refack |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222793469 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #22006 | https://github.com/nodejs/node/issues/22006 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| refack | https://github.com/refack |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222793910 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #22006 | https://github.com/nodejs/node/issues/22006 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-427133373 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/22920#pullrequestreview-161765669 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22920/files |
| deps/v8/gypfiles/v8.gyp | https://github.com/nodejs/node/pull/22920/files#diff-03a841fa087887c6d7f142a7c735c10319951c34b7d0a64e58d9f52ade42ec4f |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 4, 2018
| https://github.com/nodejs/node/pull/22920#pullrequestreview-161775453 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22920/files |
| deps/v8/gypfiles/features.gypi | https://github.com/nodejs/node/pull/22920/files#diff-80df43e7273439ce801e12c82184a84c9d4bb67b81618c922d0b9856d2025d98 |
| richardlau | https://github.com/richardlau |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222799854 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| refack | https://github.com/refack |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222800570 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/nodejs/node/blob/ae461f52330710858f1282bfacdd2da6e0145dd9/deps/v8/BUILD.gn#L74-L77 | https://github.com/nodejs/node/blob/ae461f52330710858f1282bfacdd2da6e0145dd9/deps/v8/BUILD.gn#L74-L77 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| targos | https://github.com/targos |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#discussion_r222801052 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| BUILD.gn | https://github.com/v8/v8/blob/fb4d8c01afe0ffeb1959d389fae65c4c35e62709/BUILD.gn#L74-L77 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/refack |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22920 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/3a80db94804d1ad4968d37b375338fb18a84d7ce..0dc2c7dc6f68c100ee40c04e420822ad02a1a68b |
| 3a80db9 | https://github.com/nodejs/node/commit/3a80db94804d1ad4968d37b375338fb18a84d7ce |
| 0dc2c7d | https://github.com/nodejs/node/commit/0dc2c7dc6f68c100ee40c04e420822ad02a1a68b |
|
Compare
| https://github.com/nodejs/node/compare/3a80db94804d1ad4968d37b375338fb18a84d7ce..0dc2c7dc6f68c100ee40c04e420822ad02a1a68b |
| October 4, 2018 21:18 | https://github.com/nodejs/node/pull/22920#event-1885746204 |
| https://github.com/refack |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22920 |
| refack | https://github.com/refack |
| October 4, 2018 17:44 | https://github.com/nodejs/node/pull/22920#commits-pushed-720c2b5 |
|
| https://github.com/refack |
| deps: V8 sync gypfiles with 7.1 | https://github.com/nodejs/node/pull/22920/commits/720c2b5fe3326cef1e8936423a9a562ef9b88ef3 |
| 720c2b5 | https://github.com/nodejs/node/pull/22920/commits/720c2b5fe3326cef1e8936423a9a562ef9b88ef3 |
|
| https://github.com/refack |
| temprary fix for CI | https://github.com/nodejs/node/pull/22920/commits/b65f4d2b6580c7590e17e3a34104a71331263df0 |
| b65f4d2 | https://github.com/nodejs/node/pull/22920/commits/b65f4d2b6580c7590e17e3a34104a71331263df0 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/0dc2c7dc6f68c100ee40c04e420822ad02a1a68b..b65f4d2b6580c7590e17e3a34104a71331263df0 |
| 0dc2c7d | https://github.com/nodejs/node/commit/0dc2c7dc6f68c100ee40c04e420822ad02a1a68b |
| b65f4d2 | https://github.com/nodejs/node/commit/b65f4d2b6580c7590e17e3a34104a71331263df0 |
|
Compare
| https://github.com/nodejs/node/compare/0dc2c7dc6f68c100ee40c04e420822ad02a1a68b..b65f4d2b6580c7590e17e3a34104a71331263df0 |
| October 4, 2018 21:45 | https://github.com/nodejs/node/pull/22920#event-1885795069 |
|
| https://github.com/refack |
| fixup! set V8 variables | https://github.com/nodejs/node/pull/22920/commits/311fd7f048ccd6fbf50d2c59395111de8a7b4b31 |
| 311fd7f | https://github.com/nodejs/node/pull/22920/commits/311fd7f048ccd6fbf50d2c59395111de8a7b4b31 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 4, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-427195167 |
| https://ci.nodejs.org/job/node-test-commit/22040/ | https://ci.nodejs.org/job/node-test-commit/22040/ |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/e366bc69c8c8cc35de5313ee2f8abbb91712a348..d17262581e4b66218584adb8b1c3ed23edb9307e |
| e366bc6 | https://github.com/nodejs/node/commit/e366bc69c8c8cc35de5313ee2f8abbb91712a348 |
| d172625 | https://github.com/nodejs/node/commit/d17262581e4b66218584adb8b1c3ed23edb9307e |
|
Compare
| https://github.com/nodejs/node/compare/e366bc69c8c8cc35de5313ee2f8abbb91712a348..d17262581e4b66218584adb8b1c3ed23edb9307e |
| October 5, 2018 06:30 | https://github.com/nodejs/node/pull/22920#event-1886342257 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 5, 2018 | https://github.com/nodejs/node/pull/22920#issuecomment-427260421 |
| d172625 | https://github.com/nodejs/node/commit/d17262581e4b66218584adb8b1c3ed23edb9307e |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 5, 2018 | https://github.com/nodejs/node/pull/22920#event-1886343578 |
|
Port support for embedded builtins/embedded bytecode handlers to gyp
nodejs/node-v8#75
| https://github.com/nodejs/node-v8/issues/75 |
|
Upcoming change to build config
nodejs/node-v8#39
| https://github.com/nodejs/node-v8/issues/39 |
|
Port torque_base to gyp
nodejs/node-v8#74
| https://github.com/nodejs/node-v8/issues/74 |
|
aix: embedded-builtins generated code doesn't compile
nodejs/node-v8#79
| https://github.com/nodejs/node-v8/issues/79 |
|
There are no binaries since 10-Sep-2018
nodejs/node-v8#80
| https://github.com/nodejs/node-v8/issues/80 |
| https://github.com/refack |
| refack | https://github.com/refack |
| October 6, 2018 00:30 | https://github.com/nodejs/node/pull/22920#event-1888331889 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 6, 2018 | https://github.com/nodejs/node/pull/22920#event-1888576499 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 12, 2018 | https://github.com/nodejs/node/pull/22920#event-1899617757 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22920 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/22920/files/ae461f52330710858f1282bfacdd2da6e0145dd9 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/22920/files/ae461f52330710858f1282bfacdd2da6e0145dd9 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22920/files/ef1ca1329b4a6d868af4b95e8dbdd5c44a148b53 |
|
| https://github.com/hashseed |
|
hashseed
| https://github.com/hashseed |
|
| https://github.com/nodejs/node/pull/22920/files/278d2059d79c108b6226bcf8275318db275cd564 |
|
| https://github.com/ivz-dev |
|
ivz-dev
| https://github.com/ivz-dev |
|
| https://github.com/nodejs/node/pull/22920/files/ef1ca1329b4a6d868af4b95e8dbdd5c44a148b53 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/22920 |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/richardlau |
|
| https://github.com/addaleax |
|
| https://github.com/hashseed |
|
| https://github.com/ivz-dev |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |