René's URL Explorer Experiment


Title: [v10.x backport] tools, test: forbid string literal as third argument for assert.strictEqual() and friends by Trott · Pull Request #22912 · nodejs/node · GitHub

Open Graph Title: [v10.x backport] tools, test: forbid string literal as third argument for assert.strictEqual() and friends by Trott · Pull Request #22912 · nodejs/node

X Title: [v10.x backport] tools, test: forbid string literal as third argument for assert.strictEqual() and friends by Trott · Pull Request #22912 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Backport of #22849. @targos

X Description: Backport of #22849. @targos

Opengraph URL: https://github.com/nodejs/node/pull/22912

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:926a0850-dcb9-b77f-d9d2-65ae5e2e2c33
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE546:20FC8E:866BAC:AF1FFB:6991EADC
html-safe-nonce68e61f363489b4fe925bae5a09ab5521dde380d1b1f133cab1a71b5b14449951
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTQ2OjIwRkM4RTo4NjZCQUM6QUYxRkZCOjY5OTFFQURDIiwidmlzaXRvcl9pZCI6IjQ1MDgyMDQwMjczNTY1MDY4NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7f0ca0506395f9709c5a9b9f065628504789478cc40f2bb7b7c4c65ae797278a
hovercard-subject-tagpull_request:216070527
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22912/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/64e729a3aa577496b3b133eacbc066f2b03f3f479ca63c71f81fbac2b19d5e2e/nodejs/node/pull/22912
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/64e729a3aa577496b3b133eacbc066f2b03f3f479ca63c71f81fbac2b19d5e2e/nodejs/node/pull/22912
og:image:altBackport of #22849. @targos
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22912#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22912
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22912
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22912
Reloadhttps://github.com/nodejs/node/pull/22912
Reloadhttps://github.com/nodejs/node/pull/22912
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22912
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 715 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
Trott:v10.x-backport-22849https://github.com/Trott/io.js/tree/v10.x-backport-22849
Conversationhttps://github.com/nodejs/node/pull/22912
Commits12 (12)https://github.com/nodejs/node/pull/22912/commits
Checkshttps://github.com/nodejs/node/pull/22912/checks
Files changedhttps://github.com/nodejs/node/pull/22912/files
[v10.x backport] tools, test: forbid string literal as third argument for assert.strictEqual() and friendshttps://github.com/nodejs/node/pull/22912#top
Trotthttps://github.com/Trott
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
Trott:v10.x-backport-22849https://github.com/Trott/io.js/tree/v10.x-backport-22849
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 17, 2018https://github.com/nodejs/node/pull/22912#issue-360985493
#22849https://github.com/nodejs/node/pull/22849
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/22912
Trotthttps://github.com/Trott
September 17, 2018 11:08https://github.com/nodejs/node/pull/22912#commits-pushed-8b69c00
https://github.com/Trott
test: remove string literal message from assertionhttps://github.com/nodejs/node/pull/22912/commits/8b69c00975d4d3f6a6870e0150509aaf54033bae
8b69c00https://github.com/nodejs/node/pull/22912/commits/8b69c00975d4d3f6a6870e0150509aaf54033bae
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: remove string literal message in assertionshttps://github.com/nodejs/node/pull/22912/commits/9579f7aa2b8dfcb0c42f38944b7571575212a0ab
9579f7ahttps://github.com/nodejs/node/pull/22912/commits/9579f7aa2b8dfcb0c42f38944b7571575212a0ab
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: improve assertion in test-inspector.jshttps://github.com/nodejs/node/pull/22912/commits/efe0d1780fa5e252167404ed18193a545dc7d347
efe0d17https://github.com/nodejs/node/pull/22912/commits/efe0d1780fa5e252167404ed18193a545dc7d347
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: simplify assertion in http2 testshttps://github.com/nodejs/node/pull/22912/commits/d1c0f51c2d3e4ab58db643519bc55d3579b81103
d1c0f51https://github.com/nodejs/node/pull/22912/commits/d1c0f51c2d3e4ab58db643519bc55d3579b81103
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: refactor flag checkhttps://github.com/nodejs/node/pull/22912/commits/c924e1674ca5ccb3b82b05529d8512662b1224aa
c924e16https://github.com/nodejs/node/pull/22912/commits/c924e1674ca5ccb3b82b05529d8512662b1224aa
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: remove string literal from assertionhttps://github.com/nodejs/node/pull/22912/commits/bc9ae8ebc4312efee61c1deec602acf1e84f8a46
bc9ae8ehttps://github.com/nodejs/node/pull/22912/commits/bc9ae8ebc4312efee61c1deec602acf1e84f8a46
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: remove string literal message from assertionhttps://github.com/nodejs/node/pull/22912/commits/8e4fc42f8e909850a228bb24494e2e25a14d707f
8e4fc42https://github.com/nodejs/node/pull/22912/commits/8e4fc42f8e909850a228bb24494e2e25a14d707f
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: remove string literal arg from assertionhttps://github.com/nodejs/node/pull/22912/commits/495bb6d621c1ed146fe9f6fb2cba8d697a92d834
495bb6dhttps://github.com/nodejs/node/pull/22912/commits/495bb6d621c1ed146fe9f6fb2cba8d697a92d834
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: remove string literal from assertionhttps://github.com/nodejs/node/pull/22912/commits/1db83a7e0ba5e75865b562b1308b4a8077629de3
1db83a7https://github.com/nodejs/node/pull/22912/commits/1db83a7e0ba5e75865b562b1308b4a8077629de3
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: remove string literal from assertionhttps://github.com/nodejs/node/pull/22912/commits/b423af60439b38e48c9105cf6eca20ad24b5fc0c
b423af6https://github.com/nodejs/node/pull/22912/commits/b423af60439b38e48c9105cf6eca20ad24b5fc0c
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
test: prepare test-assert for strictEqual lintinghttps://github.com/nodejs/node/pull/22912/commits/dcf4a35c7f576f9f2d2cdce5c25ca77e79cb7c4a
dcf4a35https://github.com/nodejs/node/pull/22912/commits/dcf4a35c7f576f9f2d2cdce5c25ca77e79cb7c4a
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
tools: prevent string literals in some assertionshttps://github.com/nodejs/node/pull/22912/commits/f6f5920b2f62f66d6601b856791bb20868ba94e9
f6f5920https://github.com/nodejs/node/pull/22912/commits/f6f5920b2f62f66d6601b856791bb20868ba94e9
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 17, 2018https://github.com/nodejs/node/pull/22912#issuecomment-422118278
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/912/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/912/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22912
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Sep 17, 2018https://github.com/nodejs/node/pull/22912#event-1850484004
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 17, 2018 https://github.com/nodejs/node/pull/22912#ref-pullrequest-360078506
tools, test: forbid string literal as third argument for assert.strictEqual() and friends #22849 https://github.com/nodejs/node/pull/22849
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 17, 2018 https://github.com/nodejs/node/pull/22912#pullrequestreview-156055777
View reviewed changes https://github.com/nodejs/node/pull/22912/files/f6f5920b2f62f66d6601b856791bb20868ba94e9
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 17, 2018https://github.com/nodejs/node/pull/22912#issuecomment-422118765
https://ci.nodejs.org/job/node-test-pull-request/17255/https://ci.nodejs.org/job/node-test-pull-request/17255/
Please reload this pagehttps://github.com/nodejs/node/pull/22912
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 17, 2018https://github.com/nodejs/node/pull/22912#issuecomment-422118935
https://ci.nodejs.org/job/node-test-pull-request/17256/https://ci.nodejs.org/job/node-test-pull-request/17256/
Please reload this pagehttps://github.com/nodejs/node/pull/22912
https://github.com/targos
targoshttps://github.com/targos
Sep 17, 2018 https://github.com/nodejs/node/pull/22912#pullrequestreview-156062728
View reviewed changes https://github.com/nodejs/node/pull/22912/files/f6f5920b2f62f66d6601b856791bb20868ba94e9
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-d5559f7
https://github.com/Trott
https://github.com/targos
test: remove string literal message from assertionhttps://github.com/nodejs/node/commit/d5559f7c33ed6c2052c10f1220bfab76cdd9da38
d5559f7https://github.com/nodejs/node/commit/d5559f7c33ed6c2052c10f1220bfab76cdd9da38
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-4c26d4c
https://github.com/Trott
https://github.com/targos
test: remove string literal message in assertionshttps://github.com/nodejs/node/commit/4c26d4c235fe9482b04d066d9778f474308236d8
4c26d4chttps://github.com/nodejs/node/commit/4c26d4c235fe9482b04d066d9778f474308236d8
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-08723d6
https://github.com/Trott
https://github.com/targos
test: improve assertion in test-inspector.jshttps://github.com/nodejs/node/commit/08723d6f08f9eb0938288c77785ed8e77e97b85a
08723d6https://github.com/nodejs/node/commit/08723d6f08f9eb0938288c77785ed8e77e97b85a
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-df47df8
https://github.com/Trott
https://github.com/targos
test: simplify assertion in http2 testshttps://github.com/nodejs/node/commit/df47df8c02d3194d18dc5033a523da7210b46ddb
df47df8https://github.com/nodejs/node/commit/df47df8c02d3194d18dc5033a523da7210b46ddb
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-0c9ca9f
https://github.com/Trott
https://github.com/targos
test: refactor flag checkhttps://github.com/nodejs/node/commit/0c9ca9f340ba4cd2b8548391a60511c8540075d7
0c9ca9fhttps://github.com/nodejs/node/commit/0c9ca9f340ba4cd2b8548391a60511c8540075d7
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-2a9a4f6
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/2a9a4f64022496128108f886eb54c2c84a1156a7
2a9a4f6https://github.com/nodejs/node/commit/2a9a4f64022496128108f886eb54c2c84a1156a7
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-8aea20a
https://github.com/Trott
https://github.com/targos
test: remove string literal message from assertionhttps://github.com/nodejs/node/commit/8aea20afb3c53b0727a34e5e90a7c2ced2ffd8b2
8aea20ahttps://github.com/nodejs/node/commit/8aea20afb3c53b0727a34e5e90a7c2ced2ffd8b2
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-2d1d113
https://github.com/Trott
https://github.com/targos
test: remove string literal arg from assertionhttps://github.com/nodejs/node/commit/2d1d1138610cd3f6dfa0280c9b67bf4fc205f788
2d1d113https://github.com/nodejs/node/commit/2d1d1138610cd3f6dfa0280c9b67bf4fc205f788
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-e528d6e
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/e528d6e7ea6adfd7a8984acd8d19e3f71bf24cf0
e528d6ehttps://github.com/nodejs/node/commit/e528d6e7ea6adfd7a8984acd8d19e3f71bf24cf0
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-47ed627
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/47ed627cb7b88441bb970270cfe71c412a598911
47ed627https://github.com/nodejs/node/commit/47ed627cb7b88441bb970270cfe71c412a598911
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-0fd614d
https://github.com/Trott
https://github.com/targos
tools: prevent string literals in some assertionshttps://github.com/nodejs/node/commit/0fd614d605c012217f57b6577814ebd4c0ead9c6
0fd614dhttps://github.com/nodejs/node/commit/0fd614d605c012217f57b6577814ebd4c0ead9c6
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-a15bfda
https://github.com/Trott
https://github.com/targos
test: remove string literal message from assertionhttps://github.com/nodejs/node/commit/a15bfdad789246e479487857604a514b8a22745d
a15bfdahttps://github.com/nodejs/node/commit/a15bfdad789246e479487857604a514b8a22745d
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-b301a7b
https://github.com/Trott
https://github.com/targos
test: remove string literal message in assertionshttps://github.com/nodejs/node/commit/b301a7b7eccf9f51611a5e80cd61c0bda0e20a7b
b301a7bhttps://github.com/nodejs/node/commit/b301a7b7eccf9f51611a5e80cd61c0bda0e20a7b
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-b31a4d0
https://github.com/Trott
https://github.com/targos
test: improve assertion in test-inspector.jshttps://github.com/nodejs/node/commit/b31a4d08084fc808f55404a5865e1b5977fa2ad2
b31a4d0https://github.com/nodejs/node/commit/b31a4d08084fc808f55404a5865e1b5977fa2ad2
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-e5de225
https://github.com/Trott
https://github.com/targos
test: simplify assertion in http2 testshttps://github.com/nodejs/node/commit/e5de2256803d4343b5d2426d3a9d6d641d424a16
e5de225https://github.com/nodejs/node/commit/e5de2256803d4343b5d2426d3a9d6d641d424a16
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-a5f7f1d
https://github.com/Trott
https://github.com/targos
test: refactor flag checkhttps://github.com/nodejs/node/commit/a5f7f1d98593e5e063f295e37f3324b5c7463168
a5f7f1dhttps://github.com/nodejs/node/commit/a5f7f1d98593e5e063f295e37f3324b5c7463168
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-266f1a9
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/266f1a9cd8d2b9be7a220e59a6811811a03709d7
266f1a9https://github.com/nodejs/node/commit/266f1a9cd8d2b9be7a220e59a6811811a03709d7
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-59b6968
https://github.com/Trott
https://github.com/targos
test: remove string literal message from assertionhttps://github.com/nodejs/node/commit/59b6968fb685af4f40015d7609901c57e5757269
59b6968https://github.com/nodejs/node/commit/59b6968fb685af4f40015d7609901c57e5757269
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-5316334
https://github.com/Trott
https://github.com/targos
test: remove string literal arg from assertionhttps://github.com/nodejs/node/commit/5316334955c64270f705d8a32febb0158aecf167
5316334https://github.com/nodejs/node/commit/5316334955c64270f705d8a32febb0158aecf167
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-5d4cbd7
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/5d4cbd7fa1b6e4e90ab94686f3a64bc378780cfb
5d4cbd7https://github.com/nodejs/node/commit/5d4cbd7fa1b6e4e90ab94686f3a64bc378780cfb
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-5a06326
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/5a0632666b715ba530e4ebc89dca953711d790b4
5a06326https://github.com/nodejs/node/commit/5a0632666b715ba530e4ebc89dca953711d790b4
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-ff6e4ea
https://github.com/Trott
https://github.com/targos
test: prepare test-assert for strictEqual lintinghttps://github.com/nodejs/node/commit/ff6e4ea4bd4f4a59d9d0bf7702c0e260e03b79c3
ff6e4eahttps://github.com/nodejs/node/commit/ff6e4ea4bd4f4a59d9d0bf7702c0e260e03b79c3
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-8ffcb2d
https://github.com/Trott
https://github.com/targos
tools: prevent string literals in some assertionshttps://github.com/nodejs/node/commit/8ffcb2d2cab59fa8174c52a8914266eee2915362
8ffcb2dhttps://github.com/nodejs/node/commit/8ffcb2d2cab59fa8174c52a8914266eee2915362
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
kjinhttps://github.com/kjin
Oct 3, 2018 https://github.com/nodejs/node/pull/22912#ref-commit-83e8649
https://github.com/Trott
https://github.com/kjin
test: simplify assertion in http2 testshttps://github.com/kjin/node/commit/83e8649e75ddda84994d3a448d74ffb1d0d9a044
83e8649https://github.com/kjin/node/commit/83e8649e75ddda84994d3a448d74ffb1d0d9a044
nodejs#22912https://github.com/nodejs/node/pull/22912
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:50https://github.com/nodejs/node/pull/22912#event-5890967840
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22912
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22912/files/f6f5920b2f62f66d6601b856791bb20868ba94e9
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/22912/files/f6f5920b2f62f66d6601b856791bb20868ba94e9
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/22912
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.