René's URL Explorer Experiment


Title: [v10.x backport] backport d48bd16 from v8 master by john-yan · Pull Request #22909 · nodejs/node · GitHub

Open Graph Title: [v10.x backport] backport d48bd16 from v8 master by john-yan · Pull Request #22909 · nodejs/node

X Title: [v10.x backport] backport d48bd16 from v8 master by john-yan · Pull Request #22909 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines #22907

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines #22907

Opengraph URL: https://github.com/nodejs/node/pull/22909

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e38202c0-334f-9b84-32db-257d9e61da61
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB5A:136ED2:257BC5C:2FF2F87:699116DE
html-safe-nonce06ae569796d2c6ae1bb7f8af0965e7bf2462503d720c518d10c36cf1bb0885d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjVBOjEzNkVEMjoyNTdCQzVDOjJGRjJGODc6Njk5MTE2REUiLCJ2aXNpdG9yX2lkIjoiMzY1NDAwMzgyODk2ODE5OTkwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4d66265e399c187d5c78a54f8771fbeed2e0d8b82c683787854bb33e56f1965a
hovercard-subject-tagpull_request:216048063
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22909/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d4d0a3224f3a113c1ff0a14ef393b2d647d1e7d28e5d6b08e57ee4d80a0ea705/nodejs/node/pull/22909
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d4d0a3224f3a113c1ff0a14ef393b2d647d1e7d28e5d6b08e57ee4d80a0ea705/nodejs/node/pull/22909
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines #22907
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejohn-yan
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22909#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22909
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22909
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22909
Reloadhttps://github.com/nodejs/node/pull/22909
Reloadhttps://github.com/nodejs/node/pull/22909
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22909
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
john-yanhttps://github.com/john-yan
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
john-yan:v10.xhttps://github.com/john-yan/node/tree/v10.x
Conversationhttps://github.com/nodejs/node/pull/22909
Commits44 (44)https://github.com/nodejs/node/pull/22909/commits
Checkshttps://github.com/nodejs/node/pull/22909/checks
Files changedhttps://github.com/nodejs/node/pull/22909/files
[v10.x backport] backport d48bd16 from v8 masterhttps://github.com/nodejs/node/pull/22909#top
john-yanhttps://github.com/john-yan
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
john-yan:v10.xhttps://github.com/john-yan/node/tree/v10.x
https://github.com/john-yan
john-yanhttps://github.com/john-yan
Sep 17, 2018https://github.com/nodejs/node/pull/22909#issue-360955998
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#22907https://github.com/nodejs/node/issues/22907
Please reload this pagehttps://github.com/nodejs/node/pull/22909
joaocgreishttps://github.com/joaocgreis
September 12, 2018 08:02https://github.com/nodejs/node/pull/22909#commits-pushed-1c3f81d
https://github.com/joaocgreis
https://github.com/targos
win,msi: install tools for native moduleshttps://github.com/nodejs/node/pull/22909/commits/1c3f81d61a0a6ec3261721fad127b25b3b3253a7
1c3f81dhttps://github.com/nodejs/node/pull/22909/commits/1c3f81d61a0a6ec3261721fad127b25b3b3253a7
nodejs#22311https://github.com/nodejs/node/issues/22311
nodejs#22645https://github.com/nodejs/node/pull/22645
https://github.com/addaleax
https://github.com/targos
doc: node debug → node inspect in CLI docshttps://github.com/nodejs/node/pull/22909/commits/05ace784c61a6f37bac85c2a02f5647222b4dd4c
05ace78https://github.com/nodejs/node/pull/22909/commits/05ace784c61a6f37bac85c2a02f5647222b4dd4c
nodejs#22774https://github.com/nodejs/node/pull/22774
https://github.com/tniessen
https://github.com/targos
tools: fix doc tool behavior for version arrayshttps://github.com/nodejs/node/pull/22909/commits/94e67b6bf49b48b014da9f7724a6bdf6c503bf86
94e67b6https://github.com/nodejs/node/pull/22909/commits/94e67b6bf49b48b014da9f7724a6bdf6c503bf86
nodejs#22766https://github.com/nodejs/node/pull/22766
https://github.com/targos
fs: implement mkdir recursive (mkdirp)https://github.com/nodejs/node/pull/22909/commits/779e07246275c81e5a95cecdf410f6c32163f3cf
779e072https://github.com/nodejs/node/pull/22909/commits/779e07246275c81e5a95cecdf410f6c32163f3cf
nodejs/user-feedback#70https://github.com/nodejs/user-feedback/pull/70
nodejs#21875https://github.com/nodejs/node/pull/21875
https://github.com/targos
test: add comment describing test-fs-mkdirhttps://github.com/nodejs/node/pull/22909/commits/b1be08fac34b73b231c9ef08581637b985dffad6
b1be08fhttps://github.com/nodejs/node/pull/22909/commits/b1be08fac34b73b231c9ef08581637b985dffad6
nodejs#22424https://github.com/nodejs/node/pull/22424
https://github.com/guybedford
https://github.com/targos
url: provide pathToFileURL and fileURLToPathhttps://github.com/nodejs/node/pull/22909/commits/75c288e1a255a3fbcde5354129a64261630b307b
75c288ehttps://github.com/nodejs/node/pull/22909/commits/75c288e1a255a3fbcde5354129a64261630b307b
nodejs#22506https://github.com/nodejs/node/pull/22506
https://github.com/targos
test: check parameter type of fs.mkdir()https://github.com/nodejs/node/pull/22909/commits/42e6ce270e966cb927db0b22e881618a4714ec85
42e6ce2https://github.com/nodejs/node/pull/22909/commits/42e6ce270e966cb927db0b22e881618a4714ec85
nodejs#22616https://github.com/nodejs/node/pull/22616
https://github.com/jasnell
https://github.com/targos
test: refactor structure of common/indexhttps://github.com/nodejs/node/pull/22909/commits/cf61a04b23090f285f9351199492c4b287ce34e8
cf61a04https://github.com/nodejs/node/pull/22909/commits/cf61a04b23090f285f9351199492c4b287ce34e8
nodejs#22511https://github.com/nodejs/node/pull/22511
https://github.com/BridgeAR
https://github.com/targos
assert: align argument nameshttps://github.com/nodejs/node/pull/22909/commits/108a1695eae229eb15fa92a510b40b7e3d2b9378
108a169https://github.com/nodejs/node/pull/22909/commits/108a1695eae229eb15fa92a510b40b7e3d2b9378
nodejs#22760https://github.com/nodejs/node/pull/22760
https://github.com/tiendq
https://github.com/targos
doc: add history for withFileTypes in fs.readdir[Sync]()https://github.com/nodejs/node/pull/22909/commits/09ae073458187de55419520e814ec7132ac3fa9b
09ae073https://github.com/nodejs/node/pull/22909/commits/09ae073458187de55419520e814ec7132ac3fa9b
nodejs#22794https://github.com/nodejs/node/pull/22794
nodejs#22777https://github.com/nodejs/node/issues/22777
https://github.com/tniessen
https://github.com/targos
crypto: fix public key encryption internalshttps://github.com/nodejs/node/pull/22909/commits/8b6a161c6596736f47d7183cf9c5f30a292c8da1
8b6a161https://github.com/nodejs/node/pull/22909/commits/8b6a161c6596736f47d7183cf9c5f30a292c8da1
nodejs#22780https://github.com/nodejs/node/pull/22780
https://github.com/tniessen
https://github.com/targos
crypto: rename symbols to match guidelineshttps://github.com/nodejs/node/pull/22909/commits/b87ab0f17762af470bf0bf7f193d48d44edb960c
b87ab0fhttps://github.com/nodejs/node/pull/22909/commits/b87ab0f17762af470bf0bf7f193d48d44edb960c
nodejs#22770https://github.com/nodejs/node/pull/22770
nodejs#22684https://github.com/nodejs/node/pull/22684
https://github.com/Trott
https://github.com/targos
doc: add gabrielschulhof to TSChttps://github.com/nodejs/node/pull/22909/commits/b9fd99ebd92256408b65787fa188c27578c01b57
b9fd99ehttps://github.com/nodejs/node/pull/22909/commits/b9fd99ebd92256408b65787fa188c27578c01b57
nodejs#22818https://github.com/nodejs/node/pull/22818
https://github.com/targos
n-api: add generic finalizer callbackhttps://github.com/nodejs/node/pull/22909/commits/8153c101e8bd14807f27b84b2d0d0252e32555ef
8153c10https://github.com/nodejs/node/pull/22909/commits/8153c101e8bd14807f27b84b2d0d0252e32555ef
nodejs/abi-stable-node#313https://github.com/nodejs/abi-stable-node/issues/313
nodejs#22244https://github.com/nodejs/node/pull/22244
https://github.com/legendecas
https://github.com/targos
test: checks on napi factory wrap’s finalizationhttps://github.com/nodejs/node/pull/22909/commits/2b3b205b402e72b50b7506cc5d549bf5c99e4ec9
2b3b205https://github.com/nodejs/node/pull/22909/commits/2b3b205b402e72b50b7506cc5d549bf5c99e4ec9
nodejs#22396https://github.com/nodejs/node/issues/22396
nodejs#22612https://github.com/nodejs/node/pull/22612
https://github.com/targos
lib: remove unnecessary symbolshttps://github.com/nodejs/node/pull/22909/commits/f41911f87848f4ac8d1c7db24fd631e09d3f4a93
f41911fhttps://github.com/nodejs/node/pull/22909/commits/f41911f87848f4ac8d1c7db24fd631e09d3f4a93
nodejs#22455https://github.com/nodejs/node/pull/22455
https://github.com/jasnell
https://github.com/targos
test: minor refactor in common/index.jshttps://github.com/nodejs/node/pull/22909/commits/01a5c7da6c614e43b62907eb56dcf1a0d12b3985
01a5c7dhttps://github.com/nodejs/node/pull/22909/commits/01a5c7da6c614e43b62907eb56dcf1a0d12b3985
nodejs#22738https://github.com/nodejs/node/pull/22738
https://github.com/sagitsofan
https://github.com/targos
doc: document http2 timeoutshttps://github.com/nodejs/node/pull/22909/commits/353cb4e97cf01bba708e2f515b037db5a83719cb
353cb4ehttps://github.com/nodejs/node/pull/22909/commits/353cb4e97cf01bba708e2f515b037db5a83719cb
nodejs#22798https://github.com/nodejs/node/pull/22798
https://github.com/mhdawson
https://github.com/targos
doc: add reference to guide for N-API additionshttps://github.com/nodejs/node/pull/22909/commits/a214769a977a234c4e0d93a7d136165531a58c9a
a214769https://github.com/nodejs/node/pull/22909/commits/a214769a977a234c4e0d93a7d136165531a58c9a
nodejs#22593https://github.com/nodejs/node/pull/22593
https://github.com/ofrobots
https://github.com/targos
deps: cherry-pick 2363cdf from upstream V8https://github.com/nodejs/node/pull/22909/commits/e85c81417d3060931bd39f8c474fe6400fed4a43
e85c814https://github.com/nodejs/node/pull/22909/commits/e85c81417d3060931bd39f8c474fe6400fed4a43
nodejs#21038https://github.com/nodejs/node/issues/21038
https://chromium-review.googlesource.com/1217726https://chromium-review.googlesource.com/1217726
nodejs#55809https://github.com/nodejs/node/pull/55809
v8/v8@2363cdfhttps://github.com/v8/v8/commit/2363cdfefeb643285cbe8593b7c17d80e5d06cd9
nodejs#22812https://github.com/nodejs/node/pull/22812
https://github.com/ofrobots
https://github.com/targos
trace_events: avoid flusing uninitialized traceshttps://github.com/nodejs/node/pull/22909/commits/92b695ed2690504b7cbc630b3f5c85e7bd87ca55
92b695ehttps://github.com/nodejs/node/pull/22909/commits/92b695ed2690504b7cbc630b3f5c85e7bd87ca55
nodejs#22812https://github.com/nodejs/node/pull/22812
https://github.com/cjihrig
https://github.com/targos
fs: ensure readdir() callback is only called oncehttps://github.com/nodejs/node/pull/22909/commits/41590001a55fcbc19e6f927c416c6d8c06568acd
4159000https://github.com/nodejs/node/pull/22909/commits/41590001a55fcbc19e6f927c416c6d8c06568acd
nodejs#22793https://github.com/nodejs/node/pull/22793
nodejs#22778https://github.com/nodejs/node/issues/22778
https://github.com/targos
lib: simplify 'processChunkSync'https://github.com/nodejs/node/pull/22909/commits/d853a3f549d5ef9ba8b7d43c09882f9f06cbd7f9
d853a3fhttps://github.com/nodejs/node/pull/22909/commits/d853a3f549d5ef9ba8b7d43c09882f9f06cbd7f9
nodejs#22802https://github.com/nodejs/node/pull/22802
https://github.com/devsnek
https://github.com/targos
module: add createRequireFunction methodhttps://github.com/nodejs/node/pull/22909/commits/535c30c20153579354cd3c4a106351411e0d290b
535c30chttps://github.com/nodejs/node/pull/22909/commits/535c30c20153579354cd3c4a106351411e0d290b
nodejs#19360https://github.com/nodejs/node/pull/19360
https://github.com/addaleax
https://github.com/targos
worker: correct (de)initialization orderhttps://github.com/nodejs/node/pull/22909/commits/ec6afb94e43533b5917ca48197f923fbde866994
ec6afb9https://github.com/nodejs/node/pull/22909/commits/ec6afb94e43533b5917ca48197f923fbde866994
nodejs#22736https://github.com/nodejs/node/issues/22736
nodejs#22773https://github.com/nodejs/node/pull/22773
https://github.com/addaleax
https://github.com/targos
tools: implement update-authors in JShttps://github.com/nodejs/node/pull/22909/commits/c9f2283d78eb7f12b446fc4ffb82a470d57a068a
c9f2283https://github.com/nodejs/node/pull/22909/commits/c9f2283d78eb7f12b446fc4ffb82a470d57a068a
nodejs#22771https://github.com/nodejs/node/pull/22771
https://github.com/addaleax
https://github.com/targos
doc: update AUTHORS listhttps://github.com/nodejs/node/pull/22909/commits/c898071c988e0459097ccce092a5392336a60d70
c898071https://github.com/nodejs/node/pull/22909/commits/c898071c988e0459097ccce092a5392336a60d70
nodejs#22771https://github.com/nodejs/node/pull/22771
https://github.com/jasnell
https://github.com/targos
src: move getActiveResources/Handles to node_process.cchttps://github.com/nodejs/node/pull/22909/commits/878d616cc2b3d6328dc1392c13b020604ab28794
878d616https://github.com/nodejs/node/pull/22909/commits/878d616cc2b3d6328dc1392c13b020604ab28794
nodejs#22758https://github.com/nodejs/node/pull/22758
https://github.com/jasnell
https://github.com/targos
src: move DebugPortGetter/Setter to node_process.cchttps://github.com/nodejs/node/pull/22909/commits/27b0cb5cfd6003e965181316281e33d1b4e03550
27b0cb5https://github.com/nodejs/node/pull/22909/commits/27b0cb5cfd6003e965181316281e33d1b4e03550
nodejs#22758https://github.com/nodejs/node/pull/22758
https://github.com/MohammedEssehemy
https://github.com/targos
doc: fix typo in dns docshttps://github.com/nodejs/node/pull/22909/commits/4ba80b18f82f455c6e0174ac77569026f42d6aff
4ba80b1https://github.com/nodejs/node/pull/22909/commits/4ba80b18f82f455c6e0174ac77569026f42d6aff
nodejs#22866https://github.com/nodejs/node/pull/22866
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 17, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422117203
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 17, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422117944
@john-yanhttps://github.com/john-yan
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 17, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422118264
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/john-yan
john-yanhttps://github.com/john-yan
Sep 17, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422120788
@addaleaxhttps://github.com/addaleax
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 17, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422121471
https://ci.nodejs.org/job/node-test-pull-request/17257/https://ci.nodejs.org/job/node-test-pull-request/17257/
https://ci.nodejs.org/job/node-test-commit-v8-linux/1693/https://ci.nodejs.org/job/node-test-commit-v8-linux/1693/
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/targos
targoshttps://github.com/targos
Sep 17, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422123094
Please reload this pagehttps://github.com/nodejs/node/pull/22909
September 17, 2018 14:43https://github.com/nodejs/node/pull/22909#commits-pushed-d0166ea
Revert "update patch level"https://github.com/nodejs/node/pull/22909/commits/d0166ead41436645c9b1500fde803c7342ee1d15
d0166eahttps://github.com/nodejs/node/pull/22909/commits/d0166ead41436645c9b1500fde803c7342ee1d15
9164ccfhttps://github.com/john-yan/node/commit/9164ccff1655a094112b93d096c86e46cbce5fcf
update embedder stringhttps://github.com/nodejs/node/pull/22909/commits/ce43fb1da139bec99387c4ed4feae2102b67d4e8
ce43fb1https://github.com/nodejs/node/pull/22909/commits/ce43fb1da139bec99387c4ed4feae2102b67d4e8
https://github.com/john-yan
john-yanhttps://github.com/john-yan
Sep 17, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422126540
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/targos
targoshttps://github.com/targos
Sep 19, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422669907
node-core-utilshttps://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-v8-backport-sha
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/774afa7d23041312bba563cbf64311c56381c0c0..7107451b4ea61a8dcddf15d27765efa76eca8e49
774afa7https://github.com/nodejs/node/commit/774afa7d23041312bba563cbf64311c56381c0c0
7107451https://github.com/nodejs/node/commit/7107451b4ea61a8dcddf15d27765efa76eca8e49
Compare https://github.com/nodejs/node/compare/774afa7d23041312bba563cbf64311c56381c0c0..7107451b4ea61a8dcddf15d27765efa76eca8e49
September 19, 2018 08:00https://github.com/nodejs/node/pull/22909#event-1854326013
https://github.com/john-yan
john-yanhttps://github.com/john-yan
Sep 19, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422907467
Please reload this pagehttps://github.com/nodejs/node/pull/22909
@targoshttps://github.com/targos
https://chromium-review.googlesource.com/c/v8/v8/+/1228638https://chromium-review.googlesource.com/c/v8/v8/+/1228638
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/targos
targoshttps://github.com/targos
Sep 19, 2018https://github.com/nodejs/node/pull/22909#issuecomment-422908706
@john-yanhttps://github.com/john-yan
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/c61e3b70fe19ba10ec5c351cc1facd899df6cfd3..5da1f0ca2cd60c1ac82c04bdb1b6744c75122a5e
c61e3b7https://github.com/nodejs/node/commit/c61e3b70fe19ba10ec5c351cc1facd899df6cfd3
5da1f0chttps://github.com/nodejs/node/commit/5da1f0ca2cd60c1ac82c04bdb1b6744c75122a5e
Compare https://github.com/nodejs/node/compare/c61e3b70fe19ba10ec5c351cc1facd899df6cfd3..5da1f0ca2cd60c1ac82c04bdb1b6744c75122a5e
September 20, 2018 06:16https://github.com/nodejs/node/pull/22909#event-1856758352
targoshttps://github.com/targos
Sep 23, 2018 https://github.com/nodejs/node/pull/22909#ref-commit-39d7699
https://github.com/targos
deps: cherry-pick d48bd16 from upstream V8https://github.com/nodejs/node/commit/39d7699a87344e53238ef3ee4f7beb7c438d65f4
39d7699https://github.com/nodejs/node/commit/39d7699a87344e53238ef3ee4f7beb7c438d65f4
https://chromium-review.googlesource.com/1194583https://chromium-review.googlesource.com/1194583
v8/v8@d48bd16https://github.com/v8/v8/commit/d48bd16c9a053a2c630d09a1550ba8bad6928638
#22909https://github.com/nodejs/node/pull/22909
https://github.com/targos
targoshttps://github.com/targos
Sep 23, 2018https://github.com/nodejs/node/pull/22909#issuecomment-423823083
39d7699https://github.com/nodejs/node/commit/39d7699a87344e53238ef3ee4f7beb7c438d65f4
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/targos
targoshttps://github.com/targos
Sep 23, 2018https://github.com/nodejs/node/pull/22909#event-1862011410
Cherry-pick d48bd16 to v10.x #22907 https://github.com/nodejs/node/issues/22907
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22909
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/22909
https://github.com/john-yan
https://github.com/mhdawson
https://github.com/addaleax
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/joaocgreis
https://github.com/tniessen
https://github.com/guybedford
https://github.com/jasnell
https://github.com/BridgeAR
https://github.com/tiendq
https://github.com/Trott
https://github.com/legendecas
https://github.com/sagitsofan
https://github.com/ofrobots
https://github.com/cjihrig
https://github.com/devsnek
https://github.com/MohammedEssehemy
https://github.com/bengl
https://github.com/apapirovski
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.