| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9a191267-bc01-d3e0-a4e5-52d478046e3f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E264:CDD1B:2A74B3E:361B083:6991B559 |
| html-safe-nonce | 37d1a32c5b0db9f709156ac3279d7370633cd1dc3512550bfd7511b682035010 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjY0OkNERDFCOjJBNzRCM0U6MzYxQjA4Mzo2OTkxQjU1OSIsInZpc2l0b3JfaWQiOiI1ODg1MTMxMDMzMDQ5OTM3MjQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 480ed67327b0fc6fe8fe3dfa612e007c9a4bdb8f77df19e977765c7178427ace |
| hovercard-subject-tag | pull_request:215940568 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22899/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a96ba2dd6c069818177b995ba7c75489e51c83123f40f42f37153cb37c78084d/nodejs/node/pull/22899 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a96ba2dd6c069818177b995ba7c75489e51c83123f40f42f37153cb37c78084d/nodejs/node/pull/22899 |
| og:image:alt | Refs: #22859
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ripsawridge |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22899#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22899 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22899 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22899 |
| Reload | https://github.com/nodejs/node/pull/22899 |
| Reload | https://github.com/nodejs/node/pull/22899 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
712
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ripsawridge | https://github.com/ripsawridge |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| ripsawridge:patchy | https://github.com/ripsawridge/node/tree/patchy |
| Conversation | https://github.com/nodejs/node/pull/22899 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22899/commits |
| Checks | https://github.com/nodejs/node/pull/22899/checks |
| Files changed | https://github.com/nodejs/node/pull/22899/files |
| deps: fix Array.prototype.forEach on v8 6.8 | https://github.com/nodejs/node/pull/22899#top |
| ripsawridge | https://github.com/ripsawridge |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| ripsawridge:patchy | https://github.com/ripsawridge/node/tree/patchy |
|
| https://github.com/ripsawridge |
| ripsawridge | https://github.com/ripsawridge |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22899#issue-360813755 |
| #22859 | https://github.com/nodejs/node/issues/22859 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22899#event-1849376184 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 18, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-422259582 |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/bricss |
| bricss | https://github.com/bricss |
|
Sep 19, 2018
| https://github.com/nodejs/node/pull/22899#ref-pullrequest-361312666 |
|
Release proposal: v10.11.0
#22932
| https://github.com/nodejs/node/pull/22932 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-422718529 |
| ab15016 | https://github.com/nodejs/node/commit/ab150160f8149063865729e52c6a7597133f9057 |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-422721049 |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/hashseed |
| hashseed | https://github.com/hashseed |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-423530847 |
| @ripsawridge | https://github.com/ripsawridge |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-423531580 |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| September 22, 2018 10:07 | https://github.com/nodejs/node/pull/22899#event-1861541260 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/2caf1c095b1fa90168b25a9062dddb6ff934976b..d8852623b84d552bb44abe3ae7f501bad0c29baf |
| 2caf1c0 | https://github.com/nodejs/node/commit/2caf1c095b1fa90168b25a9062dddb6ff934976b |
| d885262 | https://github.com/nodejs/node/commit/d8852623b84d552bb44abe3ae7f501bad0c29baf |
|
Compare
| https://github.com/nodejs/node/compare/2caf1c095b1fa90168b25a9062dddb6ff934976b..d8852623b84d552bb44abe3ae7f501bad0c29baf |
| September 22, 2018 10:16 | https://github.com/nodejs/node/pull/22899#event-1861543672 |
|
| https://github.com/ripsawridge |
|
| https://github.com/addaleax |
| deps: fix Array.prototype.forEach on v8 6.8 | https://github.com/nodejs/node/pull/22899/commits/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
| 1e8be82 | https://github.com/nodejs/node/pull/22899/commits/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
| v8/v8@e1163c14f7e4fef2c549 | https://github.com/v8/v8/commit/e1163c14f7e4fef2c549 |
| https://chromium-review.googlesource.com/1213207 | https://chromium-review.googlesource.com/1213207 |
| nodejs#55733 | https://github.com/nodejs/node/issues/55733 |
| v8/v8@e1163c1 | https://github.com/v8/v8/commit/e1163c14f7e4fef2c5499888fc8d1542f662a71a |
| nodejs#22859 | https://github.com/nodejs/node/issues/22859 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/d8852623b84d552bb44abe3ae7f501bad0c29baf..1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
| d885262 | https://github.com/nodejs/node/commit/d8852623b84d552bb44abe3ae7f501bad0c29baf |
| 1e8be82 | https://github.com/nodejs/node/commit/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
|
Compare
| https://github.com/nodejs/node/compare/d8852623b84d552bb44abe3ae7f501bad0c29baf..1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
| September 22, 2018 10:20 | https://github.com/nodejs/node/pull/22899#event-1861544563 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-423733185 |
| v8/v8@e1163c1 | https://github.com/v8/v8/commit/e1163c14f7e4fef2c5499888fc8d1542f662a71a |
| https://ci.nodejs.org/job/node-test-pull-request/17368/ | https://ci.nodejs.org/job/node-test-pull-request/17368/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1709/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1709/ |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/22899#pullrequestreview-157906680 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22899/files/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
| targos | https://github.com/targos |
| https://github.com/nodejs/node/pull/22899#pullrequestreview-157906680 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/22899#event-1861560181 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/22899#pullrequestreview-158445858 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22899/files/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/22899#pullrequestreview-158445858 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-424296338 |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-424340734 |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/22899#pullrequestreview-158537027 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22899/files/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
| targos | https://github.com/targos |
|
Sep 25, 2018
| https://github.com/nodejs/node/pull/22899#ref-commit-5d70652 |
|
| https://github.com/ripsawridge |
|
| https://github.com/targos |
| deps: fix Array.prototype.forEach on v8 6.8 | https://github.com/nodejs/node/commit/5d70652d867fb2b38d6a1be25b70fcbc4575568f |
| 5d70652 | https://github.com/nodejs/node/commit/5d70652d867fb2b38d6a1be25b70fcbc4575568f |
| v8/v8@e1163c14f7e4fef2c549 | https://github.com/v8/v8/commit/e1163c14f7e4fef2c549 |
| v8:8112 | https://bugs.chromium.org/p/v8/issues/detail?id=8112 |
| https://chromium-review.googlesource.com/1213207 | https://chromium-review.googlesource.com/1213207 |
| #55733 | https://github.com/nodejs/node/issues/55733 |
| v8/v8@e1163c1 | https://github.com/v8/v8/commit/e1163c14f7e4fef2c5499888fc8d1542f662a71a |
| #22859 | https://github.com/nodejs/node/issues/22859 |
| #22899 | https://github.com/nodejs/node/pull/22899 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/22899#issuecomment-424356834 |
| 5d70652 | https://github.com/nodejs/node/commit/5d70652d867fb2b38d6a1be25b70fcbc4575568f |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/22899#event-1865836929 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 7, 2018
| https://github.com/nodejs/node/pull/22899#ref-pullrequest-367548700 |
|
Release proposal: v10.12.0
#23313
| https://github.com/nodejs/node/pull/23313 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#225
| https://github.com/beevelop/docker-nodejs/issues/225 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#239
| https://github.com/beevelop/docker-android-nodejs/issues/239 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#226
| https://github.com/beevelop/docker-nodejs/issues/226 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#240
| https://github.com/beevelop/docker-android-nodejs/issues/240 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#227
| https://github.com/beevelop/docker-nodejs/issues/227 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#241
| https://github.com/beevelop/docker-android-nodejs/issues/241 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#242
| https://github.com/beevelop/docker-android-nodejs/issues/242 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#228
| https://github.com/beevelop/docker-nodejs/issues/228 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-android-nodejs#243
| https://github.com/beevelop/docker-android-nodejs/issues/243 |
|
2018-10-10 Version 10.12.0 (Current) @targos
beevelop/docker-nodejs#229
| https://github.com/beevelop/docker-nodejs/issues/229 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22899 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22899/files/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22899/files/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/22899/files/1e8be82fd3582c6952f06c66c56e33f67f1d8b59 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/22899 |
|
| https://github.com/ripsawridge |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
|
| https://github.com/targos |
|
| https://github.com/hashseed |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |