| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:17b14271-1d9a-13b1-ac60-a54bfc27228a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8762:13DA52:244D6F4:2DF9445:69919C83 |
| html-safe-nonce | 2990b28da56d5d03d5100ad3f9368942042515181e5e9cbdd0635d2221dfb6e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzYyOjEzREE1MjoyNDRENkY0OjJERjk0NDU6Njk5MTlDODMiLCJ2aXNpdG9yX2lkIjoiNjcwNDMyNjQ0OTExMTg2NjQ5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1e1328ecbd4a3cde15c30ff82f91e1a92465bcd493b8feb9ff612e306d90a6ea |
| hovercard-subject-tag | pull_request:215896530 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22892/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ef503044b5490967a3fad1d7315e2bb17a287fc2dbafeabe1005cda177f2e804/nodejs/node/pull/22892 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ef503044b5490967a3fad1d7315e2bb17a287fc2dbafeabe1005cda177f2e804/nodejs/node/pull/22892 |
| og:image:alt | Event of close does not fire when giving for stdio option that type is wrap.
For example, if we set event listener to net.server and giving child_process, that events never fire.
Checklist
make ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | koh110 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22892#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22892 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22892 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22892 |
| Reload | https://github.com/nodejs/node/pull/22892 |
| Reload | https://github.com/nodejs/node/pull/22892 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| koh110 | https://github.com/koh110 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| koh110:close_event | https://github.com/koh110/node/tree/close_event |
| Conversation | https://github.com/nodejs/node/pull/22892 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22892/commits |
| Checks | https://github.com/nodejs/node/pull/22892/checks |
| Files changed | https://github.com/nodejs/node/pull/22892/files |
| child_process: fire close event from stdio | https://github.com/nodejs/node/pull/22892#top |
| koh110 | https://github.com/koh110 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| koh110:close_event | https://github.com/koh110/node/tree/close_event |
|
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22892#issue-360755802 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22892#event-1849009492 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 17, 2018
| https://github.com/nodejs/node/pull/22892#pullrequestreview-155938701 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22892/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/22892/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| addaleax | https://github.com/addaleax |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r218080523 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| koh110 | https://github.com/koh110 |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r218123177 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/nodejs/node/blob/5a3e445304f3920590b2ae1d1237fe7615572a44/lib/internal/child_process.js#L274 | https://github.com/nodejs/node/blob/5a3e445304f3920590b2ae1d1237fe7615572a44/lib/internal/child_process.js#L274 |
| https://github.com/nodejs/node/blob/5a3e445304f3920590b2ae1d1237fe7615572a44/lib/internal/child_process.js#L377 | https://github.com/nodejs/node/blob/5a3e445304f3920590b2ae1d1237fe7615572a44/lib/internal/child_process.js#L377 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| addaleax | https://github.com/addaleax |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r218126017 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| koh110 | https://github.com/koh110 |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r218138614 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| force-pushed | https://github.com/nodejs/node/compare/5a3e445304f3920590b2ae1d1237fe7615572a44..d06e548d0f602100d6913d7712b3bfaf48550e8e |
| 5a3e445 | https://github.com/nodejs/node/commit/5a3e445304f3920590b2ae1d1237fe7615572a44 |
| d06e548 | https://github.com/nodejs/node/commit/d06e548d0f602100d6913d7712b3bfaf48550e8e |
|
Compare
| https://github.com/nodejs/node/compare/5a3e445304f3920590b2ae1d1237fe7615572a44..d06e548d0f602100d6913d7712b3bfaf48550e8e |
| September 17, 2018 22:57 | https://github.com/nodejs/node/pull/22892#event-1851030709 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-423524153 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 21, 2018
| https://github.com/nodejs/node/pull/22892#pullrequestreview-157788381 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22892/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/22892/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| addaleax | https://github.com/addaleax |
| Sep 21, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r219572524 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| koh110 | https://github.com/koh110 |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r219662028 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| force-pushed | https://github.com/nodejs/node/compare/d06e548d0f602100d6913d7712b3bfaf48550e8e..ba9c6f2e45e58c3bb25aa491a399ace32063013b |
| d06e548 | https://github.com/nodejs/node/commit/d06e548d0f602100d6913d7712b3bfaf48550e8e |
| ba9c6f2 | https://github.com/nodejs/node/commit/ba9c6f2e45e58c3bb25aa491a399ace32063013b |
|
Compare
| https://github.com/nodejs/node/compare/d06e548d0f602100d6913d7712b3bfaf48550e8e..ba9c6f2e45e58c3bb25aa491a399ace32063013b |
| September 22, 2018 04:15 | https://github.com/nodejs/node/pull/22892#event-1861452144 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-423732307 |
| https://ci.nodejs.org/job/node-test-pull-request/17367/ | https://ci.nodejs.org/job/node-test-pull-request/17367/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1556/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1556/ |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 24, 2018
| https://github.com/nodejs/node/pull/22892#pullrequestreview-158293189 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22892/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/22892#pullrequestreview-158293189 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/22892/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| addaleax | https://github.com/addaleax |
| Sep 24, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r219987309 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/nodejs/node/pull/22892/files#diff-f45eb699237c2e38dc9b49b588933c11R923 | https://github.com/nodejs/node/pull/22892/files#diff-f45eb699237c2e38dc9b49b588933c11R923 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| koh110 | https://github.com/koh110 |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r220059365 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| koh110 | https://github.com/koh110 |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r220062597 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| addaleax | https://github.com/addaleax |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r220113853 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @koh110 | https://github.com/koh110 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| koh110 | https://github.com/koh110 |
| Sep 25, 2018 | https://github.com/nodejs/node/pull/22892#discussion_r220182573 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| force-pushed | https://github.com/nodejs/node/compare/ba9c6f2e45e58c3bb25aa491a399ace32063013b..294fb6dad61cf310ecf0a713a370acba83d79ea2 |
| ba9c6f2 | https://github.com/nodejs/node/commit/ba9c6f2e45e58c3bb25aa491a399ace32063013b |
| 294fb6d | https://github.com/nodejs/node/commit/294fb6dad61cf310ecf0a713a370acba83d79ea2 |
|
Compare
| https://github.com/nodejs/node/compare/ba9c6f2e45e58c3bb25aa491a399ace32063013b..294fb6dad61cf310ecf0a713a370acba83d79ea2 |
| September 29, 2018 15:24 | https://github.com/nodejs/node/pull/22892#event-1874987364 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Sep 30, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-425691261 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Oct 19, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-431246940 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-437758063 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 14, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-438539935 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 15, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-438905616 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 24, 2018
| https://github.com/nodejs/node/pull/22892#pullrequestreview-178043187 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22892/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 24, 2018 | https://github.com/nodejs/node/pull/22892#event-1984903343 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 24, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-441350015 |
| https://ci.nodejs.org/job/node-test-pull-request/18918/ | https://ci.nodejs.org/job/node-test-pull-request/18918/ |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 25, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-441411066 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 25, 2018 | https://github.com/nodejs/node/pull/22892#event-1985220471 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 25, 2018
| https://github.com/nodejs/node/pull/22892#pullrequestreview-178067691 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22892/files |
| Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/nodejs/node/pull/22892#pullrequestreview-178067691 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| force-pushed | https://github.com/nodejs/node/compare/294fb6dad61cf310ecf0a713a370acba83d79ea2..03c7988a065025407ce6f840debf14ee0577bf89 |
| 294fb6d | https://github.com/nodejs/node/commit/294fb6dad61cf310ecf0a713a370acba83d79ea2 |
| 03c7988 | https://github.com/nodejs/node/commit/03c7988a065025407ce6f840debf14ee0577bf89 |
|
Compare
| https://github.com/nodejs/node/compare/294fb6dad61cf310ecf0a713a370acba83d79ea2..03c7988a065025407ce6f840debf14ee0577bf89 |
| November 28, 2018 10:22 | https://github.com/nodejs/node/pull/22892#event-1992017511 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-442406900 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 30, 2018 | https://github.com/nodejs/node/pull/22892#issuecomment-443101553 |
| https://ci.nodejs.org/job/node-test-pull-request/19076/ | https://ci.nodejs.org/job/node-test-pull-request/19076/ |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| force-pushed | https://github.com/nodejs/node/compare/03c7988a065025407ce6f840debf14ee0577bf89..a2b250fc10862b66771ed73836b2725df13db11a |
| 03c7988 | https://github.com/nodejs/node/commit/03c7988a065025407ce6f840debf14ee0577bf89 |
| a2b250f | https://github.com/nodejs/node/commit/a2b250fc10862b66771ed73836b2725df13db11a |
|
Compare
| https://github.com/nodejs/node/compare/03c7988a065025407ce6f840debf14ee0577bf89..a2b250fc10862b66771ed73836b2725df13db11a |
| December 8, 2018 10:39 | https://github.com/nodejs/node/pull/22892#event-2013929761 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Jan 7, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-451911043 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 7, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-452053963 |
| https://ci.nodejs.org/job/node-test-pull-request/19972/ | https://ci.nodejs.org/job/node-test-pull-request/19972/ |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| force-pushed | https://github.com/nodejs/node/compare/a2b250fc10862b66771ed73836b2725df13db11a..f8f1d101247023f3b7a0f354a698149d9789bb46 |
| a2b250f | https://github.com/nodejs/node/commit/a2b250fc10862b66771ed73836b2725df13db11a |
| f8f1d10 | https://github.com/nodejs/node/commit/f8f1d101247023f3b7a0f354a698149d9789bb46 |
|
Compare
| https://github.com/nodejs/node/compare/a2b250fc10862b66771ed73836b2725df13db11a..f8f1d101247023f3b7a0f354a698149d9789bb46 |
| January 8, 2019 10:26 | https://github.com/nodejs/node/pull/22892#event-2059818239 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Jan 8, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-452262875 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Jan 8, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-452267629 |
| https://ci.nodejs.org/job/node-test-pull-request/19990/ | https://ci.nodejs.org/job/node-test-pull-request/19990/ |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Jan 16, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-454643064 |
| https://ci.nodejs.org/job/node-test-commit-freebsd/23253/nodes=freebsd11-x64/console | https://ci.nodejs.org/job/node-test-commit-freebsd/23253/nodes=freebsd11-x64/console |
| https://ci.nodejs.org/job/node-test-binary-arm/5348/RUN_SUBSET=1,label=pi1-docker/console | https://ci.nodejs.org/job/node-test-binary-arm/5348/RUN_SUBSET=1,label=pi1-docker/console |
| https://ci.nodejs.org/job/node-compile-windows/23609/label=win-vs2017-x86/console | https://ci.nodejs.org/job/node-compile-windows/23609/label=win-vs2017-x86/console |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 17, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-455045809 |
| https://ci.nodejs.org/job/node-test-pull-request/20176/ | https://ci.nodejs.org/job/node-test-pull-request/20176/ |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Jan 17, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-455180273 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Mar 1, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-468763430 |
| node/deps/uv/src/win/process-stdio.c | https://github.com/nodejs/node/blob/0109e121d3a2f87c4bad75ac05436b56c9fd3407/deps/uv/src/win/process-stdio.c#L408-L418 |
| 0109e12 | https://github.com/nodejs/node/commit/0109e121d3a2f87c4bad75ac05436b56c9fd3407 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Mar 1, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-468764944 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 1, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-468774273 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
| Mar 4, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-469173273 |
| it is possible | https://stackoverflow.com/a/5725609/2790567 |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
|
| https://github.com/koh110 |
| child_process: fire close event from stdio | https://github.com/nodejs/node/pull/22892/commits/6fe220ad2f89fb6305b0abce9ce19bc6a09f118b |
| 6fe220a | https://github.com/nodejs/node/pull/22892/commits/6fe220ad2f89fb6305b0abce9ce19bc6a09f118b |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| force-pushed | https://github.com/nodejs/node/compare/f8f1d101247023f3b7a0f354a698149d9789bb46..6fe220ad2f89fb6305b0abce9ce19bc6a09f118b |
| f8f1d10 | https://github.com/nodejs/node/commit/f8f1d101247023f3b7a0f354a698149d9789bb46 |
| 6fe220a | https://github.com/nodejs/node/commit/6fe220ad2f89fb6305b0abce9ce19bc6a09f118b |
|
Compare
| https://github.com/nodejs/node/compare/f8f1d101247023f3b7a0f354a698149d9789bb46..6fe220ad2f89fb6305b0abce9ce19bc6a09f118b |
| March 7, 2019 15:06 | https://github.com/nodejs/node/pull/22892#event-2187490129 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| Mar 7, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-470571179 |
| @Trott | https://github.com/Trott |
| @bzoz | https://github.com/bzoz |
| This commit | https://github.com/nodejs/node/commit/b1f82e4342f8a630b1ef83cd33781a725428f569 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 7, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-470572628 |
| https://ci.nodejs.org/job/node-test-pull-request/21302/ | https://ci.nodejs.org/job/node-test-pull-request/21302/ |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 7, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-470589122 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Trott | https://github.com/Trott |
| stale review | https://github.com/nodejs/node/pull/22892#pullrequestreview-178067691 |
| March 7, 2019 16:37 | https://github.com/nodejs/node/pull/22892#event-2187781765 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 7, 2019 | https://github.com/nodejs/node/pull/22892#issuecomment-470600616 |
| 1133e0b | https://github.com/nodejs/node/commit/1133e0bf8b6f63a569b0788dde82f62bc08534ac |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 7, 2019 | https://github.com/nodejs/node/pull/22892#event-2187794686 |
| addaleax | https://github.com/addaleax |
|
Mar 7, 2019
| https://github.com/nodejs/node/pull/22892#ref-commit-1133e0b |
|
| https://github.com/koh110 |
|
| https://github.com/addaleax |
| child_process: fire close event from stdio | https://github.com/nodejs/node/commit/1133e0bf8b6f63a569b0788dde82f62bc08534ac |
| 1133e0b | https://github.com/nodejs/node/commit/1133e0bf8b6f63a569b0788dde82f62bc08534ac |
| #22892 | https://github.com/nodejs/node/pull/22892 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
| March 12, 2019 10:27 | https://github.com/nodejs/node/pull/22892#event-2196660066 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
|
Mar 12, 2019
| https://github.com/nodejs/node/pull/22892#ref-pullrequest-419914512 |
|
doc: add Note of options.stdio into child_process
#26604
| https://github.com/nodejs/node/pull/26604 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 12, 2019
| https://github.com/nodejs/node/pull/22892#ref-commit-8e94cb2 |
|
| https://github.com/koh110 |
|
| https://github.com/BridgeAR |
| child_process: fire close event from stdio | https://github.com/BridgeAR/node/commit/8e94cb2c9c696e8b5df5a6d76b45c68c9cb16f34 |
| 8e94cb2 | https://github.com/BridgeAR/node/commit/8e94cb2c9c696e8b5df5a6d76b45c68c9cb16f34 |
| nodejs#22892 | https://github.com/nodejs/node/pull/22892 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 13, 2019
| https://github.com/nodejs/node/pull/22892#ref-pullrequest-420740761 |
|
2019-03-14, Version 11.12.0 (Current)
#26644
| https://github.com/nodejs/node/pull/26644 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/22892#ref-commit-8c864de |
|
| https://github.com/koh110 |
|
| https://github.com/BridgeAR |
| child_process: fire close event from stdio | https://github.com/nodejs/node/commit/8c864deaa4c41052f7d45c6ab01a753fcc35bc85 |
| 8c864de | https://github.com/nodejs/node/commit/8c864deaa4c41052f7d45c6ab01a753fcc35bc85 |
| #22892 | https://github.com/nodejs/node/pull/22892 |
| danbev | https://github.com/danbev |
|
Mar 19, 2019
| https://github.com/nodejs/node/pull/22892#ref-commit-e08ac04 |
|
| https://github.com/koh110 |
|
| https://github.com/danbev |
| doc: add Note of options.stdio into child_process | https://github.com/nodejs/node/commit/e08ac04a1a6bcfa792c2a164c753f4fb16fa09b8 |
| e08ac04 | https://github.com/nodejs/node/commit/e08ac04a1a6bcfa792c2a164c753f4fb16fa09b8 |
| #26604 | https://github.com/nodejs/node/pull/26604 |
| #22892 (comment) | https://github.com/nodejs/node/pull/22892#issuecomment-469173273 |
| targos | https://github.com/targos |
|
Mar 27, 2019
| https://github.com/nodejs/node/pull/22892#ref-commit-3fa878b |
|
| https://github.com/koh110 |
|
| https://github.com/targos |
| doc: add Note of options.stdio into child_process | https://github.com/targos/node/commit/3fa878b65ec0e10d8c72232e299256af54b0c6a0 |
| 3fa878b | https://github.com/targos/node/commit/3fa878b65ec0e10d8c72232e299256af54b0c6a0 |
| nodejs#26604 | https://github.com/nodejs/node/pull/26604 |
| nodejs#22892 (comment) | https://github.com/nodejs/node/pull/22892#issuecomment-469173273 |
| targos | https://github.com/targos |
|
Mar 27, 2019
| https://github.com/nodejs/node/pull/22892#ref-commit-148c2ca |
|
| https://github.com/koh110 |
|
| https://github.com/targos |
| doc: add Note of options.stdio into child_process | https://github.com/nodejs/node/commit/148c2ca33d96e4a1dd599e85cb9f2b2ab8a1e1f9 |
| 148c2ca | https://github.com/nodejs/node/commit/148c2ca33d96e4a1dd599e85cb9f2b2ab8a1e1f9 |
| #26604 | https://github.com/nodejs/node/pull/26604 |
| #22892 (comment) | https://github.com/nodejs/node/pull/22892#issuecomment-469173273 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 17, 2019
| https://github.com/nodejs/node/pull/22892#ref-commit-bc7449c |
|
| https://github.com/koh110 |
|
| https://github.com/BethGriggs |
| doc: add Note of options.stdio into child_process | https://github.com/nodejs/node/commit/bc7449c9e05f2e7c4e69a4a91fe448d714b11518 |
| bc7449c | https://github.com/nodejs/node/commit/bc7449c9e05f2e7c4e69a4a91fe448d714b11518 |
| #26604 | https://github.com/nodejs/node/pull/26604 |
| #22892 (comment) | https://github.com/nodejs/node/pull/22892#issuecomment-469173273 |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/22892#ref-commit-09f162b |
|
| https://github.com/koh110 |
|
| https://github.com/MylesBorins |
| doc: add Note of options.stdio into child_process | https://github.com/nodejs/node/commit/09f162b18f972126553ae3e3da532632e1bdf34f |
| 09f162b | https://github.com/nodejs/node/commit/09f162b18f972126553ae3e3da532632e1bdf34f |
| #26604 | https://github.com/nodejs/node/pull/26604 |
| #22892 (comment) | https://github.com/nodejs/node/pull/22892#issuecomment-469173273 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22892 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22892/files/294fb6dad61cf310ecf0a713a370acba83d79ea2 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/22892/files/294fb6dad61cf310ecf0a713a370acba83d79ea2 |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Please reload this page | https://github.com/nodejs/node/pull/22892 |
|
| https://github.com/koh110 |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/bzoz |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |