René's URL Explorer Experiment


Title: tools, test: forbid string literal as third argument for assert.strictEqual() and friends by Trott · Pull Request #22849 · nodejs/node · GitHub

Open Graph Title: tools, test: forbid string literal as third argument for assert.strictEqual() and friends by Trott · Pull Request #22849 · nodejs/node

X Title: tools, test: forbid string literal as third argument for assert.strictEqual() and friends by Trott · Pull Request #22849 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: String literals provided as the third argument to assert.strictEqual() or assert.deepStrictEqual() will mask the values that are causing issues. Use a lint rule to prevent such usage. @nodejs/testi...

X Description: String literals provided as the third argument to assert.strictEqual() or assert.deepStrictEqual() will mask the values that are causing issues. Use a lint rule to prevent such usage. @nodejs/testi...

Opengraph URL: https://github.com/nodejs/node/pull/22849

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f4f9dba7-6743-2952-aa6a-7cf02ce2492c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB530:1BDEB3:11733D7:168A9B9:6990CE23
html-safe-nonce2e14dd7e3768e0e09e4304be9cf195a124aaa6152da146c46945f9251cd58fe9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTMwOjFCREVCMzoxMTczM0Q3OjE2OEE5Qjk6Njk5MENFMjMiLCJ2aXNpdG9yX2lkIjoiMTI2NjI1OTAwMTc2MDMzNzQ0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc7d61b288aa7e7b4938f807a38672269caae940ab1853be36a4954208ae426ea
hovercard-subject-tagpull_request:215425677
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22849/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/64e729a3aa577496b3b133eacbc066f2b03f3f479ca63c71f81fbac2b19d5e2e/nodejs/node/pull/22849
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/64e729a3aa577496b3b133eacbc066f2b03f3f479ca63c71f81fbac2b19d5e2e/nodejs/node/pull/22849
og:image:altString literals provided as the third argument to assert.strictEqual() or assert.deepStrictEqual() will mask the values that are causing issues. Use a lint rule to prevent such usage. @nodejs/testi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22849#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22849
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22849
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22849
Reloadhttps://github.com/nodejs/node/pull/22849
Reloadhttps://github.com/nodejs/node/pull/22849
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22849
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:strictequal-literalhttps://github.com/Trott/io.js/tree/strictequal-literal
Conversationhttps://github.com/nodejs/node/pull/22849
Commits12 (12)https://github.com/nodejs/node/pull/22849/commits
Checkshttps://github.com/nodejs/node/pull/22849/checks
Files changedhttps://github.com/nodejs/node/pull/22849/files
tools, test: forbid string literal as third argument for assert.strictEqual() and friendshttps://github.com/nodejs/node/pull/22849#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:strictequal-literalhttps://github.com/Trott/io.js/tree/strictequal-literal
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 13, 2018https://github.com/nodejs/node/pull/22849#issue-360078506
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22849
Trotthttps://github.com/Trott
September 13, 2018 14:00https://github.com/nodejs/node/pull/22849#commits-pushed-abcaf56
https://github.com/Trott
test: remove string literal message from assertionhttps://github.com/nodejs/node/pull/22849/commits/abcaf568ce36bef29fad99c009ccfc5c98412e72
abcaf56https://github.com/nodejs/node/pull/22849/commits/abcaf568ce36bef29fad99c009ccfc5c98412e72
https://github.com/Trott
test: remove string literal message in assertionshttps://github.com/nodejs/node/pull/22849/commits/486f6e86d6d191a0a67db8ac344cf188e51ad865
486f6e8https://github.com/nodejs/node/pull/22849/commits/486f6e86d6d191a0a67db8ac344cf188e51ad865
https://github.com/Trott
test: improve assertion in test-inspector.jshttps://github.com/nodejs/node/pull/22849/commits/890c455a686e59ba3e3b938dac7f9455b86f8e03
890c455https://github.com/nodejs/node/pull/22849/commits/890c455a686e59ba3e3b938dac7f9455b86f8e03
https://github.com/Trott
test: simplify assertion in http2 testshttps://github.com/nodejs/node/pull/22849/commits/d65e189c7994c65bfff4a8e59102d0e88242222b
d65e189https://github.com/nodejs/node/pull/22849/commits/d65e189c7994c65bfff4a8e59102d0e88242222b
https://github.com/Trott
test: refactor flag checkhttps://github.com/nodejs/node/pull/22849/commits/b23cb6c57c5439ba8784d09d6567174f152bac48
b23cb6chttps://github.com/nodejs/node/pull/22849/commits/b23cb6c57c5439ba8784d09d6567174f152bac48
https://github.com/Trott
test: remove string literal from assertionhttps://github.com/nodejs/node/pull/22849/commits/36769bec8cb797ea17e6c1746bcae803fa2b343b
36769behttps://github.com/nodejs/node/pull/22849/commits/36769bec8cb797ea17e6c1746bcae803fa2b343b
https://github.com/Trott
test: remove string literal message from assertionhttps://github.com/nodejs/node/pull/22849/commits/26f2e991ada2ff76e1a18d3fd96d109b5eeed2b9
26f2e99https://github.com/nodejs/node/pull/22849/commits/26f2e991ada2ff76e1a18d3fd96d109b5eeed2b9
https://github.com/Trott
test: remove string literal arg from assertionhttps://github.com/nodejs/node/pull/22849/commits/798a6dd7e338c264d57649dbd4b04710d74a49ff
798a6ddhttps://github.com/nodejs/node/pull/22849/commits/798a6dd7e338c264d57649dbd4b04710d74a49ff
https://github.com/Trott
test: remove string literal from assertionhttps://github.com/nodejs/node/pull/22849/commits/af1f7c762af2b30893295565d1aa203dfd65de67
af1f7c7https://github.com/nodejs/node/pull/22849/commits/af1f7c762af2b30893295565d1aa203dfd65de67
https://github.com/Trott
test: remove string literal from assertionhttps://github.com/nodejs/node/pull/22849/commits/8572e6e5306b5cb4ceb60f0ccb45b6640520fb53
8572e6ehttps://github.com/nodejs/node/pull/22849/commits/8572e6e5306b5cb4ceb60f0ccb45b6640520fb53
https://github.com/Trott
test: prepare test-assert for strictEqual lintinghttps://github.com/nodejs/node/pull/22849/commits/4b9142cc9e36af9413010a82804113fa38075cf5
4b9142chttps://github.com/nodejs/node/pull/22849/commits/4b9142cc9e36af9413010a82804113fa38075cf5
https://github.com/Trott
tools: prevent string literals in some assertionshttps://github.com/nodejs/node/pull/22849/commits/51cd1ea4788ef8f0d4b555ce6664971a6521b978
51cd1eahttps://github.com/nodejs/node/pull/22849/commits/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 13, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421163867
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/885/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/885/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Sep 13, 2018https://github.com/nodejs/node/pull/22849#event-1844752380
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 13, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421164130
https://ci.nodejs.org/job/node-test-pull-request/17177/https://ci.nodejs.org/job/node-test-pull-request/17177/
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/not-an-aardvark
not-an-aardvarkhttps://github.com/not-an-aardvark
Sep 13, 2018 https://github.com/nodejs/node/pull/22849#pullrequestreview-155286326
View reviewed changes https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 13, 2018https://github.com/nodejs/node/pull/22849#event-1844760209
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 13, 2018 https://github.com/nodejs/node/pull/22849#pullrequestreview-155287105
View reviewed changes https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/22849#pullrequestreview-155287105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 14, 2018 https://github.com/nodejs/node/pull/22849#pullrequestreview-155314851
View reviewed changes https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
mscdexhttps://github.com/mscdex
https://github.com/nodejs/node/pull/22849#pullrequestreview-155314851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 14, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421230548
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421249305
@Trotthttps://github.com/Trott
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2018 https://github.com/nodejs/node/pull/22849#pullrequestreview-155370816
View reviewed changes https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/22849#pullrequestreview-155370816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 14, 2018 https://github.com/nodejs/node/pull/22849#pullrequestreview-155562091
View reviewed changes https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 14, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421406806
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 14, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421452248
@Trotthttps://github.com/Trott
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 14, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421452808
Please reload this pagehttps://github.com/nodejs/node/pull/22849
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 14, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421457539
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
stale reviewhttps://github.com/nodejs/node/pull/22849#pullrequestreview-155287105
September 14, 2018 19:14https://github.com/nodejs/node/pull/22849#event-1846847344
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 14, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421460374
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/refack
refackhttps://github.com/refack
Sep 14, 2018https://github.com/nodejs/node/pull/22849#issuecomment-421466266
Please reload this pagehttps://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-a15bfda
https://github.com/Trott
https://github.com/targos
test: remove string literal message from assertionhttps://github.com/nodejs/node/commit/a15bfdad789246e479487857604a514b8a22745d
a15bfdahttps://github.com/nodejs/node/commit/a15bfdad789246e479487857604a514b8a22745d
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-b301a7b
https://github.com/Trott
https://github.com/targos
test: remove string literal message in assertionshttps://github.com/nodejs/node/commit/b301a7b7eccf9f51611a5e80cd61c0bda0e20a7b
b301a7bhttps://github.com/nodejs/node/commit/b301a7b7eccf9f51611a5e80cd61c0bda0e20a7b
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-b31a4d0
https://github.com/Trott
https://github.com/targos
test: improve assertion in test-inspector.jshttps://github.com/nodejs/node/commit/b31a4d08084fc808f55404a5865e1b5977fa2ad2
b31a4d0https://github.com/nodejs/node/commit/b31a4d08084fc808f55404a5865e1b5977fa2ad2
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-e5de225
https://github.com/Trott
https://github.com/targos
test: simplify assertion in http2 testshttps://github.com/nodejs/node/commit/e5de2256803d4343b5d2426d3a9d6d641d424a16
e5de225https://github.com/nodejs/node/commit/e5de2256803d4343b5d2426d3a9d6d641d424a16
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-a5f7f1d
https://github.com/Trott
https://github.com/targos
test: refactor flag checkhttps://github.com/nodejs/node/commit/a5f7f1d98593e5e063f295e37f3324b5c7463168
a5f7f1dhttps://github.com/nodejs/node/commit/a5f7f1d98593e5e063f295e37f3324b5c7463168
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-266f1a9
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/266f1a9cd8d2b9be7a220e59a6811811a03709d7
266f1a9https://github.com/nodejs/node/commit/266f1a9cd8d2b9be7a220e59a6811811a03709d7
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-59b6968
https://github.com/Trott
https://github.com/targos
test: remove string literal message from assertionhttps://github.com/nodejs/node/commit/59b6968fb685af4f40015d7609901c57e5757269
59b6968https://github.com/nodejs/node/commit/59b6968fb685af4f40015d7609901c57e5757269
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-5316334
https://github.com/Trott
https://github.com/targos
test: remove string literal arg from assertionhttps://github.com/nodejs/node/commit/5316334955c64270f705d8a32febb0158aecf167
5316334https://github.com/nodejs/node/commit/5316334955c64270f705d8a32febb0158aecf167
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-5d4cbd7
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/5d4cbd7fa1b6e4e90ab94686f3a64bc378780cfb
5d4cbd7https://github.com/nodejs/node/commit/5d4cbd7fa1b6e4e90ab94686f3a64bc378780cfb
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-5a06326
https://github.com/Trott
https://github.com/targos
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/5a0632666b715ba530e4ebc89dca953711d790b4
5a06326https://github.com/nodejs/node/commit/5a0632666b715ba530e4ebc89dca953711d790b4
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-ff6e4ea
https://github.com/Trott
https://github.com/targos
test: prepare test-assert for strictEqual lintinghttps://github.com/nodejs/node/commit/ff6e4ea4bd4f4a59d9d0bf7702c0e260e03b79c3
ff6e4eahttps://github.com/nodejs/node/commit/ff6e4ea4bd4f4a59d9d0bf7702c0e260e03b79c3
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-8ffcb2d
https://github.com/Trott
https://github.com/targos
tools: prevent string literals in some assertionshttps://github.com/nodejs/node/commit/8ffcb2d2cab59fa8174c52a8914266eee2915362
8ffcb2dhttps://github.com/nodejs/node/commit/8ffcb2d2cab59fa8174c52a8914266eee2915362
#22912https://github.com/nodejs/node/pull/22912
#22849https://github.com/nodejs/node/pull/22849
addaleaxhttps://github.com/addaleax
Sep 22, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-ee31c28
https://github.com/addaleax
test: remove string literals for strictEquals/notStrictEqualshttps://github.com/nodejs/node/commit/ee31c28298ce257847e08b1279909a4a3002866d
ee31c28https://github.com/nodejs/node/commit/ee31c28298ce257847e08b1279909a4a3002866d
#22849https://github.com/nodejs/node/pull/22849
#22891https://github.com/nodejs/node/pull/22891
targoshttps://github.com/targos
Sep 23, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-9de6b26
https://github.com/targos
test: remove string literals for strictEquals/notStrictEqualshttps://github.com/nodejs/node/commit/9de6b26a0c1dae1c77ca88947481f52c354c4d08
9de6b26https://github.com/nodejs/node/commit/9de6b26a0c1dae1c77ca88947481f52c354c4d08
#22849https://github.com/nodejs/node/pull/22849
#22891https://github.com/nodejs/node/pull/22891
MylesBorinshttps://github.com/MylesBorins
Sep 25, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-f2158f3
https://github.com/Trott
https://github.com/MylesBorins
test: improve assertion in test-inspector.jshttps://github.com/nodejs/node/commit/f2158f30fbf0ca63886a0f8c22cbbf1b683035bd
f2158f3https://github.com/nodejs/node/commit/f2158f30fbf0ca63886a0f8c22cbbf1b683035bd
#22888https://github.com/nodejs/node/pull/22888
#22849https://github.com/nodejs/node/pull/22849
MylesBorinshttps://github.com/MylesBorins
Sep 25, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-e9416d4
https://github.com/Trott
https://github.com/MylesBorins
test: simplify assertion in http2 testshttps://github.com/nodejs/node/commit/e9416d4f678ac435f2234d94ede02daace29aa8e
e9416d4https://github.com/nodejs/node/commit/e9416d4f678ac435f2234d94ede02daace29aa8e
#22888https://github.com/nodejs/node/pull/22888
#22849https://github.com/nodejs/node/pull/22849
MylesBorinshttps://github.com/MylesBorins
Sep 25, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-702d67f
https://github.com/Trott
https://github.com/MylesBorins
test: refactor flag checkhttps://github.com/nodejs/node/commit/702d67f4c4e6988250dde078c348fe94a5e33038
702d67fhttps://github.com/nodejs/node/commit/702d67f4c4e6988250dde078c348fe94a5e33038
#22888https://github.com/nodejs/node/pull/22888
#22849https://github.com/nodejs/node/pull/22849
MylesBorinshttps://github.com/MylesBorins
Sep 25, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-976d55f
https://github.com/Trott
https://github.com/MylesBorins
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/976d55f9e358da4e6ed6a6c78fe33da722d0c8e8
976d55fhttps://github.com/nodejs/node/commit/976d55f9e358da4e6ed6a6c78fe33da722d0c8e8
#22888https://github.com/nodejs/node/pull/22888
#22849https://github.com/nodejs/node/pull/22849
MylesBorinshttps://github.com/MylesBorins
Sep 25, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-52b21ca
https://github.com/Trott
https://github.com/MylesBorins
test: remove string literal from assertionhttps://github.com/nodejs/node/commit/52b21caff28a0792051dfa1bc537723f8acc0c95
52b21cahttps://github.com/nodejs/node/commit/52b21caff28a0792051dfa1bc537723f8acc0c95
#22888https://github.com/nodejs/node/pull/22888
#22849https://github.com/nodejs/node/pull/22849
MylesBorinshttps://github.com/MylesBorins
Sep 25, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-8209ccb
https://github.com/Trott
https://github.com/MylesBorins
test: prepare test-assert for strictEqual lintinghttps://github.com/nodejs/node/commit/8209ccb3132051ed2eaa25f010a96ee902396f04
8209ccbhttps://github.com/nodejs/node/commit/8209ccb3132051ed2eaa25f010a96ee902396f04
#22888https://github.com/nodejs/node/pull/22888
#22849https://github.com/nodejs/node/pull/22849
kjinhttps://github.com/kjin
Oct 3, 2018 https://github.com/nodejs/node/pull/22849#ref-commit-83e8649
https://github.com/Trott
https://github.com/kjin
test: simplify assertion in http2 testshttps://github.com/kjin/node/commit/83e8649e75ddda84994d3a448d74ffb1d0d9a044
83e8649https://github.com/kjin/node/commit/83e8649e75ddda84994d3a448d74ffb1d0d9a044
nodejs#22912https://github.com/nodejs/node/pull/22912
nodejs#22849https://github.com/nodejs/node/pull/22849
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 30, 2018 https://github.com/nodejs/node/pull/22849#ref-pullrequest-375564151
v8.13.0 proposal #23974 https://github.com/nodejs/node/pull/23974
https://github.com/beevelop
beevelophttps://github.com/beevelop
Nov 20, 2018 https://github.com/nodejs/node/pull/22849#ref-issue-382804528
2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250 https://github.com/beevelop/docker-android-nodejs/issues/250
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:50https://github.com/nodejs/node/pull/22849#event-5890967818
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 13, 2024 https://github.com/nodejs/node/pull/22849#ref-pullrequest-2645150180
test: ensure that CLI options are alphabetical #55790 https://github.com/nodejs/node/pull/55790
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 24, 2025 https://github.com/nodejs/node/pull/22849#ref-pullrequest-3656403387
test: add lint rule to forbid use of assert.ok(/regex/.test(…)) #60832 https://github.com/nodejs/node/pull/60832
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22849
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/not-an-aardvark
not-an-aardvark https://github.com/not-an-aardvark
https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/22849/files/51cd1ea4788ef8f0d4b555ce6664971a6521b978
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/22849
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com/refack
https://github.com/joaocgreis
https://github.com/targos
https://github.com/mscdex
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/not-an-aardvark
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.