René's URL Explorer Experiment


Title: fs: consistently return symlink type from readdir by ajafff · Pull Request #22808 · nodejs/node · GitHub

Open Graph Title: fs: consistently return symlink type from readdir by ajafff · Pull Request #22808 · nodejs/node

X Title: fs: consistently return symlink type from readdir by ajafff · Pull Request #22808 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use 'lstat' to determine type of directory entry. This is more consistent with the type returned from the readdir binding. Also use 'path.join' over 'path.resolve' because &...

X Description: Use 'lstat' to determine type of directory entry. This is more consistent with the type returned from the readdir binding. Also use 'path.join' over 'path.re...

Opengraph URL: https://github.com/nodejs/node/pull/22808

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e4030cf-5d28-0c12-b309-d57c5f55d483
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCC8:25A6BD:147EE5C:19D117F:69917BFD
html-safe-nonce9b0ce3865d9c68c2d74689ce68d6b7c7095e26dd854cb6f42dcf5fe02ae7f869
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0M4OjI1QTZCRDoxNDdFRTVDOjE5RDExN0Y6Njk5MTdCRkQiLCJ2aXNpdG9yX2lkIjoiODEzOTg2MDM0MDg0ODU1NzA1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac98b60335c37039b1bd94bc51d8419371b18bb6b94431fb9b3d71a01203e52ae0
hovercard-subject-tagpull_request:214639887
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22808/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3b37aad93bab21e5c2101217dc9eca6a909f53a05273d199bb2879d7d5944ab3/nodejs/node/pull/22808
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3b37aad93bab21e5c2101217dc9eca6a909f53a05273d199bb2879d7d5944ab3/nodejs/node/pull/22808
og:image:altUse 'lstat' to determine type of directory entry. This is more consistent with the type returned from the readdir binding. Also use 'path.join' over 'path.resolve' because &...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameajafff
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22808#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22808
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22808
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22808
Reloadhttps://github.com/nodejs/node/pull/22808
Reloadhttps://github.com/nodejs/node/pull/22808
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22808
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ajafffhttps://github.com/ajafff
nodejs:masterhttps://github.com/nodejs/node/tree/master
ajafff:getdirentshttps://github.com/ajafff/node/tree/getdirents
Conversationhttps://github.com/nodejs/node/pull/22808
Commits1 (1)https://github.com/nodejs/node/pull/22808/commits
Checkshttps://github.com/nodejs/node/pull/22808/checks
Files changedhttps://github.com/nodejs/node/pull/22808/files
fs: consistently return symlink type from readdirhttps://github.com/nodejs/node/pull/22808#top
ajafffhttps://github.com/ajafff
nodejs:masterhttps://github.com/nodejs/node/tree/master
ajafff:getdirentshttps://github.com/ajafff/node/tree/getdirents
https://github.com/ajafff
ajafffhttps://github.com/ajafff
Sep 11, 2018https://github.com/nodejs/node/pull/22808#issue-359057037
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Sep 11, 2018https://github.com/nodejs/node/pull/22808#event-1838592180
https://github.com/ajafff
fs: consistently return symlink type from readdirhttps://github.com/nodejs/node/pull/22808/commits/6197ca269bf4436d01f0084df7fd1485d666c83a
6197ca2https://github.com/nodejs/node/pull/22808/commits/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/ajafff
ajafffhttps://github.com/ajafff
force-pushedhttps://github.com/nodejs/node/compare/0a367f70ac162b33c7ab2366c1ab7f324b2edb9e..6197ca269bf4436d01f0084df7fd1485d666c83a
0a367f7https://github.com/nodejs/node/commit/0a367f70ac162b33c7ab2366c1ab7f324b2edb9e
6197ca2https://github.com/nodejs/node/commit/6197ca269bf4436d01f0084df7fd1485d666c83a
Compare https://github.com/nodejs/node/compare/0a367f70ac162b33c7ab2366c1ab7f324b2edb9e..6197ca269bf4436d01f0084df7fd1485d666c83a
September 11, 2018 18:48https://github.com/nodejs/node/pull/22808#event-1839315230
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 19, 2018https://github.com/nodejs/node/pull/22808#issuecomment-422715129
https://ci.nodejs.org/job/node-test-pull-request/17315/https://ci.nodejs.org/job/node-test-pull-request/17315/
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 19, 2018 https://github.com/nodejs/node/pull/22808#pullrequestreview-156915212
View reviewed changes https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 24, 2018 https://github.com/nodejs/node/pull/22808#pullrequestreview-158287414
View reviewed changes https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
benglhttps://github.com/bengl
September 24, 2018 20:45https://github.com/nodejs/node/pull/22808#event-1864145638
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 24, 2018https://github.com/nodejs/node/pull/22808#event-1864146345
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 24, 2018https://github.com/nodejs/node/pull/22808#issuecomment-424119147
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 25, 2018https://github.com/nodejs/node/pull/22808#issuecomment-424171840
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 25, 2018https://github.com/nodejs/node/pull/22808#issuecomment-424179375
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/ajafff
ajafffhttps://github.com/ajafff
Sep 25, 2018https://github.com/nodejs/node/pull/22808#issuecomment-424204293
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/bengl
benglhttps://github.com/bengl
Sep 25, 2018https://github.com/nodejs/node/pull/22808#issuecomment-424214917
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/bengl
benglhttps://github.com/bengl
Sep 25, 2018 https://github.com/nodejs/node/pull/22808#pullrequestreview-158384717
View reviewed changes https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 25, 2018https://github.com/nodejs/node/pull/22808#issuecomment-424262139
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 25, 2018 https://github.com/nodejs/node/pull/22808#pullrequestreview-158514872
View reviewed changes https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 27, 2018 https://github.com/nodejs/node/pull/22808#pullrequestreview-159472637
View reviewed changes https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/22808#pullrequestreview-159472637
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 27, 2018https://github.com/nodejs/node/pull/22808#issuecomment-425112509
https://ci.nodejs.org/job/node-test-pull-request/17471/https://ci.nodejs.org/job/node-test-pull-request/17471/
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 27, 2018https://github.com/nodejs/node/pull/22808#issuecomment-425140063
#23127https://github.com/nodejs/node/issues/23127
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 27, 2018https://github.com/nodejs/node/pull/22808#issuecomment-425217649
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://ci.nodejs.org/job/node-test-pull-request/17473/https://ci.nodejs.org/job/node-test-pull-request/17473/
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 27, 2018https://github.com/nodejs/node/pull/22808#issuecomment-425219245
83864b3https://github.com/nodejs/node/commit/83864b3bb0a18bf37548586c66be95be5843e640
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 27, 2018https://github.com/nodejs/node/pull/22808#event-1871979441
mhdawsonhttps://github.com/mhdawson
Sep 27, 2018 https://github.com/nodejs/node/pull/22808#ref-commit-83864b3
https://github.com/ajafff
https://github.com/mhdawson
fs: consistently return symlink type from readdirhttps://github.com/nodejs/node/commit/83864b3bb0a18bf37548586c66be95be5843e640
83864b3https://github.com/nodejs/node/commit/83864b3bb0a18bf37548586c66be95be5843e640
#22808https://github.com/nodejs/node/pull/22808
targoshttps://github.com/targos
Sep 27, 2018 https://github.com/nodejs/node/pull/22808#ref-commit-58490d5
https://github.com/ajafff
https://github.com/targos
fs: consistently return symlink type from readdirhttps://github.com/nodejs/node/commit/58490d5098475e709730e78ea5a3369c6e9876ad
58490d5https://github.com/nodejs/node/commit/58490d5098475e709730e78ea5a3369c6e9876ad
#22808https://github.com/nodejs/node/pull/22808
targoshttps://github.com/targos
Oct 3, 2018 https://github.com/nodejs/node/pull/22808#ref-commit-bb6530b
https://github.com/ajafff
https://github.com/targos
fs: consistently return symlink type from readdirhttps://github.com/nodejs/node/commit/bb6530b31bfcec75230a7c772e751c4bb904f4eb
bb6530bhttps://github.com/nodejs/node/commit/bb6530b31bfcec75230a7c772e751c4bb904f4eb
#22808https://github.com/nodejs/node/pull/22808
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2018 https://github.com/nodejs/node/pull/22808#ref-pullrequest-367548700
Release proposal: v10.12.0 #23313 https://github.com/nodejs/node/pull/23313
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225 https://github.com/beevelop/docker-nodejs/issues/225
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#239 https://github.com/beevelop/docker-android-nodejs/issues/239
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#226 https://github.com/beevelop/docker-nodejs/issues/226
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#240 https://github.com/beevelop/docker-android-nodejs/issues/240
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#227 https://github.com/beevelop/docker-nodejs/issues/227
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#241 https://github.com/beevelop/docker-android-nodejs/issues/241
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#242 https://github.com/beevelop/docker-android-nodejs/issues/242
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#228 https://github.com/beevelop/docker-nodejs/issues/228
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-android-nodejs#243 https://github.com/beevelop/docker-android-nodejs/issues/243
2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#229 https://github.com/beevelop/docker-nodejs/issues/229
https://github.com/bpasero
bpaserohttps://github.com/bpasero
Aug 10, 2019 https://github.com/nodejs/node/pull/22808#ref-issue-478754553
1.37 Explorer not showing any files or folders microsoft/vscode#78743 https://github.com/microsoft/vscode/issues/78743
bpaserohttps://github.com/bpasero
Sep 10, 2019 https://github.com/nodejs/node/pull/22808#ref-commit-956208b
https://github.com/bpasero
Revert "debt - adopt new fs.readdir with stat info"https://github.com/microsoft/vscode/commit/956208bb05ac9cc75579f6a1c282575351485afa
https://github.com/microsoft/vscode/commit/956208bb05ac9cc75579f6a1c282575351485afa#comments
956208bhttps://github.com/microsoft/vscode/commit/956208bb05ac9cc75579f6a1c282575351485afa
da5fb7dhttps://github.com/microsoft/vscode/commit/da5fb7d5b865aa522abc7e82c10b746834b98639
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22808
https://github.com/bengl
bengl https://github.com/bengl
https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/22808/files/6197ca269bf4436d01f0084df7fd1485d666c83a
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/22808
https://github.com/ajafff
https://github.com/danbev
https://github.com/addaleax
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/bengl
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.