| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1239f5c4-61da-5ff9-9e44-6af2bc53f375 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E292:6E988:D785D0:1112718:69901B95 |
| html-safe-nonce | 0befba0add64d01be7744d80aff64050a80e75cb542a1a0cc89923708852ce1b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjkyOjZFOTg4OkQ3ODVEMDoxMTEyNzE4OjY5OTAxQjk1IiwidmlzaXRvcl9pZCI6IjUxMjE5MDYzNTk0NzkwNDkxMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5cd4b6c8fcfb02d44ff75aa12f352a0bf9f76b8d8a839a5b36f083ffc1975513 |
| hovercard-subject-tag | pull_request:214359682 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22795/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/48fa2bc9e358acad373b13b8eab7f707375a0c677540f06aabf0445fcfc3817b/nodejs/node/pull/22795 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/48fa2bc9e358acad373b13b8eab7f707375a0c677540f06aabf0445fcfc3817b/nodejs/node/pull/22795 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
This adds a n... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafintosh |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22795#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22795 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22795 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22795 |
| Reload | https://github.com/nodejs/node/pull/22795 |
| Reload | https://github.com/nodejs/node/pull/22795 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mafintosh | https://github.com/mafintosh |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mafintosh:auto-destroy-stream | https://github.com/mafintosh/io.js/tree/auto-destroy-stream |
| Conversation | https://github.com/nodejs/node/pull/22795 |
| Commits7 (7) | https://github.com/nodejs/node/pull/22795/commits |
| Checks | https://github.com/nodejs/node/pull/22795/checks |
| Files changed | https://github.com/nodejs/node/pull/22795/files |
| stream: add auto-destroy mode | https://github.com/nodejs/node/pull/22795#top |
| mafintosh | https://github.com/mafintosh |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mafintosh:auto-destroy-stream | https://github.com/mafintosh/io.js/tree/auto-destroy-stream |
|
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#issue-358682458 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-419960464 |
| @mafintosh | https://github.com/mafintosh |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/852/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/852/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#event-1836360519 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
dont-land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#event-1836407528 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-419968089 |
| @mafintosh | https://github.com/mafintosh |
| #20096 | https://github.com/nodejs/node/issues/20096 |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 10, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-153852121 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/22795/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r216383747 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| addaleax | https://github.com/addaleax |
| Sep 11, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r216623915 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 10, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-153852263 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/22795/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r216383858 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Sep 10, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-153855289 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files |
| lib/_stream_readable.js | https://github.com/nodejs/node/pull/22795/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7 |
| mscdex | https://github.com/mscdex |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r216386301 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 10, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-419974326 |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 10, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-153873637 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 11, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-154145722 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/22795/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| addaleax | https://github.com/addaleax |
| Sep 11, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r216623915 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| test/parallel/test-stream-auto-destroy.js | https://github.com/nodejs/node/pull/22795/files#diff-bda8b1beaad53eafcb2f3762df0a21ae0f1ed8059191342a70eb0251269a5a76 |
| addaleax | https://github.com/addaleax |
| Sep 11, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r216624273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 14, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-421414538 |
| @mafintosh | https://github.com/mafintosh |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-422012884 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-422068828 |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Sep 19, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-422829538 |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-157922640 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files |
| lib/internal/http2/compat.js | https://github.com/nodejs/node/pull/22795/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f |
| addaleax | https://github.com/addaleax |
| Sep 22, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r219682424 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Oct 5, 2018
| https://github.com/nodejs/node/pull/22795#ref-issue-365783336 |
|
pipeline does not wait for full stream destruction
#23214
| https://github.com/nodejs/node/issues/23214 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| force-pushed | https://github.com/nodejs/node/compare/bb2cb3c59c45f19a792054aa2fe131e788cf2f2a..387516c8b699a24faf8c26fd942d10110385635a |
| bb2cb3c | https://github.com/nodejs/node/commit/bb2cb3c59c45f19a792054aa2fe131e788cf2f2a |
| 387516c | https://github.com/nodejs/node/commit/387516c8b699a24faf8c26fd942d10110385635a |
|
Compare
| https://github.com/nodejs/node/compare/bb2cb3c59c45f19a792054aa2fe131e788cf2f2a..387516c8b699a24faf8c26fd942d10110385635a |
| October 26, 2018 14:08 | https://github.com/nodejs/node/pull/22795#event-1928938434 |
|
| https://github.com/mafintosh |
| stream: add auto-destroy mode | https://github.com/nodejs/node/pull/22795/commits/ccc94a986729a43cbcfbb64954affd3448d71685 |
| ccc94a9 | https://github.com/nodejs/node/pull/22795/commits/ccc94a986729a43cbcfbb64954affd3448d71685 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| force-pushed | https://github.com/nodejs/node/compare/387516c8b699a24faf8c26fd942d10110385635a..ccc94a986729a43cbcfbb64954affd3448d71685 |
| 387516c | https://github.com/nodejs/node/commit/387516c8b699a24faf8c26fd942d10110385635a |
| ccc94a9 | https://github.com/nodejs/node/commit/ccc94a986729a43cbcfbb64954affd3448d71685 |
|
Compare
| https://github.com/nodejs/node/compare/387516c8b699a24faf8c26fd942d10110385635a..ccc94a986729a43cbcfbb64954affd3448d71685 |
| October 26, 2018 14:13 | https://github.com/nodejs/node/pull/22795#event-1928949623 |
| mafintosh | https://github.com/mafintosh |
| October 26, 2018 16:22 | https://github.com/nodejs/node/pull/22795#commits-pushed-38077e6 |
|
| https://github.com/mafintosh |
| inline duplex autodestroy logic | https://github.com/nodejs/node/pull/22795/commits/38077e66d9229649b6a1873fa6bf27b0f063099b |
| 38077e6 | https://github.com/nodejs/node/pull/22795/commits/38077e66d9229649b6a1873fa6bf27b0f063099b |
|
| https://github.com/mafintosh |
| move errorOrDestroy to destroyImpl | https://github.com/nodejs/node/pull/22795/commits/294e10c0a6594423d11bcd5efb7b30286644607d |
| 294e10c | https://github.com/nodejs/node/pull/22795/commits/294e10c0a6594423d11bcd5efb7b30286644607d |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Oct 26, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-168870979 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files/294e10c0a6594423d11bcd5efb7b30286644607d |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/22795#pullrequestreview-168870979 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| mafintosh | https://github.com/mafintosh |
| October 26, 2018 18:05 | https://github.com/nodejs/node/pull/22795#commits-pushed-a6eb82e |
|
| https://github.com/mafintosh |
| test ordering of events | https://github.com/nodejs/node/pull/22795/commits/a6eb82edc9655b6f3b20e7b580248e30fb44c234 |
| a6eb82e | https://github.com/nodejs/node/pull/22795/commits/a6eb82edc9655b6f3b20e7b580248e30fb44c234 |
|
| https://github.com/mafintosh |
| fix docs | https://github.com/nodejs/node/pull/22795/commits/c40028a7a8c979a54b910b05859d17d8a312e614 |
| c40028a | https://github.com/nodejs/node/pull/22795/commits/c40028a7a8c979a54b910b05859d17d8a312e614 |
|
| https://github.com/mafintosh |
| add to changes: section | https://github.com/nodejs/node/pull/22795/commits/7eb4e6409228cabaf45cbcb103e741fd95d82fd4 |
| 7eb4e64 | https://github.com/nodejs/node/pull/22795/commits/7eb4e6409228cabaf45cbcb103e741fd95d82fd4 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-433869477 |
| @addaleax | https://github.com/addaleax |
| @targos | https://github.com/targos |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-433869776 |
| https://ci.nodejs.org/view/Node.js/job/node-test-pull-request/18202/ | https://ci.nodejs.org/view/Node.js/job/node-test-pull-request/18202/ |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-169251903 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files/7eb4e6409228cabaf45cbcb103e741fd95d82fd4 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/22795#pullrequestreview-169251903 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/22795/files/7eb4e6409228cabaf45cbcb103e741fd95d82fd4#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| mcollina | https://github.com/mcollina |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r228886166 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| addaleax | https://github.com/addaleax |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r228889455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| mafintosh | https://github.com/mafintosh |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/22795#discussion_r228894338 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-433889590 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1604/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1604/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1603/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1603/ |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
|
| https://github.com/mafintosh |
| TDB -> REPLACEME | https://github.com/nodejs/node/pull/22795/commits/713a808bff40699aeb309cae1405f1fdf8eeb784 |
| 713a808 | https://github.com/nodejs/node/pull/22795/commits/713a808bff40699aeb309cae1405f1fdf8eeb784 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-169302965 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files/713a808bff40699aeb309cae1405f1fdf8eeb784 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/22795#pullrequestreview-169442974 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22795/files/713a808bff40699aeb309cae1405f1fdf8eeb784 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/22795#ref-issue-367938540 |
|
fs: read/write streams don't emit close after error
#23338
| https://github.com/nodejs/node/issues/23338 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-434269895 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1606/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1606/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1607/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1607/ |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-434317887 |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| Trott | https://github.com/Trott |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/22795#ref-commit-f24b070 |
|
| https://github.com/mafintosh |
| stream: add auto-destroy mode | https://github.com/Trott/io.js/commit/f24b070cb7fb04df6249fab5264df2146e2b6cac |
| f24b070 | https://github.com/Trott/io.js/commit/f24b070cb7fb04df6249fab5264df2146e2b6cac |
| nodejs#22795 | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/22795#issuecomment-434319401 |
| f24b070 | https://github.com/nodejs/node/commit/f24b070cb7fb04df6249fab5264df2146e2b6cac |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/22795#event-1935193850 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| October 30, 2018 14:19 | https://github.com/nodejs/node/pull/22795#event-1935194105 |
| targos | https://github.com/targos |
|
Nov 2, 2018
| https://github.com/nodejs/node/pull/22795#ref-commit-d6bcf8b |
|
| https://github.com/mafintosh |
|
| https://github.com/targos |
| stream: add auto-destroy mode | https://github.com/nodejs/node/commit/d6bcf8b98b7e8ddd6c5467f56542ce4c242ae915 |
| d6bcf8b | https://github.com/nodejs/node/commit/d6bcf8b98b7e8ddd6c5467f56542ce4c242ae915 |
| #22795 | https://github.com/nodejs/node/pull/22795 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Nov 6, 2018
| https://github.com/nodejs/node/pull/22795#ref-pullrequest-377812281 |
|
test: add test for autoDestroy in stream
#24127
| https://github.com/nodejs/node/pull/24127 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 14, 2018
| https://github.com/nodejs/node/pull/22795#ref-pullrequest-380492752 |
|
Release proposal: v11.2
#24350
| https://github.com/nodejs/node/pull/24350 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#232
| https://github.com/beevelop/docker-nodejs/issues/232 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#249
| https://github.com/beevelop/docker-android-nodejs/issues/249 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#233
| https://github.com/beevelop/docker-nodejs/issues/233 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#234
| https://github.com/beevelop/docker-nodejs/issues/234 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#235
| https://github.com/beevelop/docker-nodejs/issues/235 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#236
| https://github.com/beevelop/docker-nodejs/issues/236 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 8, 2019
| https://github.com/nodejs/node/pull/22795#ref-commit-a1b253a |
|
| https://github.com/mafintosh |
|
| https://github.com/BethGriggs |
| stream: add auto-destroy mode | https://github.com/nodejs/node/commit/a1b253a4163f55ead1d97117cd26117ddc609fb7 |
| a1b253a | https://github.com/nodejs/node/commit/a1b253a4163f55ead1d97117cd26117ddc609fb7 |
| #22795 | https://github.com/nodejs/node/pull/22795 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
May 1, 2019
| https://github.com/nodejs/node/pull/22795#ref-pullrequest-439147711 |
|
v10.16.0 proposal
#27514
| https://github.com/nodejs/node/pull/27514 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#315
| https://github.com/beevelop/docker-android-nodejs/issues/315 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#316
| https://github.com/beevelop/docker-android-nodejs/issues/316 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#317
| https://github.com/beevelop/docker-android-nodejs/issues/317 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#318
| https://github.com/beevelop/docker-android-nodejs/issues/318 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#319
| https://github.com/beevelop/docker-android-nodejs/issues/319 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22795 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/22795/files/7eb4e6409228cabaf45cbcb103e741fd95d82fd4 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22795/files/7c033b1dfe04919f473210949238f66a6754ce31 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22795/files/713a808bff40699aeb309cae1405f1fdf8eeb784 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/22795/files/7c033b1dfe04919f473210949238f66a6754ce31 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/22795/files/7c033b1dfe04919f473210949238f66a6754ce31 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/22795/files/713a808bff40699aeb309cae1405f1fdf8eeb784 |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/22795 |
|
| https://github.com/mafintosh |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/targos |
|
| https://github.com/addaleax |
|
| https://github.com/Fishrock123 |
|
| https://github.com/tniessen |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |