René's URL Explorer Experiment


Title: worker: correct (de)initialization order by addaleax · Pull Request #22773 · nodejs/node · GitHub

Open Graph Title: worker: correct (de)initialization order by addaleax · Pull Request #22773 · nodejs/node

X Title: worker: correct (de)initialization order by addaleax · Pull Request #22773 · nodejs/node

Description: Initialize thread_exit_async_ only once the thread has been started. This is done since it is only triggered from the thread when it is exiting. Move the final uv_run to the Worker destructor. This makes sure that it is always run, regardless of whether the thread is actually started or not. Always dispose the Isolate before cleaning up the libuv event loop. This now matches the reverse order of initialization. Fixes: #22736 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines /cc @nodejs/workers

Open Graph Description: Initialize thread_exit_async_ only once the thread has been started. This is done since it is only triggered from the thread when it is exiting. Move the final uv_run to the Worker destructor. This...

X Description: Initialize thread_exit_async_ only once the thread has been started. This is done since it is only triggered from the thread when it is exiting. Move the final uv_run to the Worker destructor. This...

Opengraph URL: https://github.com/nodejs/node/pull/22773

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:36edb029-4701-7fe2-8f81-7f17de73f387
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE642:22F696:529FE21:6EBBEBF:6995B020
html-safe-nonce1448dd8e3338f67ab36894f44242a3b4ea516f4de078d2160e4133c642bcf906
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjQyOjIyRjY5Njo1MjlGRTIxOjZFQkJFQkY6Njk5NUIwMjAiLCJ2aXNpdG9yX2lkIjoiNjA0NDAwMTk5Nzg4MzI4OTYzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac365fa1eb288f018cc819de63dc6fa3669b5d2e2be6ae369541413b7eb2d7489e
hovercard-subject-tagpull_request:214145982
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
twitter:imagehttps://avatars.githubusercontent.com/u/899444?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/899444?s=400&v=4
og:image:altInitialize thread_exit_async_ only once the thread has been started. This is done since it is only triggered from the thread when it is exiting. Move the final uv_run to the Worker destructor. This...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4bd759bc5f83244e2a0de29b937365905c0fefd238b6f077c24a49830375b4df
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseca709e595006be878b5ff15e639197cf6e6c8efb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22773%2Ffiles%2Febb15f6c5493fc2a5546f2449f31f528a02051a1
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22773%2Ffiles%2Febb15f6c5493fc2a5546f2449f31f528a02051a1
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
Reloadhttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
Reloadhttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.8k https://github.com/nodejs/node/issues
Pull requests 717 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-fix-uninitializedhttps://github.com/addaleax/node/tree/worker-fix-uninitialized
Conversation 6 https://github.com/nodejs/node/pull/22773
Commits 1 https://github.com/nodejs/node/pull/22773/commits
Checks 0 https://github.com/nodejs/node/pull/22773/checks
Files changed https://github.com/nodejs/node/pull/22773/files
Please reload this pagehttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
worker: correct (de)initialization order https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#top
Show all changes 1 commit https://github.com/nodejs/node/pull/22773/files
ebb15f6 worker: correct (de)initialization order addaleax Sep 9, 2018 https://github.com/nodejs/node/pull/22773/commits/ebb15f6c5493fc2a5546f2449f31f528a02051a1
Clear filters https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
Please reload this pagehttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
Please reload this pagehttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
node_worker.cc https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
test-worker-invalid-workerdata.js https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-248f5b0151f79d96ab154f37b10e30637ad8de544a97c78880ae2b4bccefd9eb
src/node_worker.cchttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
View file https://github.com/addaleax/node/blob/ebb15f6c5493fc2a5546f2449f31f528a02051a1/src/node_worker.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/22773/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
refackhttps://github.com/refack
Sep 9, 2018https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#r216160715
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
addaleaxhttps://github.com/addaleax
Sep 12, 2018https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#r216987274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
test/parallel/test-worker-invalid-workerdata.jshttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-248f5b0151f79d96ab154f37b10e30637ad8de544a97c78880ae2b4bccefd9eb
View file https://github.com/addaleax/node/blob/ebb15f6c5493fc2a5546f2449f31f528a02051a1/test/parallel/test-worker-invalid-workerdata.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/22773/files/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.