René's URL Explorer Experiment


Title: worker: correct (de)initialization order by addaleax · Pull Request #22773 · nodejs/node · GitHub

Open Graph Title: worker: correct (de)initialization order by addaleax · Pull Request #22773 · nodejs/node

X Title: worker: correct (de)initialization order by addaleax · Pull Request #22773 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Initialize thread_exit_async_ only once the thread has been started. This is done since it is only triggered from the thread when it is exiting. Move the final uv_run to the Worker destructor. This...

X Description: Initialize thread_exit_async_ only once the thread has been started. This is done since it is only triggered from the thread when it is exiting. Move the final uv_run to the Worker destructor. This...

Opengraph URL: https://github.com/nodejs/node/pull/22773

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c2cae73a-d260-ee44-458e-7056bb0f1c7f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFF8:178552:B5727E:E8190B:69917D85
html-safe-nonce4db60da73e19eaa3385d32d29cf0a9d12ad17c69c18a62e70fc879af11a8cf69
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkY4OjE3ODU1MjpCNTcyN0U6RTgxOTBCOjY5OTE3RDg1IiwidmlzaXRvcl9pZCI6Ijc0NDM5MTc5MzE5OTI0MTU2MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccaeb35fa76da0b0208c7f930b3209542e06d2f7abe9c267a7d6e1fc23442a9e3
hovercard-subject-tagpull_request:214145982
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22773/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fc41ee900cd8c2163b08deadb39d6ec3fccaabf3686efbdb0680dd55ca438216/nodejs/node/pull/22773
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fc41ee900cd8c2163b08deadb39d6ec3fccaabf3686efbdb0680dd55ca438216/nodejs/node/pull/22773
og:image:altInitialize thread_exit_async_ only once the thread has been started. This is done since it is only triggered from the thread when it is exiting. Move the final uv_run to the Worker destructor. This...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22773#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22773
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22773
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22773
Reloadhttps://github.com/nodejs/node/pull/22773
Reloadhttps://github.com/nodejs/node/pull/22773
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22773
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-fix-uninitializedhttps://github.com/addaleax/node/tree/worker-fix-uninitialized
Conversationhttps://github.com/nodejs/node/pull/22773
Commits1 (1)https://github.com/nodejs/node/pull/22773/commits
Checkshttps://github.com/nodejs/node/pull/22773/checks
Files changedhttps://github.com/nodejs/node/pull/22773/files
worker: correct (de)initialization orderhttps://github.com/nodejs/node/pull/22773#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-fix-uninitializedhttps://github.com/addaleax/node/tree/worker-fix-uninitialized
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2018https://github.com/nodejs/node/pull/22773#issue-358379575
#22736https://github.com/nodejs/node/issues/22736
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22773
https://github.com/addaleax
worker: correct (de)initialization orderhttps://github.com/nodejs/node/pull/22773/commits/ebb15f6c5493fc2a5546f2449f31f528a02051a1
ebb15f6https://github.com/nodejs/node/pull/22773/commits/ebb15f6c5493fc2a5546f2449f31f528a02051a1
nodejs#22736https://github.com/nodejs/node/issues/22736
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Sep 9, 2018https://github.com/nodejs/node/pull/22773#event-1834586089
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Sep 9, 2018https://github.com/nodejs/node/pull/22773#event-1834586118
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 9, 2018https://github.com/nodejs/node/pull/22773#issuecomment-419716900
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/841/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/841/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22773
https://github.com/refack
refackhttps://github.com/refack
Sep 9, 2018 https://github.com/nodejs/node/pull/22773#pullrequestreview-153584617
View reviewed changes https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
src/node_worker.cchttps://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62
refackhttps://github.com/refack
Sep 9, 2018https://github.com/nodejs/node/pull/22773#discussion_r216160715
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22773
addaleaxhttps://github.com/addaleax
Sep 12, 2018https://github.com/nodejs/node/pull/22773#discussion_r216987274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22773
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 10, 2018 https://github.com/nodejs/node/pull/22773#pullrequestreview-153862873
View reviewed changes https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 12, 2018https://github.com/nodejs/node/pull/22773#issuecomment-420609614
https://ci.nodejs.org/job/node-test-pull-request/17135/https://ci.nodejs.org/job/node-test-pull-request/17135/
Please reload this pagehttps://github.com/nodejs/node/pull/22773
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 13, 2018https://github.com/nodejs/node/pull/22773#issuecomment-420934529
https://ci.nodejs.org/job/node-test-pull-request/17167/https://ci.nodejs.org/job/node-test-pull-request/17167/
Please reload this pagehttps://github.com/nodejs/node/pull/22773
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 13, 2018https://github.com/nodejs/node/pull/22773#event-1843075105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 14, 2018https://github.com/nodejs/node/pull/22773#issuecomment-421420358
df7ebfahttps://github.com/nodejs/node/commit/df7ebfab4e9575eeeb133826c54907053115a0b7
Please reload this pagehttps://github.com/nodejs/node/pull/22773
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 14, 2018https://github.com/nodejs/node/pull/22773#event-1846586239
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
September 14, 2018 16:56https://github.com/nodejs/node/pull/22773#event-1846586368
addaleaxhttps://github.com/addaleax
Sep 14, 2018 https://github.com/nodejs/node/pull/22773#ref-commit-df7ebfa
https://github.com/addaleax
worker: correct (de)initialization orderhttps://github.com/nodejs/node/commit/df7ebfab4e9575eeeb133826c54907053115a0b7
df7ebfahttps://github.com/nodejs/node/commit/df7ebfab4e9575eeeb133826c54907053115a0b7
#22736https://github.com/nodejs/node/issues/22736
#22773https://github.com/nodejs/node/pull/22773
targoshttps://github.com/targos
Sep 15, 2018 https://github.com/nodejs/node/pull/22773#ref-commit-ec6afb9
https://github.com/addaleax
https://github.com/targos
worker: correct (de)initialization orderhttps://github.com/nodejs/node/commit/ec6afb94e43533b5917ca48197f923fbde866994
ec6afb9https://github.com/nodejs/node/commit/ec6afb94e43533b5917ca48197f923fbde866994
#22736https://github.com/nodejs/node/issues/22736
#22773https://github.com/nodejs/node/pull/22773
https://github.com/targos
targoshttps://github.com/targos
Sep 18, 2018 https://github.com/nodejs/node/pull/22773#ref-pullrequest-361312666
Release proposal: v10.11.0 #22932 https://github.com/nodejs/node/pull/22932
targoshttps://github.com/targos
Sep 19, 2018 https://github.com/nodejs/node/pull/22773#ref-commit-217fb2e
https://github.com/addaleax
https://github.com/targos
worker: correct (de)initialization orderhttps://github.com/nodejs/node/commit/217fb2ed5576e1ca78d9035a95c28a0aab31d9ec
217fb2ehttps://github.com/nodejs/node/commit/217fb2ed5576e1ca78d9035a95c28a0aab31d9ec
#22736https://github.com/nodejs/node/issues/22736
#22773https://github.com/nodejs/node/pull/22773
targoshttps://github.com/targos
Sep 20, 2018 https://github.com/nodejs/node/pull/22773#ref-commit-a96a846
https://github.com/addaleax
https://github.com/targos
worker: correct (de)initialization orderhttps://github.com/nodejs/node/commit/a96a8468d6105fcdc4d79ef18dc14ecb522049d1
a96a846https://github.com/nodejs/node/commit/a96a8468d6105fcdc4d79ef18dc14ecb522049d1
#22736https://github.com/nodejs/node/issues/22736
#22773https://github.com/nodejs/node/pull/22773
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22773
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/22773/files/ebb15f6c5493fc2a5546f2449f31f528a02051a1
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Worker threads: the process keeps living on exception https://github.com/nodejs/node/issues/22736
Please reload this pagehttps://github.com/nodejs/node/pull/22773
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.