René's URL Explorer Experiment


Title: Revert "build: enabling pgo at configure" by addaleax · Pull Request #22772 · nodejs/node · GitHub

Open Graph Title: Revert "build: enabling pgo at configure" by addaleax · Pull Request #22772 · nodejs/node

X Title: Revert "build: enabling pgo at configure" by addaleax · Pull Request #22772 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 9be1555. This commit broke native addon compilation by adding variables to common.gypi that are not available to builds outside of Node.js core. Checklist make -j4 test (UNI...

X Description: This reverts commit 9be1555. This commit broke native addon compilation by adding variables to common.gypi that are not available to builds outside of Node.js core. Checklist make -j4 test (UNI...

Opengraph URL: https://github.com/nodejs/node/pull/22772

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a3f2c10e-43a2-e863-c4ac-3799aae6c493
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEA2:629BA:2698F0A:3147B33:69911C22
html-safe-nonce44bfc308778624626b91e898880a784edeb0189acb9d537d95de30683cd3cc36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUEyOjYyOUJBOjI2OThGMEE6MzE0N0IzMzo2OTkxMUMyMiIsInZpc2l0b3JfaWQiOiI4NDg5NzcyMTcyNTYyMjA5ODI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5ccf92ee8d231a0da84489438169d330db1d81ffaadda02a651f92213c821016
hovercard-subject-tagpull_request:214143794
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22772/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aa36dbf84809c83515c278b236527ee7f2001569a4fb5f3103c955c439550a7d/nodejs/node/pull/22772
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa36dbf84809c83515c278b236527ee7f2001569a4fb5f3103c955c439550a7d/nodejs/node/pull/22772
og:image:altThis reverts commit 9be1555. This commit broke native addon compilation by adding variables to common.gypi that are not available to builds outside of Node.js core. Checklist make -j4 test (UNI...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22772#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22772
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22772
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22772
Reloadhttps://github.com/nodejs/node/pull/22772
Reloadhttps://github.com/nodejs/node/pull/22772
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22772
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:revert-pgohttps://github.com/addaleax/node/tree/revert-pgo
Conversationhttps://github.com/nodejs/node/pull/22772
Commits1 (1)https://github.com/nodejs/node/pull/22772/commits
Checkshttps://github.com/nodejs/node/pull/22772/checks
Files changedhttps://github.com/nodejs/node/pull/22772/files
Revert "build: enabling pgo at configure"https://github.com/nodejs/node/pull/22772#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:revert-pgohttps://github.com/addaleax/node/tree/revert-pgo
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issue-358376039
9be1555https://github.com/nodejs/node/commit/9be15559cc0bfe506d9cdfba4ad0f4beacf5ce17
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/addaleax
Revert "build: enabling pgo at configure"https://github.com/nodejs/node/pull/22772/commits/7dec57e0a99a294832219ffa6e2b6494f417f91b
7dec57ehttps://github.com/nodejs/node/pull/22772/commits/7dec57e0a99a294832219ffa6e2b6494f417f91b
9be1555https://github.com/addaleax/node/commit/9be15559cc0bfe506d9cdfba4ad0f4beacf5ce17
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419713712
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/840/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/840/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Sep 9, 2018https://github.com/nodejs/node/pull/22772#event-1834570347
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419713757
@octaviansoldeahttps://github.com/octaviansoldea
@jasnellhttps://github.com/jasnell
@richardlauhttps://github.com/richardlau
@lundibundihttps://github.com/lundibundi
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Sep 9, 2018https://github.com/nodejs/node/pull/22772#event-1834570596
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419715243
https://ci.nodejs.org/job/node-test-pull-request/17091/https://ci.nodejs.org/job/node-test-pull-request/17091/
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 9, 2018 https://github.com/nodejs/node/pull/22772#pullrequestreview-153585436
View reviewed changes https://github.com/nodejs/node/pull/22772/files/7dec57e0a99a294832219ffa6e2b6494f417f91b
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419726166
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/refack
refackhttps://github.com/refack
Sep 9, 2018 https://github.com/nodejs/node/pull/22772#pullrequestreview-153585652
View reviewed changes https://github.com/nodejs/node/pull/22772/files/7dec57e0a99a294832219ffa6e2b6494f417f91b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419726817
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 9, 2018 https://github.com/nodejs/node/pull/22772#pullrequestreview-153587171
View reviewed changes https://github.com/nodejs/node/pull/22772/files/7dec57e0a99a294832219ffa6e2b6494f417f91b
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419742133
https://github.com/nodejs/node-gyp/blob/9a404d6d36dcf9c7be2ae9963019c4d89bbb9155/lib/configure.js#L116-L118https://github.com/nodejs/node-gyp/blob/9a404d6d36dcf9c7be2ae9963019c4d89bbb9155/lib/configure.js#L116-L118
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/refack
refackhttps://github.com/refack
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419742456
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419743778
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/refack
refackhttps://github.com/refack
Sep 9, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419749224
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Sep 10, 2018https://github.com/nodejs/node/pull/22772#event-1835795522
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 10, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419888577
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/refack
refackhttps://github.com/refack
Sep 10, 2018https://github.com/nodejs/node/pull/22772#issuecomment-419930590
Please reload this pagehttps://github.com/nodejs/node/pull/22772
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 12, 2018https://github.com/nodejs/node/pull/22772#issuecomment-420608209
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 14, 2018https://github.com/nodejs/node/pull/22772#issuecomment-421420492
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 14, 2018https://github.com/nodejs/node/pull/22772#event-1846587154
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
September 14, 2018 16:56https://github.com/nodejs/node/pull/22772#event-1846587429
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 25, 2018 https://github.com/nodejs/node/pull/22772#ref-pullrequest-337163700
pgo: enabling pgo at configure #21596 https://github.com/nodejs/node/pull/21596
lundibundihttps://github.com/lundibundi
Sep 26, 2018 https://github.com/nodejs/node/pull/22772#ref-commit-a6304a8
https://github.com/lundibundi
build: add pgo specific variables to common.gypihttps://github.com/lundibundi/node/commit/a6304a8b64deaae6586991cf9289d6acf695f52c
a6304a8https://github.com/lundibundi/node/commit/a6304a8b64deaae6586991cf9289d6acf695f52c
nodejs#22772 (comment)https://github.com/nodejs/node/pull/22772#issuecomment-419930590
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 26, 2018 https://github.com/nodejs/node/pull/22772#ref-pullrequest-363982879
build: add pgo specific variables to common.gypi #23102 https://github.com/nodejs/node/pull/23102
addaleaxhttps://github.com/addaleax
Oct 4, 2018 https://github.com/nodejs/node/pull/22772#ref-commit-6f7fd7f
https://github.com/lundibundi
https://github.com/addaleax
build: add pgo specific variables to common.gypihttps://github.com/nodejs/node/commit/6f7fd7f9bc743f7244f820a1b7be1e01562c96fd
6f7fd7fhttps://github.com/nodejs/node/commit/6f7fd7f9bc743f7244f820a1b7be1e01562c96fd
#22772 (comment)https://github.com/nodejs/node/pull/22772#issuecomment-419930590
#23102https://github.com/nodejs/node/pull/23102
targoshttps://github.com/targos
Oct 5, 2018 https://github.com/nodejs/node/pull/22772#ref-commit-3f46104
https://github.com/lundibundi
https://github.com/targos
build: add pgo specific variables to common.gypihttps://github.com/nodejs/node/commit/3f4610447d16f06e89aa639172f84a2aac23a336
3f46104https://github.com/nodejs/node/commit/3f4610447d16f06e89aa639172f84a2aac23a336
#22772 (comment)https://github.com/nodejs/node/pull/22772#issuecomment-419930590
#23102https://github.com/nodejs/node/pull/23102
targoshttps://github.com/targos
Oct 7, 2018 https://github.com/nodejs/node/pull/22772#ref-commit-0f236c8
https://github.com/lundibundi
https://github.com/targos
build: add pgo specific variables to common.gypihttps://github.com/nodejs/node/commit/0f236c8d42922deeea5f70d7a83d31a36224df36
0f236c8https://github.com/nodejs/node/commit/0f236c8d42922deeea5f70d7a83d31a36224df36
#22772 (comment)https://github.com/nodejs/node/pull/22772#issuecomment-419930590
#23102https://github.com/nodejs/node/pull/23102
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/22772#ref-commit-a90637a
https://github.com/lundibundi
https://github.com/jasnell
build: add pgo specific variables to common.gypihttps://github.com/nodejs/node/commit/a90637a085c9be2e78e98a05927c64ad97811c93
a90637ahttps://github.com/nodejs/node/commit/a90637a085c9be2e78e98a05927c64ad97811c93
#22772 (comment)https://github.com/nodejs/node/pull/22772#issuecomment-419930590
#23102https://github.com/nodejs/node/pull/23102
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22772
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/22772/files/7dec57e0a99a294832219ffa6e2b6494f417f91b
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/22772/files/7dec57e0a99a294832219ffa6e2b6494f417f91b
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/22772/files/7dec57e0a99a294832219ffa6e2b6494f417f91b
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/22772
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/mscdex
https://github.com/richardlau
https://github.com/refack
https://github.com/danbev
https://github.com/lundibundi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.