| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a073b58f-1e28-331c-26e7-deedfeb541d5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E7AE:6C0D0:158E86E:1B50941:69917D70 |
| html-safe-nonce | 4def00a8d0fba946ca995165962a4b200b363fe96e8698d00af312213e011df4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0FFOjZDMEQwOjE1OEU4NkU6MUI1MDk0MTo2OTkxN0Q3MCIsInZpc2l0b3JfaWQiOiI2ODk3NzUzNjQyNzcxNzc0ODMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1782912e49e8b97a15f83b0c24933ab7427ad0e40847db09cf3a8ca20ae41bb6 |
| hovercard-subject-tag | pull_request:214138648 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22770/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9acaca35760f701c5a461ea0a8cc20a81f5b2c315af530eeba832382b5a15c7e/nodejs/node/pull/22770 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9acaca35760f701c5a461ea0a8cc20a81f5b2c315af530eeba832382b5a15c7e/nodejs/node/pull/22770 |
| og:image:alt | As suggested by @addaleax in #22684, rename symbols to match the variable name.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22770#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22770 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22770 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22770 |
| Reload | https://github.com/nodejs/node/pull/22770 |
| Reload | https://github.com/nodejs/node/pull/22770 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22770 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:crypto-rename-state-symbols | https://github.com/tniessen/node/tree/crypto-rename-state-symbols |
| Conversation | https://github.com/nodejs/node/pull/22770 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22770/commits |
| Checks | https://github.com/nodejs/node/pull/22770/checks |
| Files changed | https://github.com/nodejs/node/pull/22770/files |
| crypto: rename symbols to match guidelines | https://github.com/nodejs/node/pull/22770#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:crypto-rename-state-symbols | https://github.com/tniessen/node/tree/crypto-rename-state-symbols |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22770#issue-358367300 |
| @addaleax | https://github.com/addaleax |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22770 |
|
| https://github.com/tniessen |
| crypto: rename symbols to match guidelines | https://github.com/nodejs/node/pull/22770/commits/251696e253876c2fc9637ed0515d10554aaada21 |
| 251696e | https://github.com/nodejs/node/pull/22770/commits/251696e253876c2fc9637ed0515d10554aaada21 |
| nodejs#22684 | https://github.com/nodejs/node/pull/22684 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22770#event-1834529193 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22770#issuecomment-419705506 |
| @tniessen | https://github.com/tniessen |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/838/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/838/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22770 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 9, 2018
| https://github.com/nodejs/node/pull/22770#pullrequestreview-153578017 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 9, 2018
| https://github.com/nodejs/node/pull/22770#pullrequestreview-153578334 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 9, 2018
| https://github.com/nodejs/node/pull/22770#pullrequestreview-153580984 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 10, 2018
| https://github.com/nodejs/node/pull/22770#pullrequestreview-153627826 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 10, 2018
| https://github.com/nodejs/node/pull/22770#pullrequestreview-153749244 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 10, 2018
| https://github.com/nodejs/node/pull/22770#pullrequestreview-153871077 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Sep 12, 2018 | https://github.com/nodejs/node/pull/22770#issuecomment-420598724 |
| @danbev | https://github.com/danbev |
| https://ci.nodejs.org/job/node-test-pull-request/17127/ | https://ci.nodejs.org/job/node-test-pull-request/17127/ |
| Please reload this page | https://github.com/nodejs/node/pull/22770 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Sep 12, 2018 | https://github.com/nodejs/node/pull/22770#issuecomment-420661609 |
| Please reload this page | https://github.com/nodejs/node/pull/22770 |
| https://ci.nodejs.org/job/node-test-pull-request/17141/ | https://ci.nodejs.org/job/node-test-pull-request/17141/ |
| https://ci.nodejs.org/job/node-test-pull-request/17154/ | https://ci.nodejs.org/job/node-test-pull-request/17154/ |
| https://ci.nodejs.org/job/node-test-pull-request/17156/ | https://ci.nodejs.org/job/node-test-pull-request/17156/ |
| Please reload this page | https://github.com/nodejs/node/pull/22770 |
| tniessen | https://github.com/tniessen |
|
Sep 12, 2018
| https://github.com/nodejs/node/pull/22770#ref-commit-79d2536 |
|
| https://github.com/tniessen |
| crypto: rename symbols to match guidelines | https://github.com/tniessen/node/commit/79d2536493929bd2b8924a1f7c57323b0544c465 |
| 79d2536 | https://github.com/tniessen/node/commit/79d2536493929bd2b8924a1f7c57323b0544c465 |
| nodejs#22770 | https://github.com/nodejs/node/pull/22770 |
| nodejs#22684 | https://github.com/nodejs/node/pull/22684 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Sep 12, 2018 | https://github.com/nodejs/node/pull/22770#issuecomment-420827433 |
| 79d2536 | https://github.com/nodejs/node/commit/79d2536493929bd2b8924a1f7c57323b0544c465 |
| Please reload this page | https://github.com/nodejs/node/pull/22770 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Sep 12, 2018 | https://github.com/nodejs/node/pull/22770#event-1842382166 |
| targos | https://github.com/targos |
|
Sep 14, 2018
| https://github.com/nodejs/node/pull/22770#ref-commit-b87ab0f |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| crypto: rename symbols to match guidelines | https://github.com/nodejs/node/commit/b87ab0f17762af470bf0bf7f193d48d44edb960c |
| b87ab0f | https://github.com/nodejs/node/commit/b87ab0f17762af470bf0bf7f193d48d44edb960c |
| #22770 | https://github.com/nodejs/node/pull/22770 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22770#ref-pullrequest-361312666 |
|
Release proposal: v10.11.0
#22932
| https://github.com/nodejs/node/pull/22932 |
| targos | https://github.com/targos |
|
Sep 19, 2018
| https://github.com/nodejs/node/pull/22770#ref-commit-350ef49 |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| crypto: rename symbols to match guidelines | https://github.com/nodejs/node/commit/350ef4922b7098124188ed27b623cebfc8d1a113 |
| 350ef49 | https://github.com/nodejs/node/commit/350ef4922b7098124188ed27b623cebfc8d1a113 |
| #22770 | https://github.com/nodejs/node/pull/22770 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| targos | https://github.com/targos |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22770#ref-commit-9b58b79 |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| crypto: rename symbols to match guidelines | https://github.com/nodejs/node/commit/9b58b79372c212d206e0580ca60ffcac290dff4d |
| 9b58b79 | https://github.com/nodejs/node/commit/9b58b79372c212d206e0580ca60ffcac290dff4d |
| #22770 | https://github.com/nodejs/node/pull/22770 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22770 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/22770/files/251696e253876c2fc9637ed0515d10554aaada21 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Please reload this page | https://github.com/nodejs/node/pull/22770 |
|
| https://github.com/tniessen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |