| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d92cbf51-fdd9-9bce-6832-d547b0bbc81e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D026:258E93:A125:C9F0:6990DE46 |
| html-safe-nonce | 416bf8630781dc2817f6d6dc2f661ed836420a48ba639947fd902fe7fabbead8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDI2OjI1OEU5MzpBMTI1OkM5RjA6Njk5MERFNDYiLCJ2aXNpdG9yX2lkIjoiMzc5NDcwNDI2NDY0MDY1MDgyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9ecee793e3bdee4d774e4d8ed949b7e31ccf662937bf46edfcc7a99145e4ef9f |
| hovercard-subject-tag | pull_request:214021223 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22754/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/708dfb32d6b401a36c5591ddb786dc6460224f2243cdfab0407532b9f1116191/nodejs/node/pull/22754 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/708dfb32d6b401a36c5591ddb786dc6460224f2243cdfab0407532b9f1116191/nodejs/node/pull/22754 |
| og:image:alt | ETA: Oct 16th, 2018
Issues to fix:
Build failure on most Linux systems node-v8#77
failing test-trace-events-dynamic-enable node-v8#78 https://chromium-review.googlesource.com/c/v8/v8/+/1235927
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22754#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22754 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22754 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22754 |
| Reload | https://github.com/nodejs/node/pull/22754 |
| Reload | https://github.com/nodejs/node/pull/22754 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
705
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:v8-7.0 | https://github.com/targos/node/tree/v8-7.0 |
| Conversation | https://github.com/nodejs/node/pull/22754 |
| Commits8 (8) | https://github.com/nodejs/node/pull/22754/commits |
| Checks | https://github.com/nodejs/node/pull/22754/checks |
| Files changed | https://github.com/nodejs/node/pull/22754/files |
| deps: update V8 to 7.0 | https://github.com/nodejs/node/pull/22754#top |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:v8-7.0 | https://github.com/targos/node/tree/v8-7.0 |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#issue-358187889 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| Build failure on most Linux systems node-v8#77 | https://github.com/nodejs/node-v8/issues/77 |
| failing test-trace-events-dynamic-enable node-v8#78 | https://github.com/nodejs/node-v8/issues/78 |
| https://chromium-review.googlesource.com/c/v8/v8/+/1235927 | https://chromium-review.googlesource.com/c/v8/v8/+/1235927 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#event-1833609481 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#event-1833609587 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#event-1833609806 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419545122 |
| @targos | https://github.com/targos |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/826/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/826/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/6cb23bf6ddbe1ee0495c993b73a73d6e9afb7543..3c794be8d3e5174a89871dfaae8c983b5255d8ab |
| 6cb23bf | https://github.com/nodejs/node/commit/6cb23bf6ddbe1ee0495c993b73a73d6e9afb7543 |
| 3c794be | https://github.com/nodejs/node/commit/3c794be8d3e5174a89871dfaae8c983b5255d8ab |
|
Compare
| https://github.com/nodejs/node/compare/6cb23bf6ddbe1ee0495c993b73a73d6e9afb7543..3c794be8d3e5174a89871dfaae8c983b5255d8ab |
| September 7, 2018 19:39 | https://github.com/nodejs/node/pull/22754#event-1833610707 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#event-1833610847 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419549822 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://ci.nodejs.org/job/node-test-pull-request/17080/ | https://ci.nodejs.org/job/node-test-pull-request/17080/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1672/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1672/ |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#event-1833642033 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419551068 |
| stable Array.prototype.sort() | https://twitter.com/mathias/status/1036626116654637057 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 8, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419614759 |
| nodejs/node-v8#77 | https://github.com/nodejs/node-v8/issues/77 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419690983 |
| nodejs/node-v8#77 | https://github.com/nodejs/node-v8/issues/77 |
| nodejs/node-v8#78 | https://github.com/nodejs/node-v8/issues/78 |
| https://ci.nodejs.org/job/node-test-pull-request/17087/ | https://ci.nodejs.org/job/node-test-pull-request/17087/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1675/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1675/ |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/AyushG3112 |
| AyushG3112 | https://github.com/AyushG3112 |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419691596 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419691940 |
| @AyushG3112 | https://github.com/AyushG3112 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419691962 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419692047 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 9, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-419692104 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1675/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1675/ |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 12, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-420519007 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 13, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-421068598 |
| @john-yan | https://github.com/john-yan |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/john-yan |
| john-yan | https://github.com/john-yan |
| Sep 13, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-421069604 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/john-yan |
| john-yan | https://github.com/john-yan |
| Sep 13, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-421071139 |
| @targos | https://github.com/targos |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1675/#showFailuresLink | https://ci.nodejs.org/job/node-test-commit-v8-linux/1675/#showFailuresLink |
| https://chromium-review.googlesource.com/c/v8/v8/+/1217003 | https://chromium-review.googlesource.com/c/v8/v8/+/1217003 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/761f10ee343ae53809cd7845371d09034f6f6695..fe5cc29b7497f8b7cfc3887263365361e12f5591 |
| 761f10e | https://github.com/nodejs/node/commit/761f10ee343ae53809cd7845371d09034f6f6695 |
| fe5cc29 | https://github.com/nodejs/node/commit/fe5cc29b7497f8b7cfc3887263365361e12f5591 |
|
Compare
| https://github.com/nodejs/node/compare/761f10ee343ae53809cd7845371d09034f6f6695..fe5cc29b7497f8b7cfc3887263365361e12f5591 |
| September 17, 2018 10:42 | https://github.com/nodejs/node/pull/22754#event-1849359285 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-421964574 |
| @john-yan | https://github.com/john-yan |
| https://ci.nodejs.org/job/node-test-pull-request/17231/ | https://ci.nodejs.org/job/node-test-pull-request/17231/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1688/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1688/ |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-421982570 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-421983979 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-422063911 |
| @targos | https://github.com/targos |
| cjihrig@3ea5acc | https://github.com/cjihrig/node/commit/3ea5acc436c6e36db36afcefa4de902acbc49070 |
| cjihrig@38a738d | https://github.com/cjihrig/node/commit/38a738dc66e59a953a775f68989808e8843a96d6 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-422073411 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 17, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-422073601 |
| nodejs/node-v8#78 | https://github.com/nodejs/node-v8/issues/78 |
| @ofrobots | https://github.com/ofrobots |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22754#ref-issue-361489080 |
|
CI failures: 20180918
nodejs/reliability#16
| https://github.com/nodejs/reliability/issues/16 |
| jasnell | https://github.com/jasnell |
|
Oct 21, 2018
| https://github.com/nodejs/node/pull/22754#ref-commit-ab20ac4 |
|
| https://github.com/jasnell |
| 2018-10-23, Version 11.0.0 (Current) | https://github.com/nodejs/node/commit/ab20ac4d9d64c54c098f1345d7491ef2ddb5600a |
| ab20ac4 | https://github.com/nodejs/node/commit/ab20ac4d9d64c54c098f1345d7491ef2ddb5600a |
| #22617 | https://github.com/nodejs/node/pull/22617 |
| #22617 | https://github.com/nodejs/node/pull/22617 |
| #21316 | https://github.com/nodejs/node/pull/21316 |
| #21316 | https://github.com/nodejs/node/pull/21316 |
| #21649 | https://github.com/nodejs/node/pull/21649 |
| #21649 | https://github.com/nodejs/node/pull/21649 |
| #20442 | https://github.com/nodejs/node/pull/20442 |
| #20442 | https://github.com/nodejs/node/pull/20442 |
| #22754 | https://github.com/nodejs/node/pull/22754 |
| #22754 | https://github.com/nodejs/node/pull/22754 |
| #22146 | https://github.com/nodejs/node/pull/22146 |
| #22146 | https://github.com/nodejs/node/pull/22146 |
| #20735 | https://github.com/nodejs/node/pull/20735 |
| #20735 | https://github.com/nodejs/node/pull/20735 |
| #20270 | https://github.com/nodejs/node/pull/20270 |
| #20270 | https://github.com/nodejs/node/pull/20270 |
| #22951 | https://github.com/nodejs/node/pull/22951 |
| #22951 | https://github.com/nodejs/node/pull/22951 |
| #22485 | https://github.com/nodejs/node/pull/22485 |
| #22485 | https://github.com/nodejs/node/pull/22485 |
| #20887 | https://github.com/nodejs/node/pull/20887 |
| #20887 | https://github.com/nodejs/node/pull/20887 |
| #20002 | https://github.com/nodejs/node/pull/20002 |
| #20002 | https://github.com/nodejs/node/pull/20002 |
| #22281 | https://github.com/nodejs/node/pull/22281 |
| #22281 | https://github.com/nodejs/node/pull/22281 |
| #22756 | https://github.com/nodejs/node/pull/22756 |
| #22756 | https://github.com/nodejs/node/pull/22756 |
| #21914 | https://github.com/nodejs/node/pull/21914 |
| #21914 | https://github.com/nodejs/node/pull/21914 |
| jasnell | https://github.com/jasnell |
|
Oct 22, 2018
| https://github.com/nodejs/node/pull/22754#ref-commit-cea049b |
|
| https://github.com/jasnell |
| 2018-10-23, Version 11.0.0 (Current) | https://github.com/nodejs/node/commit/cea049bcf8bb0f9a6e0095dbd5dffdb14dc8f71b |
|
| https://github.com/nodejs/node/commit/cea049bcf8bb0f9a6e0095dbd5dffdb14dc8f71b#comments |
| cea049b | https://github.com/nodejs/node/commit/cea049bcf8bb0f9a6e0095dbd5dffdb14dc8f71b |
| #22617 | https://github.com/nodejs/node/pull/22617 |
| #22617 | https://github.com/nodejs/node/pull/22617 |
| #21316 | https://github.com/nodejs/node/pull/21316 |
| #21316 | https://github.com/nodejs/node/pull/21316 |
| #21649 | https://github.com/nodejs/node/pull/21649 |
| #21649 | https://github.com/nodejs/node/pull/21649 |
| #20442 | https://github.com/nodejs/node/pull/20442 |
| #20442 | https://github.com/nodejs/node/pull/20442 |
| #22754 | https://github.com/nodejs/node/pull/22754 |
| #22754 | https://github.com/nodejs/node/pull/22754 |
| #22146 | https://github.com/nodejs/node/pull/22146 |
| #22146 | https://github.com/nodejs/node/pull/22146 |
| #20735 | https://github.com/nodejs/node/pull/20735 |
| #20735 | https://github.com/nodejs/node/pull/20735 |
| #20270 | https://github.com/nodejs/node/pull/20270 |
| #20270 | https://github.com/nodejs/node/pull/20270 |
| #22951 | https://github.com/nodejs/node/pull/22951 |
| #22951 | https://github.com/nodejs/node/pull/22951 |
| #22485 | https://github.com/nodejs/node/pull/22485 |
| #22485 | https://github.com/nodejs/node/pull/22485 |
| #20887 | https://github.com/nodejs/node/pull/20887 |
| #20887 | https://github.com/nodejs/node/pull/20887 |
| #20002 | https://github.com/nodejs/node/pull/20002 |
| #20002 | https://github.com/nodejs/node/pull/20002 |
| #22281 | https://github.com/nodejs/node/pull/22281 |
| #22281 | https://github.com/nodejs/node/pull/22281 |
| #22756 | https://github.com/nodejs/node/pull/22756 |
| #22756 | https://github.com/nodejs/node/pull/22756 |
| #21914 | https://github.com/nodejs/node/pull/21914 |
| #21914 | https://github.com/nodejs/node/pull/21914 |
| devsnek | https://github.com/devsnek |
|
Oct 23, 2018
| https://github.com/nodejs/node/pull/22754#ref-commit-3516052 |
|
| https://github.com/jasnell |
| 2018-10-23, Version 11.0.0 (Current) | https://github.com/devsnek/node/commit/3516052bee118dce767dd330fa857f6615c5b28a |
| 3516052 | https://github.com/devsnek/node/commit/3516052bee118dce767dd330fa857f6615c5b28a |
| nodejs#22617 | https://github.com/nodejs/node/pull/22617 |
| nodejs#22617 | https://github.com/nodejs/node/pull/22617 |
| nodejs#21316 | https://github.com/nodejs/node/pull/21316 |
| nodejs#21316 | https://github.com/nodejs/node/pull/21316 |
| nodejs#21649 | https://github.com/nodejs/node/pull/21649 |
| nodejs#21649 | https://github.com/nodejs/node/pull/21649 |
| nodejs#20442 | https://github.com/nodejs/node/pull/20442 |
| nodejs#20442 | https://github.com/nodejs/node/pull/20442 |
| nodejs#22754 | https://github.com/nodejs/node/pull/22754 |
| nodejs#22754 | https://github.com/nodejs/node/pull/22754 |
| nodejs#22146 | https://github.com/nodejs/node/pull/22146 |
| nodejs#22146 | https://github.com/nodejs/node/pull/22146 |
| nodejs#20735 | https://github.com/nodejs/node/pull/20735 |
| nodejs#20735 | https://github.com/nodejs/node/pull/20735 |
| nodejs#20270 | https://github.com/nodejs/node/pull/20270 |
| nodejs#20270 | https://github.com/nodejs/node/pull/20270 |
| nodejs#22951 | https://github.com/nodejs/node/pull/22951 |
| nodejs#22951 | https://github.com/nodejs/node/pull/22951 |
| nodejs#22485 | https://github.com/nodejs/node/pull/22485 |
| nodejs#22485 | https://github.com/nodejs/node/pull/22485 |
| nodejs#20887 | https://github.com/nodejs/node/pull/20887 |
| nodejs#20887 | https://github.com/nodejs/node/pull/20887 |
| nodejs#20002 | https://github.com/nodejs/node/pull/20002 |
| nodejs#20002 | https://github.com/nodejs/node/pull/20002 |
| nodejs#22281 | https://github.com/nodejs/node/pull/22281 |
| nodejs#22281 | https://github.com/nodejs/node/pull/22281 |
| nodejs#22756 | https://github.com/nodejs/node/pull/22756 |
| nodejs#22756 | https://github.com/nodejs/node/pull/22756 |
| nodejs#21914 | https://github.com/nodejs/node/pull/21914 |
| nodejs#21914 | https://github.com/nodejs/node/pull/21914 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 5, 2018
| https://github.com/nodejs/node/pull/22754#ref-issue-377423115 |
|
Array#sort is broken in node 11
#24106
| https://github.com/nodejs/node/issues/24106 |
| https://github.com/Hypnosphi |
| Hypnosphi | https://github.com/Hypnosphi |
|
Nov 5, 2018
| https://github.com/nodejs/node/pull/22754#ref-pullrequest-377431005 |
|
Fix tests in node 11 by using Array#sort correctly
storybookjs/storybook#4720
| https://github.com/storybookjs/storybook/pull/4720 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
landed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alanded |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/22754#event-1949195254 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 10, 2018
| https://github.com/nodejs/node/pull/22754#ref-issue-379467023 |
|
Array.sort arguments order changed in Node.js 11
#24294
| https://github.com/nodejs/node/issues/24294 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/22754#event-1958668012 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-437635459 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/22754#issuecomment-437648408 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Dec 6, 2018
| https://github.com/nodejs/node/pull/22754#ref-issue-388357624 |
|
Suggestion: Promote use of N-API for native addons
nodejs/package-maintenance#52
| https://github.com/nodejs/package-maintenance/issues/52 |
| deepak1556 | https://github.com/deepak1556 |
|
Dec 10, 2018
| https://github.com/nodejs/node/pull/22754#ref-commit-fffd852 |
|
| https://github.com/jasnell |
|
| https://github.com/deepak1556 |
| 2018-10-23, Version 11.0.0 (Current) | https://github.com/electron/node/commit/fffd85229ce423a5533a5ab5885c26fb3857eb59 |
| fffd852 | https://github.com/electron/node/commit/fffd85229ce423a5533a5ab5885c26fb3857eb59 |
| nodejs/node#22617 | https://github.com/nodejs/node/pull/22617 |
| nodejs/node#21316 | https://github.com/nodejs/node/pull/21316 |
| nodejs/node#21649 | https://github.com/nodejs/node/pull/21649 |
| nodejs/node#20442 | https://github.com/nodejs/node/pull/20442 |
| nodejs/node#22754 | https://github.com/nodejs/node/pull/22754 |
| nodejs/node#22146 | https://github.com/nodejs/node/pull/22146 |
| nodejs/node#20735 | https://github.com/nodejs/node/pull/20735 |
| nodejs/node#20270 | https://github.com/nodejs/node/pull/20270 |
| nodejs/node#22951 | https://github.com/nodejs/node/pull/22951 |
| nodejs/node#22485 | https://github.com/nodejs/node/pull/22485 |
| nodejs/node#20887 | https://github.com/nodejs/node/pull/20887 |
| nodejs/node#20002 | https://github.com/nodejs/node/pull/20002 |
| nodejs/node#22281 | https://github.com/nodejs/node/pull/22281 |
| nodejs/node#22756 | https://github.com/nodejs/node/pull/22756 |
| nodejs/node#21914 | https://github.com/nodejs/node/pull/21914 |
| deepak1556 | https://github.com/deepak1556 |
|
Dec 19, 2018
| https://github.com/nodejs/node/pull/22754#ref-commit-0b2f9b4 |
|
| https://github.com/jasnell |
|
| https://github.com/deepak1556 |
| 2018-10-23, Version 11.0.0 (Current) | https://github.com/electron/node/commit/0b2f9b42ca0e483902f47460d5ec8c24902f58ce |
| 0b2f9b4 | https://github.com/electron/node/commit/0b2f9b42ca0e483902f47460d5ec8c24902f58ce |
| nodejs/node#22617 | https://github.com/nodejs/node/pull/22617 |
| nodejs/node#21316 | https://github.com/nodejs/node/pull/21316 |
| nodejs/node#21649 | https://github.com/nodejs/node/pull/21649 |
| nodejs/node#20442 | https://github.com/nodejs/node/pull/20442 |
| nodejs/node#22754 | https://github.com/nodejs/node/pull/22754 |
| nodejs/node#22146 | https://github.com/nodejs/node/pull/22146 |
| nodejs/node#20735 | https://github.com/nodejs/node/pull/20735 |
| nodejs/node#20270 | https://github.com/nodejs/node/pull/20270 |
| nodejs/node#22951 | https://github.com/nodejs/node/pull/22951 |
| nodejs/node#22485 | https://github.com/nodejs/node/pull/22485 |
| nodejs/node#20887 | https://github.com/nodejs/node/pull/20887 |
| nodejs/node#20002 | https://github.com/nodejs/node/pull/20002 |
| nodejs/node#22281 | https://github.com/nodejs/node/pull/22281 |
| nodejs/node#22756 | https://github.com/nodejs/node/pull/22756 |
| nodejs/node#21914 | https://github.com/nodejs/node/pull/21914 |
| https://github.com/orangejulius |
| orangejulius | https://github.com/orangejulius |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/22754#ref-pullrequest-398771474 |
|
fix stable sorting on node 11.6.0
pelias/api#1253
| https://github.com/pelias/api/pull/1253 |
| https://github.com/JamieMagee |
| JamieMagee | https://github.com/JamieMagee |
|
Apr 16, 2019
| https://github.com/nodejs/node/pull/22754#ref-pullrequest-433691650 |
|
fix: nodejs 11 support
renovatebot/renovate#3549
| https://github.com/renovatebot/renovate/pull/3549 |
| rarkins | https://github.com/rarkins |
|
Apr 16, 2019
| https://github.com/nodejs/node/pull/22754#ref-commit-05a46dd |
|
| https://github.com/JamieMagee |
|
| https://github.com/rarkins |
| fix: nodejs 11 support ( | https://github.com/renovatebot/renovate/commit/05a46ddb4c78df8d9118600b5d60d32f7fcd130c |
| #3549 | https://github.com/renovatebot/renovate/pull/3549 |
| ) | https://github.com/renovatebot/renovate/commit/05a46ddb4c78df8d9118600b5d60d32f7fcd130c |
| 05a46dd | https://github.com/renovatebot/renovate/commit/05a46ddb4c78df8d9118600b5d60d32f7fcd130c |
| nodejs/node#22754 (comment) | https://github.com/nodejs/node/pull/22754#issuecomment-423452575 |
| #3445 | https://github.com/renovatebot/renovate/issues/3445 |
| https://github.com/Hakerh400 |
| Hakerh400 | https://github.com/Hakerh400 |
|
Jul 26, 2019
| https://github.com/nodejs/node/pull/22754#ref-issue-402110313 |
|
Async function execute in different version got different output about async function itself
nodejs/help#1733
| https://github.com/nodejs/help/issues/1733 |
| https://github.com/nolleto |
| nolleto | https://github.com/nolleto |
|
Oct 21, 2019
| https://github.com/nodejs/node/pull/22754#ref-pullrequest-509992850 |
|
Fix shuffle color for node 11
bayesjs/bayesjs-editor#51
| https://github.com/bayesjs/bayesjs-editor/pull/51 |
| https://github.com/slowbackspace |
| slowbackspace | https://github.com/slowbackspace |
|
Oct 31, 2019
| https://github.com/nodejs/node/pull/22754#ref-issue-515301307 |
|
Unit tests failing with Node.js v11+
trezor/trezor-suite#745
| https://github.com/trezor/trezor-suite/issues/745 |
| das7pad | https://github.com/das7pad |
|
Nov 5, 2019
| https://github.com/nodejs/node/pull/22754#ref-commit-85dc1bf |
|
| https://github.com/das7pad |
| [ProjectController] fix the sorting of project entities for node v11+ | https://github.com/das7pad/web-sharelatex/commit/85dc1bf2e4b1f95cd0840c7e42fc4c01ee7f9441 |
| 85dc1bf | https://github.com/das7pad/web-sharelatex/commit/85dc1bf2e4b1f95cd0840c7e42fc4c01ee7f9441 |
| https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description | https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description |
| nodejs/node#22754 | https://github.com/nodejs/node/pull/22754 |
| https://chromium-review.googlesource.com/c/v8/v8/+/1186801 | https://chromium-review.googlesource.com/c/v8/v8/+/1186801 |
| https://github.com/das7pad |
| das7pad | https://github.com/das7pad |
|
Nov 5, 2019
| https://github.com/nodejs/node/pull/22754#ref-pullrequest-517781638 |
|
[ProjectController] fix the sorting of project entities for node v11+
overleaf/web#697
| https://github.com/overleaf/web/pull/697 |
| das7pad | https://github.com/das7pad |
|
Nov 20, 2019
| https://github.com/nodejs/node/pull/22754#ref-commit-633c7a6 |
|
| https://github.com/das7pad |
| [ProjectController] fix the sorting of project entities for node v11+ | https://github.com/das7pad/web-sharelatex/commit/633c7a6250208b87297ef026bad2c93d06a2b5b3 |
| 633c7a6 | https://github.com/das7pad/web-sharelatex/commit/633c7a6250208b87297ef026bad2c93d06a2b5b3 |
| https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description | https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description |
| nodejs/node#22754 | https://github.com/nodejs/node/pull/22754 |
| https://chromium-review.googlesource.com/c/v8/v8/+/1186801 | https://chromium-review.googlesource.com/c/v8/v8/+/1186801 |
| https://github.com/owaiswiz |
| owaiswiz | https://github.com/owaiswiz |
|
Mar 28, 2020
| https://github.com/nodejs/node/pull/22754#ref-issue-587998857 |
|
Transforms only work if applied after classes like rotate, translate
ben-rogerson/twin.macro#20
| https://github.com/ben-rogerson/twin.macro/issues/20 |
| MunifTanjim | https://github.com/MunifTanjim |
|
Nov 17, 2020
| https://github.com/nodejs/node/pull/22754#ref-commit-13cd663 |
|
| https://github.com/MunifTanjim |
| test(core): update utils/sort expected result | https://github.com/Synor/synor/commit/13cd6637b82072e5f633e67fc73f4329fd59e237 |
| 13cd663 | https://github.com/Synor/synor/commit/13cd6637b82072e5f633e67fc73f4329fd59e237 |
| https://v8.dev/features/stable-sort | https://v8.dev/features/stable-sort |
| nodejs/node#22754 (comment) | https://github.com/nodejs/node/pull/22754#issuecomment-419551068 |
| https://github.com/MunifTanjim |
| MunifTanjim | https://github.com/MunifTanjim |
|
Nov 17, 2020
| https://github.com/nodejs/node/pull/22754#ref-pullrequest-744767558 |
|
Use Node.js 12 for testing
Synor/synor#6
| https://github.com/Synor/synor/pull/6 |
| MunifTanjim | https://github.com/MunifTanjim |
|
Nov 17, 2020
| https://github.com/nodejs/node/pull/22754#ref-commit-3a0aef1 |
|
| https://github.com/MunifTanjim |
| test(core): update utils/sort expected result | https://github.com/Synor/synor/commit/3a0aef1f534f46d74fad908e2a8989f291ba6fec |
| 3a0aef1 | https://github.com/Synor/synor/commit/3a0aef1f534f46d74fad908e2a8989f291ba6fec |
| https://v8.dev/features/stable-sort | https://v8.dev/features/stable-sort |
| nodejs/node#22754 (comment) | https://github.com/nodejs/node/pull/22754#issuecomment-419551068 |
| MunifTanjim | https://github.com/MunifTanjim |
|
Nov 17, 2020
| https://github.com/nodejs/node/pull/22754#ref-commit-c6cc6e2 |
|
| https://github.com/MunifTanjim |
| test(core): update utils/sort expected result | https://github.com/Synor/synor/commit/c6cc6e2a29344bf328acb28588509eff992cb835 |
| c6cc6e2 | https://github.com/Synor/synor/commit/c6cc6e2a29344bf328acb28588509eff992cb835 |
| https://v8.dev/features/stable-sort | https://v8.dev/features/stable-sort |
| nodejs/node#22754 (comment) | https://github.com/nodejs/node/pull/22754#issuecomment-419551068 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22754 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/22754/files/71591f9b6b6dd05b83fa87ea1b9be534688e9efe |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22754/files/71591f9b6b6dd05b83fa87ea1b9be534688e9efe |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/22754/files/0affb0c0b6f8f1f58cbb2bb9f7b72e2adbc29c19 |
|
| https://github.com/ofrobots |
|
ofrobots
| https://github.com/ofrobots |
|
| https://github.com/nodejs/node/pull/22754/files/71591f9b6b6dd05b83fa87ea1b9be534688e9efe |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/22754/files/71591f9b6b6dd05b83fa87ea1b9be534688e9efe |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/22754 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/AyushG3112 |
|
| https://github.com/mhdawson |
|
| https://github.com/john-yan |
|
| https://github.com/cjihrig |
|
| https://github.com/refack |
|
| https://github.com/hashseed |
|
| https://github.com/motss |
|
| https://github.com/ofrobots |
|
| https://github.com/addaleax |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |