| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4a314c34-561f-0894-9418-ce91206ea2e4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8984:4D0D3:225618D:2BA9DCA:6991A01B |
| html-safe-nonce | 77847da9dee29531a8ebda8087c5b295b79ff7e0ab70edd16cee34dd6e37fc53 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTg0OjREMEQzOjIyNTYxOEQ6MkJBOURDQTo2OTkxQTAxQiIsInZpc2l0b3JfaWQiOiI1ODI4ODgzNjczMTkwMDgwNTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b09bdb6dc82234137b3d822c6dd79eacbcf6c06c941306c7f18d607669211fc6 |
| hovercard-subject-tag | pull_request:212930068 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22684/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/26be72edf75bcd84b65561c030da60857a8496b4bf5fb8d0cc5588325ff09006/nodejs/node/pull/22684 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/26be72edf75bcd84b65561c030da60857a8496b4bf5fb8d0cc5588325ff09006/nodejs/node/pull/22684 |
| og:image:alt | I've added the Symbol guideline that spun out from the discussion in #20857.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit messa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mcollina |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22684#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22684 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22684 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22684 |
| Reload | https://github.com/nodejs/node/pull/22684 |
| Reload | https://github.com/nodejs/node/pull/22684 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mcollina | https://github.com/mcollina |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mcollina:symbols-guideline | https://github.com/mcollina/node/tree/symbols-guideline |
| Conversation | https://github.com/nodejs/node/pull/22684 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22684/commits |
| Checks | https://github.com/nodejs/node/pull/22684/checks |
| Files changed | https://github.com/nodejs/node/pull/22684/files |
| doc: added symbols guidelines | https://github.com/nodejs/node/pull/22684#top |
| mcollina | https://github.com/mcollina |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mcollina:symbols-guideline | https://github.com/mcollina/node/tree/symbols-guideline |
|
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#issue-356750468 |
| #20857 | https://github.com/nodejs/node/pull/20857 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-418320007 |
| @mcollina | https://github.com/mcollina |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/789/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/789/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#event-1824925091 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-418320224 |
| @devsnek | https://github.com/devsnek |
| #22302 | https://github.com/nodejs/node/pull/22302 |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152055769 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152148159 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| jasnell | https://github.com/jasnell |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r214981119 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152148392 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-418462290 |
| @devsnek | https://github.com/devsnek |
| #22302 | https://github.com/nodejs/node/pull/22302 |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/801d47fb302913112964ed02ea315d5c7ec2bdec..40ec16be28c434864496f4f57d3078c437ac2fe7 |
| 801d47f | https://github.com/nodejs/node/commit/801d47fb302913112964ed02ea315d5c7ec2bdec |
| 40ec16b | https://github.com/nodejs/node/commit/40ec16be28c434864496f4f57d3078c437ac2fe7 |
|
Compare
| https://github.com/nodejs/node/compare/801d47fb302913112964ed02ea315d5c7ec2bdec..40ec16be28c434864496f4f57d3078c437ac2fe7 |
| September 4, 2018 20:42 | https://github.com/nodejs/node/pull/22684#event-1826294469 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
tsc-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#event-1826294593 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-418510955 |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| September 4, 2018 20:42 | https://github.com/nodejs/node/pull/22684#event-1826295729 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#event-1826295934 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152248490 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152248490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152248475 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| BridgeAR | https://github.com/BridgeAR |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215062896 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| BridgeAR | https://github.com/BridgeAR |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215063682 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152249616 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152250054 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152268004 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215078580 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215078904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215082264 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152302585 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| TimothyGu | https://github.com/TimothyGu |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215108319 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| mcollina | https://github.com/mcollina |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215243521 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| TimothyGu | https://github.com/TimothyGu |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215108480 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| TimothyGu | https://github.com/TimothyGu |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215108722 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| TimothyGu | https://github.com/TimothyGu |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215109043 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| TimothyGu | https://github.com/TimothyGu |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215109196 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| devsnek | https://github.com/devsnek |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215112273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152330880 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152410516 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| addaleax | https://github.com/addaleax |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215199232 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/40ec16be28c434864496f4f57d3078c437ac2fe7..a9d210a3e8fa4fd89efcf702509e789636dafb8a |
| 40ec16b | https://github.com/nodejs/node/commit/40ec16be28c434864496f4f57d3078c437ac2fe7 |
| a9d210a | https://github.com/nodejs/node/commit/a9d210a3e8fa4fd89efcf702509e789636dafb8a |
|
Compare
| https://github.com/nodejs/node/compare/40ec16be28c434864496f4f57d3078c437ac2fe7..a9d210a3e8fa4fd89efcf702509e789636dafb8a |
| September 5, 2018 12:23 | https://github.com/nodejs/node/pull/22684#event-1827683805 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-418710675 |
| @TimothyGu | https://github.com/TimothyGu |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152501618 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| BridgeAR | https://github.com/BridgeAR |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215274688 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| doc/guides/using-symbols.md | https://github.com/nodejs/node/pull/22684/files#diff-18efea37528c4acc8809d604785c322444d038cb7a011c6d8b86b5b4b90357bd |
| BridgeAR | https://github.com/BridgeAR |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#discussion_r215275318 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
|
| https://github.com/mcollina |
| doc: added symbols guidelines | https://github.com/nodejs/node/pull/22684/commits/0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
| 0d9162a | https://github.com/nodejs/node/pull/22684/commits/0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/a9d210a3e8fa4fd89efcf702509e789636dafb8a..0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
| a9d210a | https://github.com/nodejs/node/commit/a9d210a3e8fa4fd89efcf702509e789636dafb8a |
| 0d9162a | https://github.com/nodejs/node/commit/0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
|
Compare
| https://github.com/nodejs/node/compare/a9d210a3e8fa4fd89efcf702509e789636dafb8a..0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
| September 5, 2018 13:54 | https://github.com/nodejs/node/pull/22684#event-1827906768 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152544851 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files/0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
tsc-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22684#event-1829012738 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22684#pullrequestreview-152705110 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22684/files/0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-419349220 |
| 4f5aa36 | https://github.com/nodejs/node/commit/4f5aa3607d84ad500e496fbffccd91b769cab259 |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22684#event-1832176238 |
| danbev | https://github.com/danbev |
|
Sep 7, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-4f5aa36 |
|
| https://github.com/mcollina |
|
| https://github.com/danbev |
| doc: added symbols guidelines | https://github.com/nodejs/node/commit/4f5aa3607d84ad500e496fbffccd91b769cab259 |
| 4f5aa36 | https://github.com/nodejs/node/commit/4f5aa3607d84ad500e496fbffccd91b769cab259 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| September 7, 2018 07:59 | https://github.com/nodejs/node/pull/22684#event-1832229927 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Sep 7, 2018
| https://github.com/nodejs/node/pull/22684#ref-pullrequest-324747306 |
|
util: use a shared symbol for util.inspect.custom
#20857
| https://github.com/nodejs/node/pull/20857 |
| tniessen | https://github.com/tniessen |
|
Sep 7, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-251696e |
|
| https://github.com/tniessen |
| crypto: rename symbols to match guidelines | https://github.com/tniessen/node/commit/251696e253876c2fc9637ed0515d10554aaada21 |
| 251696e | https://github.com/tniessen/node/commit/251696e253876c2fc9637ed0515d10554aaada21 |
| nodejs#22684 | https://github.com/nodejs/node/pull/22684 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Sep 7, 2018
| https://github.com/nodejs/node/pull/22684#ref-pullrequest-358066845 |
|
crypto: hide native handles from JS modules
#22747
| https://github.com/nodejs/node/pull/22747 |
| targos | https://github.com/targos |
|
Sep 7, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-2b49b43 |
|
| https://github.com/mcollina |
|
| https://github.com/targos |
| doc: added symbols guidelines | https://github.com/nodejs/node/commit/2b49b43f790420441a01c8d74ff16ffe630b09d3 |
| 2b49b43 | https://github.com/nodejs/node/commit/2b49b43f790420441a01c8d74ff16ffe630b09d3 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-419559043 |
| @BridgeAR | https://github.com/BridgeAR |
| #22747 (comment) | https://github.com/nodejs/node/pull/22747#discussion_r216013555 |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-419581021 |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-419581347 |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 7, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-419583455 |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 8, 2018 | https://github.com/nodejs/node/pull/22684#issuecomment-419630214 |
| https://github.com/nodejs/node/blob/master/lib/internal/http2/core.js | https://github.com/nodejs/node/blob/master/lib/internal/http2/core.js |
| node/lib/internal/http2/core.js | https://github.com/nodejs/node/blob/922a1b03b638e19d8d29efdaab93d5c9455c02ce/lib/internal/http2/core.js#L1566-L1595 |
| 922a1b0 | https://github.com/nodejs/node/commit/922a1b03b638e19d8d29efdaab93d5c9455c02ce |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Sep 9, 2018
| https://github.com/nodejs/node/pull/22684#ref-pullrequest-358367300 |
|
crypto: rename symbols to match guidelines
#22770
| https://github.com/nodejs/node/pull/22770 |
| tniessen | https://github.com/tniessen |
|
Sep 12, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-79d2536 |
|
| https://github.com/tniessen |
| crypto: rename symbols to match guidelines | https://github.com/tniessen/node/commit/79d2536493929bd2b8924a1f7c57323b0544c465 |
| 79d2536 | https://github.com/tniessen/node/commit/79d2536493929bd2b8924a1f7c57323b0544c465 |
| nodejs#22770 | https://github.com/nodejs/node/pull/22770 |
| nodejs#22684 | https://github.com/nodejs/node/pull/22684 |
| targos | https://github.com/targos |
|
Sep 14, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-b87ab0f |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| crypto: rename symbols to match guidelines | https://github.com/nodejs/node/commit/b87ab0f17762af470bf0bf7f193d48d44edb960c |
| b87ab0f | https://github.com/nodejs/node/commit/b87ab0f17762af470bf0bf7f193d48d44edb960c |
| #22770 | https://github.com/nodejs/node/pull/22770 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| targos | https://github.com/targos |
|
Sep 15, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-dadd6e1 |
|
| https://github.com/chocolateboy |
|
| https://github.com/targos |
| util: use a shared symbol for util.inspect.custom | https://github.com/nodejs/node/commit/dadd6e16888baac8fd110432b81f3fd1237be3e1 |
| dadd6e1 | https://github.com/nodejs/node/commit/dadd6e16888baac8fd110432b81f3fd1237be3e1 |
| #20821 | https://github.com/nodejs/node/issues/20821 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| #20857 | https://github.com/nodejs/node/pull/20857 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 18, 2018
| https://github.com/nodejs/node/pull/22684#ref-pullrequest-361312666 |
|
Release proposal: v10.11.0
#22932
| https://github.com/nodejs/node/pull/22932 |
| targos | https://github.com/targos |
|
Sep 19, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-350ef49 |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| crypto: rename symbols to match guidelines | https://github.com/nodejs/node/commit/350ef4922b7098124188ed27b623cebfc8d1a113 |
| 350ef49 | https://github.com/nodejs/node/commit/350ef4922b7098124188ed27b623cebfc8d1a113 |
| #22770 | https://github.com/nodejs/node/pull/22770 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| targos | https://github.com/targos |
|
Sep 20, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-9b58b79 |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| crypto: rename symbols to match guidelines | https://github.com/nodejs/node/commit/9b58b79372c212d206e0580ca60ffcac290dff4d |
| 9b58b79 | https://github.com/nodejs/node/commit/9b58b79372c212d206e0580ca60ffcac290dff4d |
| #22770 | https://github.com/nodejs/node/pull/22770 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| targos | https://github.com/targos |
|
Sep 23, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-cc9898b |
|
| https://github.com/chocolateboy |
|
| https://github.com/targos |
| util: use a shared symbol for util.inspect.custom | https://github.com/targos/node/commit/cc9898bd7747d2884afe9da8fff7e954225ba347 |
| cc9898b | https://github.com/targos/node/commit/cc9898bd7747d2884afe9da8fff7e954225ba347 |
| nodejs#20821 | https://github.com/nodejs/node/issues/20821 |
| nodejs#22684 | https://github.com/nodejs/node/pull/22684 |
| nodejs#20857 | https://github.com/nodejs/node/pull/20857 |
| targos | https://github.com/targos |
|
Sep 24, 2018
| https://github.com/nodejs/node/pull/22684#ref-commit-a2a1ebf |
|
| https://github.com/chocolateboy |
|
| https://github.com/targos |
| util: use a shared symbol for util.inspect.custom | https://github.com/nodejs/node/commit/a2a1ebfecface85509faaecfc830e05bb4bfe8e3 |
| a2a1ebf | https://github.com/nodejs/node/commit/a2a1ebfecface85509faaecfc830e05bb4bfe8e3 |
| #20821 | https://github.com/nodejs/node/issues/20821 |
| #22684 | https://github.com/nodejs/node/pull/22684 |
| #23039 | https://github.com/nodejs/node/pull/23039 |
| #20857 | https://github.com/nodejs/node/pull/20857 |
| https://github.com/vweevers |
| vweevers | https://github.com/vweevers |
|
Jan 5, 2023
| https://github.com/nodejs/node/pull/22684#ref-pullrequest-1467827082 |
|
stream: expose stream symbols
#45671
| https://github.com/nodejs/node/pull/45671 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22684 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/22684/files/a9d210a3e8fa4fd89efcf702509e789636dafb8a |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22684/files/801d47fb302913112964ed02ea315d5c7ec2bdec |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22684/files/0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/22684/files/40ec16be28c434864496f4f57d3078c437ac2fe7 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/22684/files/40ec16be28c434864496f4f57d3078c437ac2fe7 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/22684/files/801d47fb302913112964ed02ea315d5c7ec2bdec |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/22684/files/40ec16be28c434864496f4f57d3078c437ac2fe7 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/22684/files/40ec16be28c434864496f4f57d3078c437ac2fe7 |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/22684/files/0d9162a8f24ce2f8ed2dc352dd7617ac68251f3e |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/22684/files/40ec16be28c434864496f4f57d3078c437ac2fe7 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/22684/files/40ec16be28c434864496f4f57d3078c437ac2fe7 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Please reload this page | https://github.com/nodejs/node/pull/22684 |
|
| https://github.com/mcollina |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/richardlau |
|
| https://github.com/danbev |
|
| https://github.com/tniessen |
|
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
| https://github.com/apapirovski |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/TimothyGu |
|
| https://github.com/cjihrig |
|
| https://github.com/devsnek |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |