René's URL Explorer Experiment


Title: deps: fix V8 test regression by targos · Pull Request #22677 · nodejs/node · GitHub

Open Graph Title: deps: fix V8 test regression by targos · Pull Request #22677 · nodejs/node

X Title: deps: fix V8 test regression by targos · Pull Request #22677 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea

X Description: Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea

Opengraph URL: https://github.com/nodejs/node/pull/22677

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:46297be0-d92e-6cf4-7af7-d0ffa8821936
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8A4:1074E3:1625A9D:1CA132A:69908646
html-safe-nonceb8ce8806a8e210d767f17a59c869db90ad685bc1f74e39c6e199ecf39d94ec6e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEE0OjEwNzRFMzoxNjI1QTlEOjFDQTEzMkE6Njk5MDg2NDYiLCJ2aXNpdG9yX2lkIjoiNjE2NDk4NDk1MTY2NDA1MTc4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccd07940a07773c862da7cced800ad55c6e0b2f8d35a3929e588b83ee0efebdc7
hovercard-subject-tagpull_request:212810650
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22677/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f50455614bdafb092470ccc443bc3a03aefed6bb06d4cd2c590078719231328d/nodejs/node/pull/22677
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f50455614bdafb092470ccc443bc3a03aefed6bb06d4cd2c590078719231328d/nodejs/node/pull/22677
og:image:altFixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametargos
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22677#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22677
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22677
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22677
Reloadhttps://github.com/nodejs/node/pull/22677
Reloadhttps://github.com/nodejs/node/pull/22677
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22677
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
targoshttps://github.com/targos
nodejs:masterhttps://github.com/nodejs/node/tree/master
targos:fix-v8-testshttps://github.com/targos/node/tree/fix-v8-tests
Conversationhttps://github.com/nodejs/node/pull/22677
Commits1 (1)https://github.com/nodejs/node/pull/22677/commits
Checkshttps://github.com/nodejs/node/pull/22677/checks
Files changedhttps://github.com/nodejs/node/pull/22677/files
deps: fix V8 test regressionhttps://github.com/nodejs/node/pull/22677#top
targoshttps://github.com/targos
nodejs:masterhttps://github.com/nodejs/node/tree/master
targos:fix-v8-testshttps://github.com/targos/node/tree/fix-v8-tests
https://github.com/targos
targoshttps://github.com/targos
Sep 3, 2018https://github.com/nodejs/node/pull/22677#issue-356588147
#22028https://github.com/nodejs/node/pull/22028
v8/v8@ba752eahttps://github.com/v8/v8/commit/ba752ea4c50713dff1e94f45a79db3ba968a8d66
Please reload this pagehttps://github.com/nodejs/node/pull/22677
https://github.com/targos
deps: fix V8 test regressionhttps://github.com/nodejs/node/pull/22677/commits/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
d8b470ahttps://github.com/nodejs/node/pull/22677/commits/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
nodejs#22028https://github.com/nodejs/node/pull/22028
v8/v8@ba752eahttps://github.com/v8/v8/commit/ba752ea4c50713dff1e94f45a79db3ba968a8d66
https://github.com/targos
targoshttps://github.com/targos
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
regression https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Sep 3, 2018https://github.com/nodejs/node/pull/22677#event-1823979865
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 3, 2018https://github.com/nodejs/node/pull/22677#issuecomment-418182736
@targoshttps://github.com/targos
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/784/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/784/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22677
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Sep 3, 2018https://github.com/nodejs/node/pull/22677#event-1823979895
https://github.com/targos
targoshttps://github.com/targos
Sep 3, 2018https://github.com/nodejs/node/pull/22677#issuecomment-418182816
Please reload this pagehttps://github.com/nodejs/node/pull/22677
https://github.com/targos
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22677#ref-pullrequest-345728613
[10.x] deps: V8: backport 4 CPU profiler commits from upstream #22028 https://github.com/nodejs/node/pull/22028
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 3, 2018 https://github.com/nodejs/node/pull/22677#pullrequestreview-151866703
View reviewed changes https://github.com/nodejs/node/pull/22677/files/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
https://github.com/targos
targoshttps://github.com/targos
Sep 3, 2018https://github.com/nodejs/node/pull/22677#issuecomment-418182919
Please reload this pagehttps://github.com/nodejs/node/pull/22677
https://ci.nodejs.org/job/node-test-commit-v8-linux/1652/https://ci.nodejs.org/job/node-test-commit-v8-linux/1652/
Please reload this pagehttps://github.com/nodejs/node/pull/22677
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 3, 2018 https://github.com/nodejs/node/pull/22677#pullrequestreview-151866739
View reviewed changes https://github.com/nodejs/node/pull/22677/files/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
https://github.com/mihalskiy
mihalskiyhttps://github.com/mihalskiy
Sep 3, 2018 https://github.com/nodejs/node/pull/22677#pullrequestreview-151868527
View reviewed changes https://github.com/nodejs/node/pull/22677/files/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Sep 4, 2018 https://github.com/nodejs/node/pull/22677#pullrequestreview-151911156
View reviewed changes https://github.com/nodejs/node/pull/22677/files/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
https://github.com/targos
targoshttps://github.com/targos
Sep 4, 2018https://github.com/nodejs/node/pull/22677#issuecomment-418254926
ebc965fhttps://github.com/nodejs/node/commit/ebc965f021fa23eca9bb9a1235b4e1046574dde5
Please reload this pagehttps://github.com/nodejs/node/pull/22677
https://github.com/targos
targoshttps://github.com/targos
Sep 4, 2018https://github.com/nodejs/node/pull/22677#event-1824431102
targoshttps://github.com/targos
Sep 4, 2018 https://github.com/nodejs/node/pull/22677#ref-commit-ebc965f
https://github.com/targos
deps: fix V8 test regressionhttps://github.com/targos/node/commit/ebc965f021fa23eca9bb9a1235b4e1046574dde5
ebc965fhttps://github.com/targos/node/commit/ebc965f021fa23eca9bb9a1235b4e1046574dde5
nodejs#22028https://github.com/nodejs/node/pull/22028
v8/v8@ba752eahttps://github.com/v8/v8/commit/ba752ea4c50713dff1e94f45a79db3ba968a8d66
nodejs#22677https://github.com/nodejs/node/pull/22677
https://github.com/targos
targoshttps://github.com/targos
September 4, 2018 06:26https://github.com/nodejs/node/pull/22677#event-1824431158
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22677#ref-commit-a986abc
https://github.com/targos
deps: fix V8 test regressionhttps://github.com/nodejs/node/commit/a986abc5296d4c90cb15e9c55fd03304a0b278d4
a986abchttps://github.com/nodejs/node/commit/a986abc5296d4c90cb15e9c55fd03304a0b278d4
#22028https://github.com/nodejs/node/pull/22028
v8/v8@ba752eahttps://github.com/v8/v8/commit/ba752ea4c50713dff1e94f45a79db3ba968a8d66
#22677https://github.com/nodejs/node/pull/22677
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22677#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22677#ref-commit-29d19fd
https://github.com/targos
deps: fix V8 test regressionhttps://github.com/nodejs/node/commit/29d19fde51472bae46444790c67b17c163c13640
29d19fdhttps://github.com/nodejs/node/commit/29d19fde51472bae46444790c67b17c163c13640
#22028https://github.com/nodejs/node/pull/22028
v8/v8@ba752eahttps://github.com/v8/v8/commit/ba752ea4c50713dff1e94f45a79db3ba968a8d66
#22677https://github.com/nodejs/node/pull/22677
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22677
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22677/files/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22677/files/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/22677/files/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
https://github.com/mihalskiy
mihalskiy https://github.com/mihalskiy
https://github.com/nodejs/node/pull/22677/files/d8b470a475e795b574bfc8c0c9f7bca03c2a22aa
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
regression https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/22677
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/apapirovski
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/mihalskiy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.