René's URL Explorer Experiment


Title: net: port isIPv6() to JS by starkwang · Pull Request #22673 · nodejs/node · GitHub

Open Graph Title: net: port isIPv6() to JS by starkwang · Pull Request #22673 · nodejs/node

X Title: net: port isIPv6() to JS by starkwang · Pull Request #22673 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Porting isIPv6() to JS makes it 10%-250% faster in most cases and reduces some C++ code. This change also adds tests for some edge cases. Checklist make -j4 test (UNIX), or vcbuild test (Window...

X Description: Porting isIPv6() to JS makes it 10%-250% faster in most cases and reduces some C++ code. This change also adds tests for some edge cases. Checklist make -j4 test (UNIX), or vcbuild test (Window...

Opengraph URL: https://github.com/nodejs/node/pull/22673

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cff468e0-40ce-fffd-cd9f-bd9dc3598011
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA98:1E8EEE:472583:5A7556:6992171E
html-safe-nonce1024f9e84d2b39684b2ea158b5dcdbb9fc64a4e5ef56b57e33d28b008fefaf6b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTk4OjFFOEVFRTo0NzI1ODM6NUE3NTU2OjY5OTIxNzFFIiwidmlzaXRvcl9pZCI6IjkxODM1MzQ2NTIzNDgyMjk0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2e876c792f507ef6a82b1aec570ec4e49c26edb2ff089d4da49e880468766f45
hovercard-subject-tagpull_request:212735010
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22673/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c124d207c58246c467f109375dec37a8e49be39043c1962807355303b771a8b/nodejs/node/pull/22673
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c124d207c58246c467f109375dec37a8e49be39043c1962807355303b771a8b/nodejs/node/pull/22673
og:image:altPorting isIPv6() to JS makes it 10%-250% faster in most cases and reduces some C++ code. This change also adds tests for some edge cases. Checklist make -j4 test (UNIX), or vcbuild test (Window...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestarkwang
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22673#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22673
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22673
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22673
Reloadhttps://github.com/nodejs/node/pull/22673
Reloadhttps://github.com/nodejs/node/pull/22673
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22673
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
starkwanghttps://github.com/starkwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
starkwang:net-port-isipv6https://github.com/starkwang/node/tree/net-port-isipv6
Conversationhttps://github.com/nodejs/node/pull/22673
Commits2 (2)https://github.com/nodejs/node/pull/22673/commits
Checkshttps://github.com/nodejs/node/pull/22673/checks
Files changedhttps://github.com/nodejs/node/pull/22673/files
net: port isIPv6() to JShttps://github.com/nodejs/node/pull/22673#top
starkwanghttps://github.com/starkwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
starkwang:net-port-isipv6https://github.com/starkwang/node/tree/net-port-isipv6
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Sep 3, 2018https://github.com/nodejs/node/pull/22673#issue-356488152
Please reload this pagehttps://github.com/nodejs/node/pull/22673
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/starkwang
net: port isIPv6 to JShttps://github.com/nodejs/node/pull/22673/commits/0c1e1049e300221019f91482469c6c00f7524353
0c1e104https://github.com/nodejs/node/pull/22673/commits/0c1e1049e300221019f91482469c6c00f7524353
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 3, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418102279
@starkwanghttps://github.com/starkwang
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/781/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/781/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Sep 3, 2018https://github.com/nodejs/node/pull/22673#event-1823419637
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Sep 3, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418103464
https://ci.nodejs.org/job/node-test-pull-request/16986/https://ci.nodejs.org/job/node-test-pull-request/16986/
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 3, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418103922
Please reload this pagehttps://github.com/nodejs/node/pull/22673
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 3, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418171354
https://github.com/sindresorhus/ip-regex/blob/master/test.jshttps://github.com/sindresorhus/ip-regex/blob/master/test.js
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 4, 2018 https://github.com/nodejs/node/pull/22673#pullrequestreview-152141457
View reviewed changes https://github.com/nodejs/node/pull/22673/files/0c1e1049e300221019f91482469c6c00f7524353
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 4, 2018 https://github.com/nodejs/node/pull/22673#pullrequestreview-152161020
View reviewed changes https://github.com/nodejs/node/pull/22673/files/0c1e1049e300221019f91482469c6c00f7524353
mscdexhttps://github.com/mscdex
https://github.com/nodejs/node/pull/22673#pullrequestreview-152161020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/starkwang
add more tests for isiphttps://github.com/nodejs/node/pull/22673/commits/618fbcc44bc1d9d0d6e07390e687f32aecf132f9
618fbcchttps://github.com/nodejs/node/pull/22673/commits/618fbcc44bc1d9d0d6e07390e687f32aecf132f9
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Sep 4, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418453942
https://github.com/sindresorhus/ip-regex/blob/master/test.jshttps://github.com/sindresorhus/ip-regex/blob/master/test.js
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 4, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418455267
Please reload this pagehttps://github.com/nodejs/node/pull/22673
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 4, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418530606
Please reload this pagehttps://github.com/nodejs/node/pull/22673
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/mscdex
mscdexhttps://github.com/mscdex
stale reviewhttps://github.com/nodejs/node/pull/22673#pullrequestreview-152161020
September 4, 2018 21:55https://github.com/nodejs/node/pull/22673#event-1826432349
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 5, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418558337
https://ci.nodejs.org/job/node-test-commit/21225/https://ci.nodejs.org/job/node-test-commit/21225/
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 5, 2018 https://github.com/nodejs/node/pull/22673#pullrequestreview-152301954
View reviewed changes https://github.com/nodejs/node/pull/22673/files/618fbcc44bc1d9d0d6e07390e687f32aecf132f9
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 5, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418562909
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 5, 2018https://github.com/nodejs/node/pull/22673#event-1826638209
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Sep 5, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418563086
Please reload this pagehttps://github.com/nodejs/node/pull/22673
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 5, 2018 https://github.com/nodejs/node/pull/22673#pullrequestreview-152604730
View reviewed changes https://github.com/nodejs/node/pull/22673/files/618fbcc44bc1d9d0d6e07390e687f32aecf132f9
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 5, 2018https://github.com/nodejs/node/pull/22673#issuecomment-418820106
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Sep 6, 2018https://github.com/nodejs/node/pull/22673#issuecomment-419115403
Please reload this pagehttps://github.com/nodejs/node/pull/22673
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 6, 2018https://github.com/nodejs/node/pull/22673#issuecomment-419152277
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 6, 2018https://github.com/nodejs/node/pull/22673#issuecomment-419256805
Please reload this pagehttps://github.com/nodejs/node/pull/22673
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 6, 2018https://github.com/nodejs/node/pull/22673#issuecomment-419257966
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 6, 2018https://github.com/nodejs/node/pull/22673#issuecomment-419277257
Please reload this pagehttps://github.com/nodejs/node/pull/22673
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Sep 11, 2018https://github.com/nodejs/node/pull/22673#issuecomment-420150912
https://ci.nodejs.org/job/node-test-pull-request/17113/https://ci.nodejs.org/job/node-test-pull-request/17113/
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Sep 11, 2018https://github.com/nodejs/node/pull/22673#issuecomment-420200480
8e73594https://github.com/nodejs/node/commit/8e73594a5c82de26ebc0b1daedb20b6d3053dd4b
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Sep 11, 2018https://github.com/nodejs/node/pull/22673#event-1837974952
starkwanghttps://github.com/starkwang
Sep 11, 2018 https://github.com/nodejs/node/pull/22673#ref-commit-8e73594
https://github.com/starkwang
net: port isIPv6 to JShttps://github.com/nodejs/node/commit/8e73594a5c82de26ebc0b1daedb20b6d3053dd4b
8e73594https://github.com/nodejs/node/commit/8e73594a5c82de26ebc0b1daedb20b6d3053dd4b
#22673https://github.com/nodejs/node/pull/22673
targoshttps://github.com/targos
Sep 11, 2018 https://github.com/nodejs/node/pull/22673#ref-commit-4e3f1ae
https://github.com/starkwang
https://github.com/targos
net: port isIPv6 to JShttps://github.com/nodejs/node/commit/4e3f1aef8d3dce68781cc41969e0152c6360b47b
4e3f1aehttps://github.com/nodejs/node/commit/4e3f1aef8d3dce68781cc41969e0152c6360b47b
#22673https://github.com/nodejs/node/pull/22673
https://github.com/targos
targoshttps://github.com/targos
Sep 18, 2018 https://github.com/nodejs/node/pull/22673#ref-pullrequest-361312666
Release proposal: v10.11.0 #22932 https://github.com/nodejs/node/pull/22932
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22673
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22673/files/0c1e1049e300221019f91482469c6c00f7524353
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/22673/files/618fbcc44bc1d9d0d6e07390e687f32aecf132f9
https://github.com/silverwind
silverwind https://github.com/silverwind
https://github.com/nodejs/node/pull/22673/files/618fbcc44bc1d9d0d6e07390e687f32aecf132f9
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/22673/files/0c1e1049e300221019f91482469c6c00f7524353
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/22673
https://github.com/starkwang
https://github.com/nodejs-github-bot
https://github.com/mscdex
https://github.com/silverwind
https://github.com/BridgeAR
https://github.com/richardlau
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.