René's URL Explorer Experiment


Title: src: remove calls to deprecated V8 functions (Equals) by targos · Pull Request #22665 · nodejs/node · GitHub

Open Graph Title: src: remove calls to deprecated V8 functions (Equals) by targos · Pull Request #22665 · nodejs/node

X Title: src: remove calls to deprecated V8 functions (Equals) by targos · Pull Request #22665 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Remove all calls to deprecated V8 functions (here: String::Equals) inside the code. @addaleax @ryzokuken @jasnell Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message...

X Description: Remove all calls to deprecated V8 functions (here: String::Equals) inside the code. @addaleax @ryzokuken @jasnell Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message...

Opengraph URL: https://github.com/nodejs/node/pull/22665

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4fe56839-b98d-fb83-0284-012e78ade47f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8522:9376:253C690:2F8D7C6:6991B55C
html-safe-nonce171d45767630473b0940580c8346a90358bdeab189a9dd64ed7f99dac8508cf7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTIyOjkzNzY6MjUzQzY5MDoyRjhEN0M2OjY5OTFCNTVDIiwidmlzaXRvcl9pZCI6IjU0ODQwODU4NzYyMTU2MjUwNTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7abbc1355f9159ea2e78a65491babcc726eddb5ad5a2bc5af57d72def271d030
hovercard-subject-tagpull_request:212605028
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22665/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c5c307aac2e6271344eb43c193bdc8268fcdd29a2124cf271e983210963a7a9/nodejs/node/pull/22665
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c5c307aac2e6271344eb43c193bdc8268fcdd29a2124cf271e983210963a7a9/nodejs/node/pull/22665
og:image:altRemove all calls to deprecated V8 functions (here: String::Equals) inside the code. @addaleax @ryzokuken @jasnell Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametargos
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22665#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22665
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22665
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22665
Reloadhttps://github.com/nodejs/node/pull/22665
Reloadhttps://github.com/nodejs/node/pull/22665
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22665
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
targoshttps://github.com/targos
nodejs:masterhttps://github.com/nodejs/node/tree/master
targos:deprecated-equalshttps://github.com/targos/node/tree/deprecated-equals
Conversationhttps://github.com/nodejs/node/pull/22665
Commits1 (1)https://github.com/nodejs/node/pull/22665/commits
Checkshttps://github.com/nodejs/node/pull/22665/checks
Files changedhttps://github.com/nodejs/node/pull/22665/files
src: remove calls to deprecated V8 functions (Equals)https://github.com/nodejs/node/pull/22665#top
targoshttps://github.com/targos
nodejs:masterhttps://github.com/nodejs/node/tree/master
targos:deprecated-equalshttps://github.com/targos/node/tree/deprecated-equals
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22665#issue-356302668
@addaleaxhttps://github.com/addaleax
@ryzokukenhttps://github.com/ryzokuken
@jasnellhttps://github.com/jasnell
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22665
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 2, 2018https://github.com/nodejs/node/pull/22665#issuecomment-417949223
@targoshttps://github.com/targos
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/777/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/777/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22665
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Sep 2, 2018https://github.com/nodejs/node/pull/22665#event-1822342926
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22665#issuecomment-417949447
Please reload this pagehttps://github.com/nodejs/node/pull/22665
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22665#issuecomment-417950694
Please reload this pagehttps://github.com/nodejs/node/pull/22665
https://github.com/targos
src: remove calls to deprecated V8 functions (Equals)https://github.com/nodejs/node/pull/22665/commits/9a76224f49f68427ed8ac80333d9188f8b8540e7
9a76224https://github.com/nodejs/node/pull/22665/commits/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/a6b1c93a852cd831e2fa14d059a1443eeb43bee6..9a76224f49f68427ed8ac80333d9188f8b8540e7
a6b1c93https://github.com/nodejs/node/commit/a6b1c93a852cd831e2fa14d059a1443eeb43bee6
9a76224https://github.com/nodejs/node/commit/9a76224f49f68427ed8ac80333d9188f8b8540e7
Compare https://github.com/nodejs/node/compare/a6b1c93a852cd831e2fa14d059a1443eeb43bee6..9a76224f49f68427ed8ac80333d9188f8b8540e7
September 2, 2018 18:40https://github.com/nodejs/node/pull/22665#event-1822349566
https://github.com/targos
targoshttps://github.com/targos
Sep 2, 2018https://github.com/nodejs/node/pull/22665#issuecomment-417950973
Please reload this pagehttps://github.com/nodejs/node/pull/22665
https://ci.nodejs.org/job/node-test-pull-request/16969/https://ci.nodejs.org/job/node-test-pull-request/16969/
Please reload this pagehttps://github.com/nodejs/node/pull/22665
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/22665#pullrequestreview-151630001
View reviewed changes https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 3, 2018 https://github.com/nodejs/node/pull/22665#pullrequestreview-151659942
View reviewed changes https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Sep 3, 2018 https://github.com/nodejs/node/pull/22665#pullrequestreview-151738777
View reviewed changes https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 3, 2018 https://github.com/nodejs/node/pull/22665#pullrequestreview-151792176
View reviewed changes https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 4, 2018 https://github.com/nodejs/node/pull/22665#pullrequestreview-152137100
View reviewed changes https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 5, 2018https://github.com/nodejs/node/pull/22665#event-1826597445
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 5, 2018 https://github.com/nodejs/node/pull/22665#pullrequestreview-152296208
View reviewed changes https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22665#ref-commit-0740394
https://github.com/targos
src: remove calls to deprecated V8 functions (Equals)https://github.com/targos/node/commit/0740394269a5c17402686ffe8b66adc5095c7079
0740394https://github.com/targos/node/commit/0740394269a5c17402686ffe8b66adc5095c7079
nodejs#22665https://github.com/nodejs/node/pull/22665
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018https://github.com/nodejs/node/pull/22665#issuecomment-418707066
0740394https://github.com/nodejs/node/commit/0740394269a5c17402686ffe8b66adc5095c7079
Please reload this pagehttps://github.com/nodejs/node/pull/22665
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018https://github.com/nodejs/node/pull/22665#event-1827656427
https://github.com/targos
targoshttps://github.com/targos
September 5, 2018 12:09https://github.com/nodejs/node/pull/22665#event-1827656556
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22665#ref-commit-1025868
https://github.com/targos
src: remove calls to deprecated V8 functions (Equals)https://github.com/nodejs/node/commit/1025868d5c40796d6b342583625ba0c986172f33
1025868https://github.com/nodejs/node/commit/1025868d5c40796d6b342583625ba0c986172f33
#22665https://github.com/nodejs/node/pull/22665
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22665#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22665#ref-commit-dd8e007
https://github.com/targos
src: remove calls to deprecated V8 functions (Equals)https://github.com/nodejs/node/commit/dd8e0075b77eb370d0a053bc00c923cf5cef2220
dd8e007https://github.com/nodejs/node/commit/dd8e0075b77eb370d0a053bc00c923cf5cef2220
#22665https://github.com/nodejs/node/pull/22665
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22665
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/22665/files/9a76224f49f68427ed8ac80333d9188f8b8540e7
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Please reload this pagehttps://github.com/nodejs/node/pull/22665
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/danbev
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/ryzokuken
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.