| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:06c74fa0-0066-33e2-661d-9520b039e858 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC06:1C043A:13EC1FE:19FA447:699086B3 |
| html-safe-nonce | 13d23e5a13080016a0d615497645d851561b455057440b0b573a8211aa5909b8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzA2OjFDMDQzQToxM0VDMUZFOjE5RkE0NDc6Njk5MDg2QjMiLCJ2aXNpdG9yX2lkIjoiMzUzNTYzNTEzMTU4NTgyNDQzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fbebc47cf9e3fbe72db17073d43e320a7b4ab7ec12abdebd3bf9e7bba01367d6 |
| hovercard-subject-tag | pull_request:212600480 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22662/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e09addbeb5c9d04730950b4a79708899d2262f02a423e9b2b4e0aadd95e9fe40/nodejs/node/pull/22662 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e09addbeb5c9d04730950b4a79708899d2262f02a423e9b2b4e0aadd95e9fe40/nodejs/node/pull/22662 |
| og:image:alt | Remove all calls to deprecated V8 functions (here: Value::Int32Value)
inside the code.
/cc @ryzokuken @addaleax @jasnell
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22662#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22662 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22662 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22662 |
| Reload | https://github.com/nodejs/node/pull/22662 |
| Reload | https://github.com/nodejs/node/pull/22662 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22662 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:deprecated-int32value | https://github.com/targos/node/tree/deprecated-int32value |
| Conversation | https://github.com/nodejs/node/pull/22662 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22662/commits |
| Checks | https://github.com/nodejs/node/pull/22662/checks |
| Files changed | https://github.com/nodejs/node/pull/22662/files |
| src: remove calls to deprecated V8 functions (Int32Value) | https://github.com/nodejs/node/pull/22662#top |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:deprecated-int32value | https://github.com/targos/node/tree/deprecated-int32value |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22662#issue-356295073 |
| @ryzokuken | https://github.com/ryzokuken |
| @addaleax | https://github.com/addaleax |
| @jasnell | https://github.com/jasnell |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22662 |
|
| https://github.com/targos |
| src: remove calls to deprecated V8 functions (Int32Value) | https://github.com/nodejs/node/pull/22662/commits/46cb10d9af2488d150464fb741de3541d802920d |
| 46cb10d | https://github.com/nodejs/node/pull/22662/commits/46cb10d9af2488d150464fb741de3541d802920d |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22662#issuecomment-417942231 |
| @targos | https://github.com/targos |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/775/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/775/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22662 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22662#event-1822307668 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22662#pullrequestreview-151626351 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22662/files/46cb10d9af2488d150464fb741de3541d802920d |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22662#issuecomment-417943209 |
| Please reload this page | https://github.com/nodejs/node/pull/22662 |
| https://ci.nodejs.org/job/node-test-pull-request/16962/ | https://ci.nodejs.org/job/node-test-pull-request/16962/ |
| Please reload this page | https://github.com/nodejs/node/pull/22662 |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22662#pullrequestreview-151644088 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22662/files/46cb10d9af2488d150464fb741de3541d802920d |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22662#pullrequestreview-152136044 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22662/files/46cb10d9af2488d150464fb741de3541d802920d |
| https://github.com/ryzokuken |
| ryzokuken | https://github.com/ryzokuken |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22662#pullrequestreview-152211313 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22662/files/46cb10d9af2488d150464fb741de3541d802920d |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22662#event-1826596806 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22662#issuecomment-418691144 |
| 594a84d | https://github.com/nodejs/node/commit/594a84d8f2cb3c630744487d02dbcff05675d6cf |
| Please reload this page | https://github.com/nodejs/node/pull/22662 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22662#event-1827531594 |
| danbev | https://github.com/danbev |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22662#ref-commit-594a84d |
|
| https://github.com/targos |
|
| https://github.com/danbev |
| src: remove calls to deprecated V8 functions (Int32Value) | https://github.com/nodejs/node/commit/594a84d8f2cb3c630744487d02dbcff05675d6cf |
| 594a84d | https://github.com/nodejs/node/commit/594a84d8f2cb3c630744487d02dbcff05675d6cf |
| #22662 | https://github.com/nodejs/node/pull/22662 |
| https://github.com/targos |
| targos | https://github.com/targos |
| September 5, 2018 11:14 | https://github.com/nodejs/node/pull/22662#event-1827548455 |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22662#ref-commit-b1e5491 |
|
| https://github.com/targos |
| src: remove calls to deprecated V8 functions (Int32Value) | https://github.com/nodejs/node/commit/b1e5491ae98e71abfdc0c0c8c53f2c5fe3a0c9b8 |
| b1e5491 | https://github.com/nodejs/node/commit/b1e5491ae98e71abfdc0c0c8c53f2c5fe3a0c9b8 |
| #22662 | https://github.com/nodejs/node/pull/22662 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22662#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
| targos | https://github.com/targos |
|
Sep 6, 2018
| https://github.com/nodejs/node/pull/22662#ref-commit-416cfea |
|
| https://github.com/targos |
| src: remove calls to deprecated V8 functions (Int32Value) | https://github.com/nodejs/node/commit/416cfeae140029da80c8de33c8d0ad888d369639 |
| 416cfea | https://github.com/nodejs/node/commit/416cfeae140029da80c8de33c8d0ad888d369639 |
| #22662 | https://github.com/nodejs/node/pull/22662 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22662 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22662/files/46cb10d9af2488d150464fb741de3541d802920d |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22662/files/46cb10d9af2488d150464fb741de3541d802920d |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/22662/files/46cb10d9af2488d150464fb741de3541d802920d |
|
| https://github.com/ryzokuken |
|
ryzokuken
| https://github.com/ryzokuken |
|
| https://github.com/nodejs/node/pull/22662/files/46cb10d9af2488d150464fb741de3541d802920d |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/22662 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/JungMinu |
|
| https://github.com/ryzokuken |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |