| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ab28d82a-4666-38e4-5f51-8426da5dedc2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8988:1C3C8A:E8EDDA:126E82B:69915215 |
| html-safe-nonce | 6c726f7c571c3c1d6e7416b9b55dff758bfe74475975c1d0c969cd96abb18f1e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTg4OjFDM0M4QTpFOEVEREE6MTI2RTgyQjo2OTkxNTIxNSIsInZpc2l0b3JfaWQiOiIzMTYwNTc3MzY1ODY1NzQ2OTY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c642eb65be4c02b1c9639802d449d2e5497deb4fd3e7c07c0b975ec9b9cf88e2 |
| hovercard-subject-tag | pull_request:212599192 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22659/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/783fdf9d8959a64af83032da9c4f97c75e400c147e00deec81a6a74a20509e3a/nodejs/node/pull/22659 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/783fdf9d8959a64af83032da9c4f97c75e400c147e00deec81a6a74a20509e3a/nodejs/node/pull/22659 |
| og:image:alt | Using the same filename for different async tests could lead
to race conditions.
Example failure: https://travis-ci.com/nodejs/node/jobs/143351655
Refs: #22150
Checklist
make -j4 test (UNIX), o... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22659#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22659 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22659 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22659 |
| Reload | https://github.com/nodejs/node/pull/22659 |
| Reload | https://github.com/nodejs/node/pull/22659 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:fix-flaky-fs-write-file-typedarrays | https://github.com/addaleax/node/tree/fix-flaky-fs-write-file-typedarrays |
| Conversation | https://github.com/nodejs/node/pull/22659 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22659/commits |
| Checks | https://github.com/nodejs/node/pull/22659/checks |
| Files changed | https://github.com/nodejs/node/pull/22659/files |
| test: fix flaky parallel/test-fs-write-file-typedarrays | https://github.com/nodejs/node/pull/22659#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:fix-flaky-fs-write-file-typedarrays | https://github.com/addaleax/node/tree/fix-flaky-fs-write-file-typedarrays |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22659#issue-356292917 |
| https://travis-ci.com/nodejs/node/jobs/143351655 | https://travis-ci.com/nodejs/node/jobs/143351655 |
| #22150 | https://github.com/nodejs/node/pull/22150 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
|
| https://github.com/addaleax |
| test: fix flaky parallel/test-fs-write-file-typedarrays | https://github.com/nodejs/node/pull/22659/commits/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7 |
| 40b718f | https://github.com/nodejs/node/pull/22659/commits/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7 |
| https://travis-ci.com/nodejs/node/jobs/143351655 | https://travis-ci.com/nodejs/node/jobs/143351655 |
| nodejs#22150 | https://github.com/nodejs/node/pull/22150 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22659#issuecomment-417940206 |
| @addaleax | https://github.com/addaleax |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/773/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/773/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22659#event-1822297823 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22659#event-1822297870 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22659#pullrequestreview-151625843 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22659/files/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22659#event-1822304082 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22659#issuecomment-417941870 |
| https://ci.nodejs.org/job/node-test-pull-request/16960/ | https://ci.nodejs.org/job/node-test-pull-request/16960/ |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22659#event-1822305934 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22659#pullrequestreview-151630566 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22659/files/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22659#pullrequestreview-151634581 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22659/files/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22659#issuecomment-417964159 |
| https://ci.nodejs.org/job/node-test-pull-request/16976/ | https://ci.nodejs.org/job/node-test-pull-request/16976/ |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| Sep 3, 2018 | https://github.com/nodejs/node/pull/22659#issuecomment-418006996 |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
| https://ci.nodejs.org/job/node-test-pull-request/16978/ | https://ci.nodejs.org/job/node-test-pull-request/16978/ |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 3, 2018 | https://github.com/nodejs/node/pull/22659#issuecomment-418099608 |
| @lundibundi | https://github.com/lundibundi |
| #22628 (comment) | https://github.com/nodejs/node/issues/22628#issuecomment-417946830 |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 3, 2018 | https://github.com/nodejs/node/pull/22659#issuecomment-418099949 |
| ba43bce | https://github.com/nodejs/node/commit/ba43bce9e2383d445b9e669b34576ec4982d3f0d |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 3, 2018 | https://github.com/nodejs/node/pull/22659#event-1823399194 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| September 3, 2018 12:23 | https://github.com/nodejs/node/pull/22659#event-1823399395 |
| addaleax | https://github.com/addaleax |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22659#ref-commit-ba43bce |
|
| https://github.com/addaleax |
| test: fix flaky parallel/test-fs-write-file-typedarrays | https://github.com/nodejs/node/commit/ba43bce9e2383d445b9e669b34576ec4982d3f0d |
| ba43bce | https://github.com/nodejs/node/commit/ba43bce9e2383d445b9e669b34576ec4982d3f0d |
| https://travis-ci.com/nodejs/node/jobs/143351655 | https://travis-ci.com/nodejs/node/jobs/143351655 |
| #22150 | https://github.com/nodejs/node/pull/22150 |
| #22659 | https://github.com/nodejs/node/pull/22659 |
| targos | https://github.com/targos |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22659#ref-commit-cb15017 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| test: fix flaky parallel/test-fs-write-file-typedarrays | https://github.com/nodejs/node/commit/cb15017bfef21022b84acb212be238217662d331 |
| cb15017 | https://github.com/nodejs/node/commit/cb15017bfef21022b84acb212be238217662d331 |
| https://travis-ci.com/nodejs/node/jobs/143351655 | https://travis-ci.com/nodejs/node/jobs/143351655 |
| #22150 | https://github.com/nodejs/node/pull/22150 |
| #22659 | https://github.com/nodejs/node/pull/22659 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22659#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
| targos | https://github.com/targos |
|
Sep 6, 2018
| https://github.com/nodejs/node/pull/22659#ref-commit-8efbda0 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| test: fix flaky parallel/test-fs-write-file-typedarrays | https://github.com/nodejs/node/commit/8efbda05f191e80ac6f2d805f05e244031f8c2f3 |
| 8efbda0 | https://github.com/nodejs/node/commit/8efbda05f191e80ac6f2d805f05e244031f8c2f3 |
| https://travis-ci.com/nodejs/node/jobs/143351655 | https://travis-ci.com/nodejs/node/jobs/143351655 |
| #22150 | https://github.com/nodejs/node/pull/22150 |
| #22659 | https://github.com/nodejs/node/pull/22659 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22659 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/22659/files/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/22659/files/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/22659/files/40b718f48bf3ee8dca4a66f3629eaa7f975e86f7 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/22659 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lundibundi |
|
| https://github.com/Trott |
|
| https://github.com/targos |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |