René's URL Explorer Experiment


Title: src: fix node::FatalException by tniessen · Pull Request #22654 · nodejs/node · GitHub

Open Graph Title: src: fix node::FatalException by tniessen · Pull Request #22654 · nodejs/node

X Title: src: fix node::FatalException by tniessen · Pull Request #22654 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If a fatal exception occurs before node had a chance to setup the handler in JS properly, node::FatalException crashes with FATAL ERROR: v8::Function::Cast Could not convert to function This fixes...

X Description: If a fatal exception occurs before node had a chance to setup the handler in JS properly, node::FatalException crashes with FATAL ERROR: v8::Function::Cast Could not convert to function This fixes...

Opengraph URL: https://github.com/nodejs/node/pull/22654

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7587089c-b684-85c0-3c15-1bfe28e81569
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8874:19BFE5:16D7EE0:1D85A90:699086B4
html-safe-noncea47e9236845411c3537face396fbaff7f3938385047c39b32099d76fc622d013
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODc0OjE5QkZFNToxNkQ3RUUwOjFEODVBOTA6Njk5MDg2QjQiLCJ2aXNpdG9yX2lkIjoiMTAzMTI5ODU4ODM0NDY2NDg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca2cc4b5a0d137f02eccfed57f6d8f5b5caa839ee4495b73d3ce253c0875c1b02
hovercard-subject-tagpull_request:212592208
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22654/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cfa1c09954390751c259a66068120d896b2ec8258abea81b1b5e62c73f83a0cf/nodejs/node/pull/22654
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cfa1c09954390751c259a66068120d896b2ec8258abea81b1b5e62c73f83a0cf/nodejs/node/pull/22654
og:image:altIf a fatal exception occurs before node had a chance to setup the handler in JS properly, node::FatalException crashes with FATAL ERROR: v8::Function::Cast Could not convert to function This fixes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22654#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22654
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22654
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22654
Reloadhttps://github.com/nodejs/node/pull/22654
Reloadhttps://github.com/nodejs/node/pull/22654
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22654
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:src-fix-fatalexceptionhttps://github.com/tniessen/node/tree/src-fix-fatalexception
Conversationhttps://github.com/nodejs/node/pull/22654
Commits1 (1)https://github.com/nodejs/node/pull/22654/commits
Checkshttps://github.com/nodejs/node/pull/22654/checks
Files changedhttps://github.com/nodejs/node/pull/22654/files
src: fix node::FatalExceptionhttps://github.com/nodejs/node/pull/22654#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:src-fix-fatalexceptionhttps://github.com/tniessen/node/tree/src-fix-fatalexception
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 2, 2018https://github.com/nodejs/node/pull/22654#issue-356281546
@addaleaxhttps://github.com/addaleax
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://github.com/tniessen
src: fix node::FatalExceptionhttps://github.com/nodejs/node/pull/22654/commits/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
3fdf2d0https://github.com/nodejs/node/pull/22654/commits/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 2, 2018https://github.com/nodejs/node/pull/22654#issuecomment-417930031
@tniessenhttps://github.com/tniessen
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/768/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/768/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Sep 2, 2018https://github.com/nodejs/node/pull/22654#event-1822245249
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 2, 2018 https://github.com/nodejs/node/pull/22654#pullrequestreview-151620738
View reviewed changes https://github.com/nodejs/node/pull/22654/files/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/22654#pullrequestreview-151620915
View reviewed changes https://github.com/nodejs/node/pull/22654/files/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/22654#pullrequestreview-151620915
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 2, 2018 https://github.com/nodejs/node/pull/22654#pullrequestreview-151621524
View reviewed changes https://github.com/nodejs/node/pull/22654/files/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 2, 2018https://github.com/nodejs/node/pull/22654#event-1822257049
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22654#issuecomment-417932289
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://ci.nodejs.org/job/node-test-pull-request/16948/https://ci.nodejs.org/job/node-test-pull-request/16948/
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 2, 2018 https://github.com/nodejs/node/pull/22654#pullrequestreview-151622023
View reviewed changes https://github.com/nodejs/node/pull/22654/files/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
lundibundihttps://github.com/lundibundi
https://github.com/nodejs/node/pull/22654#pullrequestreview-151622023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22654#issuecomment-417944143
https://ci.nodejs.org/job/node-test-pull-request/16964/https://ci.nodejs.org/job/node-test-pull-request/16964/
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22654#issuecomment-417948878
b797103https://github.com/nodejs/node/commit/b797103e2635bc059a7d5b6ed4fcc0a771a61432
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22654#event-1822341026
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/22654#ref-commit-b797103
https://github.com/tniessen
https://github.com/addaleax
src: fix node::FatalExceptionhttps://github.com/nodejs/node/commit/b797103e2635bc059a7d5b6ed4fcc0a771a61432
b797103https://github.com/nodejs/node/commit/b797103e2635bc059a7d5b6ed4fcc0a771a61432
#22654https://github.com/nodejs/node/pull/22654
targoshttps://github.com/targos
Sep 2, 2018 https://github.com/nodejs/node/pull/22654#ref-commit-280070f
https://github.com/tniessen
https://github.com/targos
src: fix node::FatalExceptionhttps://github.com/nodejs/node/commit/280070f242e16d2651821c0346f107286c05a5c6
280070fhttps://github.com/nodejs/node/commit/280070f242e16d2651821c0346f107286c05a5c6
#22654https://github.com/nodejs/node/pull/22654
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22654#ref-commit-8930268
https://github.com/tniessen
https://github.com/targos
src: fix node::FatalExceptionhttps://github.com/nodejs/node/commit/893026838279b846330a347a352c451f7bca7ac4
8930268https://github.com/nodejs/node/commit/893026838279b846330a347a352c451f7bca7ac4
#22654https://github.com/nodejs/node/pull/22654
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22654#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22654#ref-commit-6924d3d
https://github.com/tniessen
https://github.com/targos
src: fix node::FatalExceptionhttps://github.com/nodejs/node/commit/6924d3dcb91e11fc5cfd03d2c80037f1d30bbbdb
6924d3dhttps://github.com/nodejs/node/commit/6924d3dcb91e11fc5cfd03d2c80037f1d30bbbdb
#22654https://github.com/nodejs/node/pull/22654
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 12, 2018https://github.com/nodejs/node/pull/22654#event-1842135612
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22654
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22654/files/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22654/files/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/22654/files/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/22654/files/3fdf2d09ecd228a9c8e08a639cfa6ab655ff2841
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/22654
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/lundibundi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.