| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4de49ecd-6ced-7241-9818-50ebd273bde0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C8AA:3457A:13F04:179CE:69911D38 |
| html-safe-nonce | e7ae6e631948b6bb6f040ce6a10bfc35595fd917ae39bf28c48969a731d89ad2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEFBOjM0NTdBOjEzRjA0OjE3OUNFOjY5OTExRDM4IiwidmlzaXRvcl9pZCI6IjM3MjkxMDY5MDI3MTEzNDQ0NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 29be345069be70d7650b9a3663b80d48a9d00a5a1fef79f31cff90360d875eeb |
| hovercard-subject-tag | pull_request:212587635 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22651/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9ef95f6ccf38a9f176c53a78ca3cd40323ceb9985da6e11c2c846b6dcc6677d0/nodejs/node/pull/22651 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9ef95f6ccf38a9f176c53a78ca3cd40323ceb9985da6e11c2c846b6dcc6677d0/nodejs/node/pull/22651 |
| og:image:alt | Don’t use network connections, we don’t need them and
they add more native objects into the mix when we care
about other kinds of native objects.
Run GC only once every 64 iterations – this cuts do... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22651#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22651 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22651 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22651 |
| Reload | https://github.com/nodejs/node/pull/22651 |
| Reload | https://github.com/nodejs/node/pull/22651 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:refactor-tls-gc | https://github.com/addaleax/node/tree/refactor-tls-gc |
| Conversation | https://github.com/nodejs/node/pull/22651 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22651/commits |
| Checks | https://github.com/nodejs/node/pull/22651/checks |
| Files changed | https://github.com/nodejs/node/pull/22651/files |
| test: refactor test-gc-tls-external-memory | https://github.com/nodejs/node/pull/22651#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:refactor-tls-gc | https://github.com/addaleax/node/tree/refactor-tls-gc |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22651#issue-356273837 |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22651#issuecomment-417923258 |
| @addaleax | https://github.com/addaleax |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/766/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/766/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22651#event-1822207621 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22651#event-1822207691 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22651#issuecomment-417928187 |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
|
| https://github.com/addaleax |
| test: refactor test-gc-tls-external-memory | https://github.com/nodejs/node/pull/22651/commits/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
| ddb45bd | https://github.com/nodejs/node/pull/22651/commits/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/e8250f6bded739d7ab728cde600e08cf20eb266b..ddb45bd631c941d9fb25283cead1adc7c1825e7a |
| e8250f6 | https://github.com/nodejs/node/commit/e8250f6bded739d7ab728cde600e08cf20eb266b |
| ddb45bd | https://github.com/nodejs/node/commit/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
|
Compare
| https://github.com/nodejs/node/compare/e8250f6bded739d7ab728cde600e08cf20eb266b..ddb45bd631c941d9fb25283cead1adc7c1825e7a |
| September 2, 2018 12:43 | https://github.com/nodejs/node/pull/22651#event-1822235701 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22651#issuecomment-417928263 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22651#pullrequestreview-151619885 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22651/files/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22651#issuecomment-417929024 |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
| https://ci.nodejs.org/job/node-test-pull-request/16943/ | https://ci.nodejs.org/job/node-test-pull-request/16943/ |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22651#event-1822239863 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22651#pullrequestreview-151634684 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22651/files/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
| https://github.com/gdams |
| gdams | https://github.com/gdams |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22651#pullrequestreview-152027677 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22651/files/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22651#pullrequestreview-152147612 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22651/files/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22651#issuecomment-418685770 |
| d4cdb2c | https://github.com/nodejs/node/commit/d4cdb2ce662e9521d0671058a0f129ccad3f7e03 |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22651#event-1827493225 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| September 5, 2018 10:45 | https://github.com/nodejs/node/pull/22651#event-1827493390 |
| addaleax | https://github.com/addaleax |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22651#ref-commit-d4cdb2c |
|
| https://github.com/addaleax |
| test: refactor test-gc-tls-external-memory | https://github.com/nodejs/node/commit/d4cdb2ce662e9521d0671058a0f129ccad3f7e03 |
| d4cdb2c | https://github.com/nodejs/node/commit/d4cdb2ce662e9521d0671058a0f129ccad3f7e03 |
| #22651 | https://github.com/nodejs/node/pull/22651 |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22651#ref-commit-dd772c1 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| test: refactor test-gc-tls-external-memory | https://github.com/nodejs/node/commit/dd772c1f131213df68524acfe115929ffb277a6d |
| dd772c1 | https://github.com/nodejs/node/commit/dd772c1f131213df68524acfe115929ffb277a6d |
| #22651 | https://github.com/nodejs/node/pull/22651 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22651#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
| targos | https://github.com/targos |
|
Sep 6, 2018
| https://github.com/nodejs/node/pull/22651#ref-commit-cb93719 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| test: refactor test-gc-tls-external-memory | https://github.com/nodejs/node/commit/cb9371963de9866f3409ada26c38d3aa0cc221a5 |
| cb93719 | https://github.com/nodejs/node/commit/cb9371963de9866f3409ada26c38d3aa0cc221a5 |
| #22651 | https://github.com/nodejs/node/pull/22651 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22651 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22651/files/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/22651/files/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/22651/files/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
|
| https://github.com/gdams |
|
gdams
| https://github.com/gdams |
|
| https://github.com/nodejs/node/pull/22651/files/ddb45bd631c941d9fb25283cead1adc7c1825e7a |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Please reload this page | https://github.com/nodejs/node/pull/22651 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/gdams |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |