| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:efe998a0-b7ee-e3ef-0a37-d6ff2dc489bb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 87AE:25A6BD:F11FB8:12F4B2B:699167FD |
| html-safe-nonce | 842f06c8ea4038db82c22ed9ec9fcb150d67cfdff4bd1b5e593a6a453f443b38 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0FFOjI1QTZCRDpGMTFGQjg6MTJGNEIyQjo2OTkxNjdGRCIsInZpc2l0b3JfaWQiOiI1MzM5MzQxMzUzOTMyMTY1MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6a4dd9131c79de38f3945a25be56446c5a6f5c48021579ffc24af3c130633134 |
| hovercard-subject-tag | pull_request:212533171 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22641/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0a41ff38d9a785fc86b0dca4d5afc93244d5779f1990cdfe8c07e77fe6abe0f4/nodejs/node/pull/22641 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0a41ff38d9a785fc86b0dca4d5afc93244d5779f1990cdfe8c07e77fe6abe0f4/nodejs/node/pull/22641 |
| og:image:alt | there are several places where v8 artifacts appear with scope resolution
operator inline with the source. Elevate them for improved readability
as well as to follow the convention.
Checklist
ma... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gireeshpunathil |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22641#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22641 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22641 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22641 |
| Reload | https://github.com/nodejs/node/pull/22641 |
| Reload | https://github.com/nodejs/node/pull/22641 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gireeshpunathil | https://github.com/gireeshpunathil |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gireeshpunathil:namespace | https://github.com/gireeshpunathil/node/tree/namespace |
| Conversation | https://github.com/nodejs/node/pull/22641 |
| Commits1 (1) | https://github.com/nodejs/node/pull/22641/commits |
| Checks | https://github.com/nodejs/node/pull/22641/checks |
| Files changed | https://github.com/nodejs/node/pull/22641/files |
| src: promote v8 name spaces with using | https://github.com/nodejs/node/pull/22641#top |
| gireeshpunathil | https://github.com/gireeshpunathil |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gireeshpunathil:namespace | https://github.com/gireeshpunathil/node/tree/namespace |
|
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22641#issue-356178317 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22641#issuecomment-417837998 |
| @gireeshpunathil | https://github.com/gireeshpunathil |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/759/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/759/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22641#event-1821785308 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 1, 2018
| https://github.com/nodejs/node/pull/22641#pullrequestreview-151587354 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22641/files |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 1, 2018
| https://github.com/nodejs/node/pull/22641#pullrequestreview-151590854 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22641/files |
| src/node.cc | https://github.com/nodejs/node/pull/22641/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| targos | https://github.com/targos |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22641#discussion_r214511147 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22641#discussion_r214514954 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 1, 2018
| https://github.com/nodejs/node/pull/22641#pullrequestreview-151591297 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22641/files |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| force-pushed | https://github.com/nodejs/node/compare/5862a74a49379e5c1f931d80ef0e734014f3e6b8..af280ad9021912f92e1f8235eb9c1799c79dc11b |
| 5862a74 | https://github.com/nodejs/node/commit/5862a74a49379e5c1f931d80ef0e734014f3e6b8 |
| af280ad | https://github.com/nodejs/node/commit/af280ad9021912f92e1f8235eb9c1799c79dc11b |
|
Compare
| https://github.com/nodejs/node/compare/5862a74a49379e5c1f931d80ef0e734014f3e6b8..af280ad9021912f92e1f8235eb9c1799c79dc11b |
| September 1, 2018 14:14 | https://github.com/nodejs/node/pull/22641#event-1821907327 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Sep 1, 2018
| https://github.com/nodejs/node/pull/22641#pullrequestreview-151596498 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22641/files |
| src/node.cc | https://github.com/nodejs/node/pull/22641/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| TimothyGu | https://github.com/TimothyGu |
| Sep 1, 2018 | https://github.com/nodejs/node/pull/22641#discussion_r214516654 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22641#discussion_r214530142 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 1, 2018
| https://github.com/nodejs/node/pull/22641#pullrequestreview-151599806 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22641/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 1, 2018
| https://github.com/nodejs/node/pull/22641#pullrequestreview-151602193 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22641/files |
|
| https://github.com/gireeshpunathil |
| src: promote v8 name spaces with using | https://github.com/nodejs/node/pull/22641/commits/b4ccad9c4340f50ef65394dc3d047acc20e87936 |
| b4ccad9 | https://github.com/nodejs/node/pull/22641/commits/b4ccad9c4340f50ef65394dc3d047acc20e87936 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| force-pushed | https://github.com/nodejs/node/compare/3e469e8ceb71f78a2594c576f95f2757f31140ec..b4ccad9c4340f50ef65394dc3d047acc20e87936 |
| 3e469e8 | https://github.com/nodejs/node/commit/3e469e8ceb71f78a2594c576f95f2757f31140ec |
| b4ccad9 | https://github.com/nodejs/node/commit/b4ccad9c4340f50ef65394dc3d047acc20e87936 |
|
Compare
| https://github.com/nodejs/node/compare/3e469e8ceb71f78a2594c576f95f2757f31140ec..b4ccad9c4340f50ef65394dc3d047acc20e87936 |
| September 2, 2018 06:36 | https://github.com/nodejs/node/pull/22641#event-1822131961 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Sep 3, 2018 | https://github.com/nodejs/node/pull/22641#issuecomment-418041722 |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| https://ci.nodejs.org/job/node-test-pull-request/16983/ | https://ci.nodejs.org/job/node-test-pull-request/16983/ |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22641#pullrequestreview-152136738 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22641/files/b4ccad9c4340f50ef65394dc3d047acc20e87936 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22641#issuecomment-418693363 |
| 31ca5dc | https://github.com/nodejs/node/commit/31ca5dc75a0d76d4aeee174e70e335e4ea7428ac |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22641#event-1827547649 |
| danbev | https://github.com/danbev |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22641#ref-commit-31ca5dc |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/danbev |
| src: promote v8 name spaces with using | https://github.com/nodejs/node/commit/31ca5dc75a0d76d4aeee174e70e335e4ea7428ac |
| 31ca5dc | https://github.com/nodejs/node/commit/31ca5dc75a0d76d4aeee174e70e335e4ea7428ac |
| #22641 | https://github.com/nodejs/node/pull/22641 |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22641#ref-commit-be86ddb |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/targos |
| src: promote v8 name spaces with using | https://github.com/nodejs/node/commit/be86ddb7ec3d812c60e8624a30e4af7b25d58432 |
| be86ddb | https://github.com/nodejs/node/commit/be86ddb7ec3d812c60e8624a30e4af7b25d58432 |
| #22641 | https://github.com/nodejs/node/pull/22641 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22641#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
| targos | https://github.com/targos |
|
Sep 6, 2018
| https://github.com/nodejs/node/pull/22641#ref-commit-8b3b973 |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/targos |
| src: promote v8 name spaces with using | https://github.com/nodejs/node/commit/8b3b973b2e3814c5cdf4ab905730466f400bc517 |
| 8b3b973 | https://github.com/nodejs/node/commit/8b3b973b2e3814c5cdf4ab905730466f400bc517 |
| #22641 | https://github.com/nodejs/node/pull/22641 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Nov 5, 2018
| https://github.com/nodejs/node/pull/22641#ref-issue-376657327 |
|
Bangalore, November 17th
nodejs/code-and-learn#88
| https://github.com/nodejs/code-and-learn/issues/88 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22641 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/22641/files/9ad384f6afb9f33800016ef7a086c30ac104adf0 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22641/files/b4ccad9c4340f50ef65394dc3d047acc20e87936 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22641/files/af280ad9021912f92e1f8235eb9c1799c79dc11b |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/22641/files/af280ad9021912f92e1f8235eb9c1799c79dc11b |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/22641/files/9ad384f6afb9f33800016ef7a086c30ac104adf0 |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/22641/files/af280ad9021912f92e1f8235eb9c1799c79dc11b |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/22641 |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/TimothyGu |
|
| https://github.com/targos |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |