| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ad9c19bf-5211-c62c-da7a-8573a4c3ed1e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 878C:1258FA:13463A5:1910D01:69908639 |
| html-safe-nonce | 8fbd4e0291f7b57b953e551a2c04df99aff81142c2c702e6d13e4d523b0019d2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzhDOjEyNThGQToxMzQ2M0E1OjE5MTBEMDE6Njk5MDg2MzkiLCJ2aXNpdG9yX2lkIjoiNzc3MTQwODAxNTc4NjI4MDUwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c1088e749ff36f3e6361c5c59cc5c0096234008426477796b9326b0e3c65890f |
| hovercard-subject-tag | pull_request:212103768 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22601/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/35d5d84407623ae1ed87056aff45ef9b476fc57c27f9d6137a99da6cc76d61fa/nodejs/node/pull/22601 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/35d5d84407623ae1ed87056aff45ef9b476fc57c27f9d6137a99da6cc76d61fa/nodejs/node/pull/22601 |
| og:image:alt | Parse const assert = module.exports = ok; as exporting a constructor
named assert.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rubys |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22601#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22601 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22601 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22601 |
| Reload | https://github.com/nodejs/node/pull/22601 |
| Reload | https://github.com/nodejs/node/pull/22601 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| rubys | https://github.com/rubys |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rubys:assert_src_links | https://github.com/rubys/node/tree/assert_src_links |
| Conversation | https://github.com/nodejs/node/pull/22601 |
| Commits2 (2) | https://github.com/nodejs/node/pull/22601/commits |
| Checks | https://github.com/nodejs/node/pull/22601/checks |
| Files changed | https://github.com/nodejs/node/pull/22601/files |
| tools: add [src] links to assert.html | https://github.com/nodejs/node/pull/22601#top |
| rubys | https://github.com/rubys |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rubys:assert_src_links | https://github.com/rubys/node/tree/assert_src_links |
|
| https://github.com/rubys |
| rubys | https://github.com/rubys |
| Aug 30, 2018 | https://github.com/nodejs/node/pull/22601#issue-355616672 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
|
| https://github.com/rubys |
| tools: add [src] links to assert.html | https://github.com/nodejs/node/pull/22601/commits/40e96e5aec1b88a7774afd29233474b36df5965f |
| 40e96e5 | https://github.com/nodejs/node/pull/22601/commits/40e96e5aec1b88a7774afd29233474b36df5965f |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 30, 2018 | https://github.com/nodejs/node/pull/22601#issuecomment-417343819 |
| @rubys | https://github.com/rubys |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/733/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/733/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Aug 30, 2018 | https://github.com/nodejs/node/pull/22601#event-1818396109 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 30, 2018
| https://github.com/nodejs/node/pull/22601#pullrequestreview-151106206 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22601/files/40e96e5aec1b88a7774afd29233474b36df5965f |
| test/fixtures/apilinks/reverse.json | https://github.com/nodejs/node/pull/22601/files/40e96e5aec1b88a7774afd29233474b36df5965f#diff-a89c745e436eaf4118e07738f05581a533dda494b0a1fe1c62416d3e4a42eddb |
| addaleax | https://github.com/addaleax |
| Aug 30, 2018 | https://github.com/nodejs/node/pull/22601#discussion_r214119752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
| rubys | https://github.com/rubys |
| Aug 30, 2018 | https://github.com/nodejs/node/pull/22601#discussion_r214123448 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
| addaleax | https://github.com/addaleax |
| Aug 30, 2018 | https://github.com/nodejs/node/pull/22601#discussion_r214123832 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
|
| https://github.com/rubys |
| [squashable] indirect and module reverse defintions | https://github.com/nodejs/node/pull/22601/commits/62fc53b4615a93490804101ad9da4d9a59c0a31e |
| 62fc53b | https://github.com/nodejs/node/pull/22601/commits/62fc53b4615a93490804101ad9da4d9a59c0a31e |
| https://github.com/rubys |
| rubys | https://github.com/rubys |
| Aug 30, 2018 | https://github.com/nodejs/node/pull/22601#issuecomment-417505560 |
| https://ci.nodejs.org/job/node-test-pull-request/16881/ | https://ci.nodejs.org/job/node-test-pull-request/16881/ |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 31, 2018
| https://github.com/nodejs/node/pull/22601#pullrequestreview-151404548 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22601/files/62fc53b4615a93490804101ad9da4d9a59c0a31e |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22601#event-1820650503 |
| rubys | https://github.com/rubys |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22601#ref-commit-5da1553 |
|
| https://github.com/rubys |
| tools: add [src] links to assert.html | https://github.com/rubys/node/commit/5da155398ef8645c76872c6db3114a3e796a80da |
| 5da1553 | https://github.com/rubys/node/commit/5da155398ef8645c76872c6db3114a3e796a80da |
| nodejs#22601 | https://github.com/nodejs/node/pull/22601 |
| https://github.com/rubys |
| rubys | https://github.com/rubys |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22601#issuecomment-417933817 |
| 5da1553 | https://github.com/nodejs/node/commit/5da155398ef8645c76872c6db3114a3e796a80da |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
| https://github.com/rubys |
| rubys | https://github.com/rubys |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22601#event-1822265112 |
| targos | https://github.com/targos |
|
Sep 2, 2018
| https://github.com/nodejs/node/pull/22601#ref-commit-97397bc |
|
| https://github.com/rubys |
|
| https://github.com/targos |
| tools: add [src] links to assert.html | https://github.com/nodejs/node/commit/97397bcd827aa13f1d2f1d3eeacc73c50abfbd6f |
| 97397bc | https://github.com/nodejs/node/commit/97397bcd827aa13f1d2f1d3eeacc73c50abfbd6f |
| #22601 | https://github.com/nodejs/node/pull/22601 |
| targos | https://github.com/targos |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22601#ref-commit-c32d557 |
|
| https://github.com/rubys |
|
| https://github.com/targos |
| tools: add [src] links to assert.html | https://github.com/nodejs/node/commit/c32d5577b6fb52ca39eec0b2fb50ce9d2d3bf671 |
| c32d557 | https://github.com/nodejs/node/commit/c32d5577b6fb52ca39eec0b2fb50ce9d2d3bf671 |
| #22601 | https://github.com/nodejs/node/pull/22601 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22601#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
| targos | https://github.com/targos |
|
Sep 6, 2018
| https://github.com/nodejs/node/pull/22601#ref-commit-3f35e88 |
|
| https://github.com/rubys |
|
| https://github.com/targos |
| tools: add [src] links to assert.html | https://github.com/nodejs/node/commit/3f35e88329a9c70e15ec970f41c93f06509bf77a |
| 3f35e88 | https://github.com/nodejs/node/commit/3f35e88329a9c70e15ec970f41c93f06509bf77a |
| #22601 | https://github.com/nodejs/node/pull/22601 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22601 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22601/files/40e96e5aec1b88a7774afd29233474b36df5965f |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/22601/files/62fc53b4615a93490804101ad9da4d9a59c0a31e |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/22601 |
|
| https://github.com/rubys |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |