René's URL Explorer Experiment


Title: src: fix external memory usage going negative by mafintosh · Pull Request #22594 · nodejs/node · GitHub

Open Graph Title: src: fix external memory usage going negative by mafintosh · Pull Request #22594 · nodejs/node

X Title: src: fix external memory usage going negative by mafintosh · Pull Request #22594 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Fixes a bug i...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Fixes a bug i...

Opengraph URL: https://github.com/nodejs/node/pull/22594

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:570275fd-686a-12e1-1dfc-2c22b7d3d6e7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93F2:10927B:B91BB5:EF74ED:69908710
html-safe-noncee6b81faaf254e5f39f15cec3c2437ef3883158c67d35ba6ab271ab9fa15c28db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0YyOjEwOTI3QjpCOTFCQjU6RUY3NEVEOjY5OTA4NzEwIiwidmlzaXRvcl9pZCI6IjgxNDE2ODk0MTI4MDEwMzgwOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6e6cbbb6fdca3b2ca33888e0db176c68182e8d7cbea0c711801721ed3bd3777f
hovercard-subject-tagpull_request:211931019
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22594/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/77619ed2c05cac2649efb062b90e5081c24cfc0e1c86a169df469ad25787c59b/nodejs/node/pull/22594
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/77619ed2c05cac2649efb062b90e5081c24cfc0e1c86a169df469ad25787c59b/nodejs/node/pull/22594
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Fixes a bug i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafintosh
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22594#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22594
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22594
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22594
Reloadhttps://github.com/nodejs/node/pull/22594
Reloadhttps://github.com/nodejs/node/pull/22594
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22594
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mafintoshhttps://github.com/mafintosh
nodejs:masterhttps://github.com/nodejs/node/tree/master
mafintosh:fix-negative-external-memory-usagehttps://github.com/mafintosh/io.js/tree/fix-negative-external-memory-usage
Conversationhttps://github.com/nodejs/node/pull/22594
Commits3 (3)https://github.com/nodejs/node/pull/22594/commits
Checkshttps://github.com/nodejs/node/pull/22594/checks
Files changedhttps://github.com/nodejs/node/pull/22594/files
src: fix external memory usage going negativehttps://github.com/nodejs/node/pull/22594#top
mafintoshhttps://github.com/mafintosh
nodejs:masterhttps://github.com/nodejs/node/tree/master
mafintosh:fix-negative-external-memory-usagehttps://github.com/mafintosh/io.js/tree/fix-negative-external-memory-usage
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Aug 30, 2018https://github.com/nodejs/node/pull/22594#issue-355390059
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
d7cba76https://github.com/nodejs/node/commit/d7cba76856e80108edb47b2e4c50a2c5fe5e1427
Resethttps://github.com/nodejs/node/blob/d7cba76856e80108edb47b2e4c50a2c5fe5e1427/src/node_crypto.h#L205
destructuringhttps://github.com/nodejs/node/blob/d7cba76856e80108edb47b2e4c50a2c5fe5e1427/src/node_crypto.h#L116
Closehttps://github.com/nodejs/node/blob/d7cba76856e80108edb47b2e4c50a2c5fe5e1427/src/node_crypto.cc#L1030
#21570https://github.com/nodejs/node/issues/21570
Please reload this pagehttps://github.com/nodejs/node/pull/22594
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 30, 2018https://github.com/nodejs/node/pull/22594#issuecomment-417160064
@mafintoshhttps://github.com/mafintosh
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/728/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/728/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22594
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Aug 30, 2018https://github.com/nodejs/node/pull/22594#event-1817053772
https://github.com/mafintosh
src: fix external memory usage going negativehttps://github.com/nodejs/node/pull/22594/commits/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
d783377https://github.com/nodejs/node/pull/22594/commits/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
force-pushedhttps://github.com/nodejs/node/compare/f8c6a8a327a8fbde30568192fe7ec93b5cefc6fb..d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
f8c6a8ahttps://github.com/nodejs/node/commit/f8c6a8a327a8fbde30568192fe7ec93b5cefc6fb
d783377https://github.com/nodejs/node/commit/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
Compare https://github.com/nodejs/node/compare/f8c6a8a327a8fbde30568192fe7ec93b5cefc6fb..d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
August 30, 2018 01:32https://github.com/nodejs/node/pull/22594#event-1817054834
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Aug 30, 2018 https://github.com/nodejs/node/pull/22594#ref-issue-336490258
Memory usage (external) reports a negative value? #21570 https://github.com/nodejs/node/issues/21570
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Aug 30, 2018https://github.com/nodejs/node/pull/22594#event-1817055853
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 30, 2018 https://github.com/nodejs/node/pull/22594#pullrequestreview-150811531
View reviewed changes https://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
https://github.com/oliyy
oliyyhttps://github.com/oliyy
Aug 30, 2018 https://github.com/nodejs/node/pull/22594#pullrequestreview-150818204
View reviewed changes https://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 30, 2018 https://github.com/nodejs/node/pull/22594#pullrequestreview-150841034
View reviewed changes https://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
src/node_crypto.hhttps://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5#diff-470e0cf24a7d187261d3d90860324ab61599d549fbbcd910c011d394d2a3a950
TimothyGuhttps://github.com/TimothyGu
Aug 30, 2018https://github.com/nodejs/node/pull/22594#discussion_r213906791
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22594
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 30, 2018 https://github.com/nodejs/node/pull/22594#pullrequestreview-151015094
View reviewed changes https://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
test/parallel/test-gc-tls-external-memory.jshttps://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5#diff-617d46d2a4f135fa60a10229f17a84d829e977ab4e2dde9756c9cf523ee3a1a2
cjihrighttps://github.com/cjihrig
Aug 30, 2018https://github.com/nodejs/node/pull/22594#discussion_r214047182
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22594
mafintoshhttps://github.com/mafintosh
August 30, 2018 17:12https://github.com/nodejs/node/pull/22594#commits-pushed-44dc6b5
https://github.com/mafintosh
fix nithttps://github.com/nodejs/node/pull/22594/commits/44dc6b5d6f7bb774b30f2f405be2bb129752dc62
44dc6b5https://github.com/nodejs/node/pull/22594/commits/44dc6b5d6f7bb774b30f2f405be2bb129752dc62
https://github.com/mafintosh
add common.mustCallhttps://github.com/nodejs/node/pull/22594/commits/8376f460c53cf3733728821bf4e3363105277d48
8376f46https://github.com/nodejs/node/pull/22594/commits/8376f460c53cf3733728821bf4e3363105277d48
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 30, 2018 https://github.com/nodejs/node/pull/22594#pullrequestreview-151105238
View reviewed changes https://github.com/nodejs/node/pull/22594/files/8376f460c53cf3733728821bf4e3363105277d48
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 31, 2018https://github.com/nodejs/node/pull/22594#event-1820644190
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 31, 2018https://github.com/nodejs/node/pull/22594#issuecomment-417670876
https://ci.nodejs.org/job/node-test-pull-request/16899/https://ci.nodejs.org/job/node-test-pull-request/16899/
Please reload this pagehttps://github.com/nodejs/node/pull/22594
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 31, 2018 https://github.com/nodejs/node/pull/22594#pullrequestreview-151560952
View reviewed changes https://github.com/nodejs/node/pull/22594/files/8376f460c53cf3733728821bf4e3363105277d48
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22594#issuecomment-417921211
1287e52https://github.com/nodejs/node/commit/1287e524eeba4632decce231da161426efb8fc34
Please reload this pagehttps://github.com/nodejs/node/pull/22594
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22594#event-1822199303
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/22594#ref-commit-1287e52
https://github.com/mafintosh
https://github.com/addaleax
src: fix external memory usage going negativehttps://github.com/nodejs/node/commit/1287e524eeba4632decce231da161426efb8fc34
1287e52https://github.com/nodejs/node/commit/1287e524eeba4632decce231da161426efb8fc34
#22594https://github.com/nodejs/node/pull/22594
targoshttps://github.com/targos
Sep 2, 2018 https://github.com/nodejs/node/pull/22594#ref-commit-6b7cc49
https://github.com/mafintosh
https://github.com/targos
src: fix external memory usage going negativehttps://github.com/nodejs/node/commit/6b7cc49963264652747c89a22ce217e08d4ed130
6b7cc49https://github.com/nodejs/node/commit/6b7cc49963264652747c89a22ce217e08d4ed130
#22594https://github.com/nodejs/node/pull/22594
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22594#ref-commit-75a9192
https://github.com/mafintosh
https://github.com/targos
src: fix external memory usage going negativehttps://github.com/nodejs/node/commit/75a919254992823c338b381407d9504850304b1d
75a9192https://github.com/nodejs/node/commit/75a919254992823c338b381407d9504850304b1d
#22594https://github.com/nodejs/node/pull/22594
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22594#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22594#ref-commit-f918e36
https://github.com/mafintosh
https://github.com/targos
src: fix external memory usage going negativehttps://github.com/nodejs/node/commit/f918e36f9b4dbfff88837158d1fb94857bd02c96
f918e36https://github.com/nodejs/node/commit/f918e36f9b4dbfff88837158d1fb94857bd02c96
#22594https://github.com/nodejs/node/pull/22594
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22594
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22594/files/8376f460c53cf3733728821bf4e3363105277d48
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/22594/files/8376f460c53cf3733728821bf4e3363105277d48
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
https://github.com/oliyy
oliyy https://github.com/oliyy
https://github.com/nodejs/node/pull/22594/files/d783377dd9184b5db6bd61bd47f22c5f01a4c5c5
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Memory usage (external) reports a negative value? https://github.com/nodejs/node/issues/21570
Please reload this pagehttps://github.com/nodejs/node/pull/22594
https://github.com/mafintosh
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/addaleax
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/oliyy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.