René's URL Explorer Experiment


Title: child_process: fix handling of incorrect uid/gid in spawn by lundibundi · Pull Request #22574 · nodejs/node · GitHub

Open Graph Title: child_process: fix handling of incorrect uid/gid in spawn by lundibundi · Pull Request #22574 · nodejs/node

X Title: child_process: fix handling of incorrect uid/gid in spawn by lundibundi · Pull Request #22574 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: uid/gid must be int32, which is asserted on a c++ side but wasn't checked on a JS side and therefore resulted in a process crash. Refs: #22570 Checklist make -j4 test (UNIX), or vcbuild test...

X Description: uid/gid must be int32, which is asserted on a c++ side but wasn't checked on a JS side and therefore resulted in a process crash. Refs: #22570 Checklist make -j4 test (UNIX), or vcbuild ...

Opengraph URL: https://github.com/nodejs/node/pull/22574

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:962c7fe6-dd19-128b-b9fa-912d19095b17
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE40A:24FF8:B8FDAC:F10E1E:699086AB
html-safe-nonce02263fd21e82ff1cbde6f853a2ca8327629591a9c186f10cd798e8fd4fb57f15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDBBOjI0RkY4OkI4RkRBQzpGMTBFMUU6Njk5MDg2QUIiLCJ2aXNpdG9yX2lkIjoiOTA0MTI3MzQxODIwOTU5MzAwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac40d2ef43fd607a0e3402c59697e3cae00cf9f0ac91c3b2a37ac6c4c2d8e4e1f8
hovercard-subject-tagpull_request:211592285
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22574/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1a70c8ed44db62dc26ccb1d7e18f9d7df585bc4b55887d46471a33232a2dfe10/nodejs/node/pull/22574
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1a70c8ed44db62dc26ccb1d7e18f9d7df585bc4b55887d46471a33232a2dfe10/nodejs/node/pull/22574
og:image:altuid/gid must be int32, which is asserted on a c++ side but wasn't checked on a JS side and therefore resulted in a process crash. Refs: #22570 Checklist make -j4 test (UNIX), or vcbuild test...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelundibundi
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22574#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22574
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22574
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22574
Reloadhttps://github.com/nodejs/node/pull/22574
Reloadhttps://github.com/nodejs/node/pull/22574
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22574
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:fix-child-process-uid-gidhttps://github.com/lundibundi/node/tree/fix-child-process-uid-gid
Conversationhttps://github.com/nodejs/node/pull/22574
Commits2 (2)https://github.com/nodejs/node/pull/22574/commits
Checkshttps://github.com/nodejs/node/pull/22574/checks
Files changedhttps://github.com/nodejs/node/pull/22574/files
child_process: fix handling of incorrect uid/gid in spawnhttps://github.com/nodejs/node/pull/22574#top
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:fix-child-process-uid-gidhttps://github.com/lundibundi/node/tree/fix-child-process-uid-gid
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 29, 2018https://github.com/nodejs/node/pull/22574#issue-354947065
Please reload this pagehttps://github.com/nodejs/node/pull/22574
#22570https://github.com/nodejs/node/issues/22570
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22574
https://github.com/lundibundi
child_process: fix handling of incorrect uid/gid in spawnhttps://github.com/nodejs/node/pull/22574/commits/c842094c3bb08388b73f3efc0923280ae20ff767
c842094https://github.com/nodejs/node/pull/22574/commits/c842094c3bb08388b73f3efc0923280ae20ff767
nodejs#22570https://github.com/nodejs/node/issues/22570
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Aug 29, 2018https://github.com/nodejs/node/pull/22574#event-1814413291
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 29, 2018https://github.com/nodejs/node/pull/22574#issuecomment-416779335
@lundibundihttps://github.com/lundibundi
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/717/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/717/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22574
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Aug 29, 2018https://github.com/nodejs/node/pull/22574#event-1814413397
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 29, 2018https://github.com/nodejs/node/pull/22574#issuecomment-416779507
https://ci.nodejs.org/job/node-test-pull-request/16841/https://ci.nodejs.org/job/node-test-pull-request/16841/
Please reload this pagehttps://github.com/nodejs/node/pull/22574
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 29, 2018 https://github.com/nodejs/node/pull/22574#pullrequestreview-150364289
View reviewed changes https://github.com/nodejs/node/pull/22574/files/c842094c3bb08388b73f3efc0923280ae20ff767
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 29, 2018https://github.com/nodejs/node/pull/22574#event-1814432359
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 29, 2018 https://github.com/nodejs/node/pull/22574#pullrequestreview-150371681
View reviewed changes https://github.com/nodejs/node/pull/22574/files/c842094c3bb08388b73f3efc0923280ae20ff767
lib/child_process.jshttps://github.com/nodejs/node/pull/22574/files/c842094c3bb08388b73f3efc0923280ae20ff767#diff-56c0eb11e943939908cf3d1d251bf1aadda236b5adbf8111d79b0809ec403f97
cjihrighttps://github.com/cjihrig
Aug 29, 2018https://github.com/nodejs/node/pull/22574#discussion_r213518386
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22574
lundibundihttps://github.com/lundibundi
Aug 29, 2018https://github.com/nodejs/node/pull/22574#discussion_r213520625
Please reload this pagehttps://github.com/nodejs/node/pull/22574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22574
lundibundihttps://github.com/lundibundi
Aug 29, 2018https://github.com/nodejs/node/pull/22574#discussion_r213522607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22574
https://github.com/lundibundi
fixup! child_process: fix handling of incorrect uid/gid in spawnhttps://github.com/nodejs/node/pull/22574/commits/7952acddfe42ac1b1faf62843ae512835dc43fcf
7952acdhttps://github.com/nodejs/node/pull/22574/commits/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 29, 2018https://github.com/nodejs/node/pull/22574#issuecomment-416795841
Please reload this pagehttps://github.com/nodejs/node/pull/22574
https://ci.nodejs.org/job/node-test-pull-request/16845/https://ci.nodejs.org/job/node-test-pull-request/16845/
https://ci.nodejs.org/job/node-test-pull-request/16850/https://ci.nodejs.org/job/node-test-pull-request/16850/
https://ci.nodejs.org/job/node-test-pull-request/16865/https://ci.nodejs.org/job/node-test-pull-request/16865/
Please reload this pagehttps://github.com/nodejs/node/pull/22574
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Aug 29, 2018 https://github.com/nodejs/node/pull/22574#pullrequestreview-150459315
View reviewed changes https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 29, 2018 https://github.com/nodejs/node/pull/22574#pullrequestreview-150479828
View reviewed changes https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 29, 2018 https://github.com/nodejs/node/pull/22574#pullrequestreview-150523893
View reviewed changes https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 29, 2018 https://github.com/nodejs/node/pull/22574#pullrequestreview-150537882
View reviewed changes https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 29, 2018 https://github.com/nodejs/node/pull/22574#pullrequestreview-150631477
View reviewed changes https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/oliyy
oliyyhttps://github.com/oliyy
Aug 30, 2018 https://github.com/nodejs/node/pull/22574#pullrequestreview-150818520
View reviewed changes https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Aug 31, 2018https://github.com/nodejs/node/pull/22574#event-1821070894
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 31, 2018https://github.com/nodejs/node/pull/22574#issuecomment-417729869
22789fdhttps://github.com/nodejs/node/commit/22789fd6d0a53a986073373136c269016d4267c8
Please reload this pagehttps://github.com/nodejs/node/pull/22574
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 31, 2018https://github.com/nodejs/node/pull/22574#event-1821075487
addaleaxhttps://github.com/addaleax
Aug 31, 2018 https://github.com/nodejs/node/pull/22574#ref-commit-22789fd
https://github.com/lundibundi
https://github.com/addaleax
child_process: fix handling of incorrect uid/gid in spawnhttps://github.com/nodejs/node/commit/22789fd6d0a53a986073373136c269016d4267c8
22789fdhttps://github.com/nodejs/node/commit/22789fd6d0a53a986073373136c269016d4267c8
#22570https://github.com/nodejs/node/issues/22570
#22574https://github.com/nodejs/node/pull/22574
addaleaxhttps://github.com/addaleax
Aug 31, 2018 https://github.com/nodejs/node/pull/22574#ref-commit-723ea9a
https://github.com/lundibundi
https://github.com/addaleax
child_process: fix handling of incorrect uid/gid in spawnhttps://github.com/nodejs/node/commit/723ea9a1d5efccb4442db78b6695fbda1ecacb4e
723ea9ahttps://github.com/nodejs/node/commit/723ea9a1d5efccb4442db78b6695fbda1ecacb4e
#22570https://github.com/nodejs/node/issues/22570
#22574https://github.com/nodejs/node/pull/22574
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22574#ref-commit-180bb0b
https://github.com/lundibundi
https://github.com/targos
child_process: fix handling of incorrect uid/gid in spawnhttps://github.com/nodejs/node/commit/180bb0b7d87672eb702436f820b237265d43190d
180bb0bhttps://github.com/nodejs/node/commit/180bb0b7d87672eb702436f820b237265d43190d
#22570https://github.com/nodejs/node/issues/22570
#22574https://github.com/nodejs/node/pull/22574
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22574#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22574#ref-commit-45eb97e
https://github.com/lundibundi
https://github.com/targos
child_process: fix handling of incorrect uid/gid in spawnhttps://github.com/nodejs/node/commit/45eb97ec76f02c36c73b59a693021d3c5b262780
45eb97ehttps://github.com/nodejs/node/commit/45eb97ec76f02c36c73b59a693021d3c5b262780
#22570https://github.com/nodejs/node/issues/22570
#22574https://github.com/nodejs/node/pull/22574
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Sep 19, 2019https://github.com/nodejs/node/pull/22574#event-2648251002
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22574
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/22574/files/c842094c3bb08388b73f3efc0923280ae20ff767
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/starkwang
starkwang https://github.com/starkwang
https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
https://github.com/oliyy
oliyy https://github.com/oliyy
https://github.com/nodejs/node/pull/22574/files/7952acddfe42ac1b1faf62843ae512835dc43fcf
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Please reload this pagehttps://github.com/nodejs/node/pull/22574
https://github.com/lundibundi
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/starkwang
https://github.com/oliyy
https://github.com/trivikr
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.