| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1b41fb37-cba0-c13f-a91a-e844016642e7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 882E:139E28:A8776A:D7D25D:699086D7 |
| html-safe-nonce | e96e3ba75b414becbe0106a3683a6e9aa2f2cd8c86976d2ddda6959f807f694d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODJFOjEzOUUyODpBODc3NkE6RDdEMjVEOjY5OTA4NkQ3IiwidmlzaXRvcl9pZCI6IjUyODE5ODI2NjY5ODg5MzAxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1f56a29d0dc67dca48572aa35e5452b658958e96bbbac70751424f5d95788c2c |
| hovercard-subject-tag | pull_request:211018828 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22548/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c04a3b83bbf83aa75033930b80304c5e8d98bf44d6ef57936fa08f7009f701a1/nodejs/node/pull/22548 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c04a3b83bbf83aa75033930b80304c5e8d98bf44d6ef57936fa08f7009f701a1/nodejs/node/pull/22548 |
| og:image:alt | On a aarch64 system I can run the complete build with tests without
specifying the Makefile variable DESTCPU.
But when running the tar-headers target DESTCPU is passed to configure:
$(PYTHON) .... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22548#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22548 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22548 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22548 |
| Reload | https://github.com/nodejs/node/pull/22548 |
| Reload | https://github.com/nodejs/node/pull/22548 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:build_aarch_distcpu | https://github.com/danbev/node/tree/build_aarch_distcpu |
| Conversation | https://github.com/nodejs/node/pull/22548 |
| Commits2 (2) | https://github.com/nodejs/node/pull/22548/commits |
| Checks | https://github.com/nodejs/node/pull/22548/checks |
| Files changed | https://github.com/nodejs/node/pull/22548/files |
| build: use arm64 as DESTCPU for aarch64 | https://github.com/nodejs/node/pull/22548#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:build_aarch_distcpu | https://github.com/danbev/node/tree/build_aarch_distcpu |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 27, 2018 | https://github.com/nodejs/node/pull/22548#issue-354198193 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
|
| https://github.com/danbev |
| build: use arm64 as DESTCPU for aarch64 | https://github.com/nodejs/node/pull/22548/commits/fc228313f496af9a49ae9a56f6c0b9dbbb1a39ca |
| fc22831 | https://github.com/nodejs/node/pull/22548/commits/fc228313f496af9a49ae9a56f6c0b9dbbb1a39ca |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 27, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-416129582 |
| @danbev | https://github.com/danbev |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/693/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/693/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Aug 27, 2018 | https://github.com/nodejs/node/pull/22548#event-1809870676 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 27, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-416129807 |
| https://ci.nodejs.org/job/node-test-pull-request/16775/ | https://ci.nodejs.org/job/node-test-pull-request/16775/ |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 29, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-416829975 |
| node-test-commit-freebsd | https://ci.nodejs.org/job/node-test-commit-freebsd/20099/ |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Aug 29, 2018
| https://github.com/nodejs/node/pull/22548#pullrequestreview-150416163 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22548/files/fc228313f496af9a49ae9a56f6c0b9dbbb1a39ca |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Aug 29, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-416838452 |
| #5175 | https://github.com/nodejs/node/issues/5175 |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/yselkowitz |
| yselkowitz | https://github.com/yselkowitz |
|
Aug 29, 2018
| https://github.com/nodejs/node/pull/22548#pullrequestreview-150516683 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22548/files/fc228313f496af9a49ae9a56f6c0b9dbbb1a39ca |
| yselkowitz | https://github.com/yselkowitz |
| https://github.com/nodejs/node/pull/22548#pullrequestreview-150516683 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 30, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-417296136 |
| @yselkowitz | https://github.com/yselkowitz |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
|
| https://github.com/danbev |
| squash: update DESTCPU check for ARCH setting | https://github.com/nodejs/node/pull/22548/commits/1dedf3f0d1645271b45d829b457ed01fe2c8f38c |
| 1dedf3f | https://github.com/nodejs/node/pull/22548/commits/1dedf3f0d1645271b45d829b457ed01fe2c8f38c |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-417548510 |
| https://ci.nodejs.org/job/node-test-pull-request/16889/ | https://ci.nodejs.org/job/node-test-pull-request/16889/ |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-417730520 |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22548#event-1821080113 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-417735661 |
| https://ci.nodejs.org/job/node-test-pull-request/16914/ | https://ci.nodejs.org/job/node-test-pull-request/16914/ |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-417772304 |
| https://stackoverflow.com/a/47274698/27955 | https://stackoverflow.com/a/47274698/27955 |
| https://www.phoronix.com/scan.php?page=news_item&px=MTY5ODk | https://www.phoronix.com/scan.php?page=news_item&px=MTY5ODk |
| https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html | https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/yselkowitz |
| yselkowitz | https://github.com/yselkowitz |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-417774752 |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/gdams |
| gdams | https://github.com/gdams |
|
Aug 31, 2018
| https://github.com/nodejs/node/pull/22548#pullrequestreview-151536034 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22548/files/1dedf3f0d1645271b45d829b457ed01fe2c8f38c |
| gdams | https://github.com/gdams |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/nodejs/node/pull/22548#pullrequestreview-151536034 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-417804228 |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Aug 31, 2018
| https://github.com/nodejs/node/pull/22548#pullrequestreview-151563986 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22548/files/1dedf3f0d1645271b45d829b457ed01fe2c8f38c |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 2, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-417926286 |
| https://ci.nodejs.org/job/node-test-pull-request/16939/ | https://ci.nodejs.org/job/node-test-pull-request/16939/ |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 3, 2018 | https://github.com/nodejs/node/pull/22548#issuecomment-418020738 |
| d7d3bf5 | https://github.com/nodejs/node/commit/d7d3bf57a6a32a0e1222deb6eeb106ea0ce711c8 |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 3, 2018 | https://github.com/nodejs/node/pull/22548#event-1822783242 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| September 3, 2018 07:07 | https://github.com/nodejs/node/pull/22548#event-1822783780 |
| danbev | https://github.com/danbev |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22548#ref-commit-d7d3bf5 |
|
| https://github.com/danbev |
| build: use arm64 as DESTCPU for aarch64 | https://github.com/nodejs/node/commit/d7d3bf57a6a32a0e1222deb6eeb106ea0ce711c8 |
| d7d3bf5 | https://github.com/nodejs/node/commit/d7d3bf57a6a32a0e1222deb6eeb106ea0ce711c8 |
| #22548 | https://github.com/nodejs/node/pull/22548 |
| targos | https://github.com/targos |
|
Sep 3, 2018
| https://github.com/nodejs/node/pull/22548#ref-commit-9a10421 |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| build: use arm64 as DESTCPU for aarch64 | https://github.com/nodejs/node/commit/9a10421f537e7f257deca55b6deab8ffb8f70d26 |
| 9a10421 | https://github.com/nodejs/node/commit/9a10421f537e7f257deca55b6deab8ffb8f70d26 |
| #22548 | https://github.com/nodejs/node/pull/22548 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 5, 2018
| https://github.com/nodejs/node/pull/22548#ref-pullrequest-357375733 |
|
Release proposal: v10.10.0
#22716
| https://github.com/nodejs/node/pull/22716 |
| targos | https://github.com/targos |
|
Sep 6, 2018
| https://github.com/nodejs/node/pull/22548#ref-commit-70d4039 |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| build: use arm64 as DESTCPU for aarch64 | https://github.com/nodejs/node/commit/70d403998c251c5b3975b9954889b515452bc5b9 |
| 70d4039 | https://github.com/nodejs/node/commit/70d403998c251c5b3975b9954889b515452bc5b9 |
| #22548 | https://github.com/nodejs/node/pull/22548 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-android-nodejs#236
| https://github.com/beevelop/docker-android-nodejs/issues/236 |
|
2018-09-06 Version 10.10.0 (Current) @targos
beevelop/docker-nodejs#221
| https://github.com/beevelop/docker-nodejs/issues/221 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22548 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/22548/files/fc228313f496af9a49ae9a56f6c0b9dbbb1a39ca |
|
| https://github.com/gdams |
|
gdams
| https://github.com/gdams |
|
| https://github.com/nodejs/node/pull/22548/files/1dedf3f0d1645271b45d829b457ed01fe2c8f38c |
|
| https://github.com/yselkowitz |
|
yselkowitz
| https://github.com/yselkowitz |
|
| https://github.com/nodejs/node/pull/22548/files/fc228313f496af9a49ae9a56f6c0b9dbbb1a39ca |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/22548/files/1dedf3f0d1645271b45d829b457ed01fe2c8f38c |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/22548 |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
|
| https://github.com/addaleax |
|
| https://github.com/refack |
|
| https://github.com/yselkowitz |
|
| https://github.com/gdams |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |