René's URL Explorer Experiment


Title: src: fix NODE_OPTIONS parsing bug by addaleax · Pull Request #22529 · nodejs/node · GitHub

Open Graph Title: src: fix NODE_OPTIONS parsing bug by addaleax · Pull Request #22529 · nodejs/node

X Title: src: fix NODE_OPTIONS parsing bug by addaleax · Pull Request #22529 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: I, uhm, might have messed up by using a substr(start, end) signature when std::string actually uses substr(start, len). Fix that. Fixes: #22526 Refs: #22392 Checklist make -j4 test (UNIX), or v...

X Description: I, uhm, might have messed up by using a substr(start, end) signature when std::string actually uses substr(start, len). Fix that. Fixes: #22526 Refs: #22392 Checklist make -j4 test (UNIX), or v...

Opengraph URL: https://github.com/nodejs/node/pull/22529

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4107f73c-0117-70f1-7db4-f98bc02a6deb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FAC:6964C:1663380:1CB3AC9:699086C8
html-safe-nonce9a0125c7ccfcdf2eac157f892ddb6ceb3fec0570c14544c96f1457675c7a4b52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkFDOjY5NjRDOjE2NjMzODA6MUNCM0FDOTo2OTkwODZDOCIsInZpc2l0b3JfaWQiOiIzMDAxNTc3NDE4ODY5NzM3MTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8e97ba4344ecf9a55edfee6cab07c05e93caa0d20ac636e98fd13c01296292fe
hovercard-subject-tagpull_request:210927800
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22529/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bf194b4f880588220d677e8866f1095a37de4daa489108b2590744959543b18b/nodejs/node/pull/22529
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bf194b4f880588220d677e8866f1095a37de4daa489108b2590744959543b18b/nodejs/node/pull/22529
og:image:altI, uhm, might have messed up by using a substr(start, end) signature when std::string actually uses substr(start, len). Fix that. Fixes: #22526 Refs: #22392 Checklist make -j4 test (UNIX), or v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22529#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22529
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22529
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22529
Reloadhttps://github.com/nodejs/node/pull/22529
Reloadhttps://github.com/nodejs/node/pull/22529
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22529
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fix-node-optionshttps://github.com/addaleax/node/tree/fix-node-options
Conversationhttps://github.com/nodejs/node/pull/22529
Commits1 (1)https://github.com/nodejs/node/pull/22529/commits
Checkshttps://github.com/nodejs/node/pull/22529/checks
Files changedhttps://github.com/nodejs/node/pull/22529/files
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/pull/22529#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fix-node-optionshttps://github.com/addaleax/node/tree/fix-node-options
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 26, 2018https://github.com/nodejs/node/pull/22529#issue-354054197
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/addaleax
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/pull/22529/commits/c53349975713ec208e726c93be7895787874e38a
c533499https://github.com/nodejs/node/pull/22529/commits/c53349975713ec208e726c93be7895787874e38a
nodejs#22526https://github.com/nodejs/node/issues/22526
nodejs#22392https://github.com/nodejs/node/pull/22392
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 26, 2018https://github.com/nodejs/node/pull/22529#issuecomment-416005586
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/675/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/675/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Aug 26, 2018https://github.com/nodejs/node/pull/22529#event-1809179093
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 26, 2018 https://github.com/nodejs/node/pull/22529#ref-issue-354048112
NODE_OPTIONS do not work properly anymore #22526 https://github.com/nodejs/node/issues/22526
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
cli https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Aug 26, 2018https://github.com/nodejs/node/pull/22529#event-1809179370
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 26, 2018https://github.com/nodejs/node/pull/22529#issuecomment-416005696
https://ci.nodejs.org/job/node-test-pull-request/16754/https://ci.nodejs.org/job/node-test-pull-request/16754/
#22392https://github.com/nodejs/node/pull/22392
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 26, 2018 https://github.com/nodejs/node/pull/22529#pullrequestreview-149524019
View reviewed changes https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 26, 2018 https://github.com/nodejs/node/pull/22529#pullrequestreview-149524022
View reviewed changes https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/22529#pullrequestreview-149524022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Aug 26, 2018 https://github.com/nodejs/node/pull/22529#pullrequestreview-149524218
View reviewed changes https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
test/parallel/test-cli-node-options.jshttps://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a#diff-92036e8e1bc1f6cf849fcd5498840ba1dbbc53ba4d6335b81ea4f84426d30081
mscdexhttps://github.com/mscdex
Aug 26, 2018https://github.com/nodejs/node/pull/22529#discussion_r212812255
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22529
addaleaxhttps://github.com/addaleax
Aug 26, 2018https://github.com/nodejs/node/pull/22529#discussion_r212812436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/refack
refackhttps://github.com/refack
Aug 26, 2018 https://github.com/nodejs/node/pull/22529#pullrequestreview-149524908
View reviewed changes https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
https://github.com/refack
refackhttps://github.com/refack
Aug 26, 2018https://github.com/nodejs/node/pull/22529#issuecomment-416008528
https://ci.nodejs.org/job/node-test-commit/20911/https://ci.nodejs.org/job/node-test-commit/20911/
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 26, 2018https://github.com/nodejs/node/pull/22529#issuecomment-416013409
https://ci.nodejs.org/job/node-test-pull-request/16755/https://ci.nodejs.org/job/node-test-pull-request/16755/
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/targos
targoshttps://github.com/targos
Aug 26, 2018https://github.com/nodejs/node/pull/22529#issuecomment-416019320
https://ci.nodejs.org/job/node-test-pull-request/16757/https://ci.nodejs.org/job/node-test-pull-request/16757/
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 26, 2018 https://github.com/nodejs/node/pull/22529#pullrequestreview-149530351
View reviewed changes https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 26, 2018https://github.com/nodejs/node/pull/22529#issuecomment-416033852
1c05b16https://github.com/nodejs/node/commit/1c05b16c9e7b8d054d1661c61ae054efe83108ac
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 26, 2018https://github.com/nodejs/node/pull/22529#event-1809325929
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
August 26, 2018 12:01https://github.com/nodejs/node/pull/22529#event-1809325982
addaleaxhttps://github.com/addaleax
Aug 26, 2018 https://github.com/nodejs/node/pull/22529#ref-commit-1c05b16
https://github.com/addaleax
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/commit/1c05b16c9e7b8d054d1661c61ae054efe83108ac
1c05b16https://github.com/nodejs/node/commit/1c05b16c9e7b8d054d1661c61ae054efe83108ac
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
#22529https://github.com/nodejs/node/pull/22529
addaleaxhttps://github.com/addaleax
Aug 28, 2018 https://github.com/nodejs/node/pull/22529#ref-commit-7e3ceb1
https://github.com/addaleax
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/commit/7e3ceb1fd9a47481305f5b44cadfc3663c71d619
7e3ceb1https://github.com/nodejs/node/commit/7e3ceb1fd9a47481305f5b44cadfc3663c71d619
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
#22529https://github.com/nodejs/node/pull/22529
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22529#ref-commit-2c5dfef
https://github.com/addaleax
https://github.com/targos
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/commit/2c5dfef393ad4122242689dc79e1064e70df2cd8
2c5dfefhttps://github.com/nodejs/node/commit/2c5dfef393ad4122242689dc79e1064e70df2cd8
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
#22529https://github.com/nodejs/node/pull/22529
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22529#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22529#ref-commit-7282768
https://github.com/addaleax
https://github.com/targos
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/commit/7282768134dad75efaf82e380bad7bbab6775f6b
7282768https://github.com/nodejs/node/commit/7282768134dad75efaf82e380bad7bbab6775f6b
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
#22529https://github.com/nodejs/node/pull/22529
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22529
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/22529/files/c53349975713ec208e726c93be7895787874e38a
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cli https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
NODE_OPTIONS do not work properly anymore https://github.com/nodejs/node/issues/22526
Please reload this pagehttps://github.com/nodejs/node/pull/22529
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/Trott
https://github.com/targos
https://github.com/mscdex
https://github.com/devsnek
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.