| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0f10ae9d-9665-a9ae-5936-1f5b055a14e4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C546:3A6082:BDA549:F50CCC:696AFF41 |
| html-safe-nonce | c6e6f0fe6b988d45ca54d4bec4085b849c6569684b5d92891ede979ad9eaed62 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTQ2OjNBNjA4MjpCREE1NDk6RjUwQ0NDOjY5NkFGRjQxIiwidmlzaXRvcl9pZCI6IjY3ODE4OTg5NjU4Mzg5MjE1MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 436f33c873cd038620440a9734d6dfb96d346795c60471ad620c14c897f7b55a |
| hovercard-subject-tag | pull_request:210469494 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22478/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/55bc193cb2361750197463aa8fe0be9d800bc20282ee055a09b0712c16d53636/nodejs/node/pull/22478 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55bc193cb2361750197463aa8fe0be9d800bc20282ee055a09b0712c16d53636/nodejs/node/pull/22478 |
| og:image:alt | Refs: #22160
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shisama |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/22478#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22478 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22478 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/22478 |
| Reload | https://github.com/nodejs/node/pull/22478 |
| Reload | https://github.com/nodejs/node/pull/22478 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/22478#issue-comment-box |
| shisama | https://github.com/shisama |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| shisama:internal-binding-fs | https://github.com/shisama/node/tree/internal-binding-fs |
|
fs: make process.binding('fs') internal
| https://github.com/nodejs/node/pull/22478#top |
| shisama | https://github.com/shisama |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| shisama:internal-binding-fs | https://github.com/shisama/node/tree/internal-binding-fs |
|
Conversation
26
| https://github.com/nodejs/node/pull/22478 |
|
Commits
1
| https://github.com/nodejs/node/pull/22478/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/22478/checks |
|
Files changed
| https://github.com/nodejs/node/pull/22478/files |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Aug 23, 2018 | https://github.com/nodejs/node/pull/22478#issue-353410068 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| #22160 | https://github.com/nodejs/node/issues/22160 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Aug 23, 2018 | https://github.com/nodejs/node/pull/22478#event-1805442676 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Aug 23, 2018 | https://github.com/nodejs/node/pull/22478#event-1805449869 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 23, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-415441067 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 23, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-415441483 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1519/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1519/ |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 23, 2018
| https://github.com/nodejs/node/pull/22478#ref-issue-348054360 |
|
Tracking Issue: process.binding to internalBinding
#22160
| https://github.com/nodejs/node/issues/22160 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 23, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-415445045 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/jdalton |
| jdalton | https://github.com/jdalton |
| Aug 23, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-415607168 |
| @shisama | https://github.com/shisama |
| this other pr | https://github.com/nodejs/node/pull/22479/files#diff-362950ada44657730d806a6908957c35 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| force-pushed | https://github.com/nodejs/node/compare/121225fb213e9a5bb8f2aaa26db0fe38f599b1c0..69f7b2808773ba291a890746fc9c1140bbf2efb8 |
| 121225f | https://github.com/nodejs/node/commit/121225fb213e9a5bb8f2aaa26db0fe38f599b1c0 |
| 69f7b28 | https://github.com/nodejs/node/commit/69f7b2808773ba291a890746fc9c1140bbf2efb8 |
|
Compare
| https://github.com/nodejs/node/compare/121225fb213e9a5bb8f2aaa26db0fe38f599b1c0..69f7b2808773ba291a890746fc9c1140bbf2efb8 |
| August 25, 2018 02:52 | https://github.com/nodejs/node/pull/22478#event-1808826691 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Aug 25, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-415928980 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| force-pushed | https://github.com/nodejs/node/compare/3dd21e161b11e20a326da82a811e4f4c68b5faff..e367e778d458274af8c1cfd14f22eb6f61779940 |
| 3dd21e1 | https://github.com/nodejs/node/commit/3dd21e161b11e20a326da82a811e4f4c68b5faff |
| e367e77 | https://github.com/nodejs/node/commit/e367e778d458274af8c1cfd14f22eb6f61779940 |
|
Compare
| https://github.com/nodejs/node/compare/3dd21e161b11e20a326da82a811e4f4c68b5faff..e367e778d458274af8c1cfd14f22eb6f61779940 |
| August 31, 2018 10:01 | https://github.com/nodejs/node/pull/22478#event-1820218895 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 31, 2018
| https://github.com/nodejs/node/pull/22478#pullrequestreview-151479693 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22478/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/22478#pullrequestreview-151479693 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Aug 31, 2018 | https://github.com/nodejs/node/pull/22478#event-1821087940 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22478#pullrequestreview-152108153 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22478/files |
| https://github.com/jdalton |
| jdalton | https://github.com/jdalton |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-418401600 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-418402849 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-418463926 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-418468378 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 4, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-418468647 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| stale review | https://github.com/nodejs/node/pull/22478#pullrequestreview-152108153 |
| September 4, 2018 18:22 | https://github.com/nodejs/node/pull/22478#event-1826007680 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 4, 2018
| https://github.com/nodejs/node/pull/22478#pullrequestreview-152193946 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22478/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/22478#pullrequestreview-152193946 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 5, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-418743457 |
| https://ci.nodejs.org/job/node-test-pull-request/17032/ | https://ci.nodejs.org/job/node-test-pull-request/17032/ |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| force-pushed | https://github.com/nodejs/node/compare/8855aa730533fceb5e89826ad000cd976cce83ee..af2a68b17d28207666bdb339904ea173981467b0 |
| 8855aa7 | https://github.com/nodejs/node/commit/8855aa730533fceb5e89826ad000cd976cce83ee |
| af2a68b | https://github.com/nodejs/node/commit/af2a68b17d28207666bdb339904ea173981467b0 |
|
Compare
| https://github.com/nodejs/node/compare/8855aa730533fceb5e89826ad000cd976cce83ee..af2a68b17d28207666bdb339904ea173981467b0 |
| September 18, 2018 15:01 | https://github.com/nodejs/node/pull/22478#event-1852662375 |
| https://github.com/maxwellgerber |
| maxwellgerber | https://github.com/maxwellgerber |
|
Sep 28, 2018
| https://github.com/nodejs/node/pull/22478#ref-issue-362250817 |
|
Only works the first time
tschaub/mock-fs#254
| https://github.com/tschaub/mock-fs/issues/254 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| force-pushed | https://github.com/nodejs/node/compare/af2a68b17d28207666bdb339904ea173981467b0..b7a5a878d2912108cac0084a95b066419dfd708e |
| af2a68b | https://github.com/nodejs/node/commit/af2a68b17d28207666bdb339904ea173981467b0 |
| b7a5a87 | https://github.com/nodejs/node/commit/b7a5a878d2912108cac0084a95b066419dfd708e |
|
Compare
| https://github.com/nodejs/node/compare/af2a68b17d28207666bdb339904ea173981467b0..b7a5a878d2912108cac0084a95b066419dfd708e |
| October 17, 2018 01:10 | https://github.com/nodejs/node/pull/22478#event-1908302847 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Oct 18, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-430840139 |
| @jasnell | https://github.com/jasnell |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-437693322 |
| @shisama | https://github.com/shisama |
| https://github.com/nodejs/node/blob/7e1b178fb637abc68b1d4da1363a19db7ad02d6c/doc/guides/contributing/pull-requests.md#commit-squashing | https://github.com/nodejs/node/blob/7e1b178fb637abc68b1d4da1363a19db7ad02d6c/doc/guides/contributing/pull-requests.md#commit-squashing |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Nov 12, 2018
| https://github.com/nodejs/node/pull/22478#ref-pullrequest-374410803 |
|
Implement new writable stream
metarhia/metastreams#9
| https://github.com/metarhia/metastreams/pull/9 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Nov 12, 2018
| https://github.com/nodejs/node/pull/22478#pullrequestreview-173937223 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/22478/files |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| force-pushed | https://github.com/nodejs/node/compare/98751ddd25a98755617689d2f4de0ee199cd32a4..7b2d4a8eac1fa3c3607637710ab4073a2f6ccce3 |
| 98751dd | https://github.com/nodejs/node/commit/98751ddd25a98755617689d2f4de0ee199cd32a4 |
| 7b2d4a8 | https://github.com/nodejs/node/commit/7b2d4a8eac1fa3c3607637710ab4073a2f6ccce3 |
|
Compare
| https://github.com/nodejs/node/compare/98751ddd25a98755617689d2f4de0ee199cd32a4..7b2d4a8eac1fa3c3607637710ab4073a2f6ccce3 |
| November 12, 2018 15:46 | https://github.com/nodejs/node/pull/22478#event-1960652418 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-437929847 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| force-pushed | https://github.com/nodejs/node/compare/7b2d4a8eac1fa3c3607637710ab4073a2f6ccce3..79834c903fca2411051c386fbb22993eed351c5d |
| 7b2d4a8 | https://github.com/nodejs/node/commit/7b2d4a8eac1fa3c3607637710ab4073a2f6ccce3 |
| 79834c9 | https://github.com/nodejs/node/commit/79834c903fca2411051c386fbb22993eed351c5d |
|
Compare
| https://github.com/nodejs/node/compare/7b2d4a8eac1fa3c3607637710ab4073a2f6ccce3..79834c903fca2411051c386fbb22993eed351c5d |
| November 13, 2018 01:23 | https://github.com/nodejs/node/pull/22478#event-1961786294 |
| fs: make process.binding('fs') internal | https://github.com/nodejs/node/pull/22478/commits/df729bc0aeb71e91444d2a1b03a4f3ba3bf64cf2 |
| df729bc | https://github.com/nodejs/node/pull/22478/commits/df729bc0aeb71e91444d2a1b03a4f3ba3bf64cf2 |
| nodejs#22160 | https://github.com/nodejs/node/issues/22160 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| force-pushed | https://github.com/nodejs/node/compare/79834c903fca2411051c386fbb22993eed351c5d..df729bc0aeb71e91444d2a1b03a4f3ba3bf64cf2 |
| 79834c9 | https://github.com/nodejs/node/commit/79834c903fca2411051c386fbb22993eed351c5d |
| df729bc | https://github.com/nodejs/node/commit/df729bc0aeb71e91444d2a1b03a4f3ba3bf64cf2 |
|
Compare
| https://github.com/nodejs/node/compare/79834c903fca2411051c386fbb22993eed351c5d..df729bc0aeb71e91444d2a1b03a4f3ba3bf64cf2 |
| November 13, 2018 13:14 | https://github.com/nodejs/node/pull/22478#event-1962982477 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Nov 13, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-438263414 |
| https://ci.nodejs.org/job/node-test-pull-request/18575/ | https://ci.nodejs.org/job/node-test-pull-request/18575/ |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Nov 13, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-438288526 |
| https://ci.nodejs.org/job/node-test-pull-request/18578/ | https://ci.nodejs.org/job/node-test-pull-request/18578/ |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Nov 13, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-438321287 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Nov 13, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-438322029 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Nov 13, 2018 | https://github.com/nodejs/node/pull/22478#event-1963463360 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Nov 16, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-439318290 |
| https://ci.nodejs.org/job/node-test-pull-request/18670/ | https://ci.nodejs.org/job/node-test-pull-request/18670/ |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| shisama | https://github.com/shisama |
|
Nov 16, 2018
| https://github.com/nodejs/node/pull/22478#ref-commit-1e23e3c |
| fs: make process.binding('fs') internal | https://github.com/nodejs/node/commit/1e23e3ceb3217f2b0e076864fdbbe874a8603e2f |
| 1e23e3c | https://github.com/nodejs/node/commit/1e23e3ceb3217f2b0e076864fdbbe874a8603e2f |
| #22160 | https://github.com/nodejs/node/issues/22160 |
| #22478 | https://github.com/nodejs/node/pull/22478 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Nov 16, 2018 | https://github.com/nodejs/node/pull/22478#issuecomment-439387146 |
| 1e23e3c | https://github.com/nodejs/node/commit/1e23e3ceb3217f2b0e076864fdbbe874a8603e2f |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/shisama |
| shisama | https://github.com/shisama |
| Nov 16, 2018 | https://github.com/nodejs/node/pull/22478#event-1971199833 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jan 11, 2019
| https://github.com/nodejs/node/pull/22478#ref-pullrequest-386498160 |
|
src: use NativeModuleLoader to compile all the bootstrappers
#24775
| https://github.com/nodejs/node/pull/24775 |
| joyeecheung | https://github.com/joyeecheung |
|
Jan 11, 2019
| https://github.com/nodejs/node/pull/22478#ref-commit-106b299 |
|
| https://github.com/joyeecheung |
| fs: make process.binding('fs') internal | https://github.com/joyeecheung/node/commit/106b2993a01a1c7d7ea1963967de225b16483e6d |
| 106b299 | https://github.com/joyeecheung/node/commit/106b2993a01a1c7d7ea1963967de225b16483e6d |
| nodejs#22160 | https://github.com/nodejs/node/issues/22160 |
| nodejs#22478 | https://github.com/nodejs/node/pull/22478 |
| addaleax | https://github.com/addaleax |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/22478#ref-commit-dd0381f |
|
| https://github.com/addaleax |
| fs: make process.binding('fs') internal | https://github.com/nodejs/node/commit/dd0381fe4e4ded48d6d9b92dfeb6b7b7d4991b60 |
| dd0381f | https://github.com/nodejs/node/commit/dd0381fe4e4ded48d6d9b92dfeb6b7b7d4991b60 |
| #22160 | https://github.com/nodejs/node/issues/22160 |
| #22478 | https://github.com/nodejs/node/pull/22478 |
| #25446 | https://github.com/nodejs/node/pull/25446 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 16, 2019
| https://github.com/nodejs/node/pull/22478#ref-pullrequest-399868555 |
|
v11.7.0 proposal
#25537
| https://github.com/nodejs/node/pull/25537 |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 16, 2019
| https://github.com/nodejs/node/pull/22478#ref-commit-43c743d |
|
| https://github.com/BridgeAR |
| fs: make process.binding('fs') internal | https://github.com/BridgeAR/node/commit/43c743d7f28f849f634b543fc6a369f84dc6104b |
| 43c743d | https://github.com/BridgeAR/node/commit/43c743d7f28f849f634b543fc6a369f84dc6104b |
| nodejs#22160 | https://github.com/nodejs/node/issues/22160 |
| nodejs#22478 | https://github.com/nodejs/node/pull/22478 |
| nodejs#25446 | https://github.com/nodejs/node/pull/25446 |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 17, 2019
| https://github.com/nodejs/node/pull/22478#ref-commit-6b7b827 |
|
| https://github.com/BridgeAR |
| 2019-01-17, Version 11.7.0 (Current), | https://github.com/BridgeAR/node/commit/6b7b8276d196ea5a0e6dcee4e63c548b7938e8f4 |
| @BridgeAR | https://github.com/BridgeAR |
| 6b7b827 | https://github.com/BridgeAR/node/commit/6b7b8276d196ea5a0e6dcee4e63c548b7938e8f4 |
| nodejs#24938 | https://github.com/nodejs/node/pull/24938 |
| nodejs#24978 | https://github.com/nodejs/node/pull/24978 |
| nodejs#25217 | https://github.com/nodejs/node/pull/25217 |
| nodejs#25234 | https://github.com/nodejs/node/pull/25234 |
| nodejs#22478 | https://github.com/nodejs/node/pull/22478 |
| nodejs#25170 | https://github.com/nodejs/node/pull/25170 |
| nodejs#25006 | https://github.com/nodejs/node/pull/25006 |
| nodejs#25361 | https://github.com/nodejs/node/pull/25361 |
| nodejs#25537 | https://github.com/nodejs/node/pull/25537 |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/22478#ref-commit-d3f8f90 |
|
| https://github.com/BridgeAR |
| 2019-01-17, Version 11.7.0 (Current), | https://github.com/nodejs/node/commit/d3f8f905b33347fc95057af01b72efc2966bd7c8 |
| @BridgeAR | https://github.com/BridgeAR |
| d3f8f90 | https://github.com/nodejs/node/commit/d3f8f905b33347fc95057af01b72efc2966bd7c8 |
| #24938 | https://github.com/nodejs/node/pull/24938 |
| #24978 | https://github.com/nodejs/node/pull/24978 |
| #25217 | https://github.com/nodejs/node/pull/25217 |
| #25234 | https://github.com/nodejs/node/pull/25234 |
| #22478 | https://github.com/nodejs/node/pull/22478 |
| #25170 | https://github.com/nodejs/node/pull/25170 |
| #25006 | https://github.com/nodejs/node/pull/25006 |
| #25361 | https://github.com/nodejs/node/pull/25361 |
| #25537 | https://github.com/nodejs/node/pull/25537 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/22478#ref-pullrequest-402909465 |
|
v11.8.0 proposal
#25687
| https://github.com/nodejs/node/pull/25687 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/22478#event-2095778319 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/22478#issuecomment-457377639 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/22478#event-2437993717 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Jun 25, 2019 | https://github.com/nodejs/node/pull/22478#issuecomment-505496543 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22478 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/22478/files/98751ddd25a98755617689d2f4de0ee199cd32a4 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/22478/files/545d7db29b6e4512528c18141605208838d7d9f9 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/22478/files/545d7db29b6e4512528c18141605208838d7d9f9 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/22478/files/98751ddd25a98755617689d2f4de0ee199cd32a4 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/22478/files/e367e778d458274af8c1cfd14f22eb6f61779940 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/22478/files/98751ddd25a98755617689d2f4de0ee199cd32a4 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/22478 |
|
| https://github.com/shisama |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/jdalton |
|
| https://github.com/targos |
|
| https://github.com/BridgeAR |
|
| https://github.com/joyeecheung |
|
| https://github.com/BethGriggs |
|
| https://github.com/lundibundi |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |