René's URL Explorer Experiment


Title: lib: merge onread handlers for http2 streams & net.Socket by addaleax · Pull Request #22449 · nodejs/node · GitHub

Open Graph Title: lib: merge onread handlers for http2 streams & net.Socket by addaleax · Pull Request #22449 · nodejs/node

X Title: lib: merge onread handlers for http2 streams & net.Socket by addaleax · Pull Request #22449 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is a rebased & modified version of @aks-’s #20993, with tests passing locally Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This is a rebased & modified version of @aks-’s #20993, with tests passing locally Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/22449

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:65a64b75-9790-4aa6-9edd-86e827111226
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC59A:EB011:ADEEA1:DFBC0F:699086BE
html-safe-nonce38d5335cef524cee298b3dc0be06ad9d66851729a26455010a659b15f5e36c53
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTlBOkVCMDExOkFERUVBMTpERkJDMEY6Njk5MDg2QkUiLCJ2aXNpdG9yX2lkIjoiNDg2NjIxNjI2NjE3NDU5Njc5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2e7779af9491621ac463ee7395267da54dae9113fa3df533a74843c3a421e176
hovercard-subject-tagpull_request:209980244
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22449/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9c603c6bd4cda5543e76c1ca1633572e9eebb8864536e7b8ad1897ffd60cb2f2/nodejs/node/pull/22449
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9c603c6bd4cda5543e76c1ca1633572e9eebb8864536e7b8ad1897ffd60cb2f2/nodejs/node/pull/22449
og:image:altThis is a rebased & modified version of @aks-’s #20993, with tests passing locally Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22449#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22449
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22449
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22449
Reloadhttps://github.com/nodejs/node/pull/22449
Reloadhttps://github.com/nodejs/node/pull/22449
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22449
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:merge-net-socket-onreadhttps://github.com/addaleax/node/tree/merge-net-socket-onread
Conversationhttps://github.com/nodejs/node/pull/22449
Commits2 (2)https://github.com/nodejs/node/pull/22449/commits
Checkshttps://github.com/nodejs/node/pull/22449/checks
Files changedhttps://github.com/nodejs/node/pull/22449/files
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/pull/22449#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:merge-net-socket-onreadhttps://github.com/addaleax/node/tree/merge-net-socket-onread
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 21, 2018https://github.com/nodejs/node/pull/22449#issue-352743165
@aks-https://github.com/aks-
#20993https://github.com/nodejs/node/pull/20993
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22449
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 21, 2018https://github.com/nodejs/node/pull/22449#issuecomment-414850632
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/621/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/621/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22449
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Aug 21, 2018https://github.com/nodejs/node/pull/22449#event-1801405230
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 21, 2018https://github.com/nodejs/node/pull/22449#issuecomment-414851055
https://ci.nodejs.org/job/node-test-pull-request/16652/https://ci.nodejs.org/job/node-test-pull-request/16652/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1518/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1518/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/226/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/226/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/227/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/227/
Please reload this pagehttps://github.com/nodejs/node/pull/22449
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 21, 2018 https://github.com/nodejs/node/pull/22449#ref-pullrequest-326891785
[WIP] lib: merge onread handlers for http2 streams & net.Socket #20993 https://github.com/nodejs/node/pull/20993
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2018 https://github.com/nodejs/node/pull/22449#pullrequestreview-148318382
View reviewed changes https://github.com/nodejs/node/pull/22449/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 22, 2018 https://github.com/nodejs/node/pull/22449#pullrequestreview-148593632
View reviewed changes https://github.com/nodejs/node/pull/22449/files
lib/internal/stream_base_commons.jshttps://github.com/nodejs/node/pull/22449/files#diff-55e49d067e487da5dffc29a2cd42b82572c563784f91ae8af4fe04d0d442b227
cjihrighttps://github.com/cjihrig
Aug 22, 2018https://github.com/nodejs/node/pull/22449#discussion_r212044350
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22449
jasnellhttps://github.com/jasnell
Aug 22, 2018https://github.com/nodejs/node/pull/22449#discussion_r212054879
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22449
aks-https://github.com/aks-
August 28, 2018 00:01https://github.com/nodejs/node/pull/22449#commits-pushed-9c1443b
https://github.com/aks-
https://github.com/addaleax
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/pull/22449/commits/9c1443b581c55c79065b9bc7739ef3b7dd479257
9c1443bhttps://github.com/nodejs/node/pull/22449/commits/9c1443b581c55c79065b9bc7739ef3b7dd479257
nodejs#20993https://github.com/nodejs/node/pull/20993
https://github.com/addaleax
fixup! lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/pull/22449/commits/737b0fb5854c7977541242b39ba7397a3dc09564
737b0fbhttps://github.com/nodejs/node/pull/22449/commits/737b0fb5854c7977541242b39ba7397a3dc09564
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/c91fe6ee260fef19972d70a5751be49e3e218230..737b0fb5854c7977541242b39ba7397a3dc09564
c91fe6ehttps://github.com/nodejs/node/commit/c91fe6ee260fef19972d70a5751be49e3e218230
737b0fbhttps://github.com/nodejs/node/commit/737b0fb5854c7977541242b39ba7397a3dc09564
Compare https://github.com/nodejs/node/compare/c91fe6ee260fef19972d70a5751be49e3e218230..737b0fb5854c7977541242b39ba7397a3dc09564
August 27, 2018 22:02https://github.com/nodejs/node/pull/22449#event-1811699565
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 27, 2018https://github.com/nodejs/node/pull/22449#issuecomment-416384070
https://ci.nodejs.org/job/node-test-pull-request/16803/https://ci.nodejs.org/job/node-test-pull-request/16803/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/230/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/230/
Please reload this pagehttps://github.com/nodejs/node/pull/22449
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 27, 2018https://github.com/nodejs/node/pull/22449#event-1811702455
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 31, 2018https://github.com/nodejs/node/pull/22449#issuecomment-417669641
https://ci.nodejs.org/job/node-test-pull-request/16896/https://ci.nodejs.org/job/node-test-pull-request/16896/
Please reload this pagehttps://github.com/nodejs/node/pull/22449
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22449#issuecomment-417924896
1126dfehttps://github.com/nodejs/node/commit/1126dfe0cb9680b0d3c833c0b465c63225dcf750
Please reload this pagehttps://github.com/nodejs/node/pull/22449
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 2, 2018https://github.com/nodejs/node/pull/22449#event-1822216417
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
September 2, 2018 11:45https://github.com/nodejs/node/pull/22449#event-1822216437
addaleaxhttps://github.com/addaleax
Sep 2, 2018 https://github.com/nodejs/node/pull/22449#ref-commit-1126dfe
https://github.com/aks-
https://github.com/addaleax
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/commit/1126dfe0cb9680b0d3c833c0b465c63225dcf750
1126dfehttps://github.com/nodejs/node/commit/1126dfe0cb9680b0d3c833c0b465c63225dcf750
#20993https://github.com/nodejs/node/pull/20993
#22449https://github.com/nodejs/node/pull/22449
targoshttps://github.com/targos
Sep 2, 2018 https://github.com/nodejs/node/pull/22449#ref-commit-45a6108
https://github.com/aks-
https://github.com/targos
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/commit/45a6108abf9d4e1eeb44879538ac6993d1b8146a
45a6108https://github.com/nodejs/node/commit/45a6108abf9d4e1eeb44879538ac6993d1b8146a
#20993https://github.com/nodejs/node/pull/20993
#22449https://github.com/nodejs/node/pull/22449
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22449#ref-commit-f0be053
https://github.com/aks-
https://github.com/targos
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/commit/f0be05342bae99a6447c1e54d056690ac6fbdd98
f0be053https://github.com/nodejs/node/commit/f0be05342bae99a6447c1e54d056690ac6fbdd98
#20993https://github.com/nodejs/node/pull/20993
#22449https://github.com/nodejs/node/pull/22449
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22449#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22449#ref-commit-2a88731
https://github.com/aks-
https://github.com/targos
lib: merge onread handlers for http2 streams & net.Sockethttps://github.com/nodejs/node/commit/2a88731ed71fb17fc12ff159d59ca7f948cf1a70
2a88731https://github.com/nodejs/node/commit/2a88731ed71fb17fc12ff159d59ca7f948cf1a70
#20993https://github.com/nodejs/node/pull/20993
#22449https://github.com/nodejs/node/pull/22449
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.com/kjin
kjinhttps://github.com/kjin
Oct 3, 2018 https://github.com/nodejs/node/pull/22449#ref-pullrequest-360082879
[8.x] Backport http2 changes from 10.x #22850 https://github.com/nodejs/node/pull/22850
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 20, 2018 https://github.com/nodejs/node/pull/22449#ref-pullrequest-303192836
http2: simplify timeout tracking #19206 https://github.com/nodejs/node/pull/19206
https://github.com/imcotton
imcottonhttps://github.com/imcotton
May 1, 2019 https://github.com/nodejs/node/pull/22449#ref-issue-365175593
Almost guaranteed ECONNRESET on piped sockets if connecting to Node's HTTPS server which answers with "connection: 'close'" after setImmediate or setTimeout, on OSX #23169 https://github.com/nodejs/node/issues/23169
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22449
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22449/files/c91fe6ee260fef19972d70a5751be49e3e218230
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22449/files/c91fe6ee260fef19972d70a5751be49e3e218230
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/22449
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/aks-
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.