René's URL Explorer Experiment


Title: test: move common.ArrayStream to separate module by jasnell · Pull Request #22447 · nodejs/node · GitHub

Open Graph Title: test: move common.ArrayStream to separate module by jasnell · Pull Request #22447 · nodejs/node

X Title: test: move common.ArrayStream to separate module by jasnell · Pull Request #22447 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: In a continuing effort to de-monolithize require('../common'), move common.ArrayStream out to a separate module that is imported only when it is needed. Checklist make -j4 test (UNIX), o...

X Description: In a continuing effort to de-monolithize require('../common'), move common.ArrayStream out to a separate module that is imported only when it is needed. Checklist make -j4 test (...

Opengraph URL: https://github.com/nodejs/node/pull/22447

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ca1b8fa0-ee14-16ea-94ef-838447fe613d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id888A:13C44A:B19275:E22932:699086BD
html-safe-noncec734aff5b33d337c204dc3c40c5266e14363a1aa1138ece7edd73fde7f2e210c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODhBOjEzQzQ0QTpCMTkyNzU6RTIyOTMyOjY5OTA4NkJEIiwidmlzaXRvcl9pZCI6IjIxODgzMzAwNzcyNDYyMjgxNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac676efc3e3fecfbd1d06eaefcaed55cedd94dbe2ad57f23ed34d812ddb4067f15
hovercard-subject-tagpull_request:209965937
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22447/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6b33738a736d5c290bf7d10cac629c7f8836ab7039e0cdf07df803d6f287229a/nodejs/node/pull/22447
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6b33738a736d5c290bf7d10cac629c7f8836ab7039e0cdf07df803d6f287229a/nodejs/node/pull/22447
og:image:altIn a continuing effort to de-monolithize require('../common'), move common.ArrayStream out to a separate module that is imported only when it is needed. Checklist make -j4 test (UNIX), o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22447#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22447
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22447
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22447
Reloadhttps://github.com/nodejs/node/pull/22447
Reloadhttps://github.com/nodejs/node/pull/22447
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22447
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:test-no-common-arraystreamhttps://github.com/jasnell/node/tree/test-no-common-arraystream
Conversationhttps://github.com/nodejs/node/pull/22447
Commits3 (3)https://github.com/nodejs/node/pull/22447/commits
Checkshttps://github.com/nodejs/node/pull/22447/checks
Files changedhttps://github.com/nodejs/node/pull/22447/files
test: move common.ArrayStream to separate modulehttps://github.com/nodejs/node/pull/22447#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:test-no-common-arraystreamhttps://github.com/jasnell/node/tree/test-no-common-arraystream
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 21, 2018https://github.com/nodejs/node/pull/22447#issue-352723877
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 21, 2018https://github.com/nodejs/node/pull/22447#issuecomment-414833355
@jasnellhttps://github.com/jasnell
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/620/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/620/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 21, 2018https://github.com/nodejs/node/pull/22447#event-1801287833
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 21, 2018 https://github.com/nodejs/node/pull/22447#pullrequestreview-148266933
View reviewed changes https://github.com/nodejs/node/pull/22447/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 22, 2018 https://github.com/nodejs/node/pull/22447#pullrequestreview-148300299
View reviewed changes https://github.com/nodejs/node/pull/22447/files
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 22, 2018 https://github.com/nodejs/node/pull/22447#pullrequestreview-148345223
View reviewed changes https://github.com/nodejs/node/pull/22447/files
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 22, 2018 https://github.com/nodejs/node/pull/22447#pullrequestreview-148346848
View reviewed changes https://github.com/nodejs/node/pull/22447/files
test/common/README.mdhttps://github.com/nodejs/node/pull/22447/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6
trivikrhttps://github.com/trivikr
Aug 22, 2018https://github.com/nodejs/node/pull/22447#discussion_r211841526
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22447
Trotthttps://github.com/Trott
Aug 23, 2018https://github.com/nodejs/node/pull/22447#discussion_r212476278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2018https://github.com/nodejs/node/pull/22447#issuecomment-415034398
https://ci.nodejs.org/job/node-test-pull-request/16679/https://ci.nodejs.org/job/node-test-pull-request/16679/
Please reload this pagehttps://github.com/nodejs/node/pull/22447
jasnellhttps://github.com/jasnell
August 22, 2018 06:42https://github.com/nodejs/node/pull/22447#commits-pushed-172c628
https://github.com/jasnell
test: move common.ArrayStream to separate modulehttps://github.com/nodejs/node/pull/22447/commits/172c62862d80c30af8193faaa07b6ae59ddb6b5b
172c628https://github.com/nodejs/node/pull/22447/commits/172c62862d80c30af8193faaa07b6ae59ddb6b5b
https://github.com/jasnell
[Squash] linthttps://github.com/nodejs/node/pull/22447/commits/4a82568722d7f55fbcfab72e5840832bb3fe950d
4a82568https://github.com/nodejs/node/pull/22447/commits/4a82568722d7f55fbcfab72e5840832bb3fe950d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/6ff0d5da52113ba4c942da94cac0e1a06d38949e..4a82568722d7f55fbcfab72e5840832bb3fe950d
6ff0d5dhttps://github.com/nodejs/node/commit/6ff0d5da52113ba4c942da94cac0e1a06d38949e
4a82568https://github.com/nodejs/node/commit/4a82568722d7f55fbcfab72e5840832bb3fe950d
Compare https://github.com/nodejs/node/compare/6ff0d5da52113ba4c942da94cac0e1a06d38949e..4a82568722d7f55fbcfab72e5840832bb3fe950d
August 22, 2018 13:44https://github.com/nodejs/node/pull/22447#event-1802689747
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2018https://github.com/nodejs/node/pull/22447#issuecomment-415057206
https://ci.nodejs.org/job/node-test-pull-request/16682/https://ci.nodejs.org/job/node-test-pull-request/16682/
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2018https://github.com/nodejs/node/pull/22447#issuecomment-415063321
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/refack
refackhttps://github.com/refack
Aug 22, 2018 https://github.com/nodejs/node/pull/22447#pullrequestreview-148552838
View reviewed changes https://github.com/nodejs/node/pull/22447/files/4a82568722d7f55fbcfab72e5840832bb3fe950d
https://github.com/refack
refackhttps://github.com/refack
Aug 22, 2018https://github.com/nodejs/node/pull/22447#issuecomment-415084893
https://ci.nodejs.org/job/node-test-commit-linuxone/4284/https://ci.nodejs.org/job/node-test-commit-linuxone/4284/
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 22, 2018 https://github.com/nodejs/node/pull/22447#pullrequestreview-148655265
View reviewed changes https://github.com/nodejs/node/pull/22447/files/4a82568722d7f55fbcfab72e5840832bb3fe950d
https://github.com/Trott
squash! remove old docshttps://github.com/nodejs/node/pull/22447/commits/4f66f9ed6a0e01edc50b52156e228fc57bf7c606
4f66f9ehttps://github.com/nodejs/node/pull/22447/commits/4f66f9ed6a0e01edc50b52156e228fc57bf7c606
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 23, 2018https://github.com/nodejs/node/pull/22447#issuecomment-415591522
https://ci.nodejs.org/job/node-test-pull-request/16706/https://ci.nodejs.org/job/node-test-pull-request/16706/
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 23, 2018https://github.com/nodejs/node/pull/22447#event-1806560106
jasnellhttps://github.com/jasnell
Aug 23, 2018 https://github.com/nodejs/node/pull/22447#ref-commit-fa543c0
https://github.com/jasnell
test: move common.ArrayStream to separate modulehttps://github.com/nodejs/node/commit/fa543c00cdaca6a6c68d1df4c68c061e2b82ca21
fa543c0https://github.com/nodejs/node/commit/fa543c00cdaca6a6c68d1df4c68c061e2b82ca21
#22447https://github.com/nodejs/node/pull/22447
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 23, 2018https://github.com/nodejs/node/pull/22447#issuecomment-415608744
fa543c0https://github.com/nodejs/node/commit/fa543c00cdaca6a6c68d1df4c68c061e2b82ca21
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 23, 2018https://github.com/nodejs/node/pull/22447#event-1806599339
targoshttps://github.com/targos
Aug 24, 2018 https://github.com/nodejs/node/pull/22447#ref-commit-244850d
https://github.com/jasnell
https://github.com/targos
test: move common.ArrayStream to separate modulehttps://github.com/nodejs/node/commit/244850d34d0360d410d29f9577f586e19ec27499
244850dhttps://github.com/nodejs/node/commit/244850d34d0360d410d29f9577f586e19ec27499
#22447https://github.com/nodejs/node/pull/22447
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22447#ref-commit-98af170
https://github.com/jasnell
https://github.com/targos
test: move common.ArrayStream to separate modulehttps://github.com/nodejs/node/commit/98af1704ae587a8f8ec79e5e53379640bc0b255a
98af170https://github.com/nodejs/node/commit/98af1704ae587a8f8ec79e5e53379640bc0b255a
#22447https://github.com/nodejs/node/pull/22447
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22447#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22447
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/22447/files/4f66f9ed6a0e01edc50b52156e228fc57bf7c606
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/22447/files/6ff0d5da52113ba4c942da94cac0e1a06d38949e
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/22447/files/4a82568722d7f55fbcfab72e5840832bb3fe950d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22447/files/6ff0d5da52113ba4c942da94cac0e1a06d38949e
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/22447/files/6ff0d5da52113ba4c942da94cac0e1a06d38949e
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/22447/files/4a82568722d7f55fbcfab72e5840832bb3fe950d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/22447
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/Trott
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.