René's URL Explorer Experiment


Title: test: remove isGlibc from common by jasnell · Pull Request #22443 · nodejs/node · GitHub

Open Graph Title: test: remove isGlibc from common by jasnell · Pull Request #22443 · nodejs/node

X Title: test: remove isGlibc from common by jasnell · Pull Request #22443 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The common.isGlibc() function is called exactly once from only one test. There's no reason for it to be in require('../common') at the current time. If it ends up needing to be used by ...

X Description: The common.isGlibc() function is called exactly once from only one test. There's no reason for it to be in require('../common') at the current time. If it ends up needing to...

Opengraph URL: https://github.com/nodejs/node/pull/22443

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f8ab4193-caa3-d70b-5d1b-2d4e4ed39726
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8AF2:1121AC:176292B:1DC5EB5:69917174
html-safe-nonced1d1028d04ca1252d0752a1554bf29f8623794b85864d56ea2cedb6b58a16be2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUYyOjExMjFBQzoxNzYyOTJCOjFEQzVFQjU6Njk5MTcxNzQiLCJ2aXNpdG9yX2lkIjoiMzMxMDQzMzM2MTg0ODI2NzEyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac71d234faa8a5aa74488d305302690aaa791ef448b2185de32b499d566986be42
hovercard-subject-tagpull_request:209940623
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22443/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/668816808057a386d938f580721a207a32e1af8c895bc00bda3809c0792a9e78/nodejs/node/pull/22443
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/668816808057a386d938f580721a207a32e1af8c895bc00bda3809c0792a9e78/nodejs/node/pull/22443
og:image:altThe common.isGlibc() function is called exactly once from only one test. There's no reason for it to be in require('../common') at the current time. If it ends up needing to be used by ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22443#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22443
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22443
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22443
Reloadhttps://github.com/nodejs/node/pull/22443
Reloadhttps://github.com/nodejs/node/pull/22443
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22443
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:test-no-common-isglibchttps://github.com/jasnell/node/tree/test-no-common-isglibc
Conversationhttps://github.com/nodejs/node/pull/22443
Commits1 (1)https://github.com/nodejs/node/pull/22443/commits
Checkshttps://github.com/nodejs/node/pull/22443/checks
Files changedhttps://github.com/nodejs/node/pull/22443/files
test: remove isGlibc from commonhttps://github.com/nodejs/node/pull/22443#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:test-no-common-isglibchttps://github.com/jasnell/node/tree/test-no-common-isglibc
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 21, 2018https://github.com/nodejs/node/pull/22443#issue-352689711
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22443
https://github.com/jasnell
test: remove isGlibc from commonhttps://github.com/nodejs/node/pull/22443/commits/ba3a99892b102109c192f8ab75cd44fdbd28f82f
ba3a998https://github.com/nodejs/node/pull/22443/commits/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 21, 2018https://github.com/nodejs/node/pull/22443#issuecomment-414804192
@jasnellhttps://github.com/jasnell
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/618/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/618/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22443
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 21, 2018https://github.com/nodejs/node/pull/22443#event-1801081401
https://github.com/refack
refackhttps://github.com/refack
Aug 21, 2018 https://github.com/nodejs/node/pull/22443#pullrequestreview-148252152
View reviewed changes https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/refack
refackhttps://github.com/refack
Aug 21, 2018https://github.com/nodejs/node/pull/22443#issuecomment-414824539
https://github.com/nodejs/node/blob/master/test/common/README.mdhttps://github.com/nodejs/node/blob/master/test/common/README.md
Please reload this pagehttps://github.com/nodejs/node/pull/22443
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 21, 2018 https://github.com/nodejs/node/pull/22443#pullrequestreview-148260918
View reviewed changes https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 22, 2018 https://github.com/nodejs/node/pull/22443#pullrequestreview-148300484
View reviewed changes https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 22, 2018 https://github.com/nodejs/node/pull/22443#pullrequestreview-148337907
View reviewed changes https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 22, 2018 https://github.com/nodejs/node/pull/22443#pullrequestreview-148347309
View reviewed changes https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2018https://github.com/nodejs/node/pull/22443#issuecomment-415033774
https://ci.nodejs.org/job/node-test-pull-request/16677/https://ci.nodejs.org/job/node-test-pull-request/16677/
Please reload this pagehttps://github.com/nodejs/node/pull/22443
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 22, 2018https://github.com/nodejs/node/pull/22443#event-1802668649
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 22, 2018 https://github.com/nodejs/node/pull/22443#pullrequestreview-148650025
View reviewed changes https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 22, 2018https://github.com/nodejs/node/pull/22443#issuecomment-415167326
https://ci.nodejs.org/job/node-test-pull-request/16685/https://ci.nodejs.org/job/node-test-pull-request/16685/
Please reload this pagehttps://github.com/nodejs/node/pull/22443
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 23, 2018 https://github.com/nodejs/node/pull/22443#pullrequestreview-148930409
View reviewed changes https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
jasnellhttps://github.com/jasnell
Aug 23, 2018 https://github.com/nodejs/node/pull/22443#ref-commit-2d64a51
https://github.com/jasnell
test: remove isGlibc from commonhttps://github.com/nodejs/node/commit/2d64a51270f20e47de663fd45326a93dda1694e4
2d64a51https://github.com/nodejs/node/commit/2d64a51270f20e47de663fd45326a93dda1694e4
#22443https://github.com/nodejs/node/pull/22443
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 23, 2018https://github.com/nodejs/node/pull/22443#issuecomment-415602742
Please reload this pagehttps://github.com/nodejs/node/pull/22443
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 23, 2018https://github.com/nodejs/node/pull/22443#event-1806558641
targoshttps://github.com/targos
Aug 24, 2018 https://github.com/nodejs/node/pull/22443#ref-commit-3c0f11f
https://github.com/jasnell
https://github.com/targos
test: remove isGlibc from commonhttps://github.com/nodejs/node/commit/3c0f11fa6a3aa10c1f8226f08bdac944936f1f90
3c0f11fhttps://github.com/nodejs/node/commit/3c0f11fa6a3aa10c1f8226f08bdac944936f1f90
#22443https://github.com/nodejs/node/pull/22443
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22443#ref-commit-e684382
https://github.com/jasnell
https://github.com/targos
test: remove isGlibc from commonhttps://github.com/nodejs/node/commit/e68438246ef89e289a33b38dbbad426d945b7fce
e684382https://github.com/nodejs/node/commit/e68438246ef89e289a33b38dbbad426d945b7fce
#22443https://github.com/nodejs/node/pull/22443
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22443#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22443
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/22443/files/ba3a99892b102109c192f8ab75cd44fdbd28f82f
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/22443
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/Trott
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.