René's URL Explorer Experiment


Title: src: refactor options parsing by addaleax · Pull Request #22392 · nodejs/node · GitHub

Open Graph Title: src: refactor options parsing by addaleax · Pull Request #22392 · nodejs/node

X Title: src: refactor options parsing by addaleax · Pull Request #22392 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: In case anybody was wondering what I’ve been up to this week. 😸 This is a major refactor of our Node’s parser. See node_options.cc for how it is used, and node_options-inl.h for the bulk of its i...

X Description: In case anybody was wondering what I’ve been up to this week. 😸 This is a major refactor of our Node’s parser. See node_options.cc for how it is used, and node_options-inl.h for the bulk of its i...

Opengraph URL: https://github.com/nodejs/node/pull/22392

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b923990d-df4d-0c64-0114-319608cbf099
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA8A:17203:A4D6A9:D4C21A:6990C80F
html-safe-nonce73042bb70c59e55600dd11b231bfb4ae72853f6537955ba78bd5f7cdb7d64e35
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQThBOjE3MjAzOkE0RDZBOTpENEMyMUE6Njk5MEM4MEYiLCJ2aXNpdG9yX2lkIjoiNTY2OTIzOTY3MDA3ODIyODQ5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac873711e7912761edc020de67657062f07f58910e97c8f86d12f2a1208f527f3c
hovercard-subject-tagpull_request:209333934
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22392/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5b44ece0fd7764d2586da21f119facedddf06a7a17f00133af946542f746c84f/nodejs/node/pull/22392
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b44ece0fd7764d2586da21f119facedddf06a7a17f00133af946542f746c84f/nodejs/node/pull/22392
og:image:altIn case anybody was wondering what I’ve been up to this week. 😸 This is a major refactor of our Node’s parser. See node_options.cc for how it is used, and node_options-inl.h for the bulk of its i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22392#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22392
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22392
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22392
Reloadhttps://github.com/nodejs/node/pull/22392
Reloadhttps://github.com/nodejs/node/pull/22392
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22392
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:optionshttps://github.com/addaleax/node/tree/options
Conversationhttps://github.com/nodejs/node/pull/22392
Commits4 (4)https://github.com/nodejs/node/pull/22392/commits
Checkshttps://github.com/nodejs/node/pull/22392/checks
Files changedhttps://github.com/nodejs/node/pull/22392/files
src: refactor options parsinghttps://github.com/nodejs/node/pull/22392#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:optionshttps://github.com/addaleax/node/tree/options
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 18, 2018https://github.com/nodejs/node/pull/22392#issue-351858132
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@boneskullhttps://github.com/boneskull
#19335https://github.com/nodejs/node/pull/19335
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
src: refactor options parsinghttps://github.com/nodejs/node/pull/22392/commits/5d123558d6cd8140261ba208fd8db74c83f7537e
5d12355https://github.com/nodejs/node/pull/22392/commits/5d123558d6cd8140261ba208fd8db74c83f7537e
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
cli https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli
Aug 18, 2018https://github.com/nodejs/node/pull/22392#event-1796142026
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 18, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414091003
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/589/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/589/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Aug 18, 2018https://github.com/nodejs/node/pull/22392#event-1796142039
https://github.com/refack
refackhttps://github.com/refack
Aug 18, 2018 https://github.com/nodejs/node/pull/22392#pullrequestreview-147442939
View reviewed changes https://github.com/nodejs/node/pull/22392/files/5d123558d6cd8140261ba208fd8db74c83f7537e
src/node_config.cchttps://github.com/nodejs/node/pull/22392/files/5d123558d6cd8140261ba208fd8db74c83f7537e#diff-53943e9637cbf19a6176e5b3610954b224857fbf209f9cbf9f97f03f7739a43f
refackhttps://github.com/refack
Aug 18, 2018https://github.com/nodejs/node/pull/22392#discussion_r211087489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@srl295https://github.com/srl295
Please reload this pagehttps://github.com/nodejs/node/pull/22392
addaleaxhttps://github.com/addaleax
Aug 18, 2018https://github.com/nodejs/node/pull/22392#discussion_r211087743
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
Aug 18, 2018 https://github.com/nodejs/node/pull/22392#pullrequestreview-147443071
View reviewed changes https://github.com/nodejs/node/pull/22392/files/5d123558d6cd8140261ba208fd8db74c83f7537e
refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/nodejs/node/pull/22392#pullrequestreview-147443071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
stale reviewhttps://github.com/nodejs/node/pull/22392#pullrequestreview-147443071
August 18, 2018 23:22https://github.com/nodejs/node/pull/22392#event-1796148203
https://github.com/refack
refackhttps://github.com/refack
Aug 18, 2018 https://github.com/nodejs/node/pull/22392#pullrequestreview-147443219
View reviewed changes https://github.com/nodejs/node/pull/22392/files/5d123558d6cd8140261ba208fd8db74c83f7537e
src/node_options.hhttps://github.com/nodejs/node/pull/22392/files/5d123558d6cd8140261ba208fd8db74c83f7537e#diff-a6dd6c44925932d3134081da80ed07216f5f66449f540442835557616bcd14f9
refackhttps://github.com/refack
Aug 18, 2018https://github.com/nodejs/node/pull/22392#discussion_r211087706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
addaleaxhttps://github.com/addaleax
Aug 18, 2018https://github.com/nodejs/node/pull/22392#discussion_r211087760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 18, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414092476
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
Aug 18, 2018 https://github.com/nodejs/node/pull/22392#pullrequestreview-147443318
View reviewed changes https://github.com/nodejs/node/pull/22392/files/5d123558d6cd8140261ba208fd8db74c83f7537e
src/node_options.cchttps://github.com/nodejs/node/pull/22392/files/5d123558d6cd8140261ba208fd8db74c83f7537e#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
refackhttps://github.com/refack
Aug 18, 2018https://github.com/nodejs/node/pull/22392#discussion_r211087797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
addaleaxhttps://github.com/addaleax
Aug 18, 2018https://github.com/nodejs/node/pull/22392#discussion_r211087899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
refackhttps://github.com/refack
Aug 18, 2018https://github.com/nodejs/node/pull/22392#discussion_r211087934
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
addaleaxhttps://github.com/addaleax
Aug 18, 2018https://github.com/nodejs/node/pull/22392#discussion_r211087967
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
3c9b03ahttps://github.com/nodejs/node/commit/3c9b03a8ae10e14bfd51dda01dd38e3e93caf0fb
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
fixup! src: refactor options parsinghttps://github.com/nodejs/node/pull/22392/commits/3c9b03a8ae10e14bfd51dda01dd38e3e93caf0fb
3c9b03ahttps://github.com/nodejs/node/pull/22392/commits/3c9b03a8ae10e14bfd51dda01dd38e3e93caf0fb
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 18, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414093206
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 18, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414093259
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 18, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414093368
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
Aug 18, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414093468
https://github.com/search?l=C%2B%2B&q=argument+parser&type=Repositorieshttps://github.com/search?l=C%2B%2B&q=argument+parser&type=Repositories
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 19, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414093681
https://github.com/search?l=C%2B%2B&q=argument+parser&type=Repositorieshttps://github.com/search?l=C%2B%2B&q=argument+parser&type=Repositories
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
Aug 20, 2018 https://github.com/nodejs/node/pull/22392#pullrequestreview-147476298
View reviewed changes https://github.com/nodejs/node/pull/22392/files/3c9b03a8ae10e14bfd51dda01dd38e3e93caf0fb
src/node_options-inl.hhttps://github.com/nodejs/node/pull/22392/files/3c9b03a8ae10e14bfd51dda01dd38e3e93caf0fb#diff-9839d2ff827c6533c400880889fc1772119349be904a5aedf07bf4c5118bc4db
refackhttps://github.com/refack
Aug 20, 2018https://github.com/nodejs/node/pull/22392#discussion_r211120313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
refackhttps://github.com/refack
Aug 20, 2018https://github.com/nodejs/node/pull/22392#discussion_r211121399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
addaleaxhttps://github.com/addaleax
Aug 20, 2018https://github.com/nodejs/node/pull/22392#discussion_r211227211
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 20, 2018 https://github.com/nodejs/node/pull/22392#pullrequestreview-147632055
View reviewed changes https://github.com/nodejs/node/pull/22392/files/3c9b03a8ae10e14bfd51dda01dd38e3e93caf0fb
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/22392#pullrequestreview-147632055
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 20, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414312095
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1517/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1517/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1516/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1516/
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/boneskull
boneskullhttps://github.com/boneskull
Aug 20, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414462195
@addaleaxhttps://github.com/addaleax
#19335https://github.com/nodejs/node/pull/19335
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 20, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414469018
@boneskullhttps://github.com/boneskull
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 21, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414853612
@refackhttps://github.com/refack
https://ci.nodejs.org/job/node-test-pull-request/16653/https://ci.nodejs.org/job/node-test-pull-request/16653/
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
Aug 21, 2018 https://github.com/nodejs/node/pull/22392#pullrequestreview-148290269
View reviewed changes https://github.com/nodejs/node/pull/22392/files/3c9b03a8ae10e14bfd51dda01dd38e3e93caf0fb
https://github.com/refack
refackhttps://github.com/refack
Aug 21, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414857125
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
Aug 22, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414866652
Please reload this pagehttps://github.com/nodejs/node/pull/22392
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
fixup! src: refactor options parsinghttps://github.com/nodejs/node/pull/22392/commits/9b811b38b447b813bc9ee40c389f79122674d8dc
9b811b3https://github.com/nodejs/node/pull/22392/commits/9b811b38b447b813bc9ee40c389f79122674d8dc
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 22, 2018https://github.com/nodejs/node/pull/22392#issuecomment-414868869
@refackhttps://github.com/refack
https://ci.nodejs.org/job/node-test-pull-request/16655/https://ci.nodejs.org/job/node-test-pull-request/16655/
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
Aug 22, 2018 https://github.com/nodejs/node/pull/22392#pullrequestreview-148305993
View reviewed changes https://github.com/nodejs/node/pull/22392/files/9b811b38b447b813bc9ee40c389f79122674d8dc
src/node_options.cchttps://github.com/nodejs/node/pull/22392/files/9b811b38b447b813bc9ee40c389f79122674d8dc#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
refackhttps://github.com/refack
Aug 22, 2018https://github.com/nodejs/node/pull/22392#discussion_r211806020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
addaleaxhttps://github.com/addaleax
Aug 22, 2018https://github.com/nodejs/node/pull/22392#discussion_r211886671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
refackhttps://github.com/refack
Aug 22, 2018https://github.com/nodejs/node/pull/22392#discussion_r211951780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 22, 2018https://github.com/nodejs/node/pull/22392#event-1803786771
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
August 22, 2018 21:41https://github.com/nodejs/node/pull/22392#event-1803786864
addaleaxhttps://github.com/addaleax
Aug 22, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-29a71ba
https://github.com/addaleax
src: refactor options parsinghttps://github.com/nodejs/node/commit/29a71bae40ffa0bbc8ba6b2bdf051a09987da7f7
29a71bahttps://github.com/nodejs/node/commit/29a71bae40ffa0bbc8ba6b2bdf051a09987da7f7
#22392https://github.com/nodejs/node/pull/22392
https://github.com/refack
refackhttps://github.com/refack
Aug 23, 2018https://github.com/nodejs/node/pull/22392#issuecomment-415493906
@addaleaxhttps://github.com/addaleax
#22484https://github.com/nodejs/node/pull/22484
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 25, 2018 https://github.com/nodejs/node/pull/22392#ref-issue-354048112
NODE_OPTIONS do not work properly anymore #22526 https://github.com/nodejs/node/issues/22526
addaleaxhttps://github.com/addaleax
Aug 26, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-c533499
https://github.com/addaleax
src: fix NODE_OPTIONS parsing bughttps://github.com/addaleax/node/commit/c53349975713ec208e726c93be7895787874e38a
c533499https://github.com/addaleax/node/commit/c53349975713ec208e726c93be7895787874e38a
nodejs#22526https://github.com/nodejs/node/issues/22526
nodejs#22392https://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 26, 2018 https://github.com/nodejs/node/pull/22392#ref-pullrequest-354054197
src: fix NODE_OPTIONS parsing bug #22529 https://github.com/nodejs/node/pull/22529
addaleaxhttps://github.com/addaleax
Aug 26, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-1c05b16
https://github.com/addaleax
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/commit/1c05b16c9e7b8d054d1661c61ae054efe83108ac
1c05b16https://github.com/nodejs/node/commit/1c05b16c9e7b8d054d1661c61ae054efe83108ac
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
#22529https://github.com/nodejs/node/pull/22529
addaleaxhttps://github.com/addaleax
Aug 27, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-f33c89d
https://github.com/addaleax
src: refactor options parsinghttps://github.com/addaleax/node/commit/f33c89df6ee80f27a28c73e6fee65d256d609d74
f33c89dhttps://github.com/addaleax/node/commit/f33c89df6ee80f27a28c73e6fee65d256d609d74
nodejs#22392https://github.com/nodejs/node/pull/22392
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 27, 2018 https://github.com/nodejs/node/pull/22392#ref-pullrequest-354510450
[v10.x] src: refactor options parsing #22558 https://github.com/nodejs/node/pull/22558
addaleaxhttps://github.com/addaleax
Aug 28, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-b2f8050
https://github.com/addaleax
src: refactor options parsinghttps://github.com/nodejs/node/commit/b2f8050bd8ba361fbb4a86515e96ee84e41375c7
b2f8050https://github.com/nodejs/node/commit/b2f8050bd8ba361fbb4a86515e96ee84e41375c7
#22392https://github.com/nodejs/node/pull/22392
#22558https://github.com/nodejs/node/pull/22558
https://github.com/targos
targoshttps://github.com/targos
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 28, 2018https://github.com/nodejs/node/pull/22392#event-1814038320
addaleaxhttps://github.com/addaleax
Aug 28, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-7e3ceb1
https://github.com/addaleax
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/commit/7e3ceb1fd9a47481305f5b44cadfc3663c71d619
7e3ceb1https://github.com/nodejs/node/commit/7e3ceb1fd9a47481305f5b44cadfc3663c71d619
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
#22529https://github.com/nodejs/node/pull/22529
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-8fd55ff
https://github.com/addaleax
https://github.com/targos
src: refactor options parsinghttps://github.com/nodejs/node/commit/8fd55fffeee021dc9c0dec1f2515286a6ffe46d3
8fd55ffhttps://github.com/nodejs/node/commit/8fd55fffeee021dc9c0dec1f2515286a6ffe46d3
#22392https://github.com/nodejs/node/pull/22392
#22558https://github.com/nodejs/node/pull/22558
targoshttps://github.com/targos
Sep 3, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-2c5dfef
https://github.com/addaleax
https://github.com/targos
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/commit/2c5dfef393ad4122242689dc79e1064e70df2cd8
2c5dfefhttps://github.com/nodejs/node/commit/2c5dfef393ad4122242689dc79e1064e70df2cd8
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
#22529https://github.com/nodejs/node/pull/22529
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-8a45a6c
https://github.com/targos
2018-09-06, Version 10.10.0 (Current)https://github.com/nodejs/node/commit/8a45a6c3e83b46d28cc4e40d89eb347da927f03b
8a45a6chttps://github.com/nodejs/node/commit/8a45a6c3e83b46d28cc4e40d89eb347da927f03b
#22409https://github.com/nodejs/node/pull/22409
#22527https://github.com/nodejs/node/pull/22527
#22591https://github.com/nodejs/node/pull/22591
https://github.com/npm/cli/releases/tag/v6.3.0-next.0https://github.com/npm/cli/releases/tag/v6.3.0-next.0
https://github.com/npm/cli/releases/tag/v6.3.0https://github.com/npm/cli/releases/tag/v6.3.0
https://github.com/npm/cli/releases/tag/v6.4.0https://github.com/npm/cli/releases/tag/v6.4.0
https://github.com/npm/cli/releases/tag/v6.4.1https://github.com/npm/cli/releases/tag/v6.4.1
#22150https://github.com/nodejs/node/pull/22150
#22020https://github.com/nodejs/node/pull/22020
#22466https://github.com/nodejs/node/pull/22466
#22394https://github.com/nodejs/node/pull/22394
#19335https://github.com/nodejs/node/pull/19335
#22392https://github.com/nodejs/node/pull/22392
#22392https://github.com/nodejs/node/pull/22392
#21571https://github.com/nodejs/node/pull/21571
https://github.com/lundibundihttps://github.com/lundibundi
#22716https://github.com/nodejs/node/pull/22716
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2018 https://github.com/nodejs/node/pull/22392#ref-pullrequest-357375733
Release proposal: v10.10.0 #22716 https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-52c797c
https://github.com/addaleax
https://github.com/targos
src: refactor options parsinghttps://github.com/nodejs/node/commit/52c797cc4d4a170ef59947d79979888d87c15ed0
52c797chttps://github.com/nodejs/node/commit/52c797cc4d4a170ef59947d79979888d87c15ed0
#22392https://github.com/nodejs/node/pull/22392
#22558https://github.com/nodejs/node/pull/22558
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-7282768
https://github.com/addaleax
https://github.com/targos
src: fix NODE_OPTIONS parsing bughttps://github.com/nodejs/node/commit/7282768134dad75efaf82e380bad7bbab6775f6b
7282768https://github.com/nodejs/node/commit/7282768134dad75efaf82e380bad7bbab6775f6b
#22526https://github.com/nodejs/node/issues/22526
#22392https://github.com/nodejs/node/pull/22392
#22529https://github.com/nodejs/node/pull/22529
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-814a0c0
https://github.com/targos
2018-09-06, Version 10.10.0 (Current)https://github.com/nodejs/node/commit/814a0c0ef756ff26e6bab186bf2e5efe5b486dfb
814a0c0https://github.com/nodejs/node/commit/814a0c0ef756ff26e6bab186bf2e5efe5b486dfb
#22409https://github.com/nodejs/node/pull/22409
#22527https://github.com/nodejs/node/pull/22527
#22591https://github.com/nodejs/node/pull/22591
https://github.com/npm/cli/releases/tag/v6.3.0-next.0https://github.com/npm/cli/releases/tag/v6.3.0-next.0
https://github.com/npm/cli/releases/tag/v6.3.0https://github.com/npm/cli/releases/tag/v6.3.0
https://github.com/npm/cli/releases/tag/v6.4.0https://github.com/npm/cli/releases/tag/v6.4.0
https://github.com/npm/cli/releases/tag/v6.4.1https://github.com/npm/cli/releases/tag/v6.4.1
#22150https://github.com/nodejs/node/pull/22150
#22020https://github.com/nodejs/node/pull/22020
#22466https://github.com/nodejs/node/pull/22466
#22407https://github.com/nodejs/node/pull/22407
#19335https://github.com/nodejs/node/pull/19335
#22515https://github.com/nodejs/node/pull/22515
#22392https://github.com/nodejs/node/pull/22392
#21571https://github.com/nodejs/node/pull/21571
https://github.com/lundibundihttps://github.com/lundibundi
#22716https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-cdb3598
https://github.com/targos
2018-09-06, Version 10.10.0 (Current)https://github.com/nodejs/node/commit/cdb359840c9537e460b1bf0536fc36ec5fe2db2d
cdb3598https://github.com/nodejs/node/commit/cdb359840c9537e460b1bf0536fc36ec5fe2db2d
#22409https://github.com/nodejs/node/pull/22409
#22527https://github.com/nodejs/node/pull/22527
#22591https://github.com/nodejs/node/pull/22591
https://github.com/npm/cli/releases/tag/v6.3.0-next.0https://github.com/npm/cli/releases/tag/v6.3.0-next.0
https://github.com/npm/cli/releases/tag/v6.3.0https://github.com/npm/cli/releases/tag/v6.3.0
https://github.com/npm/cli/releases/tag/v6.4.0https://github.com/npm/cli/releases/tag/v6.4.0
https://github.com/npm/cli/releases/tag/v6.4.1https://github.com/npm/cli/releases/tag/v6.4.1
#22150https://github.com/nodejs/node/pull/22150
#22020https://github.com/nodejs/node/pull/22020
#22466https://github.com/nodejs/node/pull/22466
#22407https://github.com/nodejs/node/pull/22407
#19335https://github.com/nodejs/node/pull/19335
#22515https://github.com/nodejs/node/pull/22515
#22392https://github.com/nodejs/node/pull/22392
#21571https://github.com/nodejs/node/pull/21571
https://github.com/lundibundihttps://github.com/lundibundi
#22716https://github.com/nodejs/node/pull/22716
targoshttps://github.com/targos
Sep 6, 2018 https://github.com/nodejs/node/pull/22392#ref-commit-ed976d7
https://github.com/targos
2018-09-06, Version 10.10.0 (Current)https://github.com/nodejs/node/commit/ed976d76b0cab84eb26618d50541289d3e0687b8
ed976d7https://github.com/nodejs/node/commit/ed976d76b0cab84eb26618d50541289d3e0687b8
#22409https://github.com/nodejs/node/pull/22409
#22527https://github.com/nodejs/node/pull/22527
#22591https://github.com/nodejs/node/pull/22591
https://github.com/npm/cli/releases/tag/v6.3.0-next.0https://github.com/npm/cli/releases/tag/v6.3.0-next.0
https://github.com/npm/cli/releases/tag/v6.3.0https://github.com/npm/cli/releases/tag/v6.3.0
https://github.com/npm/cli/releases/tag/v6.4.0https://github.com/npm/cli/releases/tag/v6.4.0
https://github.com/npm/cli/releases/tag/v6.4.1https://github.com/npm/cli/releases/tag/v6.4.1
#22150https://github.com/nodejs/node/pull/22150
#22020https://github.com/nodejs/node/pull/22020
#22466https://github.com/nodejs/node/pull/22466
#22407https://github.com/nodejs/node/pull/22407
#19335https://github.com/nodejs/node/pull/19335
#22515https://github.com/nodejs/node/pull/22515
#22392https://github.com/nodejs/node/pull/22392
#21571https://github.com/nodejs/node/pull/21571
https://github.com/lundibundihttps://github.com/lundibundi
#22716https://github.com/nodejs/node/pull/22716
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236 https://github.com/beevelop/docker-android-nodejs/issues/236
2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221 https://github.com/beevelop/docker-nodejs/issues/221
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 10, 2018 https://github.com/nodejs/node/pull/22392#ref-issue-358489339
--prof-process CLI args no longer work in 10.10.0 #22786 https://github.com/nodejs/node/issues/22786
https://github.com/demurgos
demurgoshttps://github.com/demurgos
Nov 25, 2018 https://github.com/nodejs/node/pull/22392#ref-issue-384122368
End of CLI options -- is now part of process.execArgv (regression in Node 10.10) #24647 https://github.com/nodejs/node/issues/24647
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Aug 11, 2020 https://github.com/nodejs/node/pull/22392#ref-pullrequest-677227479
[Snyk] Upgrade: gatsby, gatsby-image, gatsby-plugin-catch-links, gatsby-plugin-manifest, gatsby-plugin-no-sourcemaps, gatsby-plugin-offline, gatsby-plugin-react-helmet, gatsby-plugin-sharp, gatsby-plugin-styled-components, gatsby-remark-autolink-headers, gatsby-remark-prismjs, gatsby-source-filesystem, gatsby-transformer-remark radiumrasheed/node#4 https://github.com/radiumrasheed/node/pull/4
https://github.com/ckerr
ckerrhttps://github.com/ckerr
Dec 6, 2023 https://github.com/nodejs/node/pull/22392#ref-pullrequest-2019458810
fix: wrong default port in docs electron/electron#40665 https://github.com/electron/electron/pull/40665
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22392
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/22392/files/3c9b03a8ae10e14bfd51dda01dd38e3e93caf0fb
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22392/files/9b811b38b447b813bc9ee40c389f79122674d8dc
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/22392/files/be4a3b658a692d390f4fa9a187189c2ee993de1c
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/22392/files/be4a3b658a692d390f4fa9a187189c2ee993de1c
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cli https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/22392
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/refack
https://github.com/boneskull
https://github.com/Fishrock123
https://github.com/mcollina
https://github.com/devsnek
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.