René's URL Explorer Experiment


Title: vm: add dynamic import support by devsnek · Pull Request #22381 · nodejs/node · GitHub

Open Graph Title: vm: add dynamic import support by devsnek · Pull Request #22381 · nodejs/node

X Title: vm: add dynamic import support by devsnek · Pull Request #22381 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: adds importModuleDynamically callback option to vm.SourceTextModule and vm.Script constructors. splits contextify::ContextifyScript into node_contextify.h and node_contextify.cc Closes #19363 Refs...

X Description: adds importModuleDynamically callback option to vm.SourceTextModule and vm.Script constructors. splits contextify::ContextifyScript into node_contextify.h and node_contextify.cc Closes #19363 Refs...

Opengraph URL: https://github.com/nodejs/node/pull/22381

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:855556a1-9c51-fcfa-a893-b231a92c07ff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB90C:1C3DF0:7ADB56:9FD669:6990AAD3
html-safe-noncecd7fd6d03dcf7f76501cf49ad9d45958dae3f7efb5d79b003caa6942a93eb872
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTBDOjFDM0RGMDo3QURCNTY6OUZENjY5OjY5OTBBQUQzIiwidmlzaXRvcl9pZCI6IjIyMDIxNjg1MTc3MDg1MjQyNDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacec8852c80212122e37fff040a957350abd256af57b5292faa265f7b76016f63a
hovercard-subject-tagpull_request:209277512
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/22381/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cdccd46216befaef24567f04fc42ec8ff45716ef7ae73c1acd8f1a814f5731c1/nodejs/node/pull/22381
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cdccd46216befaef24567f04fc42ec8ff45716ef7ae73c1acd8f1a814f5731c1/nodejs/node/pull/22381
og:image:altadds importModuleDynamically callback option to vm.SourceTextModule and vm.Script constructors. splits contextify::ContextifyScript into node_contextify.h and node_contextify.cc Closes #19363 Refs...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevsnek
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/22381#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22381
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22381
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/22381
Reloadhttps://github.com/nodejs/node/pull/22381
Reloadhttps://github.com/nodejs/node/pull/22381
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/22381
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:feature/vm-dynamic-importhttps://github.com/devsnek/node/tree/feature/vm-dynamic-import
Conversationhttps://github.com/nodejs/node/pull/22381
Commits1 (1)https://github.com/nodejs/node/pull/22381/commits
Checkshttps://github.com/nodejs/node/pull/22381/checks
Files changedhttps://github.com/nodejs/node/pull/22381/files
vm: add dynamic import supporthttps://github.com/nodejs/node/pull/22381#top
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:feature/vm-dynamic-importhttps://github.com/devsnek/node/tree/feature/vm-dynamic-import
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 17, 2018https://github.com/nodejs/node/pull/22381#issue-351765031
Please reload this pagehttps://github.com/nodejs/node/pull/22381
#19363https://github.com/nodejs/node/issues/19363
#19570https://github.com/nodejs/node/issues/19570
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Aug 17, 2018https://github.com/nodejs/node/pull/22381#event-1795715021
https://github.com/devsnek
devsnekhttps://github.com/devsnek
bmeckhttps://github.com/bmeck
hybristhttps://github.com/hybrist
August 17, 2018 23:14https://github.com/nodejs/node/pull/22381#event-1795715026
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2018https://github.com/nodejs/node/pull/22381#issuecomment-414010069
@devsnekhttps://github.com/devsnek
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/583/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/583/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Aug 17, 2018https://github.com/nodejs/node/pull/22381#event-1795715058
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/e93c142746e7ced03b19ca99885b3134a2168461..81cc2234824fecfe02789be3f77ebb0ee7470b51
e93c142https://github.com/nodejs/node/commit/e93c142746e7ced03b19ca99885b3134a2168461
81cc223https://github.com/nodejs/node/commit/81cc2234824fecfe02789be3f77ebb0ee7470b51
Compare https://github.com/nodejs/node/compare/e93c142746e7ced03b19ca99885b3134a2168461..81cc2234824fecfe02789be3f77ebb0ee7470b51
August 19, 2018 01:48https://github.com/nodejs/node/pull/22381#event-1796178656
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 23, 2018https://github.com/nodejs/node/pull/22381#issuecomment-415597415
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/67b5f6fc816c30cebecadc28f673d55cf1a6e9ae..580fb8a6e63a8de3f6517a803422ab70140908ac
67b5f6fhttps://github.com/nodejs/node/commit/67b5f6fc816c30cebecadc28f673d55cf1a6e9ae
580fb8ahttps://github.com/nodejs/node/commit/580fb8a6e63a8de3f6517a803422ab70140908ac
Compare https://github.com/nodejs/node/compare/67b5f6fc816c30cebecadc28f673d55cf1a6e9ae..580fb8a6e63a8de3f6517a803422ab70140908ac
August 24, 2018 00:12https://github.com/nodejs/node/pull/22381#event-1806617926
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 24, 2018https://github.com/nodejs/node/pull/22381#issuecomment-415611545
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Aug 24, 2018https://github.com/nodejs/node/pull/22381#issuecomment-415613200
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/vsemozhetbyt
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/580fb8a6e63a8de3f6517a803422ab70140908ac..51e65e9d50b202170f490a7d07daeac8d113cae1
580fb8ahttps://github.com/nodejs/node/commit/580fb8a6e63a8de3f6517a803422ab70140908ac
51e65e9https://github.com/nodejs/node/commit/51e65e9d50b202170f490a7d07daeac8d113cae1
Compare https://github.com/nodejs/node/compare/580fb8a6e63a8de3f6517a803422ab70140908ac..51e65e9d50b202170f490a7d07daeac8d113cae1
August 24, 2018 14:49https://github.com/nodejs/node/pull/22381#event-1807846870
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 24, 2018https://github.com/nodejs/node/pull/22381#issuecomment-415887336
@vsemozhetbythttps://github.com/vsemozhetbyt
https://ci.nodejs.org/job/node-test-pull-request/16737/https://ci.nodejs.org/job/node-test-pull-request/16737/
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 24, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-149486406
View reviewed changes https://github.com/nodejs/node/pull/22381/files
doc/api/vm.mdhttps://github.com/nodejs/node/pull/22381/files#diff-bacb1b2d18a751bd71c28f44b002080ad5b3808ccef7ae2260274968c9a07976
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 24, 2018https://github.com/nodejs/node/pull/22381#discussion_r212776320
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 24, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-149486431
View reviewed changes https://github.com/nodejs/node/pull/22381/files
doc/api/vm.mdhttps://github.com/nodejs/node/pull/22381/files#diff-bacb1b2d18a751bd71c28f44b002080ad5b3808ccef7ae2260274968c9a07976
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 24, 2018https://github.com/nodejs/node/pull/22381#discussion_r212776342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/51e65e9d50b202170f490a7d07daeac8d113cae1..b746fbdeab07bdad2670b5801dbc25e259de707a
51e65e9https://github.com/nodejs/node/commit/51e65e9d50b202170f490a7d07daeac8d113cae1
b746fbdhttps://github.com/nodejs/node/commit/b746fbdeab07bdad2670b5801dbc25e259de707a
Compare https://github.com/nodejs/node/compare/51e65e9d50b202170f490a7d07daeac8d113cae1..b746fbdeab07bdad2670b5801dbc25e259de707a
August 25, 2018 00:33https://github.com/nodejs/node/pull/22381#event-1808768417
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 25, 2018https://github.com/nodejs/node/pull/22381#issuecomment-415915221
https://ci.nodejs.org/job/node-test-pull-request/16745/https://ci.nodejs.org/job/node-test-pull-request/16745/
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 25, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-149492960
View reviewed changes https://github.com/nodejs/node/pull/22381/files
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 25, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-149505331
View reviewed changes https://github.com/nodejs/node/pull/22381/files
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/22381#pullrequestreview-149505331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
lib/internal/modules/esm/translators.jshttps://github.com/nodejs/node/pull/22381/files#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c
Please reload this pagehttps://github.com/nodejs/node/pull/22381
src/env.hhttps://github.com/nodejs/node/pull/22381/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
guybedfordhttps://github.com/guybedford
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212793650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
devsnekhttps://github.com/devsnek
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212801776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212803165
Please reload this pagehttps://github.com/nodejs/node/pull/22381
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
src/module_wrap.cchttps://github.com/nodejs/node/pull/22381/files#diff-ea501528b0419a0e268dba0a111869879926d671b7e4240a7f8177e9eb384a4b
guybedfordhttps://github.com/guybedford
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212793684
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
devsnekhttps://github.com/devsnek
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212801784
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/b746fbdeab07bdad2670b5801dbc25e259de707a..b331674f82c7cac2fb163412ce57818098c05751
b746fbdhttps://github.com/nodejs/node/commit/b746fbdeab07bdad2670b5801dbc25e259de707a
b331674https://github.com/nodejs/node/commit/b331674f82c7cac2fb163412ce57818098c05751
Compare https://github.com/nodejs/node/compare/b746fbdeab07bdad2670b5801dbc25e259de707a..b331674f82c7cac2fb163412ce57818098c05751
August 25, 2018 17:55https://github.com/nodejs/node/pull/22381#event-1809079727
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-149515974
View reviewed changes https://github.com/nodejs/node/pull/22381/files
lib/internal/process/esm_loader.jshttps://github.com/nodejs/node/pull/22381/files#diff-72e781a50541066b01a07699fce4956ab4d808d77588bd9c61d4784549664714
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212803822
Please reload this pagehttps://github.com/nodejs/node/pull/22381
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
doc/api/vm.mdhttps://github.com/nodejs/node/pull/22381/files#diff-bacb1b2d18a751bd71c28f44b002080ad5b3808ccef7ae2260274968c9a07976
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212803837
Please reload this pagehttps://github.com/nodejs/node/pull/22381
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
lib/internal/errors.jshttps://github.com/nodejs/node/pull/22381/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212803844
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
src/node_contextify.cchttps://github.com/nodejs/node/pull/22381/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212804403
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
src/module_wrap.cchttps://github.com/nodejs/node/pull/22381/files#diff-ea501528b0419a0e268dba0a111869879926d671b7e4240a7f8177e9eb384a4b
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212804436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
test/parallel/test-vm-module-dynamic-import.jshttps://github.com/nodejs/node/pull/22381/files#diff-eae55cd300c71348b8ea0ffcf32d9be884565b84f512b29b1474f1b969ee6f71
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22381
Please reload this pagehttps://github.com/nodejs/node/pull/22381
src/module_wrap.cchttps://github.com/nodejs/node/pull/22381/files#diff-ea501528b0419a0e268dba0a111869879926d671b7e4240a7f8177e9eb384a4b
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212804782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
src/module_wrap.cchttps://github.com/nodejs/node/pull/22381/files#diff-ea501528b0419a0e268dba0a111869879926d671b7e4240a7f8177e9eb384a4b
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212804797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
src/module_wrap.cchttps://github.com/nodejs/node/pull/22381/files#diff-ea501528b0419a0e268dba0a111869879926d671b7e4240a7f8177e9eb384a4b
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212804809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
doc/api/vm.mdhttps://github.com/nodejs/node/pull/22381/files#diff-bacb1b2d18a751bd71c28f44b002080ad5b3808ccef7ae2260274968c9a07976
TimothyGuhttps://github.com/TimothyGu
Aug 25, 2018https://github.com/nodejs/node/pull/22381#discussion_r212804935
Please reload this pagehttps://github.com/nodejs/node/pull/22381
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/6df2a36f7063f7a1832f8ae4c11baede52c3108c..5ad9d8aa62f080a1d7dabeb9bf3594ad789d306a
6df2a36https://github.com/nodejs/node/commit/6df2a36f7063f7a1832f8ae4c11baede52c3108c
5ad9d8ahttps://github.com/nodejs/node/commit/5ad9d8aa62f080a1d7dabeb9bf3594ad789d306a
Compare https://github.com/nodejs/node/compare/6df2a36f7063f7a1832f8ae4c11baede52c3108c..5ad9d8aa62f080a1d7dabeb9bf3594ad789d306a
August 25, 2018 23:46https://github.com/nodejs/node/pull/22381#event-1809169553
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 26, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-149537395
View reviewed changes https://github.com/nodejs/node/pull/22381/files
lib/internal/modules/esm/translators.jshttps://github.com/nodejs/node/pull/22381/files#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 26, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-149537531
View reviewed changes https://github.com/nodejs/node/pull/22381/files
doc/api/vm.mdhttps://github.com/nodejs/node/pull/22381/files#diff-bacb1b2d18a751bd71c28f44b002080ad5b3808ccef7ae2260274968c9a07976
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 26, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-149537705
View reviewed changes https://github.com/nodejs/node/pull/22381/files
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/22381#pullrequestreview-149537705
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#19717https://github.com/nodejs/node/pull/19717
Please reload this pagehttps://github.com/nodejs/node/pull/22381
test/parallel/test-vm-module-dynamic-import.jshttps://github.com/nodejs/node/pull/22381/files#diff-eae55cd300c71348b8ea0ffcf32d9be884565b84f512b29b1474f1b969ee6f71
guybedfordhttps://github.com/guybedford
Aug 26, 2018https://github.com/nodejs/node/pull/22381#discussion_r212825620
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
devsnekhttps://github.com/devsnek
Aug 26, 2018https://github.com/nodejs/node/pull/22381#discussion_r212826800
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
guybedfordhttps://github.com/guybedford
Aug 26, 2018https://github.com/nodejs/node/pull/22381#discussion_r212827054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
devsnekhttps://github.com/devsnek
Aug 26, 2018https://github.com/nodejs/node/pull/22381#discussion_r212827163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
guybedfordhttps://github.com/guybedford
Aug 26, 2018https://github.com/nodejs/node/pull/22381#discussion_r212827408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
TimothyGuhttps://github.com/TimothyGu
Aug 26, 2018https://github.com/nodejs/node/pull/22381#discussion_r212829466
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
devsnekhttps://github.com/devsnek
Aug 26, 2018https://github.com/nodejs/node/pull/22381#discussion_r212841336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
TimothyGuhttps://github.com/TimothyGu
Aug 27, 2018https://github.com/nodejs/node/pull/22381#discussion_r212863837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
guybedfordhttps://github.com/guybedford
Aug 27, 2018https://github.com/nodejs/node/pull/22381#discussion_r212972297
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://tc39.github.io/proposal-dynamic-import/#sec-hostimportmoduledynamicallyhttps://tc39.github.io/proposal-dynamic-import/#sec-hostimportmoduledynamically
Please reload this pagehttps://github.com/nodejs/node/pull/22381
guybedfordhttps://github.com/guybedford
Aug 27, 2018https://github.com/nodejs/node/pull/22381#discussion_r212975370
Please reload this pagehttps://github.com/nodejs/node/pull/22381
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22381
https://github.com/devsnek
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22381
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 2, 2018 https://github.com/nodejs/node/pull/22381#ref-issue-365839731
CI failures: 20180927-20181002 nodejs/reliability#18 https://github.com/nodejs/reliability/issues/18
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/c742e31614820a3e27a543f44425fe0072f73126..ce01c43efc08f741953b14f5f56acac0dea686f2
c742e31https://github.com/nodejs/node/commit/c742e31614820a3e27a543f44425fe0072f73126
ce01c43https://github.com/nodejs/node/commit/ce01c43efc08f741953b14f5f56acac0dea686f2
Compare https://github.com/nodejs/node/compare/c742e31614820a3e27a543f44425fe0072f73126..ce01c43efc08f741953b14f5f56acac0dea686f2
October 4, 2018 18:47https://github.com/nodejs/node/pull/22381#event-1885430014
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 4, 2018 https://github.com/nodejs/node/pull/22381#pullrequestreview-161798100
View reviewed changes https://github.com/nodejs/node/pull/22381/files
src/node_contextify.hhttps://github.com/nodejs/node/pull/22381/files#diff-41a6062dde107d7bca0ba5a925c4bb226c9d6ba69b357d56701d13b61fdbf30b
joyeecheunghttps://github.com/joyeecheung
Oct 4, 2018https://github.com/nodejs/node/pull/22381#discussion_r222817598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/ce01c43efc08f741953b14f5f56acac0dea686f2..6cf22085c84b86837e3e6c3e03b2534669954258
ce01c43https://github.com/nodejs/node/commit/ce01c43efc08f741953b14f5f56acac0dea686f2
6cf2208https://github.com/nodejs/node/commit/6cf22085c84b86837e3e6c3e03b2534669954258
Compare https://github.com/nodejs/node/compare/ce01c43efc08f741953b14f5f56acac0dea686f2..6cf22085c84b86837e3e6c3e03b2534669954258
October 4, 2018 21:20https://github.com/nodejs/node/pull/22381#event-1885748762
https://github.com/devsnek
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/6cf22085c84b86837e3e6c3e03b2534669954258..948fcb4801cec60e5a2667551583d0a34c7460df
6cf2208https://github.com/nodejs/node/commit/6cf22085c84b86837e3e6c3e03b2534669954258
948fcb4https://github.com/nodejs/node/commit/948fcb4801cec60e5a2667551583d0a34c7460df
Compare https://github.com/nodejs/node/compare/6cf22085c84b86837e3e6c3e03b2534669954258..948fcb4801cec60e5a2667551583d0a34c7460df
October 5, 2018 14:44https://github.com/nodejs/node/pull/22381#event-1887342013
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 5, 2018https://github.com/nodejs/node/pull/22381#issuecomment-427428748
https://ci.nodejs.org/job/node-test-pull-request/17649/https://ci.nodejs.org/job/node-test-pull-request/17649/
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 6, 2018https://github.com/nodejs/node/pull/22381#issuecomment-427594733
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://ci.nodejs.org/job/node-test-commit-linux-containered/7619/https://ci.nodejs.org/job/node-test-commit-linux-containered/7619/
https://ci.nodejs.org/job/node-test-commit-linux-containered/7620/https://ci.nodejs.org/job/node-test-commit-linux-containered/7620/
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
vm: add dynamic import supporthttps://github.com/nodejs/node/pull/22381/commits/4c37df779cf944b5666fc72e2a27fbf2e745881f
4c37df7https://github.com/nodejs/node/pull/22381/commits/4c37df779cf944b5666fc72e2a27fbf2e745881f
nodejs#22381https://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/948fcb4801cec60e5a2667551583d0a34c7460df..4c37df779cf944b5666fc72e2a27fbf2e745881f
948fcb4https://github.com/nodejs/node/commit/948fcb4801cec60e5a2667551583d0a34c7460df
4c37df7https://github.com/nodejs/node/commit/4c37df779cf944b5666fc72e2a27fbf2e745881f
Compare https://github.com/nodejs/node/compare/948fcb4801cec60e5a2667551583d0a34c7460df..4c37df779cf944b5666fc72e2a27fbf2e745881f
October 6, 2018 22:33https://github.com/nodejs/node/pull/22381#event-1888773254
https://github.com/devsnek
devsnekhttps://github.com/devsnek
4c37df7https://github.com/nodejs/node/commit/4c37df779cf944b5666fc72e2a27fbf2e745881f
Oct 6, 2018https://github.com/nodejs/node/pull/22381#event-1888773496
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 6, 2018https://github.com/nodejs/node/pull/22381#issuecomment-427611054
4c37df7https://github.com/nodejs/node/commit/4c37df779cf944b5666fc72e2a27fbf2e745881f
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
devsnekhttps://github.com/devsnek
October 6, 2018 22:34https://github.com/nodejs/node/pull/22381#event-1888773533
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Oct 7, 2018https://github.com/nodejs/node/pull/22381#event-1888928049
https://github.com/targos
targoshttps://github.com/targos
Oct 7, 2018https://github.com/nodejs/node/pull/22381#issuecomment-427639273
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/22381
jasnellhttps://github.com/jasnell
Oct 17, 2018 https://github.com/nodejs/node/pull/22381#ref-commit-6487f07
https://github.com/devsnek
https://github.com/jasnell
vm: add dynamic import supporthttps://github.com/nodejs/node/commit/6487f07e0ce83977955bdf36ab970f34ada5390a
6487f07https://github.com/nodejs/node/commit/6487f07e0ce83977955bdf36ab970f34ada5390a
#22381https://github.com/nodejs/node/pull/22381
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 24, 2018 https://github.com/nodejs/node/pull/22381#ref-pullrequest-378238583
src: compile native modules and their code cache in C++ #24221 https://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 22, 2018 https://github.com/nodejs/node/pull/22381#ref-pullrequest-336494782
module: use compileFunction over Module.wrap #21573 https://github.com/nodejs/node/pull/21573
joyeecheunghttps://github.com/joyeecheung
Jan 9, 2019 https://github.com/nodejs/node/pull/22381#ref-commit-3060cdf
https://github.com/devsnek
https://github.com/joyeecheung
vm: add dynamic import supporthttps://github.com/joyeecheung/node/commit/3060cdf2eaf3796fe90247ac6c91ef3d9324dec4
3060cdfhttps://github.com/joyeecheung/node/commit/3060cdf2eaf3796fe90247ac6c91ef3d9324dec4
nodejs#22381https://github.com/nodejs/node/pull/22381
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 9, 2019 https://github.com/nodejs/node/pull/22381#ref-pullrequest-397529076
[10.x] vm: add dynamic import support #25421 https://github.com/nodejs/node/pull/25421
BethGriggshttps://github.com/BethGriggs
Feb 5, 2019 https://github.com/nodejs/node/pull/22381#ref-commit-134d1e9
https://github.com/devsnek
https://github.com/BethGriggs
vm: add dynamic import supporthttps://github.com/nodejs/node/commit/134d1e9526d9681c3124581a04ac917d4b4cb202
134d1e9https://github.com/nodejs/node/commit/134d1e9526d9681c3124581a04ac917d4b4cb202
#25421https://github.com/nodejs/node/pull/25421
#22381https://github.com/nodejs/node/pull/22381
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/22381#ref-pullrequest-409543286
v10.15.3 proposal #26063 https://github.com/nodejs/node/pull/26063
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/22381#ref-commit-0d1500d
https://github.com/devsnek
https://github.com/rvagg
vm: add dynamic import supporthttps://github.com/nodejs/node/commit/0d1500d9e2306bb66a6ceb7fe66333350b6d3bbc
0d1500dhttps://github.com/nodejs/node/commit/0d1500d9e2306bb66a6ceb7fe66333350b6d3bbc
#25421https://github.com/nodejs/node/pull/25421
#22381https://github.com/nodejs/node/pull/22381
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jun 14, 2019https://github.com/nodejs/node/pull/22381#event-2413530636
https://github.com/SimenB
SimenBhttps://github.com/SimenB
Apr 21, 2020 https://github.com/nodejs/node/pull/22381#ref-issue-567242922
vm.compileFunction is missing importModuleDynamically #31860 https://github.com/nodejs/node/issues/31860
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F22381
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/22381/files/ce01c43efc08f741953b14f5f56acac0dea686f2
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/22381/files/b746fbdeab07bdad2670b5801dbc25e259de707a
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/22381/files/aa0d14ccf649170e508fc4229936db182635a936
https://github.com/bmeck
bmeck https://github.com/bmeck
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/hashseed
hashseed https://github.com/hashseed
https://github.com/nodejs/node/pull/22381/files/74a569a587ba5579638ada43aa388cd46d66fe3f
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/22381/files/51e65e9d50b202170f490a7d07daeac8d113cae1
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/22381/files/837a320585550607e25ba233ca9d41154a38498f
https://github.com/jdalton
jdalton https://github.com/jdalton
https://github.com/nodejs/node/pull/22381/files/267e27380db3faf7a304cba25d444fea01fb45b5
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Call linker when dynamically importing inside a vm.Module https://github.com/nodejs/node/issues/19363
Please reload this pagehttps://github.com/nodejs/node/pull/22381
https://github.com/devsnek
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/jdalton
https://github.com/vsemozhetbyt
https://github.com/BridgeAR
https://github.com/hashseed
https://github.com/targos
https://github.com/jasnell
https://github.com/guybedford
https://github.com/TimothyGu
https://github.com/joyeecheung
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.